<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225380</bug_id>
          
          <creation_ts>2021-05-04 21:02:41 -0700</creation_ts>
          <short_desc>copy/paste error in Recorder::canAppendItemOfType</short_desc>
          <delta_ts>2021-05-05 15:31:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=152816</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Cameron McCormack (:heycam)">heycam</reporter>
          <assigned_to name="Cameron McCormack (:heycam)">heycam</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1756793</commentid>
    <comment_count>0</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2021-05-04 21:02:41 -0700</bug_when>
    <thetext>https://webkit-search.igalia.com/webkit/rev/a221ff61ad355d85ae240e1313c5906779f00692/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp#131

&gt;         || type == ItemType::ApplyStrokePattern || type == ItemType::ApplyStrokePattern

One of these should presumably be ApplyFillPattern.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756794</commentid>
    <comment_count>1</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2021-05-04 21:03:56 -0700</bug_when>
    <thetext>Good catch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756798</commentid>
    <comment_count>2</comment_count>
      <attachid>427731</attachid>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2021-05-04 21:45:31 -0700</bug_when>
    <thetext>Created attachment 427731
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756799</commentid>
    <comment_count>3</comment_count>
    <who name="Cameron McCormack (:heycam)">heycam</who>
    <bug_when>2021-05-04 21:45:49 -0700</bug_when>
    <thetext>(Happy to add a test if needed.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757128</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-05 15:30:41 -0700</bug_when>
    <thetext>Committed r277046 (237358@main): &lt;https://commits.webkit.org/237358@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427731.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757129</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-05 15:31:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/77578785&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427731</attachid>
            <date>2021-05-04 21:45:31 -0700</date>
            <delta_ts>2021-05-05 15:30:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225380-20210505144529.patch</filename>
            <type>text/plain</type>
            <size>1564</size>
            <attacher name="Cameron McCormack (:heycam)">heycam</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZhNTVkNTMzZmNmNjc1
MzIzMzQyMzA4ZTc0ZmE2ZDg4Y2VmZTMyNy4uZmNlY2IwMDU1YzlhMjQ3MTZiZjcyZjE4M2ZkMDZm
ZjM0NmExZDE3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTA0ICBDYW1l
cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGNvcHkgcGFz
dGUgZXJyb3IgaW4gUmVjb3JkZXI6OmNhbkFwcGVuZEl0ZW1PZlR5cGUuCisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUzODAKKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Rp
c3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRp
c3BsYXlMaXN0OjpSZWNvcmRlcjo6Y2FuQXBwZW5kSXRlbU9mVHlwZSk6CisKIDIwMjEtMDUtMDQg
IENhbWVyb24gTWNDb3JtYWNrICA8aGV5Y2FtQGFwcGxlLmNvbT4KIAogICAgICAgICBIYW5kbGUg
Y2xhbXBpbmcgb2YgaGVpZ2h0cyBmb3IgaW1hZ2VzIGFmZmVjdGVkIGJ5IGJhY2tncm91bmQtc2l6
ZSBhbmQgRVhJRiBvcmllbnRhdGlvbiBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5TGlzdFJlY29yZGVyLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0cy9EaXNwbGF5
TGlzdFJlY29yZGVyLmNwcAppbmRleCA2MTQ1YmZmMjQyODdlZTEzZWVmMTYxOGEwNzc5OWNmNTM4
YmMwNDAyLi5kYjBhYzJmMjc3MzllZWNmOWFkMDgzMGM3NWI2Mjg3MjBlMjg1YjQ5IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxh
eUxpc3RSZWNvcmRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
ZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVjb3JkZXIuY3BwCkBAIC0xMjgsNyArMTI4LDcgQEAg
Ym9vbCBSZWNvcmRlcjo6Y2FuQXBwZW5kSXRlbU9mVHlwZShJdGVtVHlwZSB0eXBlKQogCiAgICAg
aWYgKGlzRHJhd2luZ0l0ZW0odHlwZSkKICNpZiBVU0UoQ0cpCi0gICAgICAgIHx8IHR5cGUgPT0g
SXRlbVR5cGU6OkFwcGx5U3Ryb2tlUGF0dGVybiB8fCB0eXBlID09IEl0ZW1UeXBlOjpBcHBseVN0
cm9rZVBhdHRlcm4KKyAgICAgICAgfHwgdHlwZSA9PSBJdGVtVHlwZTo6QXBwbHlGaWxsUGF0dGVy
biB8fCB0eXBlID09IEl0ZW1UeXBlOjpBcHBseVN0cm9rZVBhdHRlcm4KICNlbmRpZgogICAgICkg
ewogICAgICAgICBHcmFwaGljc0NvbnRleHRTdGF0ZUNoYW5nZSYgc3RhdGVDaGFuZ2VzID0gY3Vy
cmVudFN0YXRlKCkuc3RhdGVDaGFuZ2U7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>