<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22538</bug_id>
          
          <creation_ts>2008-11-28 00:02:46 -0800</creation_ts>
          <short_desc>StringImpl::startsWith uses find which searches the whole string.</short_desc>
          <delta_ts>2008-12-02 12:27:45 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Text</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="David Levin">levin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>100580</commentid>
    <comment_count>0</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2008-11-28 00:02:46 -0800</bug_when>
    <thetext>It wouldn&apos;t if it used StringImpl::reverseFind.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100606</commentid>
    <comment_count>1</comment_count>
      <attachid>25573</attachid>
    <who name="David Levin">levin</who>
    <bug_when>2008-11-28 08:26:49 -0800</bug_when>
    <thetext>Created attachment 25573
Simply changes the find to reverseFind in StringImpl::startswith</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100864</commentid>
    <comment_count>2</comment_count>
      <attachid>25573</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-12-01 13:01:03 -0800</bug_when>
    <thetext>Comment on attachment 25573
Simply changes the find to reverseFind in StringImpl::startswith

Looks fine to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101040</commentid>
    <comment_count>3</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-12-02 12:27:45 -0800</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/text/StringImpl.h
Committed r38910
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25573</attachid>
            <date>2008-11-28 08:26:49 -0800</date>
            <delta_ts>2008-12-01 13:01:03 -0800</delta_ts>
            <desc>Simply changes the find to reverseFind in StringImpl::startswith</desc>
            <filename>patch-for-bug22538.txt</filename>
            <type>text/plain</type>
            <size>1626</size>
            <attacher name="David Levin">levin</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzODgyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTkgQEAKKzIwMDgtMTEtMjcgIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0u
b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUzOAorICAgICAgICAKKyAg
ICAgICAgc3RhcnRzV2l0aCB1c2VzIGZpbmQgd2hpY2ggc2VhcmNoZXMgdGhyb3VnaCB0aGUgd2hv
bGUgc3RyaW5nIGlmIG5vIG1hdGNoIGlzIGZvdW5kLgorICAgICAgICBVc2luZyByZXZlcnNlRmlu
ZCB3aXRoIGFuIGluZGV4IG9mIDAgaGFzIHRoZSBiZW5lZml0IG9mIG9ubHkgc2VhcmNoaW5nIGZv
ciB0aGUgbWF0Y2gKKyAgICAgICAgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgc3RyaW5nLiAgVGhp
cyBtYXkgb25seSBiZSBhIHNtYWxsIGJlbmVmaXQgaW4gdGhlIG92ZXJhbGwgcHJvZ3JhbSwKKyAg
ICAgICAgYnV0IGl0IG1heSBoZWxwIGluIHNvbWUgY2FzZXMgd2hlbiB0aGUgc3RyaW5nIGlzIGJp
Zy4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGNoYW5nZSBpbiBiZWhhdmlvciwgc28gbm8gdGVz
dC4KKyAKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuaDoKKyAgICAgICAgKFdl
YkNvcmU6OlN0cmluZ0ltcGw6OnN0YXJ0c1dpdGgpOgorCiAyMDA4LTExLTI3ICBDYW1lcm9uIFp3
YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCkluZGV4
OiBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5oCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv
cmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmgJKHJldmlzaW9uIDM4ODI2KQorKysgV2ViQ29y
ZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMTQyLDcgKzE0
Miw3IEBAIHB1YmxpYzoKICAgICBpbnQgcmV2ZXJzZUZpbmQoVUNoYXIsIGludCBpbmRleCk7CiAg
ICAgaW50IHJldmVyc2VGaW5kKFN0cmluZ0ltcGwqLCBpbnQgaW5kZXgsIGJvb2wgY2FzZVNlbnNp
dGl2ZSA9IHRydWUpOwogICAgIAotICAgIGJvb2wgc3RhcnRzV2l0aChTdHJpbmdJbXBsKiBtX2Rh
dGEsIGJvb2wgY2FzZVNlbnNpdGl2ZSA9IHRydWUpIHsgcmV0dXJuIGZpbmQobV9kYXRhLCAwLCBj
YXNlU2Vuc2l0aXZlKSA9PSAwOyB9CisgICAgYm9vbCBzdGFydHNXaXRoKFN0cmluZ0ltcGwqIG1f
ZGF0YSwgYm9vbCBjYXNlU2Vuc2l0aXZlID0gdHJ1ZSkgeyByZXR1cm4gcmV2ZXJzZUZpbmQobV9k
YXRhLCAwLCBjYXNlU2Vuc2l0aXZlKSA9PSAwOyB9CiAgICAgYm9vbCBlbmRzV2l0aChTdHJpbmdJ
bXBsKiwgYm9vbCBjYXNlU2Vuc2l0aXZlID0gdHJ1ZSk7CiAKICAgICBQYXNzUmVmUHRyPFN0cmlu
Z0ltcGw+IHJlcGxhY2UoVUNoYXIsIFVDaGFyKTsK
</data>
<flag name="review"
          id="11901"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>