225360 2021-05-04 10:30:26 -0700 [ews] Ensure file handles are not leaked in unit tests 2021-08-06 09:43:53 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228866 InRadar P2 Normal --- 1 aakash_jain aakash_jain dewei_zhu jbedard webkit-bug-importer oldest_to_newest 1756585 0 aakash_jain 2021-05-04 10:30:26 -0700 Ensure that file handles are not leaked in ews unit tests. 1756587 1 427684 aakash_jain 2021-05-04 10:32:31 -0700 Created attachment 427684 [fast-cq] Patch 1756603 2 ews-feeder 2021-05-04 11:14:56 -0700 Committed r276970 (237299@main): <https://commits.webkit.org/237299@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427684. 1756604 3 webkit-bug-importer 2021-05-04 11:15:15 -0700 <rdar://problem/77516002> 427684 2021-05-04 10:32:31 -0700 2021-05-04 11:14:56 -0700 [fast-cq] Patch bug-225360-20210504133230.patch text/plain 2972 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3Njk2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA1LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBFbnN1cmUgZmlsZSBoYW5kbGVzIGFyZSBub3QgbGVha2VkIGlu IHVuaXQgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNTM2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9lbWFpbF91bml0dGVzdC5weToKKyAgICAgICAgKEVt YWlsc0RvdEpTT05UZXN0LnRlc3RfdmFsaWRfZW1haWxzX2pzb24pOgorICAgICAgICAoRW1haWxz RG90SlNPTlRlc3QudGVzdF9lbWFpbHNfanNvbl9yZXF1aXJlZF9jYXRlZ29yaWVzX3ByZXNlbnQp OgorICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weToK KyAgICAgICAgKENvbmZpZ0RvdEpTT05UZXN0LmdldF9jb25maWcpOgorCiAyMDIxLTA1LTAzICBL aW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVBdIE1v dmUgR1BVUHJvY2VzcyBXZWJHTCB0byBFeHBlcmltZW50YWwgRmVhdHVyZQpJbmRleDogVG9vbHMv Q0lTdXBwb3J0L2V3cy1idWlsZC9lbWFpbF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2VtYWlsX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNzY5NjYp CisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2VtYWlsX3VuaXR0ZXN0LnB5CSh3b3JraW5n IGNvcHkpCkBAIC0zMSwxNCArMzEsMTYgQEAgaW1wb3J0IHVuaXR0ZXN0CiBjbGFzcyBFbWFpbHNE b3RKU09OVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfdmFsaWRfZW1haWxz X2pzb24oc2VsZik6CiAgICAgICAgIGN3ZCA9IG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmFic3Bh dGgoX19maWxlX18pKQotICAgICAgICBqc29uLmxvYWQob3Blbihvcy5wYXRoLmpvaW4oY3dkLCAn ZW1haWxzLmpzb24nKSkpCisgICAgICAgIHdpdGggb3Blbihvcy5wYXRoLmpvaW4oY3dkLCAnZW1h aWxzLmpzb24nKSkgYXMgZW1haWxzX2pzb246CisgICAgICAgICAgICBqc29uLmxvYWQoZW1haWxz X2pzb24pCiAKICAgICBkZWYgdGVzdF9lbWFpbHNfanNvbl9yZXF1aXJlZF9jYXRlZ29yaWVzX3By ZXNlbnQoc2VsZik6CiAgICAgICAgIGN3ZCA9IG9zLnBhdGguZGlybmFtZShvcy5wYXRoLmFic3Bh dGgoX19maWxlX18pKQotICAgICAgICBlbWFpbHMgPSBqc29uLmxvYWQob3Blbihvcy5wYXRoLmpv aW4oY3dkLCAnZW1haWxzLmpzb24nKSkpCi0gICAgICAgIHZhbGlkX2VtYWlsX2NhdGVnb3JpZXMg PSBbJ0FETUlOX0VNQUlMUycsICdBUFBMRV9CT1RfV0FUQ0hFUlNfRU1BSUxTJywgJ0VNQUlMX0lE U19UT19VTlNVQlNDUklCRScsICdJR0FMSUFfSlNDX1RFQU1fRU1BSUxTJywgJ0lHQUxJQV9HVEtf V1BFX0VNQUlMUyddCi0gICAgICAgIGZvciBjYXRlZ29yeSBpbiB2YWxpZF9lbWFpbF9jYXRlZ29y aWVzOgotICAgICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGNhdGVnb3J5IGluIGxpc3QoZW1haWxz LmtleXMoKSkpCisgICAgICAgIHdpdGggb3Blbihvcy5wYXRoLmpvaW4oY3dkLCAnZW1haWxzLmpz b24nKSkgYXMgZW1haWxzX2pzb246CisgICAgICAgICAgICBlbWFpbHMgPSBqc29uLmxvYWQoZW1h aWxzX2pzb24pCisgICAgICAgICAgICB2YWxpZF9lbWFpbF9jYXRlZ29yaWVzID0gWydBRE1JTl9F TUFJTFMnLCAnQVBQTEVfQk9UX1dBVENIRVJTX0VNQUlMUycsICdFTUFJTF9JRFNfVE9fVU5TVUJT Q1JJQkUnLCAnSUdBTElBX0pTQ19URUFNX0VNQUlMUycsICdJR0FMSUFfR1RLX1dQRV9FTUFJTFMn XQorICAgICAgICAgICAgZm9yIGNhdGVnb3J5IGluIHZhbGlkX2VtYWlsX2NhdGVnb3JpZXM6Cisg ICAgICAgICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKGNhdGVnb3J5IGluIGxpc3QoZW1haWxzLmtl eXMoKSkpCiAKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKSW5kZXg6IFRvb2xzL0NJU3Vw cG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWdfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI3 Njk2NikKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvbG9hZENvbmZpZ191bml0dGVzdC5w eQkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsOCBAQCBpbXBvcnQgbG9hZENvbmZpZwogY2xh c3MgQ29uZmlnRG90SlNPTlRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiBnZXRfY29u ZmlnKHNlbGYpOgogICAgICAgICBjd2QgPSBvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5hYnNwYXRo KF9fZmlsZV9fKSkKLSAgICAgICAgcmV0dXJuIGpzb24ubG9hZChvcGVuKG9zLnBhdGguam9pbihj d2QsICdjb25maWcuanNvbicpKSkKKyAgICAgICAgd2l0aCBvcGVuKG9zLnBhdGguam9pbihjd2Qs ICdjb25maWcuanNvbicpLCAncicpIGFzIGNvbmZpZzoKKyAgICAgICAgICAgIHJldHVybiBqc29u LmxvYWQoY29uZmlnKQogCiAgICAgZGVmIGdldF9idWlsZGVyX2Zyb21fY29uZmlnKHNlbGYsIGNv bmZpZywgYnVpbGRlcl9uYW1lKToKICAgICAgICAgZm9yIGJ1aWxkZXIgaW4gY29uZmlnWydidWls ZGVycyddOgo=