225344 2021-05-04 01:05:29 -0700 localStorage changes aren't reflected between WKWebViews using WKWebViewConfiguration._groupIdentifier 2021-07-29 19:37:21 -0700 1 1 1 Unclassified WebKit DOM Safari 14 Unspecified Unspecified RESOLVED FIXED InRadar P2 Blocker --- 1 jaffathecake achristensen achristensen beidson bugmail cabanier cdumez darin emilio eoconnor graouts gsnedders koddsson lwarlow m m.kurz+webkitbugs rik shantmarouti sihui_liu simon.fraser tomac twilco.o webkit-bug-importer oldest_to_newest 1756468 0 jaffathecake 2021-05-04 01:05:29 -0700 Using Safari 14.1 or later: 1. Tab A: Open https://static-misc-3.glitch.me/localstorage-bug/ in new tab 2. Tab A: Hit 'increment' 3. Tab B: Open https://static-misc-3.glitch.me/localstorage-bug/ in new tab - it displays '1' as expected 4. Tab B: Hit 'increment' Tab A does not get a 'storage' event, clicking "Re-get value" returns the same value. It seems like localStorage state is copied at some point, but it doesn't receive any updates after that. However, it's still writing to the underlying data store. Refreshing the page still returns stale data. This will result in data loss on websites, as two tabs will be writing to storage, unaware of each others' changes. Additionally, the 'storage' event is used for cross-tab communication in Safari, since it doesn't support BroadcastChannel, and this bug breaks that. In fact, BroadcastChannel polyfills use the 'storage' event https://github.com/JSmith01/broadcastchannel-polyfill. 1756480 1 jaffathecake 2021-05-04 02:36:52 -0700 In case anyone needs a workaround, you can switch to indexeddb for storage, and use service workers to communicate the changes between tabs https://static-misc-3.glitch.me/safari-storage-workaround/ 1756481 2 tomac 2021-05-04 02:52:37 -0700 (Somewhat related: people have been asking for `BroadcastChannel` support in https://bugs.webkit.org/show_bug.cgi?id=161472.) 1756487 3 webkit-bug-importer 2021-05-04 03:11:22 -0700 <rdar://problem/77496721> 1756491 4 jaffathecake 2021-05-04 03:37:44 -0700 Here's a failing wpt http://wpt.live/webstorage/storage_local_window_open.window.html 1756503 5 lwarlow 2021-05-04 05:45:50 -0700 It's worth noting this appears to only be the case on macOS. iOS seems to behave as expected. Tested with iPad OS 14.5.1 and macOS Big Sur 11.3.1. 1756538 6 cdumez 2021-05-04 08:25:46 -0700 Investigating. Thanks for the bug report. 1756545 7 cdumez 2021-05-04 08:52:59 -0700 Looks like this was caused by a Safari change, not a WebKit change. Keeping this WebKit bug report open for now in case we need a WebKit-side fix. 1756641 8 427693 achristensen 2021-05-04 13:04:25 -0700 Created attachment 427693 Patch 1756665 9 427693 simon.fraser 2021-05-04 14:03:36 -0700 Comment on attachment 427693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427693&action=review > Source/WebKit/UIProcess/WebPageGroup.cpp:86 > + data.pageGroupID = generatePageGroupID(); Why don't we use ObjectIdentifier<> for the page group? 1756668 10 achristensen 2021-05-04 14:06:58 -0700 We should. This is old code that hasn't been updated to our newer idioms, but I certainly don't want to do that in this patch for the reason stated in the ChangeLog. 1756676 11 achristensen 2021-05-04 14:32:16 -0700 http://trac.webkit.org/r276983 1756759 12 427693 darin 2021-05-04 18:36:49 -0700 Comment on attachment 427693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427693&action=review > Source/WebKit/UIProcess/WebPageGroup.cpp:81 > + if (HashMap<String, uint64_t>::isValidKey(identifier)) { Seems like overkill to use isValidKey here. If null is a special value, meaning we don’t have one, we should check for null. The fact that null also can’t be used as a hash table key is a separate thing that doesn’t seem the same to me. 1756970 13 achristensen 2021-05-05 10:05:24 -0700 It is probably overkill, but I wanted this to be as low risk as possible to merge onto a branch. I intend to remove all this code soon. 1756978 14 darin 2021-05-05 10:17:26 -0700 (In reply to Alex Christensen from comment #13) > It is probably overkill, but I wanted this to be as low risk as possible to > merge onto a branch. I intend to remove all this code soon. I understand what you are saying. I don’t think that using isValidKey makes this lower risk than an isNull() check. 1757029 15 achristensen 2021-05-05 12:19:45 -0700 I think you're right. It seems impossible to pass a hash-table-deleted string through our API. 1767881 16 tomac 2021-06-08 13:24:16 -0700 This fix seems to have rolled out with iOS/iPadOS 15 beta 1. 1775696 17 m 2021-07-08 09:56:22 -0700 Will this also land in 14.2, if/when that comes? Seems like a big regression that's worth patching before 15. Even worth a 14.1.1 if you ask me. 1775697 18 achristensen 2021-07-08 09:57:35 -0700 We are aware of how important this bug is. We have no comment on future releases. 1780196 19 gsnedders 2021-07-28 14:01:18 -0700 (In reply to Thomas Steiner from comment #16) > This fix seems to have rolled out with iOS/iPadOS 15 beta 1. As mentioned above, this never affected iOS/iPadOS, as it was macOS only. To note, this was fixed in macOS 11.5. 427693 2021-05-04 13:04:25 -0700 2021-05-04 13:23:20 -0700 Patch bug-225344-20210504130424.patch text/plain 5450 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzZDE2ZTFkMjkxZjkwYWNk MjVkYTE4M2Q2NGVjOGQ2MmMwZjJlYmIuLmEyNmU5YTE1NjJjMmM1Y2U0NDg4M2FlYzFiODUyNGNm MjUxNTQ2NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDUtMDQgIEFsZXggQ2hy aXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBsb2NhbFN0b3Jh Z2UgY2hhbmdlcyBhcmVuJ3QgcmVmbGVjdGVkIGJldHdlZW4gV0tXZWJWaWV3cyB1c2luZyBXS1dl YlZpZXdDb25maWd1cmF0aW9uLl9ncm91cElkZW50aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTM0NAorICAgICAgICA8cmRhcjovLzc3NDk2 NzIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdo ZW4gd2Ugc3dpdGNoZWQgZnJvbSB1c2luZyBfcGFnZUdyb3VwIHRvIF9ncm91cElkZW50aWZpZXIs IHdlIGFsc28gYnJva2UgbG9jYWxTdG9yYWdlIGJ5IG1ha2luZyBhIG5ldyBwYWdlR3JvdXBJRCBm b3IgZWFjaCBXS1dlYlZpZXcuCisgICAgICAgIFRoaXMgaXMgdGhlIGxvdy1yaXNrIHNvbHV0aW9u IHRvIHRoaXMgcHJvYmxlbSB0aGF0IHJlbWVtYmVycyB3aGF0IHBhZ2VHcm91cElEIHdlIHVzZWQg Zm9yIHRoaXMgc2FtZSBpZGVudGlmaWVyLCBjcmVhdGluZyB0aGUgZWZmZWN0IG9mCisgICAgICAg IHVzaW5nIHRoZSBzYW1lIFN0b3JhZ2VOYW1lc3BhY2VJZGVudGlmaWVyIGZvciBlYWNoIF9ncm91 cElkZW50aWZpZXIgbGlrZSB3ZSBkaWQgd2hlbiB3ZSB1c2VkIF9wYWdlR3JvdXAuCisgICAgICAg IFNlZSB0aGUgY29tbWVudCBpbiBTdG9yYWdlQXJlYU1hcDo6ZGlzcGF0Y2hMb2NhbFN0b3JhZ2VF dmVudC4KKworICAgICAgICBUaGUgaGlnaGVyLXJpc2sgc29sdXRpb24gdGhhdCBuZWVkcyB0byBi ZSBkb25lIGJ1dCBwcm9iYWJseSBzaG91bGRuJ3QgYmUgbWVyZ2VkIHRvIGEgYnJhbmNoIGF0IHRo aXMgcG9pbnQgaXMgdG8gcmVtb3ZlIFN0b3JhZ2VOYW1lc3BhY2VJZGVudGlmaWVyLgorICAgICAg ICBJIHBsYW4gdG8gZG8gdGhhdCBpbiBhIGZvbGxvdy11cCBwYXRjaC4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9XZWJQYWdlR3JvdXAuY3BwOgorICAgICAgICAoV2ViS2l0OjpwYWdlR3JvdXBEYXRh KToKKwogMjAyMS0wNC0zMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAog ICAgICAgICBbQ29jb2FdIEFsd2F5cyBleHRlbmQgYWNjZXNzIHRvIGxvY2FsIHByb2Nlc3MgSFRU UC8zIGNhY2hlIGRpcmVjdG9yeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZUdyb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VHcm91cC5j cHAKaW5kZXggMjdjZTU4NWVmODk5ODg5MzUxYjA1NWQwZjdiODU1NTk1MjYzYWE0ZS4uMTJiOTg0 YjM5NWNkMDM1OWUwZjNhOWRlNzliNTBjZDc3OTE0ZjE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUGFnZUdyb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlR3JvdXAuY3BwCkBAIC03Nyw3ICs3NywxMyBAQCBzdGF0aWMgV2ViUGFnZUdy b3VwRGF0YSBwYWdlR3JvdXBEYXRhKGNvbnN0IFN0cmluZyYgaWRlbnRpZmllcikKIHsKICAgICBX ZWJQYWdlR3JvdXBEYXRhIGRhdGE7CiAKLSAgICBkYXRhLnBhZ2VHcm91cElEID0gZ2VuZXJhdGVQ YWdlR3JvdXBJRCgpOworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3llZDxIYXNoTWFwPFN0cmluZywg dWludDY0X3Q+PiBtYXA7CisgICAgaWYgKEhhc2hNYXA8U3RyaW5nLCB1aW50NjRfdD46OmlzVmFs aWRLZXkoaWRlbnRpZmllcikpIHsKKyAgICAgICAgZGF0YS5wYWdlR3JvdXBJRCA9IG1hcC5nZXQo KS5lbnN1cmUoaWRlbnRpZmllciwgW10geworICAgICAgICAgICAgcmV0dXJuIGdlbmVyYXRlUGFn ZUdyb3VwSUQoKTsKKyAgICAgICAgfSkuaXRlcmF0b3ItPnZhbHVlOworICAgIH0gZWxzZQorICAg ICAgICBkYXRhLnBhZ2VHcm91cElEID0gZ2VuZXJhdGVQYWdlR3JvdXBJRCgpOwogCiAgICAgaWYg KCFpZGVudGlmaWVyLmlzRW1wdHkoKSkKICAgICAgICAgZGF0YS5pZGVudGlmaWVyID0gaWRlbnRp ZmllcjsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBkOGEzOTIyOTM1MmFjY2ViM2VkNDFjODg0MjViMzA3YzNiMGE2ZDI0Li5iZWNmYWY3ZTcyMzM5 MTQ3YmU5MzM1MWEzMTM3ZjZjOGY2YzM0YTM0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDUtMDQgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBsb2NhbFN0 b3JhZ2UgY2hhbmdlcyBhcmVuJ3QgcmVmbGVjdGVkIGJldHdlZW4gV0tXZWJWaWV3cyB1c2luZyBX S1dlYlZpZXdDb25maWd1cmF0aW9uLl9ncm91cElkZW50aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTM0NAorICAgICAgICA8cmRhcjovLzc3 NDk2NzIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Mb2NhbFN0b3JhZ2VQZXJzaXN0ZW5j ZS5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIxLTA0LTMwICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2Via2l0c2NweV0gU3VwcG9ydCBhcmd1bWVu dHMgdG8gVGFza1Bvb2wgc2V0dXAgYW5kIHRlYXJkb3duCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0xvY2FsU3RvcmFnZVBlcnNpc3RlbmNlLm1tIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Mb2NhbFN0b3JhZ2VQZXJzaXN0 ZW5jZS5tbQppbmRleCA1Zjc5MTkwOTQzYzc3MWU5ZDllNDQyYTBkYTI2NmZmOWEwM2JhMmYyLi43 YTNkMmM1YmM3ZDExOWI3OWQyNWFhNWM0NTQ0OGYxZGM0YTUyYmI3IDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0xvY2FsU3RvcmFnZVBlcnNpc3RlbmNl Lm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvTG9jYWxTdG9y YWdlUGVyc2lzdGVuY2UubW0KQEAgLTI3LDYgKzI3LDggQEAKIAogI2ltcG9ydCAiUGxhdGZvcm1V dGlsaXRpZXMuaCIKICNpbXBvcnQgIlRlc3QuaCIKKyNpbXBvcnQgIlRlc3ROYXZpZ2F0aW9uRGVs ZWdhdGUuaCIKKyNpbXBvcnQgIlRlc3RVSURlbGVnYXRlLmgiCiAjaW1wb3J0IDxXZWJLaXQvV0tQ cm9jZXNzUG9vbFByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9XS1VzZXJDb250ZW50Q29udHJv bGxlclByaXZhdGUuaD4KICNpbXBvcnQgPFdlYktpdC9XS1dlYlZpZXdDb25maWd1cmF0aW9uUHJp dmF0ZS5oPgpAQCAtNDE1LDMgKzQxNywzNCBAQCBURVNUKFdLV2ViVmlldywgQXV4aWxpYXJ5V2lu ZG93c1NoYXJlTG9jYWxTdG9yYWdlKQogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigmZmlu aXNoZWRSdW5uaW5nU2NyaXB0KTsKICAgICBmaW5pc2hlZFJ1bm5pbmdTY3JpcHQgPSBmYWxzZTsK IH0KKworVEVTVChXS1dlYlZpZXcsIExvY2FsU3RvcmFnZUdyb3VwKQoreworICAgIGF1dG8gcnVu VGVzdCA9IFtdIChib29sIHNldEdyb3VwSWRlbnRpZmllcikgeworICAgICAgICBhdXRvIGNvbmZp Z3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0p OworICAgICAgICBbY29uZmlndXJhdGlvbiBzZXRXZWJzaXRlRGF0YVN0b3JlOltXS1dlYnNpdGVE YXRhU3RvcmUgbm9uUGVyc2lzdGVudERhdGFTdG9yZV1dOworICAgICAgICBpZiAoc2V0R3JvdXBJ ZGVudGlmaWVyKQorICAgICAgICAgICAgW2NvbmZpZ3VyYXRpb24gX3NldEdyb3VwSWRlbnRpZmll cjpAInRlc3Rncm91cGlkZW50aWZpZXIiXTsKKyAgICAgICAgYXV0byB3ZWJWaWV3MSA9IGFkb3B0 TlMoW1tXS1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAs IDYwMCkgY29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7CisgICAgICAgIE5TU3Ry aW5nICpodG1sMSA9IEAiIgorICAgICAgICAiPHNjcmlwdD4iCisgICAgICAgICJsb2NhbFN0b3Jh Z2Uuc2V0SXRlbSgndGVzdGtleScsICd0ZXN0dmFsdWUxJyk7IgorICAgICAgICAid2luZG93Lm9u c3RvcmFnZSA9IGZ1bmN0aW9uKGUpIHsgYWxlcnQoJ3N0b3JhZ2UgY2hhbmdlZCBrZXkgJyArIGUu a2V5ICsgJyB2YWx1ZSBmcm9tICcgKyBlLm9sZFZhbHVlICsgJyB0byAnICsgZS5uZXdWYWx1ZSkg fTsiCisgICAgICAgICI8L3NjcmlwdD4iOworICAgICAgICBbd2ViVmlldzEgbG9hZEhUTUxTdHJp bmc6aHRtbDEgYmFzZVVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpAImh0dHBzOi8vd2Via2l0Lm9y Zy8iXV07CisgICAgICAgIFt3ZWJWaWV3MSBfdGVzdF93YWl0Rm9yRGlkRmluaXNoTmF2aWdhdGlv bl07CisKKyAgICAgICAgYXV0byB3ZWJWaWV3MiA9IGFkb3B0TlMoW1tXS1dlYlZpZXcgYWxsb2Nd IGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkgY29uZmlndXJhdGlvbjpj b25maWd1cmF0aW9uLmdldCgpXSk7CisgICAgICAgIE5TU3RyaW5nICpodG1sMiA9IEAiIgorICAg ICAgICAiPHNjcmlwdD4iCisgICAgICAgICJhbGVydCgnc2Vjb25kIHdlYiB2aWV3IGdvdCB2YWx1 ZSAnICsgbG9jYWxTdG9yYWdlLmdldEl0ZW0oJ3Rlc3RrZXknKSk7IgorICAgICAgICAibG9jYWxT dG9yYWdlLnNldEl0ZW0oJ3Rlc3RrZXknLCAndGVzdHZhbHVlMicpOyIKKyAgICAgICAgIjwvc2Ny aXB0PiI7CisgICAgICAgIFt3ZWJWaWV3MiBsb2FkSFRNTFN0cmluZzpodG1sMiBiYXNlVVJMOltO U1VSTCBVUkxXaXRoU3RyaW5nOkAiaHR0cHM6Ly93ZWJraXQub3JnLyJdXTsKKyAgICAgICAgRVhQ RUNUX1dLX1NUUkVRKFt3ZWJWaWV3MiBfdGVzdF93YWl0Rm9yQWxlcnRdLCAic2Vjb25kIHdlYiB2 aWV3IGdvdCB2YWx1ZSB0ZXN0dmFsdWUxIik7CisKKyAgICAgICAgRVhQRUNUX1dLX1NUUkVRKFt3 ZWJWaWV3MSBfdGVzdF93YWl0Rm9yQWxlcnRdLCAic3RvcmFnZSBjaGFuZ2VkIGtleSB0ZXN0a2V5 IHZhbHVlIGZyb20gdGVzdHZhbHVlMSB0byB0ZXN0dmFsdWUyIik7CisgICAgfTsKKyAgICBydW5U ZXN0KHRydWUpOworICAgIHJ1blRlc3QoZmFsc2UpOworfQo=