225340 2021-05-03 17:57:26 -0700 When assigning to the src value for a constructed Image(), Safari 14.1 mangles the string 2021-05-05 09:54:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari 14 Mac (Intel) macOS 11 RESOLVED WONTFIX InRadar P2 Normal --- 1 jarod.gowgiel achristensen achristensen benjamin cdumez clopez cmarcelo ews-watchlist sabouhallawa webkit-bug-importer youennf oldest_to_newest 1756396 0 jarod.gowgiel 2021-05-03 17:57:26 -0700 When assigning an SVG string that is not URI encoded to the src value of a constructed Image (https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/Image) the resulting string is mangled by Safari 14.1 but not Safari 14.0.3. I'm not sure specifically where this bug lies (JavaScriptCore or WebCore JavaScript) but I believe it must be in the JavaScript engine somewhere. As demonstrated in https://codepen.io/JarodG/pen/KKaOjRG?editors=1011 - notice: In both Safari 14.0.3 and Chrome 89.0.4389.128, assigning a simple SVG string to the src attribute maintains the same structure and formatting when read as the initial string. In Safari 14.1, however, assigning an SVG string to the same attribute causes the string to seemingly become partially encoded after an indeterminate point. The string in question goes from: '<svg xmlns="http://www.w3.org/2000/svg" width="20" height="20" viewBox="0 0 36 36"> <path fill="#DD2E44" d="M35.885 11.833c0-5.45-4.418-9.868-9.867-9.868-3.308 0-6.227 1.633-8.018 4.129-1.791-2.496-4.71-4.129-8.017-4.129-5.45 0-9.868 4.417-9.868 9.868 0 .772.098 1.52.266 2.241C1.751 22.587 11.216 31.568 18 34.034c6.783-2.466 16.249-11.447 17.617-19.959.17-.721.268-1.469.268-2.242z"/></svg>' to '<svg xmlns='http://www.w3.org/2000/svg' width='20' height='20' viewBox='0 0 36 36'> <path fill='#DD2E44%22%20d=%22M35.885%2011.833c0-5.45-4.418-9.868-9.867-9.868-3.308%200-6.227%201.633-8.018%204.129-1.791-2.496-4.71-4.129-8.017-4.129-5.45%200-9.868%204.417-9.868%209.868%200%20.772.098%201.52.266%202.241C1.751%2022.587%2011.216%2031.568%2018%2034.034c6.783-2.466%2016.249-11.447%2017.617-19.959.17-.721.268-1.469.268-2.242z%22/%3E%3C/svg%3E' I'm aware that setting the data URI like this is not the best practice, but wanted to report this as a deviation from the previous version of Safari (and a change which I couldn't find recorded anywhere). 1756634 1 webkit-bug-importer 2021-05-04 12:53:22 -0700 <rdar://problem/77521469> 1756711 2 achristensen 2021-05-04 16:33:59 -0700 This changed with https://trac.webkit.org/changeset/266399/webkit which adopts the behavior of the URL specification at https://url.spec.whatwg.org/#fragment-state The percent encoding starts after the '#' character, which begins the fragment of the URL. Your example also percent encodes those spaces in Firefox. I've noticed some odd things about fragment encoding in different browsers: Browser | new URL("data://example.com/# <>") | new URL("data://example.com/# <>") ------------------------------------------------------------------------------------- Firefox 88 | data://example.com/#%20<> | http://example.com/#%20%3C%3E Chrome 90 | data://example.com/# <> | http://example.com/#%20%3C%3E Safari 14.1 | data://example.com/#%20%3C%3E | http://example.com/#%20%3C%3E I've raised https://github.com/whatwg/url/issues/597 and intend to implement my proposed change to increase compatibility, which would revert https://trac.webkit.org/changeset/266399/webkit for non-special schemes. 1756719 3 427711 achristensen 2021-05-04 16:53:15 -0700 Created attachment 427711 Patch 1756720 4 ews-watchlist 2021-05-04 16:54:15 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1756965 5 427711 achristensen 2021-05-05 09:54:09 -0700 Comment on attachment 427711 Patch Since we follow the specification which seems to not want to change, and because Firefox behaves the same way in this case, I'm going to say we won't fix this for now. 427711 2021-05-04 16:53:15 -0700 2021-05-05 09:54:09 -0700 Patch bug-225340-20210504165314.patch text/plain 6361 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDI1Y2Q0NDMxYTVkYWI0ZThhZWJhMDFj YmZjZTAxYWQzYjY0YzQ4YjQuLjVlNTM3MTAxNGQxMjU2ZTYzN2QwZjEyZGRmYjRmYWI3ZDNmMzZh ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDUtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBXaGVuIGFzc2lnbmluZyB0byB0aGUg c3JjIHZhbHVlIGZvciBhIGNvbnN0cnVjdGVkIEltYWdlKCksIFNhZmFyaSAxNC4xIG1hbmdsZXMg dGhlIHN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI1MzQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBlZmZlY3RpdmVseSByZXZlcnRzIHIyNjYzOTkgZm9yIG5vbi1zcGVjaWFsIHNjaGVt ZXMgbGlrZSBkYXRhCisKKyAgICAgICAgKiB3dGYvVVJMUGFyc2VyLmNwcDoKKyAgICAgICAgKFdU Rjo6aXNJblNwZWNpYWxGcmFnbWVudEVuY29kZVNldCk6CisgICAgICAgIChXVEY6OlVSTFBhcnNl cjo6cGFyc2UpOgorICAgICAgICAoV1RGOjppc0luRnJhZ21lbnRFbmNvZGVTZXQpOiBEZWxldGVk LgorCiAyMDIxLTA1LTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgRG9uJ3QgaXRlcmF0ZSBOZXR3b3JrUHJvY2Vzc1Byb3h5OjptX3dlYnNp dGVEYXRhU3RvcmVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9VUkxQYXJzZXIuY3BwIGIv U291cmNlL1dURi93dGYvVVJMUGFyc2VyLmNwcAppbmRleCA0ZWQzZjQ1MGQ1NzY5MjVmNjQyN2I0 N2NmMjg4ODU3Nzg4YjJiYWYwLi5hMmE1YmRjNWYwZmM4NzdiOTRmOGNjMmY0MjU1NzkxMjk1MTg4 MTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9VUkxQYXJzZXIuY3BwCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1VSTFBhcnNlci5jcHAKQEAgLTMyNCw3ICszMjQsNyBAQCB0ZW1wbGF0ZTx0eXBl bmFtZSBDaGFyYWN0ZXJUeXBlPiBBTFdBWVNfSU5MSU5FIHN0YXRpYyBib29sIGlzQzBDb250cm9s KENoYXJhY3RlcgogdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gQUxXQVlTX0lOTElO RSBzdGF0aWMgYm9vbCBpc0MwQ29udHJvbE9yU3BhY2UoQ2hhcmFjdGVyVHlwZSBjaGFyYWN0ZXIp IHsgcmV0dXJuIGNoYXJhY3RlciA8PSAweDIwOyB9CiB0ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0 ZXJUeXBlPiBBTFdBWVNfSU5MSU5FIHN0YXRpYyBib29sIGlzVGFiT3JOZXdsaW5lKENoYXJhY3Rl clR5cGUgY2hhcmFjdGVyKSB7IHJldHVybiBjaGFyYWN0ZXIgPD0gMHhEICYmIGNoYXJhY3RlciA+ PSAweDkgJiYgY2hhcmFjdGVyICE9IDB4QiAmJiBjaGFyYWN0ZXIgIT0gMHhDOyB9CiB0ZW1wbGF0 ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPiBBTFdBWVNfSU5MSU5FIHN0YXRpYyBib29sIGlzSW5T aW1wbGVFbmNvZGVTZXQoQ2hhcmFjdGVyVHlwZSBjaGFyYWN0ZXIpIHsgcmV0dXJuIGNoYXJhY3Rl ciA+IDB4N0UgfHwgaXNDMENvbnRyb2woY2hhcmFjdGVyKTsgfQotdGVtcGxhdGU8dHlwZW5hbWUg Q2hhcmFjdGVyVHlwZT4gQUxXQVlTX0lOTElORSBzdGF0aWMgYm9vbCBpc0luRnJhZ21lbnRFbmNv ZGVTZXQoQ2hhcmFjdGVyVHlwZSBjaGFyYWN0ZXIpIHsgcmV0dXJuIGNoYXJhY3RlciA+IDB4N0Ug fHwgY2hhcmFjdGVyID09ICdgJyB8fCAoKGNoYXJhY3RlckNsYXNzVGFibGVbY2hhcmFjdGVyXSAm IFF1ZXJ5UGVyY2VudCkgJiYgY2hhcmFjdGVyICE9ICcjJyk7IH0KK3RlbXBsYXRlPHR5cGVuYW1l IENoYXJhY3RlclR5cGU+IEFMV0FZU19JTkxJTkUgc3RhdGljIGJvb2wgaXNJblNwZWNpYWxGcmFn bWVudEVuY29kZVNldChDaGFyYWN0ZXJUeXBlIGNoYXJhY3RlcikgeyByZXR1cm4gY2hhcmFjdGVy ID4gMHg3RSB8fCBjaGFyYWN0ZXIgPT0gJ2AnIHx8ICgoY2hhcmFjdGVyQ2xhc3NUYWJsZVtjaGFy YWN0ZXJdICYgUXVlcnlQZXJjZW50KSAmJiBjaGFyYWN0ZXIgIT0gJyMnKTsgfQogdGVtcGxhdGU8 dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gQUxXQVlTX0lOTElORSBzdGF0aWMgYm9vbCBpc0luRGVm YXVsdEVuY29kZVNldChDaGFyYWN0ZXJUeXBlIGNoYXJhY3RlcikgeyByZXR1cm4gY2hhcmFjdGVy ID4gMHg3RSB8fCBjaGFyYWN0ZXJDbGFzc1RhYmxlW2NoYXJhY3Rlcl0gJiBEZWZhdWx0OyB9CiB0 ZW1wbGF0ZTx0eXBlbmFtZSBDaGFyYWN0ZXJUeXBlPiBBTFdBWVNfSU5MSU5FIHN0YXRpYyBib29s IGlzSW5Vc2VySW5mb0VuY29kZVNldChDaGFyYWN0ZXJUeXBlIGNoYXJhY3RlcikgeyByZXR1cm4g Y2hhcmFjdGVyID4gMHg3RSB8fCBjaGFyYWN0ZXJDbGFzc1RhYmxlW2NoYXJhY3Rlcl0gJiBVc2Vy SW5mbzsgfQogdGVtcGxhdGU8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4gQUxXQVlTX0lOTElORSBz dGF0aWMgYm9vbCBpc1BlcmNlbnRPck5vbkFTQ0lJKENoYXJhY3RlclR5cGUgY2hhcmFjdGVyKSB7 IHJldHVybiAhaXNBU0NJSShjaGFyYWN0ZXIpIHx8IGNoYXJhY3RlciA9PSAnJSc7IH0KQEAgLTE3 NzYsNyArMTc3NiwxMCBAQCB2b2lkIFVSTFBhcnNlcjo6cGFyc2UoY29uc3QgQ2hhcmFjdGVyVHlw ZSogaW5wdXQsIGNvbnN0IHVuc2lnbmVkIGxlbmd0aCwgY29uc3QgVQogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIGNhc2UgU3RhdGU6OkZyYWdtZW50OgogICAgICAgICAgICAgVVJMX1BBUlNF Ul9MT0coIlN0YXRlIEZyYWdtZW50Iik7Ci0gICAgICAgICAgICB1dGY4UGVyY2VudEVuY29kZTxp c0luRnJhZ21lbnRFbmNvZGVTZXQ+KGMpOworICAgICAgICAgICAgaWYgKG1fdXJsSXNTcGVjaWFs KQorICAgICAgICAgICAgICAgIHV0ZjhQZXJjZW50RW5jb2RlPGlzSW5TcGVjaWFsRnJhZ21lbnRF bmNvZGVTZXQ+KGMpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgIHV0ZjhQZXJj ZW50RW5jb2RlPGlzSW5TaW1wbGVFbmNvZGVTZXQ+KGMpOwogICAgICAgICAgICAgKytjOwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmlu ZGV4IDNiYzBlMjhhYzVmMmEyZDFjZmU1ZDJjNzEzZjU4YTliOTgxNTkxZGMuLmFjNTg1NjNlMGNh N2I5OWQ2MDc0ZDMyYWNlYjJjZThjNGY5ZWMwOWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV2hlbiBhc3NpZ25pbmcgdG8gdGhlIHNy YyB2YWx1ZSBmb3IgYSBjb25zdHJ1Y3RlZCBJbWFnZSgpLCBTYWZhcmkgMTQuMSBtYW5nbGVzIHRo ZSBzdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNTM0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd2ViLXBsYXRmb3JtLXRlc3RzL3VybC9yZXNvdXJjZXMvc2V0dGVyc190ZXN0cy5qc29uOgor ICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy91cmwvcmVzb3VyY2VzL3VybHRlc3RkYXRhLmpz b246CisKIDIwMjEtMDUtMDMgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMjY2NTExKTogWyBtYWNPUyBpT1Mgd2syIF0gIGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL1JUQ1BlZXJDb25uZWN0aW9uLXJlc3RhcnRJ Y2UuaHR0cHMuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvdXJsL3Jlc291cmNlcy9zZXR0ZXJzX3Rl c3RzLmpzb24gYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Vy bC9yZXNvdXJjZXMvc2V0dGVyc190ZXN0cy5qc29uCmluZGV4IDhhYTc0ZDZiOGEyOGQ5MDIxMDUw ZjRlNTJlN2VlN2Y4ZjQxMTkxMmYuLjNjNDBmMjg2NDFkNzFlNDIyMDA5MDIxY2MyYWI4YjU4ZDYw NzcxNTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvdXJsL3Jlc291cmNlcy9zZXR0ZXJzX3Rlc3RzLmpzb24KKysrIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91cmwvcmVzb3VyY2VzL3NldHRlcnNfdGVz dHMuanNvbgpAQCAtMTkwNyw4ICsxOTA3LDggQEAKICAgICAgICAgICAgICJocmVmIjogImE6LyIs CiAgICAgICAgICAgICAibmV3X3ZhbHVlIjogIlx1MDAwMFx1MDAwMVx0XG5cclx1MDAxZiAhXCIj JCUmJygpKissLS4vMDk6Ozw9Pj9AQVpbXFxdXl9gYXp7fH1+XHUwMDdmXHUwMDgwXHUwMDgxw4nD qSIsCiAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7Ci0gICAgICAgICAgICAgICAgImhyZWYiOiAi YTovIyUwMCUwMSUxRiUyMCElMjIjJCUmJygpKissLS4vMDk6OyUzQz0lM0U/QEFaW1xcXV5fJTYw YXp7fH1+JTdGJUMyJTgwJUMyJTgxJUMzJTg5JUMzJUE5IiwKLSAgICAgICAgICAgICAgICAiaGFz aCI6ICIjJTAwJTAxJTFGJTIwISUyMiMkJSYnKCkqKywtLi8wOTo7JTNDPSUzRT9AQVpbXFxdXl8l NjBhent8fX4lN0YlQzIlODAlQzIlODElQzMlODklQzMlQTkiCisgICAgICAgICAgICAgICAgImhy ZWYiOiAiYTovIyUwMCUwMSUxRiAhXCIjJCUmJygpKissLS4vMDk6Ozw9Pj9AQVpbXFxdXl9gYXp7 fH1+JTdGJUMyJTgwJUMyJTgxJUMzJTg5JUMzJUE5IiwKKyAgICAgICAgICAgICAgICAiaGFzaCI6 ICIjJTAwJTAxJTFGICFcIiMkJSYnKCkqKywtLi8wOTo7PD0+P0BBWltcXF1eX2Bhent8fX4lN0Yl QzIlODAlQzIlODElQzMlODklQzMlQTkiCiAgICAgICAgICAgICB9CiAgICAgICAgIH0sCiAgICAg ICAgIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvdXJsL3Jlc291cmNlcy91cmx0ZXN0ZGF0YS5qc29uIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91cmwvcmVzb3VyY2VzL3VybHRlc3RkYXRhLmpzb24K aW5kZXggOTNiZTUzMTU1Mjg1MDhjMTBhMTU0MzFiYjE5MzMzZjFlZTk2ZTdiMi4uZWE0ZDdkZDVm ODdkYTc0MzQwMTQ3MWM2NmIwNWJiMjdiOTI1YTMxZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91cmwvcmVzb3VyY2VzL3VybHRlc3RkYXRh Lmpzb24KKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91 cmwvcmVzb3VyY2VzL3VybHRlc3RkYXRhLmpzb24KQEAgLTE2OCw3ICsxNjgsNyBAQAogICB7CiAg ICAgImlucHV0IjogImxvbHNjaGVtZTp4IHgjeCB4IiwKICAgICAiYmFzZSI6ICJhYm91dDpibGFu ayIsCi0gICAgImhyZWYiOiAibG9sc2NoZW1lOnggeCN4JTIweCIsCisgICAgImhyZWYiOiAibG9s c2NoZW1lOnggeCN4IHgiLAogICAgICJwcm90b2NvbCI6ICJsb2xzY2hlbWU6IiwKICAgICAidXNl cm5hbWUiOiAiIiwKICAgICAicGFzc3dvcmQiOiAiIiwKQEAgLTE3Nyw3ICsxNzcsNyBAQAogICAg ICJwb3J0IjogIiIsCiAgICAgInBhdGhuYW1lIjogInggeCIsCiAgICAgInNlYXJjaCI6ICIiLAot ICAgICJoYXNoIjogIiN4JTIweCIKKyAgICAiaGFzaCI6ICIjeCB4IgogICB9LAogICB7CiAgICAg ImlucHV0IjogImh0dHA6Ly9mOi9jIiwKQEAgLTIyOTEsNyArMjI5MSw3IEBACiAgIHsKICAgICAi aW5wdXQiOiAiZGF0YTp0ZXN0IyDCuyIsCiAgICAgImJhc2UiOiAiYWJvdXQ6YmxhbmsiLAotICAg ICJocmVmIjogImRhdGE6dGVzdCMlMjAlQzIlQkIiLAorICAgICJocmVmIjogImRhdGE6dGVzdCMg JUMyJUJCIiwKICAgICAib3JpZ2luIjogIm51bGwiLAogICAgICJwcm90b2NvbCI6ICJkYXRhOiIs CiAgICAgInVzZXJuYW1lIjogIiIsCkBAIC0yMzAxLDcgKzIzMDEsNyBAQAogICAgICJwb3J0Ijog IiIsCiAgICAgInBhdGhuYW1lIjogInRlc3QiLAogICAgICJzZWFyY2giOiAiIiwKLSAgICAiaGFz aCI6ICIjJTIwJUMyJUJCIgorICAgICJoYXNoIjogIiMgJUMyJUJCIgogICB9LAogICB7CiAgICAg ImlucHV0IjogImh0dHA6Ly93d3cuZ29vZ2xlLmNvbSIsCg==