225312 2021-05-03 09:40:47 -0700 Transfer ownership to ARC in speechSynthesisGetDefaultVoiceIdentifierForLocale 2021-05-03 13:25:06 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen cdumez cfleizach darin webkit-bug-importer oldest_to_newest 1756209 0 sihui_liu 2021-05-03 09:40:47 -0700 ... 1756210 1 webkit-bug-importer 2021-05-03 09:40:56 -0700 <rdar://problem/77458746> 1756211 2 427569 sihui_liu 2021-05-03 09:43:52 -0700 Created attachment 427569 Patch 1756254 3 ews-feeder 2021-05-03 11:51:13 -0700 Committed r276913 (237257@main): <https://commits.webkit.org/237257@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427569. 1756270 4 427569 darin 2021-05-03 12:20:26 -0700 Comment on attachment 427569 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427569&action=review > Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:230 > + return adoptCF(GetIdentifierStringForPreferredVoiceInListWithLocale(speechSynthesisGetVoiceIdentifiers().get(), (__bridge CFLocaleRef)userLocale)).bridgingAutorelease(); This looks wrong and looks like an overrelease which could introduce a security bug. A function named GetIdentifierStringForPreferredVoiceInListWithLocale will *not* return a retained CFStringRef that should be released or adopted. There’s something deeper going on here. If there’s a memory leak, then the is not the correct fix for that cause. 1756293 5 sihui_liu 2021-05-03 13:20:48 -0700 Reopening to attach new patch. 1756294 6 427591 sihui_liu 2021-05-03 13:20:49 -0700 Created attachment 427591 [fast-cq] Patch 1756296 7 ews-feeder 2021-05-03 13:23:07 -0700 Committed r276921 (237263@main): <https://commits.webkit.org/237263@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427591. 1756298 8 sihui_liu 2021-05-03 13:25:06 -0700 Revert the change as GetIdentifierStringForPreferredVoiceInListWithLocale does not actually returns a copy like Darin said, so it's not on us to release it. 427569 2021-05-03 09:43:52 -0700 2021-05-03 13:20:46 -0700 Patch bug-225312-20210503094351.patch text/plain 1741 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjAwMjM1NDA4NTZhZTI3 MGYzMzJhYWYwMmVkMWUxMGY5OWVhNTkyNy4uNmE2OTdiNzdjYzk4OWUyYzg3OTZlNTZkZDg3ZmY5 NTZkYTZmMmZiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFRyYW5zZmVyIG93bmVyc2hp cCB0byBBUkMgaW4gc3BlZWNoU3ludGhlc2lzR2V0RGVmYXVsdFZvaWNlSWRlbnRpZmllckZvckxv Y2FsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1 MzEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NzQ1ODc0Nj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBmaXggbWVtb3J5IGxlYWsgb2YgZGVm YXVsdFZvaWNlVVJJLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1BsYXRmb3JtU3BlZWNoU3lu dGhlc2l6ZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpzcGVlY2hTeW50aGVzaXNHZXREZWZh dWx0Vm9pY2VJZGVudGlmaWVyRm9yTG9jYWxlKToKKwogMjAyMS0wNS0wMiAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIGdldFByb3BlcnR5VmFsdWUgZm9yIHVybCBwYXRo IGRvZXNuJ3QgcmV0dXJuIHRoZSAiIyIgY2hhcmFjdGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplck1hYy5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVyTWFjLm1tCmlu ZGV4IGEyODVjMjJiMjIxMWNmYTY5MWE4ZTI4YjJkOTEwOTY5ZDk5MDZlOGYuLjIzNWI0YzRkNzE5 MTBjOWYzOGM5MzMxZmFjN2M0NTM3N2Y0MzQwZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVyTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNwZWVjaFN5bnRoZXNpemVyTWFjLm1tCkBA IC0yMjcsNyArMjI3LDcgQEAgc3RhdGljIE5TU3RyaW5nICpzcGVlY2hTeW50aGVzaXNHZXREZWZh dWx0Vm9pY2VJZGVudGlmaWVyRm9yTG9jYWxlKE5TTG9jYWxlICp1c2UKICAgICBpZiAoIXVzZXJM b2NhbGUpCiAgICAgICAgIHJldHVybiBuaWw7CiAKLSAgICByZXR1cm4gKF9fYnJpZGdlIE5TU3Ry aW5nICopR2V0SWRlbnRpZmllclN0cmluZ0ZvclByZWZlcnJlZFZvaWNlSW5MaXN0V2l0aExvY2Fs ZShzcGVlY2hTeW50aGVzaXNHZXRWb2ljZUlkZW50aWZpZXJzKCkuZ2V0KCksIChfX2JyaWRnZSBD RkxvY2FsZVJlZil1c2VyTG9jYWxlKTsKKyAgICByZXR1cm4gYWRvcHRDRihHZXRJZGVudGlmaWVy U3RyaW5nRm9yUHJlZmVycmVkVm9pY2VJbkxpc3RXaXRoTG9jYWxlKHNwZWVjaFN5bnRoZXNpc0dl dFZvaWNlSWRlbnRpZmllcnMoKS5nZXQoKSwgKF9fYnJpZGdlIENGTG9jYWxlUmVmKXVzZXJMb2Nh bGUpKS5icmlkZ2luZ0F1dG9yZWxlYXNlKCk7CiB9CiAKIHZvaWQgUGxhdGZvcm1TcGVlY2hTeW50 aGVzaXplcjo6aW5pdGlhbGl6ZVZvaWNlTGlzdCgpCg== 427591 2021-05-03 13:20:49 -0700 2021-05-03 13:23:08 -0700 [fast-cq] Patch bug-225312-20210503132049.patch text/plain 1670 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEwMDA3NzU5ODRiYmMy NTQzZTFhMmMzM2I1ZWRmMmQyOWVlZjUwYS4uOGNkY2E3Nzk3MWFkNTRlMTUzOTJjMjA1OGZiNzQz MGRjNDE5Y2Q2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA1LTAzICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJldmVy dGluZyByMjc2OTEzLgorCisgICAgICAgIENvbW1pdCBjYW4gY2F1c2UgZG91YmxlIHJlbGVhc2UK KworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIlRyYW5zZmVyIG93bmVy c2hpcCB0byBBUkMgaW4KKyAgICAgICAgc3BlZWNoU3ludGhlc2lzR2V0RGVmYXVsdFZvaWNlSWRl bnRpZmllckZvckxvY2FsZSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyNTMxMgorICAgICAgICBodHRwczovL2NvbW1pdHMud2Via2l0Lm9yZy9yMjc2 OTEzCisKIDIwMjEtMDUtMDMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAg ICAgICAgIFttYWNDYXRhbHlzdF0gIkVudGVyIEZ1bGwgU2NyZWVuIiBidXR0b24gaW4gbWVkaWEg Y29udHJvbHMgZGlzYXBwZWFycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWFjL1BsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplck1hYy5tbQppbmRleCAyMzViNGM0ZDcx OTEwYzlmMzhjOTMzMWZhYzdjNDUzNzdmNDM0MGU2Li5hMjg1YzIyYjIyMTFjZmE2OTFhOGUyOGIy ZDkxMDk2OWQ5OTA2ZThmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplck1hYy5tbQpAQCAtMjI3LDcgKzIyNyw3 IEBAIHN0YXRpYyBOU1N0cmluZyAqc3BlZWNoU3ludGhlc2lzR2V0RGVmYXVsdFZvaWNlSWRlbnRp ZmllckZvckxvY2FsZShOU0xvY2FsZSAqdXNlCiAgICAgaWYgKCF1c2VyTG9jYWxlKQogICAgICAg ICByZXR1cm4gbmlsOwogCi0gICAgcmV0dXJuIGFkb3B0Q0YoR2V0SWRlbnRpZmllclN0cmluZ0Zv clByZWZlcnJlZFZvaWNlSW5MaXN0V2l0aExvY2FsZShzcGVlY2hTeW50aGVzaXNHZXRWb2ljZUlk ZW50aWZpZXJzKCkuZ2V0KCksIChfX2JyaWRnZSBDRkxvY2FsZVJlZil1c2VyTG9jYWxlKSkuYnJp ZGdpbmdBdXRvcmVsZWFzZSgpOworICAgIHJldHVybiAoX19icmlkZ2UgTlNTdHJpbmcgKilHZXRJ ZGVudGlmaWVyU3RyaW5nRm9yUHJlZmVycmVkVm9pY2VJbkxpc3RXaXRoTG9jYWxlKHNwZWVjaFN5 bnRoZXNpc0dldFZvaWNlSWRlbnRpZmllcnMoKS5nZXQoKSwgKF9fYnJpZGdlIENGTG9jYWxlUmVm KXVzZXJMb2NhbGUpOwogfQogCiB2b2lkIFBsYXRmb3JtU3BlZWNoU3ludGhlc2l6ZXI6OmluaXRp YWxpemVWb2ljZUxpc3QoKQo=