225310 2021-05-03 08:58:48 -0700 [Stable][WPE] 2.32 build Error with ENABLE_VIDEO=OFF/ENABLE_VIDEO_TRACK=OFF 2021-05-05 02:37:44 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218042 https://bugs.webkit.org/show_bug.cgi?id=196811 P2 Normal --- 1 bst webkit-unassigned aperez bugs-noreply pnormand oldest_to_newest 1756196 0 bst 2021-05-03 08:58:48 -0700 I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch) with PACKAGECONFIG_remove = "video" That means adding -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF leads to these build failures: In file included from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:30, from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:30: [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310:39: error: 'MediaPlayer' has not been declared 1310 | virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0; | ^~~~~~~~~~~ In file included from [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:30: [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:469:10: error: 'bool WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&, PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool, bool)' marked 'final', but is not virtual 469 | bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum format, GCGLenum type, bool premultiplyAlpha, bool flipY) final; | ^~~~~~~~~~~~~~~~~~~~ 1756200 1 pnormand 2021-05-03 09:14:25 -0700 The ENABLE_VIDEO_TRACK CMake option was removed BTW. It is implied by VIDEO now. 1756219 2 pnormand 2021-05-03 10:15:51 -0700 This code was heavily updated in ToT. I don't see how the VIDEO=OFF build would fail there. Someone will need to fix this specific issue in the stable branch. 1756619 3 aperez 2021-05-04 12:03:37 -0700 (In reply to Philippe Normand from comment #2) > This code was heavily updated in ToT. I don't see how the VIDEO=OFF build > would fail there. Someone will need to fix this specific issue in the stable > branch. Backporting the fix from bug #225316 to the 2.32 release branch fixes the build with ENABLE_VIDEO=OFF. 1756622 4 pnormand 2021-05-04 12:08:37 -0700 (In reply to Bastian Krause from comment #0) > I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch) > with > > PACKAGECONFIG_remove = "video" > > That means adding > > -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF > > leads to these build failures: > > In file included from > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > GraphicsContextGLOpenGL.h:30, > from > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > GraphicsContextGLOpenGLCommon.cpp:30: > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310: > 39: error: 'MediaPlayer' has not been declared > 1310 | virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum > format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0; > | ^~~~~~~~~~~ > In file included from > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > GraphicsContextGLOpenGLCommon.cpp:30: > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > GraphicsContextGLOpenGL.h:469:10: error: 'bool > WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&, > PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool, > bool)' marked 'final', but is not virtual > 469 | bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum > format, GCGLenum type, bool premultiplyAlpha, bool flipY) final; > | ^~~~~~~~~~~~~~~~~~~~ But bug 225316 doesn't fix any of that ^^^ I'm confused now :) 1756629 5 aperez 2021-05-04 12:37:35 -0700 (In reply to Philippe Normand from comment #4) > (In reply to Bastian Krause from comment #0) > > I'm building wpewebkit 2.32.0 via meta-webkit@4cedcb6 (top of main branch) > > with > > > > PACKAGECONFIG_remove = "video" > > > > That means adding > > > > -DENABLE_VIDEO=OFF -DENABLE_VIDEO_TRACK=OFF > > > > leads to these build failures: > > > > In file included from > > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > > GraphicsContextGLOpenGL.h:30, > > from > > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > > GraphicsContextGLOpenGLCommon.cpp:30: > > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > > wpewebkit-2.32.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1310: > > 39: error: 'MediaPlayer' has not been declared > > 1310 | virtual bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject > > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum > > format, GCGLenum type, bool premultiplyAlpha, bool flipY) = 0; > > | ^~~~~~~~~~~ > > In file included from > > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > > GraphicsContextGLOpenGLCommon.cpp:30: > > [...]/build/tmp/work/cortexa9t2hf-neon-oe-linux-gnueabi/wpewebkit/2.32.0-r0/ > > wpewebkit-2.32.0/Source/WebCore/platform/graphics/opengl/ > > GraphicsContextGLOpenGL.h:469:10: error: 'bool > > WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia(WebCore::MediaPlayer&, > > PlatformGLObject, GCGLenum, GCGLint, GCGLenum, GCGLenum, GCGLenum, bool, > > bool)' marked 'final', but is not virtual > > 469 | bool copyTextureFromMedia(MediaPlayer&, PlatformGLObject > > texture, GCGLenum target, GCGLint level, GCGLenum internalFormat, GCGLenum > > format, GCGLenum type, bool premultiplyAlpha, bool flipY) final; > > | ^~~~~~~~~~~~~~~~~~~~ > > But bug 225316 doesn't fix any of that ^^^ > I'm confused now :) The fix from bug #225316 was definitely needed for ENABLE_VIDEO=OFF, maybe the reporter has other build options enabled that affect the outcome. My test build was a clean done with: % CC=clang CXX=clang++ cmake -GNinja -DPORT=WPE \ -DCMAKE_BUILD_TYPE=Release -DENABLE_VIDEO=OFF -S. \ -Bbuild-wpe % ninja -C build-wpe In my case I am working on top of the release branch, which *also* has a backport of the fix for bug #224198 — both are needed. 1756630 6 aperez 2021-05-04 12:39:54 -0700 (In reply to Adrian Perez from comment #5) > The fix from bug #225316 was definitely needed for ENABLE_VIDEO=OFF, > > […] > > In my case I am working on top of the release branch, which *also* has > a backport of the fix for bug #224198 — both are needed. I went ahead and merged the fix from bug #225316 as r276977 in the release branch; this issue will be gone in 2.32.1 which will be released later this week :) 1756875 7 bst 2021-05-05 02:37:44 -0700 Awesome, thanks!