225308 2021-05-03 08:33:05 -0700 Fix syntax error message for AUTOPLUSPLUS token. 2021-05-03 19:38:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1756188 0 mark.lam 2021-05-03 08:33:05 -0700 These tokens don't current add any value, but actually produces a bug where a SyntaxError due to mis-applied ++ operator mentions "--" instead of "++". rdar://76830934 1756190 1 427563 mark.lam 2021-05-03 08:47:56 -0700 Created attachment 427563 proposed patch. 1756230 2 427563 mark.lam 2021-05-03 10:36:40 -0700 Comment on attachment 427563 proposed patch. I'm gonna investigate why there are EWS failures. 1756325 3 mark.lam 2021-05-03 14:28:49 -0700 I was wrong about AUTOPLUSPLUS not being needed. It’s needed to distinquish this: ``` statement ++ stuff ``` from this: ``` statement ++stuff ``` AUTOPLUSPLUS tells us that that there’s a `\n` there, which tells us that the ++ is a prefix for the next token, not a postfix for the last one. So, the real bug is that the SyntaxError message needs to take into account AUTOPLUSPLUS. 1756334 4 427605 mark.lam 2021-05-03 14:47:08 -0700 Created attachment 427605 proposed patch. 1756419 5 mark.lam 2021-05-03 19:38:35 -0700 Thanks for the review. The AS Mac failures are not related. Landed in r276942: <http://trac.webkit.org/r276942>. 427563 2021-05-03 08:47:56 -0700 2021-05-03 14:47:08 -0700 proposed patch. bug-225308.patch text/plain 6248 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzY4OTkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSZW1vdmUgdW4tdXNlZnVsIEFVVE9QTFVTUExVUyBhbmQgQVVUT01JTlVT TUlOVVMgbGV2ZXIgdG9rZW5zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI1MzA4CisgICAgICAgIHJkYXI6Ly83NjgzMDkzNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3ByZWZpeC1wbHVz cGx1cy1zeW50YXgtZXJyb3Itc2hvdWxkLXNheS1wbHVzcGx1cy5qczogQWRkZWQuCisKIDIwMjEt MDUtMDMgIERtaXRyeSBCZXpoZXRza292ICA8ZGJlemhldHNrb3ZAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbV0FTTS1GdW5jdGlvbi1SZWZlcmVuY2VzXSBBZGQgY2FsbF9yZWYgaW5zdHJ1Y3Rpb24K SW5kZXg6IEpTVGVzdHMvc3RyZXNzL3ByZWZpeC1wbHVzcGx1cy1zeW50YXgtZXJyb3Itc2hvdWxk LXNheS1wbHVzcGx1cy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9wcmVmaXgtcGx1 c3BsdXMtc3ludGF4LWVycm9yLXNob3VsZC1zYXktcGx1c3BsdXMuanMJKG5vbmV4aXN0ZW50KQor KysgSlNUZXN0cy9zdHJlc3MvcHJlZml4LXBsdXNwbHVzLXN5bnRheC1lcnJvci1zaG91bGQtc2F5 LXBsdXNwbHVzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMgQEAKKy8vQCBydW5EZWZh dWx0CisKK3N0ciA9ICJcbisreD8ueTsiOworCit2YXIgZXhjZXB0aW9uOwordHJ5IHsKKyAgICBl dmFsKHN0cik7Cit9IGNhdGNoIChlKSB7CisgICAgZXhjZXB0aW9uID0gZTsKK30KKworaWYgKGV4 Y2VwdGlvbiAhPSAiU3ludGF4RXJyb3I6IFByZWZpeCArKyBvcGVyYXRvciBhcHBsaWVkIHRvIHZh bHVlIHRoYXQgaXMgbm90IGEgcmVmZXJlbmNlLiIpCisgICAgdGhyb3cgIkZBSUxFRCI7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3Njg5OSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAy MS0wNS0wMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3Zl IHVuLXVzZWZ1bCBBVVRPUExVU1BMVVMgYW5kIEFVVE9NSU5VU01JTlVTIGxldmVyIHRva2Vucy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTMwOAor ICAgICAgICByZGFyOi8vNzY4MzA5MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVzZSB0b2tlbnMgZG9uJ3QgY3VycmVudCBhZGQgYW55IHZhbHVl LCBidXQgYWN0dWFsbHkgcHJvZHVjZXMgYSBidWcgd2hlcmUgYQorICAgICAgICBTeW50YXhFcnJv ciBkdWUgdG8gbWlzLWFwcGxpZWQgKysgb3BlcmF0b3IgbWVudGlvbnMgIi0tIiBpbnN0ZWFkIG9m ICIrKyIuCisKKyAgICAgICAgKiBwYXJzZXIvTGV4ZXIuY3BwOgorICAgICAgICAoSlNDOjpMZXhl cjxUPjo6bGV4V2l0aG91dENsZWFyaW5nTGluZVRlcm1pbmF0b3IpOgorICAgICAgICAqIHBhcnNl ci9QYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpvcGVyYXRvclN0cmluZyk6CisgICAgICAgIChK U0M6OlBhcnNlcjxMZXhlclR5cGU+OjpwYXJzZVVuYXJ5RXhwcmVzc2lvbik6CisgICAgICAgICog cGFyc2VyL1BhcnNlclRva2Vucy5oOgorICAgICAgICAoSlNDOjppc1VwZGF0ZU9wKToKKwogMjAy MS0wNS0wMyAgRG1pdHJ5IEJlemhldHNrb3YgIDxkYmV6aGV0c2tvdkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtXQVNNLUZ1bmN0aW9uLVJlZmVyZW5jZXNdIEFkZCBjYWxsX3JlZiBpbnN0cnVjdGlv bgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAJKHJldmlzaW9uIDI3 Njg0MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogLyoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMCBI YXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQotICogIENvcHlyaWdodCAoQykgMjAwNi0yMDE5 IEFwcGxlIEluYy4gQWxsIFJpZ2h0cyBSZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDYt MjAyMSBBcHBsZSBJbmMuIEFsbCBSaWdodHMgUmVzZXJ2ZWQuCiAgKiAgQ29weXJpZ2h0IChDKSAy MDA3IENhbWVyb24gWndhcmljaCAoY3d6d2FyaWNoQHV3YXRlcmxvby5jYSkKICAqICBDb3B5cmln aHQgKEMpIDIwMTAgWm9sdGFuIEhlcmN6ZWcgKHpoZXJjemVnQGluZi51LXN6ZWdlZC5odSkKICAq ICBDb3B5cmlnaHQgKEMpIDIwMTIgTWF0aGlhcyBCeW5lbnMgKG1hdGhpYXNAcWl3aS5iZSkKQEAg LTIwMzAsNyArMjAzMCw3IEBAIHN0YXJ0OgogICAgICAgICBzaGlmdCgpOwogICAgICAgICBpZiAo bV9jdXJyZW50ID09ICcrJykgewogICAgICAgICAgICAgc2hpZnQoKTsKLSAgICAgICAgICAgIHRv a2VuID0gKCFtX2hhc0xpbmVUZXJtaW5hdG9yQmVmb3JlVG9rZW4pID8gUExVU1BMVVMgOiBBVVRP UExVU1BMVVM7CisgICAgICAgICAgICB0b2tlbiA9IFBMVVNQTFVTOwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KICAgICAgICAgaWYgKG1fY3VycmVudCA9PSAnPScpIHsKQEAgLTIwNTAs NyArMjA1MCw3IEBAIHN0YXJ0OgogICAgICAgICAgICAgICAgICAgICBnb3RvIGluU2luZ2xlTGlu ZUNvbW1lbnQ7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQotICAgICAgICAgICAg dG9rZW4gPSAoIW1faGFzTGluZVRlcm1pbmF0b3JCZWZvcmVUb2tlbikgPyBNSU5VU01JTlVTIDog QVVUT01JTlVTTUlOVVM7CisgICAgICAgICAgICB0b2tlbiA9IE1JTlVTTUlOVVM7CiAgICAgICAg ICAgICBicmVhazsKICAgICAgICAgfQogICAgICAgICBpZiAobV9jdXJyZW50ID09ICc9JykgewpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAkocmV2aXNpb24gMjc2 ODQzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5cmlnaHQgKEMpIDE5OTktMjAwMSBI YXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENvcHlyaWdodCAoQykgMjAwMSBQZXRl ciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdodCAoQykgMjAwMy0yMDE5IEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDMtMjAyMSBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFyeSBpcyBm cmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBtb2RpZnkg aXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAt NTMyNSwxMSArNTMyNSw5IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBvcGVyYXRvclN0cmluZyhib29s IHAKIHsKICAgICBzd2l0Y2ggKHRvaykgewogICAgIGNhc2UgTUlOVVNNSU5VUzoKLSAgICBjYXNl IEFVVE9NSU5VU01JTlVTOgogICAgICAgICByZXR1cm4gcHJlZml4ID8gInByZWZpeC1kZWNyZW1l bnQiIDogImRlY3JlbWVudCI7CiAKICAgICBjYXNlIFBMVVNQTFVTOgotICAgIGNhc2UgQVVUT1BM VVNQTFVTOgogICAgICAgICByZXR1cm4gcHJlZml4ID8gInByZWZpeC1pbmNyZW1lbnQiIDogImlu Y3JlbWVudCI7CiAKICAgICBjYXNlIEVYQ0xBTUFUSU9OOgpAQCAtNTQ0NSwxMyArNTQ0MywxMSBA QCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxkZXI+IFRyZWVFeHByZXNzCiAgICAgICAgICAgICBl eHByID0gY29udGV4dC5jcmVhdGVVbmFyeVBsdXMobG9jYXRpb24sIGV4cHIpOwogICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIGNhc2UgUExVU1BMVVM6Ci0gICAgICAgIGNhc2UgQVVUT1BMVVNQ TFVTOgogICAgICAgICAgICAgQVNTRVJUKGlzU2ltcGxlQXNzaWdubWVudFRhcmdldChjb250ZXh0 LCBleHByKSk7CiAgICAgICAgICAgICBleHByID0gY29udGV4dC5tYWtlUHJlZml4Tm9kZShsb2Nh dGlvbiwgZXhwciwgT3BlcmF0b3I6OlBsdXNQbHVzLCBzdWJFeHByU3RhcnQsIHN1YkV4cHJTdGFy dCArIDIsIGVuZCk7CiAgICAgICAgICAgICBtX3BhcnNlclN0YXRlLmFzc2lnbm1lbnRDb3VudCsr OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgTUlOVVNNSU5VUzoKLSAgICAgICAg Y2FzZSBBVVRPTUlOVVNNSU5VUzoKICAgICAgICAgICAgIEFTU0VSVChpc1NpbXBsZUFzc2lnbm1l bnRUYXJnZXQoY29udGV4dCwgZXhwcikpOwogICAgICAgICAgICAgZXhwciA9IGNvbnRleHQubWFr ZVByZWZpeE5vZGUobG9jYXRpb24sIGV4cHIsIE9wZXJhdG9yOjpNaW51c01pbnVzLCBzdWJFeHBy U3RhcnQsIHN1YkV4cHJTdGFydCArIDIsIGVuZCk7CiAgICAgICAgICAgICBtX3BhcnNlclN0YXRl LmFzc2lnbm1lbnRDb3VudCsrOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Q YXJzZXJUb2tlbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2Vy L1BhcnNlclRva2Vucy5oCShyZXZpc2lvbiAyNzY4NDMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL1BhcnNlclRva2Vucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsNSBAQAog LyoKLSAqIENvcHlyaWdodCAoQykgMjAxMCwgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTAtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJp bmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTE0OCw4ICsxNDgs NiBAQCBlbnVtIEpTVG9rZW5UeXBlIHsKICAgICAvLyBCZWdpbiB0YWdnZWQgdG9rZW5zCiAgICAg UExVU1BMVVMgPSAwIHwgVW5hcnlPcFRva2VuRmxhZywKICAgICBNSU5VU01JTlVTID0gMSB8IFVu YXJ5T3BUb2tlbkZsYWcsCi0gICAgQVVUT1BMVVNQTFVTID0gMiB8IFVuYXJ5T3BUb2tlbkZsYWcs Ci0gICAgQVVUT01JTlVTTUlOVVMgPSAzIHwgVW5hcnlPcFRva2VuRmxhZywKICAgICBFWENMQU1B VElPTiA9IDQgfCBVbmFyeU9wVG9rZW5GbGFnLAogICAgIFRJTERFID0gNSB8IFVuYXJ5T3BUb2tl bkZsYWcsCiAgICAgVFlQRU9GID0gNiB8IFVuYXJ5T3BUb2tlbkZsYWcgfCBLZXl3b3JkVG9rZW5G bGFnLApAQCAtMjkzLDcgKzI5MSw3IEBAIHN0cnVjdCBKU1Rva2VuIHsKIAogQUxXQVlTX0lOTElO RSBib29sIGlzVXBkYXRlT3AoSlNUb2tlblR5cGUgdG9rZW4pCiB7Ci0gICAgcmV0dXJuIHRva2Vu ID49IFBMVVNQTFVTICYmIHRva2VuIDw9IEFVVE9NSU5VU01JTlVTOworICAgIHJldHVybiB0b2tl biA9PSBQTFVTUExVUyB8fCB0b2tlbiA9PSBNSU5VU01JTlVTOwogfQogCiBBTFdBWVNfSU5MSU5F IGJvb2wgaXNVbmFyeU9wKEpTVG9rZW5UeXBlIHRva2VuKQo= 427605 2021-05-03 14:47:08 -0700 2021-05-03 19:16:49 -0700 proposed patch. bug-225308.patch text/plain 4008 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzY5MjUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA1LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggc3ludGF4IGVycm9yIG1lc3NhZ2UgZm9yIEFVVE9QTFVTUExVUyB0 b2tlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy NTMwOAorICAgICAgICByZGFyOi8vNzY4MzA5MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9wcmVmaXgtcGx1c3BsdXMtc3ludGF4LWVy cm9yLXNob3VsZC1zYXktcGx1c3BsdXMuanM6IEFkZGVkLgorCiAyMDIxLTA1LTAzICBEbWl0cnkg QmV6aGV0c2tvdiAgPGRiZXpoZXRza292QGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dBU00tRnVu Y3Rpb24tUmVmZXJlbmNlc10gQWRkIGNhbGxfcmVmIGluc3RydWN0aW9uCkluZGV4OiBKU1Rlc3Rz L3N0cmVzcy9wcmVmaXgtcGx1c3BsdXMtc3ludGF4LWVycm9yLXNob3VsZC1zYXktcGx1c3BsdXMu anMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvcHJlZml4LXBsdXNwbHVzLXN5bnRheC1l cnJvci1zaG91bGQtc2F5LXBsdXNwbHVzLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3Ry ZXNzL3ByZWZpeC1wbHVzcGx1cy1zeW50YXgtZXJyb3Itc2hvdWxkLXNheS1wbHVzcGx1cy5qcwko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEzIEBACisvL0AgcnVuRGVmYXVsdAorCitzdHIgPSAi XG4rK3g/Lnk7IjsKKwordmFyIGV4Y2VwdGlvbjsKK3RyeSB7CisgICAgZXZhbChzdHIpOworfSBj YXRjaCAoZSkgeworICAgIGV4Y2VwdGlvbiA9IGU7Cit9CisKK2lmIChleGNlcHRpb24gIT0gIlN5 bnRheEVycm9yOiBQcmVmaXggKysgb3BlcmF0b3IgYXBwbGllZCB0byB2YWx1ZSB0aGF0IGlzIG5v dCBhIHJlZmVyZW5jZS4iKQorICAgIHRocm93ICJGQUlMRUQiOwpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCShyZXZpc2lvbiAyNzY5MDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzEgQEAKKzIwMjEtMDUtMDMgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBzeW50YXggZXJyb3IgbWVz c2FnZSBmb3IgQVVUT1BMVVNQTFVTIHRva2VuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MzA4CisgICAgICAgIHJkYXI6Ly83NjgzMDkzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciB0aGUgcmVj b3JkLCBpdCdzIG5vdCBlYXN5IHRvIHRlbGwgZnJvbSB0aGUgY29kZSB3aHkgQVVUT1BMVVNQTFVT IGlzIG5lZWRlZC4KKyAgICAgICAgSXQncyBuZWVkZWQgdG8gZGlzdGluZ3Vpc2ggdGhpczoKKyAg ICAgICAgICAgIGBgYAorICAgICAgICAgICAgc3RhdGVtZW50ICsrIHN0dWZmICAvLyArKyBpcyBh IHBvc3RmaXggb3BlcmF0b3IgYXBwbGllZCB0byBgc3RhdGVtZW50YC4KKyAgICAgICAgICAgIGBg YAorICAgICAgICBmcm9tIHRoaXM6CisgICAgICAgICAgICBgYGAKKyAgICAgICAgICAgIHN0YXRl bWVudAorICAgICAgICAgICAgKytzdHVmZiAgICAvLyBUaGUgYFxuYCBiZWZvcmUgdGhlICsrIG1h a2VzIGl0IGEgcHJlZml4IG9wZXJhdG9yIGFwcGxpZWQgdG8gYHN0dWZmYGAuCisgICAgICAgICAg ICBgYGAKKworICAgICAgICBJZiB3ZSBtZXJlbHkgdG9rZW5pemUgdGhlICsrIGFzIGEgUExVU1BM VVMgdG9rZW4sIHRoZW4gaXQncyB1bmNsZWFyIHdoZXRoZXIgaXQgYWN0cworICAgICAgICBhcyBh IHBvc3RmaXggb3IgcHJlZml4IHRva2VuIGluIHRoZSAybmQgY2FzZSBhYm92ZS4KKworICAgICAg ICBUaGlzIGlzIHdoeSB0aGUgY29ycmVjdCBmaXggaXMgbm90IHRvIGdldCByaWQgb2YgdGhlIEFV VE9QTFVTUExVUyB0b2tlbiwgYnV0IHRvCisgICAgICAgIHRlYWNoIHRoZSBzeW50YXggZXJyb3Ig bWVzc2FnZSB0byBiZSBhd2FyZSBvZiB0aGUgQVVUT1BMVVNQTFVTIHRva2VuLgorCisgICAgICAg ICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5cGU+Ojpw YXJzZVVuYXJ5RXhwcmVzc2lvbik6CisKIDIwMjEtMDUtMDMgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrcyBi ZWZvcmUgc29tZSBqc0Nhc3RzLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Q YXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFy c2VyLmNwcAkocmV2aXNpb24gMjc2OTAyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5 cmlnaHQgKEMpIDE5OTktMjAwMSBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENv cHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdo dCAoQykgMjAwMy0yMDE5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5 cmlnaHQgKEMpIDIwMDMtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgog ICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtNTM5Miw3ICs1MzkyLDcgQEAgdGVtcGxhdGUgPGNsYXNzIFRy ZWVCdWlsZGVyPiBUcmVlRXhwcmVzcwogICAgICAgICBBU1NFUlQob2xkVG9rZW5TdGFja0RlcHRo ICsgdG9rZW5TdGFja0RlcHRoID09IGNvbnRleHQudW5hcnlUb2tlblN0YWNrRGVwdGgoKSk7CiAg ICAgaWYgKGlzVXBkYXRlT3Aoc3RhdGljX2Nhc3Q8SlNUb2tlblR5cGU+KGxhc3RPcGVyYXRvcikp KSB7CiAgICAgICAgIHNlbWFudGljRmFpbElmVHJ1ZShjb250ZXh0LmlzTWV0YVByb3BlcnR5KGV4 cHIpLCBtZXRhUHJvcGVydHlOYW1lKGNvbnRleHQsIGV4cHIpLCAiIGNhbid0IGNvbWUgYWZ0ZXIg YSBwcmVmaXggb3BlcmF0b3IiKTsKLSAgICAgICAgc2VtYW50aWNGYWlsSWZGYWxzZShpc1NpbXBs ZUFzc2lnbm1lbnRUYXJnZXQoY29udGV4dCwgZXhwciksICJQcmVmaXggIiwgbGFzdE9wZXJhdG9y ID09IFBMVVNQTFVTID8gIisrIiA6ICItLSIsICIgb3BlcmF0b3IgYXBwbGllZCB0byB2YWx1ZSB0 aGF0IGlzIG5vdCBhIHJlZmVyZW5jZSIpOworICAgICAgICBzZW1hbnRpY0ZhaWxJZkZhbHNlKGlz U2ltcGxlQXNzaWdubWVudFRhcmdldChjb250ZXh0LCBleHByKSwgIlByZWZpeCAiLCBsYXN0T3Bl cmF0b3IgPT0gUExVU1BMVVMgfHwgbGFzdE9wZXJhdG9yID09IEFVVE9QTFVTUExVUyA/ICIrKyIg OiAiLS0iLCAiIG9wZXJhdG9yIGFwcGxpZWQgdG8gdmFsdWUgdGhhdCBpcyBub3QgYSByZWZlcmVu Y2UiKTsKICAgICB9CiAgICAgYm9vbCBpc0V2YWxPckFyZ3VtZW50cyA9IGZhbHNlOwogICAgIGlm IChzdHJpY3RNb2RlKCkpIHsK