22530 2008-11-27 03:18:55 -0800 Assertion failures seen on buildbot due to uninitialized WorkerThread::m_threadID 2008-11-30 00:32:02 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 100528 0 ap 2008-11-27 03:18:55 -0800 There is a race condition when initializing WorkerThread::m_threadID, because it is stored after the thread is created. This causes assertion failures when checking current thread id. Same problem is present when initializing database threads. 100529 1 25558 ap 2008-11-27 03:40:29 -0800 Created attachment 25558 proposed fix 100759 2 ap 2008-11-30 00:32:02 -0800 Committed revision 38850. 25558 2008-11-27 03:40:29 -0800 2008-11-29 11:58:54 -0800 proposed fix RaceForThreadID.txt text/plain 5700 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODgxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDgtMTEtMjcgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUzMAorICAgICAgICBB c3NlcnRpb24gZmFpbHVyZXMgc2VlbiBvbiBidWlsZGJvdCBkdWUgdG8gdW5pbml0aWFsaXplZCBX b3JrZXJUaHJlYWQ6Om1fdGhyZWFkSUQKKworICAgICAgICAqIGRvbS9Xb3JrZXJUaHJlYWQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyVGhyZWFkOjpzdGFydCk6IFByb3RlY3Qgd29ya2Vy IHN0YXJ0dXAgd2l0aCBhIG11dGV4IHRvIGVuc3VyZSB0aGF0IHRoaXMKKyAgICAgICAgZnVuY3Rp b24gcnVucyB0byBjb21wbGV0aW9uIGJlZm9yZSB0aGUgdGhyZWFkIGJlZ2lucyBleGVjdXRpb24u CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJUaHJlYWQ6OndvcmtlclRocmVhZCk6IFVwZGF0ZWQg Y29tbWVudHMuCisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJUaHJlYWQ6OnN0b3ApOiBEaXR0by4K KyAgICAgICAgKiBkb20vV29ya2VyVGhyZWFkLmg6IFJlbmFtZWQgbV93b3JrZXJDb250ZXh0TXV0 ZXggdG8gbV90aHJlYWRDcmVhdGlvbk11dGV4LCBiZWNhdXNlIGl0IG5vdworICAgICAgICBwcm90 ZWN0cyBzdGFydHVwIGFzIGEgd2hvbGUuCisKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFiYXNlVGhy ZWFkLmNwcDoKKyAgICAgICAgKiBzdG9yYWdlL0RhdGFiYXNlVGhyZWFkLmg6CisgICAgICAgICog c3RvcmFnZS9Mb2NhbFN0b3JhZ2VUaHJlYWQuY3BwOgorICAgICAgICAqIHN0b3JhZ2UvTG9jYWxT dG9yYWdlVGhyZWFkLmg6CisgICAgICAgIEZpeGVzIHRoZSBzYW1lIG1fdGhyZWFkSUQgcHJvYmxl bS4KKwogMjAwOC0xMS0yNiAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bmlrb2xhcy56aW1tZXJtYW5u QHRvcmNobW9iaWxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4K SW5kZXg6IFdlYkNvcmUvZG9tL1dvcmtlclRocmVhZC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9kb20vV29ya2VyVGhyZWFkLmNwcAkocmV2aXNpb24gMzg4MTYpCisrKyBXZWJDb3JlL2RvbS9X b3JrZXJUaHJlYWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw5IEBAIFdvcmtlclRo cmVhZDo6fldvcmtlclRocmVhZCgpCiAKIGJvb2wgV29ya2VyVGhyZWFkOjpzdGFydCgpCiB7Cisg ICAgLy8gTXV0ZXggcHJvdGVjdGlvbiBpcyBuZWNlc3NhcnkgdG8gZW5zdXJlIHRoYXQgbV90aHJl YWRJRCBpcyBpbml0aWFsaXplZCB3aGVuIHRoZSB0aHJlYWQgc3RhcnRzLgorICAgIE11dGV4TG9j a2VyIGxvY2sobV90aHJlYWRDcmVhdGlvbk11dGV4KTsKKwogICAgIGlmIChtX3RocmVhZElEKQog ICAgICAgICByZXR1cm4gdHJ1ZTsKIApAQCAtNzUsOCArNzgsNyBAQCB2b2lkKiBXb3JrZXJUaHJl YWQ6OndvcmtlclRocmVhZFN0YXJ0KHZvCiB2b2lkKiBXb3JrZXJUaHJlYWQ6OndvcmtlclRocmVh ZCgpCiB7CiAgICAgewotICAgICAgICAvLyBNdXRleCBwcm90ZWN0aW9uIGlzIG5lY2Vzc2FyeSBi ZWNhdXNlIHN0b3AoKSBjYW4gYmUgY2FsbGVkIGJlZm9yZSB0aGUgY29udGV4dCBpcyBmdWxseSBj cmVhdGVkLgotICAgICAgICBNdXRleExvY2tlciBsb2NrKG1fd29ya2VyQ29udGV4dE11dGV4KTsK KyAgICAgICAgTXV0ZXhMb2NrZXIgbG9jayhtX3RocmVhZENyZWF0aW9uTXV0ZXgpOwogICAgICAg ICBtX3dvcmtlckNvbnRleHQgPSBXb3JrZXJDb250ZXh0OjpjcmVhdGUobV9zY3JpcHRVUkwsIHRo aXMpOwogICAgIH0KIApAQCAtMTA1LDcgKzEwNyw5IEBAIHZvaWQqIFdvcmtlclRocmVhZDo6d29y a2VyVGhyZWFkKCkKIAogdm9pZCBXb3JrZXJUaHJlYWQ6OnN0b3AoKQogewotICAgIE11dGV4TG9j a2VyIGxvY2sobV93b3JrZXJDb250ZXh0TXV0ZXgpOworICAgIC8vIE11dGV4IHByb3RlY3Rpb24g aXMgbmVjZXNzYXJ5IGJlY2F1c2Ugc3RvcCgpIGNhbiBiZSBjYWxsZWQgYmVmb3JlIHRoZSBjb250 ZXh0IGlzIGZ1bGx5IGNyZWF0ZWQuCisgICAgTXV0ZXhMb2NrZXIgbG9jayhtX3RocmVhZENyZWF0 aW9uTXV0ZXgpOworCiAgICAgLy8gRW5zdXJlIHRoYXQgdGFza3MgYXJlIGJlaW5nIGhhbmRsZWQg YnkgdGhyZWFkIGV2ZW50IGxvb3AuIElmIHNjcmlwdCBleGVjdXRpb24gd2VyZW4ndCBmb3JiaWRk ZW4sIGEgd2hpbGUoMSkgbG9vcCBpbiBKUyBjb3VsZCBrZWVwIHRoZSB0aHJlYWQgYWxpdmUgZm9y ZXZlci4KICAgICBpZiAobV93b3JrZXJDb250ZXh0KQogICAgICAgICBtX3dvcmtlckNvbnRleHQt PnNjcmlwdCgpLT5mb3JiaWRFeGVjdXRpb24oKTsKSW5kZXg6IFdlYkNvcmUvZG9tL1dvcmtlclRo cmVhZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZG9tL1dvcmtlclRocmVhZC5oCShyZXZpc2lv biAzODgxNikKKysrIFdlYkNvcmUvZG9tL1dvcmtlclRocmVhZC5oCSh3b3JraW5nIGNvcHkpCkBA IC02NSw3ICs2NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgV29ya2VyTWVzc2Fn aW5nUHJveHkqIG1fbWVzc2FnaW5nUHJveHk7CiAKICAgICAgICAgUmVmUHRyPFdvcmtlckNvbnRl eHQ+IG1fd29ya2VyQ29udGV4dDsKLSAgICAgICAgTXV0ZXggbV93b3JrZXJDb250ZXh0TXV0ZXg7 CisgICAgICAgIE11dGV4IG1fdGhyZWFkQ3JlYXRpb25NdXRleDsKIAogICAgICAgICBNZXNzYWdl UXVldWU8UmVmUHRyPFdvcmtlclRhc2s+ID4gbV9tZXNzYWdlUXVldWU7CiAgICAgfTsKSW5kZXg6 IFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZVRocmVhZC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9zdG9yYWdlL0RhdGFiYXNlVGhyZWFkLmNwcAkocmV2aXNpb24gMzg4MTYpCisrKyBXZWJDb3Jl L3N0b3JhZ2UvRGF0YWJhc2VUaHJlYWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw2ICs0OCw4 IEBAIERhdGFiYXNlVGhyZWFkOjp+RGF0YWJhc2VUaHJlYWQoKQogCiBib29sIERhdGFiYXNlVGhy ZWFkOjpzdGFydCgpCiB7CisgICAgTXV0ZXhMb2NrZXIgbG9jayhtX3RocmVhZENyZWF0aW9uTXV0 ZXgpOworCiAgICAgaWYgKG1fdGhyZWFkSUQpCiAgICAgICAgIHJldHVybiB0cnVlOwogCkBAIC03 NSw3ICs3NywxMSBAQCB2b2lkKiBEYXRhYmFzZVRocmVhZDo6ZGF0YWJhc2VUaHJlYWRTdGFyCiAK IHZvaWQqIERhdGFiYXNlVGhyZWFkOjpkYXRhYmFzZVRocmVhZCgpCiB7Ci0gICAgTE9HKFN0b3Jh Z2VBUEksICJTdGFydGluZyBEYXRhYmFzZVRocmVhZCAlcCIsIHRoaXMpOworICAgIHsKKyAgICAg ICAgLy8gV2FpdCBmb3IgRGF0YWJhc2VUaHJlYWQ6OnN0YXJ0KCkgdG8gY29tcGxldGUuCisgICAg ICAgIE11dGV4TG9ja2VyIGxvY2sobV90aHJlYWRDcmVhdGlvbk11dGV4KTsKKyAgICAgICAgTE9H KFN0b3JhZ2VBUEksICJTdGFydGVkIERhdGFiYXNlVGhyZWFkICVwIiwgdGhpcyk7CisgICAgfQog CiAgICAgQXV0b2RyYWluZWRQb29sIHBvb2w7CiAgICAgd2hpbGUgKHRydWUpIHsKSW5kZXg6IFdl YkNvcmUvc3RvcmFnZS9EYXRhYmFzZVRocmVhZC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3Rv cmFnZS9EYXRhYmFzZVRocmVhZC5oCShyZXZpc2lvbiAzODgxNikKKysrIFdlYkNvcmUvc3RvcmFn ZS9EYXRhYmFzZVRocmVhZC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCw3IEBACiAjaW5j bHVkZSA8d3RmL01lc3NhZ2VRdWV1ZS5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAj aW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogCkBAIC02MSw2ICs2Miw3IEBAIHByaXZhdGU6CiAgICAgc3RhdGlj IHZvaWQqIGRhdGFiYXNlVGhyZWFkU3RhcnQodm9pZCopOwogICAgIHZvaWQqIGRhdGFiYXNlVGhy ZWFkKCk7CiAKKyAgICBNdXRleCBtX3RocmVhZENyZWF0aW9uTXV0ZXg7CiAgICAgVGhyZWFkSWRl bnRpZmllciBtX3RocmVhZElEOwogICAgIFJlZlB0cjxEYXRhYmFzZVRocmVhZD4gbV9zZWxmUmVm OwogCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvTG9jYWxTdG9yYWdlVGhyZWFkLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3N0b3JhZ2UvTG9jYWxTdG9yYWdlVGhyZWFkLmNwcAkocmV2aXNpb24g Mzg4MTYpCisrKyBXZWJDb3JlL3N0b3JhZ2UvTG9jYWxTdG9yYWdlVGhyZWFkLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDUsNiArNDUsOCBAQCBMb2NhbFN0b3JhZ2VUaHJlYWQ6OkxvY2FsU3RvcmFn ZVRocmVhZCgpCiAKIGJvb2wgTG9jYWxTdG9yYWdlVGhyZWFkOjpzdGFydCgpCiB7CisgICAgTXV0 ZXhMb2NrZXIgbG9jayhtX3RocmVhZENyZWF0aW9uTXV0ZXgpOworCiAgICAgaWYgKG1fdGhyZWFk SUQpCiAgICAgICAgIHJldHVybiB0cnVlOwogCkBAIC02MCw2ICs2MiwxMSBAQCB2b2lkKiBMb2Nh bFN0b3JhZ2VUaHJlYWQ6OmxvY2FsU3RvcmFnZVRoCiAKIHZvaWQqIExvY2FsU3RvcmFnZVRocmVh ZDo6bG9jYWxTdG9yYWdlVGhyZWFkKCkKIHsKKyAgICB7CisgICAgICAgIC8vIFdhaXQgZm9yIExv Y2FsU3RvcmFnZVRocmVhZDo6c3RhcnQoKSB0byBjb21wbGV0ZS4KKyAgICAgICAgTXV0ZXhMb2Nr ZXIgbG9jayhtX3RocmVhZENyZWF0aW9uTXV0ZXgpOworICAgIH0KKwogICAgIHdoaWxlICh0cnVl KSB7CiAgICAgICAgIFJlZlB0cjxMb2NhbFN0b3JhZ2VUYXNrPiB0YXNrOwogICAgICAgICBpZiAo IW1fcXVldWUud2FpdEZvck1lc3NhZ2UodGFzaykpCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvTG9j YWxTdG9yYWdlVGhyZWFkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL0xvY2FsU3Rv cmFnZVRocmVhZC5oCShyZXZpc2lvbiAzODgxNikKKysrIFdlYkNvcmUvc3RvcmFnZS9Mb2NhbFN0 b3JhZ2VUaHJlYWQuaAkod29ya2luZyBjb3B5KQpAQCAtNTksNiArNTksNyBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAgICAgICAgIHN0YXRpYyB2b2lkKiBsb2NhbFN0b3JhZ2VUaHJlYWRTdGFydCh2 b2lkKik7CiAgICAgICAgIHZvaWQqIGxvY2FsU3RvcmFnZVRocmVhZCgpOwogCisgICAgICAgIE11 dGV4IG1fdGhyZWFkQ3JlYXRpb25NdXRleDsKICAgICAgICAgVGhyZWFkSWRlbnRpZmllciBtX3Ro cmVhZElEOwogICAgICAgICBSZWZQdHI8TG9jYWxTdG9yYWdlVGhyZWFkPiBtX3NlbGZSZWY7CiAK