225292 2021-05-03 00:34:09 -0700 [GLIB] REGRESSION(r276879): Several tests are crashing or failing 2021-05-05 04:32:24 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225391 InRadar P2 Normal --- 1 dpino dpino benjamin bugs-noreply cdumez clopez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1756108 0 dpino 2021-05-03 00:34:09 -0700 The following tests are failing since r276879: Regressions: Unexpected text-only failures (2) imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html [ Failure ] imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.html [ Failure ] Regressions: Unexpected crashes (5) imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-controls.tentative.html [ Crash ] imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-punctuation.tentative.html [ Crash ] imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-utf-8.html [ Crash ] imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata.html [ Crash ] imported/w3c/web-platform-tests/fetch/api/response/response-consume.html [ Crash ] https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r276889%20%281519%29/imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny-actual.txt @@ -3,5 +3,5 @@ getImageData() works for sizes smaller than one pixel -PASS getImageData() works for sizes smaller than one pixel +FAIL getImageData() works for sizes smaller than one pixel The index is not in the allowed range. https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r276889%20(945)/results.html (stacktrace from debug but crashing in release too). Thread 1 (Thread 0x7fd51bbebec0 (LWP 23166)): #0 __strlen_avx2 () at ../sysdeps/x86_64/multiarch/strlen-avx2.S:65 #1 0x00007fd525b1d644 in std::char_traits<char>::length(char const*) (__s=0x0) at /usr/include/c++/10.2.0/bits/char_traits.h:357 #2 0x00007fd526ebfd2c in std::basic_string_view<char, std::char_traits<char> >::basic_string_view(char const*) (this=0x7ffcbb88e740, __str=0x0) at /usr/include/c++/10.2.0/string_view:128 #3 0x00007fd5223433dd in std::filesystem::__cxx11::path::_S_convert(char const*, std::filesystem::__cxx11::__detail::__null_terminated) (__src=0x0) at /usr/include/c++/10.2.0/bits/fs_path.h:541 #4 0x00007fd522343967 in std::filesystem::__cxx11::path::path<char const*, std::filesystem::__cxx11::path>(char const* const&, std::filesystem::__cxx11::path::format) (this=0x7ffcbb88e820, __source=@0x7ffcbb88e800: 0x0) at /usr/include/c++/10.2.0/bits/fs_path.h:225 #5 0x00007fd522342262 in WTF::FileSystemImpl::fileIsDirectory(WTF::String const&, WTF::FileSystemImpl::ShouldFollowSymbolicLinks) (path=..., shouldFollowSymbolicLinks=WTF::FileSystemImpl::ShouldFollowSymbolicLinks::Yes) at ../../Source/WTF/wtf/FileSystem.cpp:532 #6 0x00007fd528dd1c5d in WebCore::File::isDirectory() const (this=0x7fd4cb919380) at ../../Source/WebCore/fileapi/File.cpp:151 #7 0x00007fd528dd1885 in WebCore::File::File(WebCore::ScriptExecutionContext*, WebCore::File const&, WTF::String const&) (this=0x7fd4cb9192c0, context=0x7fd4ca9f9970, file=..., name=...) at ../../Source/WebCore/fileapi/File.cpp:99 #8 0x00007fd528e0feba in WebCore::File::create(WebCore::ScriptExecutionContext*, WebCore::File const&, WTF::String const&) (context=0x7fd4ca9f9970, existingFile=..., name=...) at ../../Source/WebCore/fileapi/File.h:71 #9 0x00007fd528e0c54e in WebCore::DOMFormData::createFileEntry(WTF::String const&, WebCore::Blob&, WTF::String const&) (this=0x7fd4036d0ea0, name=..., blob=..., filename=...) at ../../Source/WebCore/html/DOMFormData.cpp:65 #10 0x00007fd528e0c6bb in WebCore::DOMFormData::append(WTF::String const&, WebCore::Blob&, WTF::String const&) (this=0x7fd4036d0ea0, name=..., blob=..., filename=...) at ../../Source/WebCore/html/DOMFormData.cpp:77 #11 0x00007fd52a9a3c5f in operator()() const (__closure=0x7ffcbb88eaf0) at WebCore/DerivedSources/JSDOMFormData.cpp:260 #12 0x00007fd52a9b9115 in WebCore::toJS<WebCore::IDLUndefined, WebCore::jsDOMFormDataPrototypeFunction_append2Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::IDLOperation<WebCore::JSDOMFormData>::ClassParameter)::<lambda()> >(JSC::JSGlobalObject &, JSC::ThrowScope &, struct {...} &&) (lexicalGlobalObject=..., throwScope=..., valueOrFunctor=...) at ../../Source/WebCore/bindings/js/JSDOMConvertBase.h:165 #13 0x00007fd52a9a40ce in WebCore::jsDOMFormDataPrototypeFunction_append2Body(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::IDLOperation<WebCore::JSDOMFormData>::ClassParameter) (lexicalGlobalObject=0x7fd450254fc0, callFrame=0x7ffcbb88ed00, castedThis=0x7fd4ca6e4218) at WebCore/DerivedSources/JSDOMFormData.cpp:260 #14 0x00007fd52a9a4314 in WebCore::jsDOMFormDataPrototypeFunction_appendOverloadDispatcher(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::IDLOperation<WebCore::JSDOMFormData>::ClassParameter) (lexicalGlobalObject=0x7fd450254fc0, callFrame=0x7ffcbb88ed00, castedThis=0x7fd4ca6e4218) at WebCore/DerivedSources/JSDOMFormData.cpp:277 #15 0x00007fd52a9b9310 in WebCore::IDLOperation<WebCore::JSDOMFormData>::call<WebCore::jsDOMFormDataPrototypeFunction_appendOverloadDispatcher>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) (lexicalGlobalObject=..., callFrame=..., operationName=0x7fd52f290078 "append") at ../../Source/WebCore/bindings/js/JSDOMOperation.h:55 #16 0x00007fd52a9a43cc in WebCore::jsDOMFormDataPrototypeFunction_append(JSC::JSGlobalObject*, JSC::CallFrame*) (lexicalGlobalObject=0x7fd450254fc0, callFrame=0x7ffcbb88ed00) at WebCore/DerivedSources/JSDOMFormData.cpp:284 #17 0x00007fd4daf871d8 in () #18 0x00007ffcbb88edc0 in () #19 0x00007fd5208656b2 in llint_op_call () at /app/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:1097 #20 0x0000000000000000 in () 1756150 1 427552 dpino 2021-05-03 05:58:38 -0700 Created attachment 427552 Patch 1756170 2 427552 cdumez 2021-05-03 07:34:23 -0700 Comment on attachment 427552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427552&action=review > Source/WTF/wtf/FileSystem.cpp:531 > + if (path.isEmpty()) Please do this before initializing the local variables. 1756198 3 427566 dpino 2021-05-03 09:03:14 -0700 Created attachment 427566 Patch 1756226 4 ews-feeder 2021-05-03 10:28:50 -0700 Committed r276907 (237252@main): <https://commits.webkit.org/237252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427566. 1756227 5 webkit-bug-importer 2021-05-03 10:29:17 -0700 <rdar://problem/77461196> 427552 2021-05-03 05:58:38 -0700 2021-05-03 09:03:04 -0700 Patch bug-225292-20210503205835.patch text/plain 1367 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJmZjI5MTAxZWVmZmI2MWUyMmMyYmE5 MjhkNWQ5ZWRiNmNiMmQ5MjQuLjIyZjA0ODg5YjQwN2I5NDQxYjlhMTM4NjFkOTI2MTIzNWE0OTUy YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDUtMDMgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc2ODc5KTog U2V2ZXJhbCB0ZXN0cyBhcmUgY3Jhc2hpbmcgb3IgZmFpbGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MjkyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvRmlsZVN5c3RlbS5jcHA6IAorICAg ICAgICAoV1RGOjpGaWxlU3lzdGVtSW1wbDo6ZmlsZUlzRGlyZWN0b3J5KTogUmV0dXJuIGZhbHNl IGlmIHBhdGggaXMgZW1wdHkuCisKIDIwMjEtMDUtMDIgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBEZXN0aW5hdGlvbkNvbG9yU3BhY2U6 OkRpc3BsYXlQMyBpbiBwcmVwYXJhdGlvbiBmb3IgRGlzcGxheVAzIGNhbnZhcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lz dGVtLmNwcAppbmRleCA0NjQxMWExY2Y2MGRlOTk1OGNhMzYzNjhlZjE3NzQ3YTA4NWU3M2M0Li5j YzdiNjEzNzYxZTg4OGIzMzA3OThjNDY5NTllNzM3YmIxNzI1ZWI2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVt LmNwcApAQCAtNTI4LDYgKzUyOCw4IEBAIGJvb2wgZmlsZUlzRGlyZWN0b3J5KGNvbnN0IFN0cmlu ZyYgcGF0aCwgU2hvdWxkRm9sbG93U3ltYm9saWNMaW5rcyBzaG91bGRGb2xsb3dTCiB7CiAgICAg c3RkOjplcnJvcl9jb2RlIGVjOwogICAgIHN0ZDo6ZmlsZXN5c3RlbTo6ZmlsZV9zdGF0dXMgZmls ZVN0YXR1czsKKyAgICBpZiAocGF0aC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICBpZiAoc2hvdWxkRm9sbG93U3ltYm9saWNMaW5rcyA9PSBTaG91bGRGb2xsb3dTeW1ib2xp Y0xpbmtzOjpZZXMpCiAgICAgICAgIGZpbGVTdGF0dXMgPSBzdGQ6OmZpbGVzeXN0ZW06OnN0YXR1 cyhmaWxlU3lzdGVtUmVwcmVzZW50YXRpb24ocGF0aCkuZGF0YSgpLCBlYyk7CiAgICAgZWxzZQo= 427566 2021-05-03 09:03:14 -0700 2021-05-03 10:28:52 -0700 Patch bug-225292-20210504000312.patch text/plain 2725 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDJmZjI5MTAxZWVmZmI2MWUyMmMyYmE5 MjhkNWQ5ZWRiNmNiMmQ5MjQuLmZhM2UxNjUzNmI5YjM2ZWFlMWUzMjEzZGQ3MjZlNGMxOTMzMDE2 NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDUtMDMgIERpZWdvIFBpbm8gR2FyY2lhICA8 ZHBpbm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR0xJQl0gUkVHUkVTU0lPTihyMjc2ODc5KTog U2V2ZXJhbCB0ZXN0cyBhcmUgY3Jhc2hpbmcgb3IgZmFpbGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MjkyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXouCisKKyAgICAgICAgKiB3dGYvRmlsZVN5c3Rl bS5jcHA6IAorICAgICAgICAoV1RGOjpGaWxlU3lzdGVtSW1wbDo6ZmlsZUlzRGlyZWN0b3J5KTog UmV0dXJuIGZhbHNlIGlmIHBhdGggaXMgZW1wdHkuCisKIDIwMjEtMDUtMDIgIFNhbSBXZWluaWcg IDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBEZXN0aW5hdGlv bkNvbG9yU3BhY2U6OkRpc3BsYXlQMyBpbiBwcmVwYXJhdGlvbiBmb3IgRGlzcGxheVAzIGNhbnZh cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvRmlsZVN5c3RlbS5jcHAgYi9Tb3VyY2UvV1RG L3d0Zi9GaWxlU3lzdGVtLmNwcAppbmRleCA0NjQxMWExY2Y2MGRlOTk1OGNhMzYzNjhlZjE3NzQ3 YTA4NWU3M2M0Li44YmIzNmIwMjc5ZjUyNzg3MjEwNGMyNDE4YzEyNGNlN2VkM2FhNTEwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9GaWxlU3lzdGVtLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9GaWxlU3lzdGVtLmNwcApAQCAtNTI2LDYgKzUyNiw4IEBAIGJvb2wgZ2V0RmlsZVNpemUoY29u c3QgU3RyaW5nJiBwYXRoLCBsb25nIGxvbmcmIHJlc3VsdCkKIAogYm9vbCBmaWxlSXNEaXJlY3Rv cnkoY29uc3QgU3RyaW5nJiBwYXRoLCBTaG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzIHNob3VsZEZv bGxvd1N5bWJvbGljTGlua3MpCiB7CisgICAgaWYgKHBhdGguaXNFbXB0eSgpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgc3RkOjplcnJvcl9jb2RlIGVjOwogICAgIHN0ZDo6ZmlsZXN5c3Rl bTo6ZmlsZV9zdGF0dXMgZmlsZVN0YXR1czsKICAgICBpZiAoc2hvdWxkRm9sbG93U3ltYm9saWNM aW5rcyA9PSBTaG91bGRGb2xsb3dTeW1ib2xpY0xpbmtzOjpZZXMpCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMmRkNTNkZTBhNDRlMGRhMjNkMTNhMDgy NjY2ZTM2NzUxMzRmNjI2MS4uZTcyYzlmMjkyY2UzOTNjY2UyMGU5MDQ3MDVmZjViMjBkMmI1ODRk ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMjM1 NiwxMiArMjM1Niw2IEBAIGZhc3QvcmVwbGFjZWQvcGRmLWFzLWVtYmVkLXdpdGgtbm8tbWltZS10 eXBlLWlzLW5vdC1ibGFuay5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyCiAjIEl0IHdhcyBhIGZsYWt5 IGNyYXNoIHVudGlsIHIyNzU1MTYsIGJ1dCBpdCdzIHN0aWxsIGEgdGltZW91dCBmbGFreS4gCiB3 ZWJraXQub3JnL2IvMjI0MTEyIG1lZGlhL3ZpZGVvLWFzLWltZy1vdXRwdXQtcHRzLmh0bWwgWyBU aW1lb3V0IFBhc3MgXQogCi13ZWJraXQub3JnL2IvMjI1MjkyIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvRmlsZUFQSS9maWxlL3NlbmQtZmlsZS1mb3JtZGF0YS1jb250cm9scy50ZW50 YXRpdmUuaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjUyOTIgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9GaWxlQVBJL2ZpbGUvc2VuZC1maWxlLWZvcm1kYXRhLXB1bmN0dWF0 aW9uLnRlbnRhdGl2ZS5odG1sIFsgQ3Jhc2ggXQotd2Via2l0Lm9yZy9iLzIyNTI5MiBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL0ZpbGVBUEkvZmlsZS9zZW5kLWZpbGUtZm9ybWRhdGEt dXRmLTguaHRtbCBbIENyYXNoIF0KLXdlYmtpdC5vcmcvYi8yMjUyOTIgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9GaWxlQVBJL2ZpbGUvc2VuZC1maWxlLWZvcm1kYXRhLmh0bWwgWyBD cmFzaCBdCi13ZWJraXQub3JnL2IvMjI1MjkyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZmV0Y2gvYXBpL3Jlc3BvbnNlL3Jlc3BvbnNlLWNvbnN1bWUuaHRtbCBbIENyYXNoIF0KLQog d2Via2l0Lm9yZy9iLzIyNTI5MiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv Y2FudmFzL29mZnNjcmVlbi9waXhlbC1tYW5pcHVsYXRpb24vMmQuaW1hZ2VEYXRhLmdldC50aW55 Lmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMjUyOTIgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9odG1sL2NhbnZhcy9vZmZzY3JlZW4vcGl4ZWwtbWFuaXB1bGF0aW9uLzJk LmltYWdlRGF0YS5nZXQudGlueS53b3JrZXIuaHRtbCBbIEZhaWx1cmUgXQogCg==