<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225283</bug_id>
          
          <creation_ts>2021-05-02 13:06:06 -0700</creation_ts>
          <short_desc>glib-genmarshal generated BrowserMarshal.[ch] contained referenced to sourcedir</short_desc>
          <delta_ts>2021-05-09 12:12:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Khem Raj">raj.khem</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>annulen</cc>
    
    <cc>clopez</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>ryuan.choi</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1756070</commentid>
    <comment_count>0</comment_count>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-05-02 13:06:06 -0700</bug_when>
    <thetext>There are references to build time source folder in comments in generated sourcecode BrowserMarshal.c/BrowserMarshal.h, these sources do end up in debug packages (ipks/debs/rpms) which ends up breaking reproducible builds. We can use --skip-source cmdline option to glib-genmarshal to not including the source path in the generated header/source files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1756071</commentid>
    <comment_count>1</comment_count>
      <attachid>427531</attachid>
    <who name="Khem Raj">raj.khem</who>
    <bug_when>2021-05-02 13:09:03 -0700</bug_when>
    <thetext>Created attachment 427531
fix-v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758351</commentid>
    <comment_count>2</comment_count>
      <attachid>427531</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2021-05-09 11:45:08 -0700</bug_when>
    <thetext>Comment on attachment 427531
fix-v1

thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758358</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-05-09 12:11:29 -0700</bug_when>
    <thetext>Committed r277252 (237521@main): &lt;https://commits.webkit.org/237521@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427531.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1758359</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-09 12:12:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/77718052&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427531</attachid>
            <date>2021-05-02 13:09:03 -0700</date>
            <delta_ts>2021-05-09 12:11:30 -0700</delta_ts>
            <desc>fix-v1</desc>
            <filename>proposed-fix.patch</filename>
            <type>text/plain</type>
            <size>1638</size>
            <attacher name="Khem Raj">raj.khem</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOTIx
MDlmZjZkMDMuLjNhMzExMDI4NjBiMiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi
L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA1LTAyICBLaGVtIFJhaiAg
PHJhai5raGVtQGdtYWlsLmNvbT4KKworICAgICAgICBbVG9vbHNdIEdlbmVyYXRlIG1hcnNoYWxs
aW5nIGNvZGUgd2l0aG91dCBzb3VyY2UgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyODMKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9DTWFrZUxpc3RzLnR4
dDoKKwogMjAyMS0wNS0wMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg
ICAgIFN0YXJ0IGxldmVyYWdpbmcgc3RkOjpmaWxlc3lzdGVtIGluIFdURjo6RmlsZVN5c3RlbQpk
aWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0NNYWtlTGlzdHMudHh0IGIvVG9vbHMv
TWluaUJyb3dzZXIvZ3RrL0NNYWtlTGlzdHMudHh0CmluZGV4IDMxODk2MDI5NzhkMC4uZTE4N2Vk
YTkzNjU5IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQ01ha2VMaXN0cy50eHQK
KysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0NNYWtlTGlzdHMudHh0CkBAIC01MCw4ICs1MCw4
IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICBPVVRQVVQgJHtNaW5pQnJvd3Nlcl9ERVJJVkVE
X1NPVVJDRVNfRElSfS9Ccm93c2VyTWFyc2hhbC5jCiAgICAgICAgICAgICR7TWluaUJyb3dzZXJf
REVSSVZFRF9TT1VSQ0VTX0RJUn0vQnJvd3Nlck1hcnNoYWwuaAogICAgIE1BSU5fREVQRU5ERU5D
WSAke01pbmlCcm93c2VyX0RJUn0vYnJvd3Nlci1tYXJzaGFsLmxpc3QKLSAgICBDT01NQU5EIGds
aWItZ2VubWFyc2hhbCAtLXByZWZpeD1icm93c2VyX21hcnNoYWwgJHtNaW5pQnJvd3Nlcl9ESVJ9
L2Jyb3dzZXItbWFyc2hhbC5saXN0IC0tYm9keSA+ICR7TWluaUJyb3dzZXJfREVSSVZFRF9TT1VS
Q0VTX0RJUn0vQnJvd3Nlck1hcnNoYWwuYwotICAgIENPTU1BTkQgZ2xpYi1nZW5tYXJzaGFsIC0t
cHJlZml4PWJyb3dzZXJfbWFyc2hhbCAke01pbmlCcm93c2VyX0RJUn0vYnJvd3Nlci1tYXJzaGFs
Lmxpc3QgLS1oZWFkZXIgPiAke01pbmlCcm93c2VyX0RFUklWRURfU09VUkNFU19ESVJ9L0Jyb3dz
ZXJNYXJzaGFsLmgKKyAgICBDT01NQU5EIGdsaWItZ2VubWFyc2hhbCAtLXByZWZpeD1icm93c2Vy
X21hcnNoYWwgJHtNaW5pQnJvd3Nlcl9ESVJ9L2Jyb3dzZXItbWFyc2hhbC5saXN0IC0tYm9keSAt
LXNraXAtc291cmNlID4gJHtNaW5pQnJvd3Nlcl9ERVJJVkVEX1NPVVJDRVNfRElSfS9Ccm93c2Vy
TWFyc2hhbC5jCisgICAgQ09NTUFORCBnbGliLWdlbm1hcnNoYWwgLS1wcmVmaXg9YnJvd3Nlcl9t
YXJzaGFsICR7TWluaUJyb3dzZXJfRElSfS9icm93c2VyLW1hcnNoYWwubGlzdCAtLWhlYWRlciAt
LXNraXAtc291cmNlID4gJHtNaW5pQnJvd3Nlcl9ERVJJVkVEX1NPVVJDRVNfRElSfS9Ccm93c2Vy
TWFyc2hhbC5oCiAgICAgVkVSQkFUSU0pCiAKIGlmIChVU0VfR1RLNCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>