225274 2021-05-01 14:01:23 -0700 editing/selection/ios/become-key-window-when-focusing-editable-area.html is timing out 2021-05-03 11:35:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi megan_gardner sam thorton webkit-bug-importer oldest_to_newest 1755996 0 wenson_hsieh 2021-05-01 14:01:23 -0700 rdar://77042575 1755998 1 427513 wenson_hsieh 2021-05-01 14:03:22 -0700 Created attachment 427513 For EWS 1756000 2 427514 wenson_hsieh 2021-05-01 15:45:14 -0700 Created attachment 427514 Patch 1756004 3 427514 sam 2021-05-01 17:29:22 -0700 Comment on attachment 427514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427514&action=review > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:251 > + if (!m_otherWindow) { > + m_otherWindow = adoptNS([[UIWindow alloc] initWithWindowScene:m_window.windowScene]); > + [m_otherWindow setFrame:CGRectMake(-1, -1, 1, 1)]; > + } > + [m_otherWindow setHidden:NO]; > + [m_otherWindow makeKeyWindow]; This seems mysterious enough to warrant a comment explaining what is going on here. 1756007 4 427516 wenson_hsieh 2021-05-01 17:41:20 -0700 Created attachment 427516 Add a comment 1756248 5 ews-feeder 2021-05-03 11:35:31 -0700 Committed r276912 (237256@main): <https://commits.webkit.org/237256@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427516. 427513 2021-05-01 14:03:22 -0700 2021-05-01 15:45:13 -0700 For EWS bug-225274-20210501140321.patch text/plain 2905 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjU4YmE4MjhhMjdjYTM3YTRiOWJhNjU5M2JjMzc0YjI1 NjAzZGI4Ni4uNjlhMzMzZWVlODBiNTE0ZmRhMDEwZmFiMzYzNmE4MWU1MDVjMTFlYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTA1LTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9iZWNvbWUta2V5LXdpbmRvdy13aGVuLWZv Y3VzaW5nLWVkaXRhYmxlLWFyZWEuaHRtbCBpcyB0aW1pbmcgb3V0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyNzQKKyAgICAgICAgcmRhcjovLzc3 MDQyNTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V0lQIHBhdGNoIGZvciBFV1MuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1BsYXRmb3Jt V2ViVmlldy5oOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2ViVmll d0lPUy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpzZXRXaW5kb3dJc0tleSk6 CisgICAgICAgICgtW1dlYktpdFRlc3RSdW5uZXJXaW5kb3cgaXNLZXlXaW5kb3ddKTogRGVsZXRl ZC4KKwogMjAyMS0wNS0wMSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgRGlzYWJsZSBzZWFyY2ggZW5naW5lIGNyYXdsaW5nIG9uIGJ1aWxkLndlYmtpdC5v cmcgd2VicGFnZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1X ZWJWaWV3LmggYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCmluZGV4 IDI0YTc2N2UwMzEzZWEzOWQ3MGE1Y2JjZjQ2YTJiM2MzZGVkMDkyZjMuLmNjZTdlNDZjNDQ3NWIz ODVlZDkyODhhMjA1MjBiYTE1ZThhMTVjM2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvUGxhdGZvcm1XZWJWaWV3LmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0 Zm9ybVdlYlZpZXcuaApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIu aD4KIE9CSkNfQ0xBU1MgTlNWaWV3OwogT0JKQ19DTEFTUyBVSVZpZXc7CitPQkpDX0NMQVNTIFVJ V2luZG93OwogT0JKQ19DTEFTUyBUZXN0UnVubmVyV0tXZWJWaWV3OwogT0JKQ19DTEFTUyBXS1dl YlZpZXdDb25maWd1cmF0aW9uOwogT0JKQ19DTEFTUyBXZWJLaXRUZXN0UnVubmVyV2luZG93OwpA QCAtMTMzLDYgKzEzNCw5IEBAIHByaXZhdGU6CiAgICAgUGxhdGZvcm1XaW5kb3cgbV93aW5kb3c7 CiAgICAgYm9vbCBtX3dpbmRvd0lzS2V5OwogICAgIGNvbnN0IFRlc3RPcHRpb25zIG1fb3B0aW9u czsKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKQorICAgIFJldGFpblB0cjxVSVdpbmRvdz4gbV9v dGhlcldpbmRvdzsKKyNlbmRpZgogI2lmIFBMQVRGT1JNKEdUSykKICAgICBHdGtXaWRnZXQqIG1f b3RoZXJXaW5kb3cgeyBudWxscHRyIH07CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2ViVmlld0lPUy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvaW9zL1BsYXRmb3JtV2ViVmlld0lPUy5tbQppbmRleCA4NjFjMzFiOGVlYWYyNWVkMDRj NDhlYWVjYWRmZGI3MGMyMmVkMzRlLi5hYzVmOTMxZjE3MzZkNzk0NjBjNmY0MGZhOTJkZDI5ZTU1 ZWRmZWMyIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9QbGF0Zm9ybVdl YlZpZXdJT1MubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJW aWV3SU9TLm1tCkBAIC05MSwxMSArOTEsNiBAQCAtICh2b2lkKWRlYWxsb2MKICAgICBbc3VwZXIg ZGVhbGxvY107CiB9CiAKLS0gKEJPT0wpaXNLZXlXaW5kb3cKLXsKLSAgICByZXR1cm4gW3N1cGVy IGlzS2V5V2luZG93XSAmJiAoX3BsYXRmb3JtV2ViVmlldyA/IF9wbGF0Zm9ybVdlYlZpZXctPndp bmRvd0lzS2V5KCkgOiBZRVMpOwotfQotCiAtICh2b2lkKXNldEZyYW1lT3JpZ2luOihDR1BvaW50 KXBvaW50CiB7CiAgICAgX2Zha2VPcmlnaW4gPSBwb2ludDsKQEAgLTI0MCw4ICsyMzUsMjEgQEAg UGxhdGZvcm1XaW5kb3cgUGxhdGZvcm1XZWJWaWV3OjprZXlXaW5kb3coKQogdm9pZCBQbGF0Zm9y bVdlYlZpZXc6OnNldFdpbmRvd0lzS2V5KGJvb2wgaXNLZXkpCiB7CiAgICAgbV93aW5kb3dJc0tl eSA9IGlzS2V5OwotICAgIGlmIChpc0tleSAmJiAhbV93aW5kb3cua2V5V2luZG93KQorCisgICAg aWYgKGlzS2V5ICYmICFtX3dpbmRvdy5rZXlXaW5kb3cpIHsKKyAgICAgICAgW21fb3RoZXJXaW5k b3cgc2V0SGlkZGVuOllFU107CiAgICAgICAgIFttX3dpbmRvdyBtYWtlS2V5V2luZG93XTsKKyAg ICAgICAgcmV0dXJuOworICAgIH0KKworICAgIGlmICghaXNLZXkgJiYgbV93aW5kb3cua2V5V2lu ZG93KSB7CisgICAgICAgIGlmICghbV9vdGhlcldpbmRvdykgeworICAgICAgICAgICAgbV9vdGhl cldpbmRvdyA9IGFkb3B0TlMoW1tVSVdpbmRvdyBhbGxvY10gaW5pdFdpdGhXaW5kb3dTY2VuZTpt X3dpbmRvdy53aW5kb3dTY2VuZV0pOworICAgICAgICAgICAgW21fb3RoZXJXaW5kb3cgc2V0RnJh bWU6Q0dSZWN0TWFrZSgtMSwgLTEsIDEsIDEpXTsKKyAgICAgICAgfQorICAgICAgICBbbV9vdGhl cldpbmRvdyBzZXRIaWRkZW46Tk9dOworICAgICAgICBbbV9vdGhlcldpbmRvdyBtYWtlS2V5V2lu ZG93XTsKKyAgICB9CiB9CiAKIHZvaWQgUGxhdGZvcm1XZWJWaWV3OjphZGRUb1dpbmRvdygpCg== 427514 2021-05-01 15:45:14 -0700 2021-05-01 17:41:18 -0700 Patch bug-225274-20210501154514.patch text/plain 4740 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjU4YmE4MjhhMjdjYTM3YTRiOWJhNjU5M2JjMzc0YjI1 NjAzZGI4Ni4uYjU0YTc4OTkyYTA2NWJlYTQwM2MzMzVkYmMxNjkxN2VkNzY5YjA2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3 IEBACisyMDIxLTA1LTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9iZWNvbWUta2V5LXdpbmRvdy13aGVuLWZv Y3VzaW5nLWVkaXRhYmxlLWFyZWEuaHRtbCBpcyB0aW1pbmcgb3V0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyNzQKKyAgICAgICAgcmRhcjovLzc3 MDQyNTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyB0ZXN0IGlzIHRpbWluZyBvdXQgb24gcmVjZW50IHZlcnNpb25zIG9mIGlPUyBiZWNhdXNl IHRoZSBgLWJlY29tZUtleVdpbmRvd2Agc3ViY2xhc3NpbmcgaG9vayBpcyBubyBsb25nZXIKKyAg ICAgICAgaW52b2tlZCB3aGVuIGNhbGxpbmcgYC1tYWtlS2V5V2luZG93YCwgaW4gdGhlIGNhc2Ug d2hlcmUgdGhlIGBVSVdpbmRvd2Agd2FzIGFscmVhZHkgdGhlIGtleSB3aW5kb3cuIFRoZSBpT1MK KyAgICAgICAgdmVyc2lvbiBvZiBXZWJLaXRUZXN0UnVubmVyIG9uIGlPUyB3YXMgZGVwZW5kZW50 IG9uIHRoaXMgYmVoYXZpb3IgYmVjYXVzZSBgc2V0V2luZG93SXNLZXkoZmFsc2UpYCBvbgorICAg ICAgICBgUGxhdGZvcm1XZWJWaWV3YCBkaWQgbm90IGFjdHVhbGx5IGNhdXNlIHRoZSB0ZXN0IHJ1 bm5lciB3aW5kb3cgdG8gcmVzaWduIGZyb20gYmVpbmcgdGhlIGtleSB3aW5kb3cuIEluc3RlYWQs IGl0CisgICAgICAgIG9ubHkgc2V0IHRoZSBib29sZWFuIGZsYWcgYFBsYXRmb3JtV2ViVmlldzo6 bV93aW5kb3dJc0tleWAsIHdoaWNoIGBXZWJLaXRUZXN0UnVubmVyV2luZG93YCB0aGVuIHVzZXMg dG8gb3ZlcnJpZGUKKyAgICAgICAgdGhlIHZhbHVlIG9mIGAtW1dlYktpdFRlc3RSdW5uZXJXaW5k b3cgaXNLZXlXaW5kb3ddYCAoZWZmZWN0aXZlbHkgc2lkZS1zdGVwcGluZyBwbGF0Zm9ybSBrZXkg d2luZG93IHN0YXRlKS4KKworICAgICAgICBXZSBjYW4gZml4IHRoaXMgYnkgcmVmYWN0b3Jpbmcg YFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93SXNLZXlgIHRvIGFjdHVhbGx5IG1ha2UgdGhlIGBX ZWJLaXRUZXN0UnVubmVyV2luZG93YAorICAgICAgICByZXNpZ24ga2V5IHdpbmRvdyB3aGVuIGNh bGxpbmcgYHNldFdpbmRvd0lzS2V5KGZhbHNlKWAuIENvbXBhcmVkIHRvIG1hY09TLCBkb2luZyB0 aGlzIG9uIGlPUyBpcyBhIGJpdCB0cmlja3kKKyAgICAgICAgc2luY2UgYC1bVUlXaW5kb3cgcmVz aWduS2V5V2luZG93XWAgaXMgcHVyZWx5IGEgc3ViY2xhc3NpbmcgaG9vayB0aGF0IGlzIGludm9r ZWQgd2hlbiB0aGUgd2luZG93IGxvc2VzIGl0cworICAgICAgICBzdGF0dXMgYXMgdGhlIGtleSB3 aW5kb3cuIEhvd2V2ZXIsIHdlIGNhbiB3b3JrIGFyb3VuZCB0aGlzIGxpbWl0YXRpb24gYnkgY3Jl YXRpbmcgYSBzZXBhcmF0ZSBgVUlXaW5kb3dgIGFuZAorICAgICAgICBtYWtpbmcgdGhhdCB3aW5k b3cga2V5IGluc3RlYWQgKHdoaWNoIGltcGxpY2l0bHkgbWFrZXMgb3VyIGN1cnJlbnQgYFdlYktp dFRlc3RSdW5uZXJXaW5kb3dgIHJlc2lnbiBrZXkgd2luZG93KS4KKworICAgICAgICAqIFdlYktp dFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3Lmg6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZp ZXc6OnNldFdpbmRvd0lzS2V5KToKKworICAgICAgICBJbnN0YWxsIHRoZSBvdGhlciBgVUlXaW5k b3dgIGFuZCBtYWtlIGl0IGtleSBpbiBvcmRlciB0byByZXNpZ24gdGhlIGN1cnJlbnQga2V5IHdp bmRvdy4gTm90ZSB0aGF0IHRoaXMgd2luZG93IGlzCisgICAgICAgIHBsYWNlZCBqdXN0IG9mZnNj cmVlbiwgc28gdGhhdCBzaW11bGF0ZWQgdGFwcyBhbmQgb3RoZXIgZ2VzdHVyZXMgd2lsbCBjb250 aW51ZSB0byBnbyB0byB0aGUgb3JpZ2luYWwgd2luZG93LgorCisgICAgICAgICgtW1dlYktpdFRl c3RSdW5uZXJXaW5kb3cgaXNLZXlXaW5kb3ddKTogRGVsZXRlZC4KKworICAgICAgICBTdG9wIG92 ZXJyaWRpbmcgdGhlIHBsYXRmb3JtIGtleSB3aW5kb3cgc3RhdGUgd2l0aCB0aGUgc2ltdWxhdGVk IHRlc3QgcnVubmVyIHN0YXRlLCBzaW5jZSB3ZSBub3cgY29ycmVjdGx5CisgICAgICAgIHVwZGF0 ZSBwbGF0Zm9ybSBrZXkgd2luZG93IHN0YXRlIHdoZW4gc2V0dGluZyBgbV93aW5kb3dJc0tleWAu IFRoaXMgYWRqdXN0bWVudCBpcyBhbHNvIG5lY2Vzc2FyeSB0byBlbnN1cmUgdGhhdAorICAgICAg ICB3ZSBhY3R1YWxseSBlbmQgdXAgaW4gdGhlIGAhaXNLZXkgJiYgbV93aW5kb3cua2V5V2luZG93 YCBjYXNlIGFib3ZlLgorCiAyMDIxLTA1LTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIHNlYXJjaCBlbmdpbmUgY3Jhd2xpbmcgb24gYnVp bGQud2Via2l0Lm9yZyB3ZWJwYWdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9QbGF0Zm9ybVdlYlZpZXcuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJW aWV3LmgKaW5kZXggMjRhNzY3ZTAzMTNlYTM5ZDcwYTVjYmNmNDZhMmIzYzNkZWQwOTJmMy4uY2Nl N2U0NmM0NDc1YjM4NWVkOTI4OGEyMDUyMGJhMTVlOGExNWMzZCAxMDA2NDQKLS0tIGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSA8d3Rm L1JldGFpblB0ci5oPgogT0JKQ19DTEFTUyBOU1ZpZXc7CiBPQkpDX0NMQVNTIFVJVmlldzsKK09C SkNfQ0xBU1MgVUlXaW5kb3c7CiBPQkpDX0NMQVNTIFRlc3RSdW5uZXJXS1dlYlZpZXc7CiBPQkpD X0NMQVNTIFdLV2ViVmlld0NvbmZpZ3VyYXRpb247CiBPQkpDX0NMQVNTIFdlYktpdFRlc3RSdW5u ZXJXaW5kb3c7CkBAIC0xMzMsNiArMTM0LDkgQEAgcHJpdmF0ZToKICAgICBQbGF0Zm9ybVdpbmRv dyBtX3dpbmRvdzsKICAgICBib29sIG1fd2luZG93SXNLZXk7CiAgICAgY29uc3QgVGVzdE9wdGlv bnMgbV9vcHRpb25zOworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgUmV0YWluUHRyPFVJ V2luZG93PiBtX290aGVyV2luZG93OworI2VuZGlmCiAjaWYgUExBVEZPUk0oR1RLKQogICAgIEd0 a1dpZGdldCogbV9vdGhlcldpbmRvdyB7IG51bGxwdHIgfTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tCmluZGV4IDg2MWMzMWI4 ZWVhZjI1ZWQwNGM0OGVhZWNhZGZkYjcwYzIyZWQzNGUuLmFjNWY5MzFmMTczNmQ3OTQ2MGM2ZjQw ZmE5MmRkMjllNTVlZGZlYzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9z L1BsYXRmb3JtV2ViVmlld0lPUy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9Q bGF0Zm9ybVdlYlZpZXdJT1MubW0KQEAgLTkxLDExICs5MSw2IEBAIC0gKHZvaWQpZGVhbGxvYwog ICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIAotLSAoQk9PTClpc0tleVdpbmRvdwotewotICAgIHJl dHVybiBbc3VwZXIgaXNLZXlXaW5kb3ddICYmIChfcGxhdGZvcm1XZWJWaWV3ID8gX3BsYXRmb3Jt V2ViVmlldy0+d2luZG93SXNLZXkoKSA6IFlFUyk7Ci19Ci0KIC0gKHZvaWQpc2V0RnJhbWVPcmln aW46KENHUG9pbnQpcG9pbnQKIHsKICAgICBfZmFrZU9yaWdpbiA9IHBvaW50OwpAQCAtMjQwLDgg KzIzNSwyMSBAQCBQbGF0Zm9ybVdpbmRvdyBQbGF0Zm9ybVdlYlZpZXc6OmtleVdpbmRvdygpCiB2 b2lkIFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93SXNLZXkoYm9vbCBpc0tleSkKIHsKICAgICBt X3dpbmRvd0lzS2V5ID0gaXNLZXk7Ci0gICAgaWYgKGlzS2V5ICYmICFtX3dpbmRvdy5rZXlXaW5k b3cpCisKKyAgICBpZiAoaXNLZXkgJiYgIW1fd2luZG93LmtleVdpbmRvdykgeworICAgICAgICBb bV9vdGhlcldpbmRvdyBzZXRIaWRkZW46WUVTXTsKICAgICAgICAgW21fd2luZG93IG1ha2VLZXlX aW5kb3ddOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKCFpc0tleSAmJiBtX3dp bmRvdy5rZXlXaW5kb3cpIHsKKyAgICAgICAgaWYgKCFtX290aGVyV2luZG93KSB7CisgICAgICAg ICAgICBtX290aGVyV2luZG93ID0gYWRvcHROUyhbW1VJV2luZG93IGFsbG9jXSBpbml0V2l0aFdp bmRvd1NjZW5lOm1fd2luZG93LndpbmRvd1NjZW5lXSk7CisgICAgICAgICAgICBbbV9vdGhlcldp bmRvdyBzZXRGcmFtZTpDR1JlY3RNYWtlKC0xLCAtMSwgMSwgMSldOworICAgICAgICB9CisgICAg ICAgIFttX290aGVyV2luZG93IHNldEhpZGRlbjpOT107CisgICAgICAgIFttX290aGVyV2luZG93 IG1ha2VLZXlXaW5kb3ddOworICAgIH0KIH0KIAogdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OmFkZFRv V2luZG93KCkK 427516 2021-05-01 17:41:20 -0700 2021-05-03 11:35:31 -0700 Add a comment bug-225274-20210501174119.patch text/plain 4990 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjU4YmE4MjhhMjdjYTM3YTRiOWJhNjU5M2JjMzc0YjI1 NjAzZGI4Ni4uYjU0YTc4OTkyYTA2NWJlYTQwM2MzMzVkYmMxNjkxN2VkNzY5YjA2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3 IEBACisyMDIxLTA1LTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIGVkaXRpbmcvc2VsZWN0aW9uL2lvcy9iZWNvbWUta2V5LXdpbmRvdy13aGVuLWZv Y3VzaW5nLWVkaXRhYmxlLWFyZWEuaHRtbCBpcyB0aW1pbmcgb3V0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyNzQKKyAgICAgICAgcmRhcjovLzc3 MDQyNTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyB0ZXN0IGlzIHRpbWluZyBvdXQgb24gcmVjZW50IHZlcnNpb25zIG9mIGlPUyBiZWNhdXNl IHRoZSBgLWJlY29tZUtleVdpbmRvd2Agc3ViY2xhc3NpbmcgaG9vayBpcyBubyBsb25nZXIKKyAg ICAgICAgaW52b2tlZCB3aGVuIGNhbGxpbmcgYC1tYWtlS2V5V2luZG93YCwgaW4gdGhlIGNhc2Ug d2hlcmUgdGhlIGBVSVdpbmRvd2Agd2FzIGFscmVhZHkgdGhlIGtleSB3aW5kb3cuIFRoZSBpT1MK KyAgICAgICAgdmVyc2lvbiBvZiBXZWJLaXRUZXN0UnVubmVyIG9uIGlPUyB3YXMgZGVwZW5kZW50 IG9uIHRoaXMgYmVoYXZpb3IgYmVjYXVzZSBgc2V0V2luZG93SXNLZXkoZmFsc2UpYCBvbgorICAg ICAgICBgUGxhdGZvcm1XZWJWaWV3YCBkaWQgbm90IGFjdHVhbGx5IGNhdXNlIHRoZSB0ZXN0IHJ1 bm5lciB3aW5kb3cgdG8gcmVzaWduIGZyb20gYmVpbmcgdGhlIGtleSB3aW5kb3cuIEluc3RlYWQs IGl0CisgICAgICAgIG9ubHkgc2V0IHRoZSBib29sZWFuIGZsYWcgYFBsYXRmb3JtV2ViVmlldzo6 bV93aW5kb3dJc0tleWAsIHdoaWNoIGBXZWJLaXRUZXN0UnVubmVyV2luZG93YCB0aGVuIHVzZXMg dG8gb3ZlcnJpZGUKKyAgICAgICAgdGhlIHZhbHVlIG9mIGAtW1dlYktpdFRlc3RSdW5uZXJXaW5k b3cgaXNLZXlXaW5kb3ddYCAoZWZmZWN0aXZlbHkgc2lkZS1zdGVwcGluZyBwbGF0Zm9ybSBrZXkg d2luZG93IHN0YXRlKS4KKworICAgICAgICBXZSBjYW4gZml4IHRoaXMgYnkgcmVmYWN0b3Jpbmcg YFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93SXNLZXlgIHRvIGFjdHVhbGx5IG1ha2UgdGhlIGBX ZWJLaXRUZXN0UnVubmVyV2luZG93YAorICAgICAgICByZXNpZ24ga2V5IHdpbmRvdyB3aGVuIGNh bGxpbmcgYHNldFdpbmRvd0lzS2V5KGZhbHNlKWAuIENvbXBhcmVkIHRvIG1hY09TLCBkb2luZyB0 aGlzIG9uIGlPUyBpcyBhIGJpdCB0cmlja3kKKyAgICAgICAgc2luY2UgYC1bVUlXaW5kb3cgcmVz aWduS2V5V2luZG93XWAgaXMgcHVyZWx5IGEgc3ViY2xhc3NpbmcgaG9vayB0aGF0IGlzIGludm9r ZWQgd2hlbiB0aGUgd2luZG93IGxvc2VzIGl0cworICAgICAgICBzdGF0dXMgYXMgdGhlIGtleSB3 aW5kb3cuIEhvd2V2ZXIsIHdlIGNhbiB3b3JrIGFyb3VuZCB0aGlzIGxpbWl0YXRpb24gYnkgY3Jl YXRpbmcgYSBzZXBhcmF0ZSBgVUlXaW5kb3dgIGFuZAorICAgICAgICBtYWtpbmcgdGhhdCB3aW5k b3cga2V5IGluc3RlYWQgKHdoaWNoIGltcGxpY2l0bHkgbWFrZXMgb3VyIGN1cnJlbnQgYFdlYktp dFRlc3RSdW5uZXJXaW5kb3dgIHJlc2lnbiBrZXkgd2luZG93KS4KKworICAgICAgICAqIFdlYktp dFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJWaWV3Lmg6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tOgorICAgICAgICAoV1RSOjpQbGF0Zm9ybVdlYlZp ZXc6OnNldFdpbmRvd0lzS2V5KToKKworICAgICAgICBJbnN0YWxsIHRoZSBvdGhlciBgVUlXaW5k b3dgIGFuZCBtYWtlIGl0IGtleSBpbiBvcmRlciB0byByZXNpZ24gdGhlIGN1cnJlbnQga2V5IHdp bmRvdy4gTm90ZSB0aGF0IHRoaXMgd2luZG93IGlzCisgICAgICAgIHBsYWNlZCBqdXN0IG9mZnNj cmVlbiwgc28gdGhhdCBzaW11bGF0ZWQgdGFwcyBhbmQgb3RoZXIgZ2VzdHVyZXMgd2lsbCBjb250 aW51ZSB0byBnbyB0byB0aGUgb3JpZ2luYWwgd2luZG93LgorCisgICAgICAgICgtW1dlYktpdFRl c3RSdW5uZXJXaW5kb3cgaXNLZXlXaW5kb3ddKTogRGVsZXRlZC4KKworICAgICAgICBTdG9wIG92 ZXJyaWRpbmcgdGhlIHBsYXRmb3JtIGtleSB3aW5kb3cgc3RhdGUgd2l0aCB0aGUgc2ltdWxhdGVk IHRlc3QgcnVubmVyIHN0YXRlLCBzaW5jZSB3ZSBub3cgY29ycmVjdGx5CisgICAgICAgIHVwZGF0 ZSBwbGF0Zm9ybSBrZXkgd2luZG93IHN0YXRlIHdoZW4gc2V0dGluZyBgbV93aW5kb3dJc0tleWAu IFRoaXMgYWRqdXN0bWVudCBpcyBhbHNvIG5lY2Vzc2FyeSB0byBlbnN1cmUgdGhhdAorICAgICAg ICB3ZSBhY3R1YWxseSBlbmQgdXAgaW4gdGhlIGAhaXNLZXkgJiYgbV93aW5kb3cua2V5V2luZG93 YCBjYXNlIGFib3ZlLgorCiAyMDIxLTA1LTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBEaXNhYmxlIHNlYXJjaCBlbmdpbmUgY3Jhd2xpbmcgb24gYnVp bGQud2Via2l0Lm9yZyB3ZWJwYWdlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5l ci9QbGF0Zm9ybVdlYlZpZXcuaCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1XZWJW aWV3LmgKaW5kZXggMjRhNzY3ZTAzMTNlYTM5ZDcwYTVjYmNmNDZhMmIzYzNkZWQwOTJmMy4uY2Nl N2U0NmM0NDc1YjM4NWVkOTI4OGEyMDUyMGJhMTVlOGExNWMzZCAxMDA2NDQKLS0tIGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybVdlYlZpZXcuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1BsYXRmb3JtV2ViVmlldy5oCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSA8d3Rm L1JldGFpblB0ci5oPgogT0JKQ19DTEFTUyBOU1ZpZXc7CiBPQkpDX0NMQVNTIFVJVmlldzsKK09C SkNfQ0xBU1MgVUlXaW5kb3c7CiBPQkpDX0NMQVNTIFRlc3RSdW5uZXJXS1dlYlZpZXc7CiBPQkpD X0NMQVNTIFdLV2ViVmlld0NvbmZpZ3VyYXRpb247CiBPQkpDX0NMQVNTIFdlYktpdFRlc3RSdW5u ZXJXaW5kb3c7CkBAIC0xMzMsNiArMTM0LDkgQEAgcHJpdmF0ZToKICAgICBQbGF0Zm9ybVdpbmRv dyBtX3dpbmRvdzsKICAgICBib29sIG1fd2luZG93SXNLZXk7CiAgICAgY29uc3QgVGVzdE9wdGlv bnMgbV9vcHRpb25zOworI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgUmV0YWluUHRyPFVJ V2luZG93PiBtX290aGVyV2luZG93OworI2VuZGlmCiAjaWYgUExBVEZPUk0oR1RLKQogICAgIEd0 a1dpZGdldCogbV9vdGhlcldpbmRvdyB7IG51bGxwdHIgfTsKICNlbmRpZgpkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tCmluZGV4IDg2MWMzMWI4 ZWVhZjI1ZWQwNGM0OGVhZWNhZGZkYjcwYzIyZWQzNGUuLjQxZmIwODY5OTZlNzY3ZDExYmRmMmFl ZWNiNjBkNmU5NjBhMzI0ZDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9z L1BsYXRmb3JtV2ViVmlld0lPUy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9Q bGF0Zm9ybVdlYlZpZXdJT1MubW0KQEAgLTkxLDExICs5MSw2IEBAIC0gKHZvaWQpZGVhbGxvYwog ICAgIFtzdXBlciBkZWFsbG9jXTsKIH0KIAotLSAoQk9PTClpc0tleVdpbmRvdwotewotICAgIHJl dHVybiBbc3VwZXIgaXNLZXlXaW5kb3ddICYmIChfcGxhdGZvcm1XZWJWaWV3ID8gX3BsYXRmb3Jt V2ViVmlldy0+d2luZG93SXNLZXkoKSA6IFlFUyk7Ci19Ci0KIC0gKHZvaWQpc2V0RnJhbWVPcmln aW46KENHUG9pbnQpcG9pbnQKIHsKICAgICBfZmFrZU9yaWdpbiA9IHBvaW50OwpAQCAtMjQwLDgg KzIzNSwyNCBAQCBQbGF0Zm9ybVdpbmRvdyBQbGF0Zm9ybVdlYlZpZXc6OmtleVdpbmRvdygpCiB2 b2lkIFBsYXRmb3JtV2ViVmlldzo6c2V0V2luZG93SXNLZXkoYm9vbCBpc0tleSkKIHsKICAgICBt X3dpbmRvd0lzS2V5ID0gaXNLZXk7Ci0gICAgaWYgKGlzS2V5ICYmICFtX3dpbmRvdy5rZXlXaW5k b3cpCisKKyAgICBpZiAoaXNLZXkgJiYgIW1fd2luZG93LmtleVdpbmRvdykgeworICAgICAgICBb bV9vdGhlcldpbmRvdyBzZXRIaWRkZW46WUVTXTsKICAgICAgICAgW21fd2luZG93IG1ha2VLZXlX aW5kb3ddOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKCFpc0tleSAmJiBtX3dp bmRvdy5rZXlXaW5kb3cpIHsKKyAgICAgICAgaWYgKCFtX290aGVyV2luZG93KSB7CisgICAgICAg ICAgICBtX290aGVyV2luZG93ID0gYWRvcHROUyhbW1VJV2luZG93IGFsbG9jXSBpbml0V2l0aFdp bmRvd1NjZW5lOm1fd2luZG93LndpbmRvd1NjZW5lXSk7CisgICAgICAgICAgICBbbV9vdGhlcldp bmRvdyBzZXRGcmFtZTpDR1JlY3RNYWtlKC0xLCAtMSwgMSwgMSldOworICAgICAgICB9CisgICAg ICAgIC8vIE9uIGlPUywgdGhlcmUncyBubyBBUEkgdG8gZm9yY2UgYSBVSVdpbmRvdyB0byByZXNp Z24ga2V5IHdpbmRvdy4gSG93ZXZlciwgd2UgY2FuIGluc3RlYWQKKyAgICAgICAgLy8gY2F1c2Ug dGhlIHRlc3QgcnVubmVyIHdpbmRvdyB0byByZXNpZ24ga2V5IHdpbmRvdyBieSBtYWtpbmcgYSBk aWZmZXJlbnQgd2luZG93IChpbiB0aGlzCisgICAgICAgIC8vIGNhc2UsIG1fb3RoZXJXaW5kb3cp IHRoZSBrZXkgd2luZG93LgorICAgICAgICBbbV9vdGhlcldpbmRvdyBzZXRIaWRkZW46Tk9dOwor ICAgICAgICBbbV9vdGhlcldpbmRvdyBtYWtlS2V5V2luZG93XTsKKyAgICB9CiB9CiAKIHZvaWQg UGxhdGZvcm1XZWJWaWV3OjphZGRUb1dpbmRvdygpCg==