225268 2021-05-01 06:33:30 -0700 start-local-buildbot-server should fail gracefully for Python 2 2021-05-01 18:33:13 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222540 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap clopez jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1755935 0 aakash_jain 2021-05-01 06:33:30 -0700 start-local-buildbot-server currently fails with a confusing error when run with python2. [CISupport]$python start-local-buildbot-server --ews Setting up virtualenv at /private/var/folders/k1/w4qtfm5j7_v36jwtf1zg50n00000gn/T/tmpuZB6fl ... ... Process Process-1: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 267, in _bootstrap self.run() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/multiprocessing/process.py", line 114, in run self._target(*self._args, **self._kwargs) File "start-local-buildbot-server", line 291, in _start_server if check_tcp_port_open('localhost', self._server_pb_port): File "start-local-buildbot-server", line 79, in check_tcp_port_open except ConnectionRefusedError: NameError: global name 'ConnectionRefusedError' is not defined ConnectionRefusedError is a built-in exception in Python 3, but doesn't work in Python 2. Instead of failing with this exception, we should gracefully exit when the script is invoked with Python 2 and print a proper error message. 1755936 1 427496 aakash_jain 2021-05-01 06:34:31 -0700 Created attachment 427496 [fast-cq] Patch 1755937 2 aakash_jain 2021-05-01 06:35:48 -0700 This is similar to https://github.com/WebKit/WebKit/blob/main/Tools/CISupport/ews-build/steps.py#L42 1756009 3 ews-feeder 2021-05-01 18:32:21 -0700 Committed r276878 (237224@main): <https://commits.webkit.org/237224@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427496. 1756010 4 webkit-bug-importer 2021-05-01 18:33:13 -0700 <rdar://problem/77424789> 427496 2021-05-01 06:34:31 -0700 2021-05-01 18:32:22 -0700 [fast-cq] Patch bug-225268-20210501093430.patch text/plain 1554 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3Njg3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTA1LTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBzdGFydC1sb2NhbC1idWlsZGJvdC1zZXJ2ZXIgc2hvdWxkIGZhaWwgZ3Jh Y2VmdWxseSBmb3IgUHl0aG9uIDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyNTI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQ0lTdXBwb3J0L3N0YXJ0LWxvY2FsLWJ1aWxkYm90LXNlcnZlcjoKKwog MjAyMS0wNS0wMSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgRGlzYWJsZSBzZWFyY2ggZW5naW5lIGNyYXdsaW5nIG9uIGJ1aWxkLndlYmtpdC5vcmcgd2Vi cGFnZXMKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9zdGFydC1sb2NhbC1idWlsZGJvdC1zZXJ2ZXIK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L3N0YXJ0LWxvY2FsLWJ1aWxkYm90LXNlcnZl cgkocmV2aXNpb24gMjc2ODczKQorKysgVG9vbHMvQ0lTdXBwb3J0L3N0YXJ0LWxvY2FsLWJ1aWxk Ym90LXNlcnZlcgkod29ya2luZyBjb3B5KQpAQCAtMSw2ICsxLDcgQEAKICMhL3Vzci9iaW4vZW52 IHB5dGhvbjMKICMKICMgQ29weXJpZ2h0IChDKSAyMDE3LCAyMDIxIElnYWxpYSBTLkwuCisjIENv cHlyaWdodCAoQykgMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjCiAjIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUg Zm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0zNjAsNiArMzYxLDEwIEBAIGNsYXNzIEJ1aWxk Ym90VGVzdFJ1bm5lcihvYmplY3QpOgogCiAKIGlmIF9fbmFtZV9fID09ICdfX21haW5fXyc6Cisg ICAgaWYgc3lzLnZlcnNpb25faW5mbyA8ICgzLCA1KToKKyAgICAgICAgcHJpbnQoJ0VSUk9SOiBQ bGVhc2UgdXNlIFB5dGhvbiAzLiBUaGlzIHNjcmlwdCBpcyBub3QgY29tcGF0aWJsZSB3aXRoIFB5 dGhvbiAyLicpCisgICAgICAgIHN5cy5leGl0KDEpCisKICAgICBwYXJzZXIgPSBhcmdwYXJzZS5B cmd1bWVudFBhcnNlcigpCiAgICAgY29uZmlndXJhdGlvbiA9IHBhcnNlci5hZGRfbXV0dWFsbHlf ZXhjbHVzaXZlX2dyb3VwKHJlcXVpcmVkPVRydWUpCiAgICAgY29uZmlndXJhdGlvbi5hZGRfYXJn dW1lbnQoJy0tZXdzJywgYWN0aW9uPSdzdG9yZV9jb25zdCcsIGNvbnN0PSdld3MnLCBkZXN0PSdj b25maWd1cmF0aW9uJywK