225250 2021-04-30 14:07:26 -0700 Defend further against a PlatformCALayer's owner becoming null in PlatformCALayerCocoa::drawLayerContents. 2021-04-30 18:19:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam bfulgham simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1755798 0 heycam 2021-04-30 14:07:26 -0700 At the end of PlatformCALayer::drawLayerContents, we null check layerContents for the platformCALayerShowRepaintCounter call but not the platformCALayerIncrementRepaintCount call. 1755801 1 heycam 2021-04-30 14:16:21 -0700 <rdar://37608882> 1755815 2 427450 heycam 2021-04-30 14:50:02 -0700 Created attachment 427450 Patch 1755817 3 427452 heycam 2021-04-30 14:50:26 -0700 Created attachment 427452 Patch 1755890 4 ews-feeder 2021-04-30 18:19:27 -0700 Committed r276867 (237213@main): <https://commits.webkit.org/237213@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427452. 427450 2021-04-30 14:50:02 -0700 2021-04-30 14:50:23 -0700 Patch bug-225250-20210501075001.patch text/plain 2407 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNThkNDVlOTg5OTExYjQ0 ZDUyODg2ZDE0Y2NkMTk5YjA2YmYzNmY5ZC4uZTJlZDkxYjJkM2UwZjA4MGI1MGMzYjdmNzczOTY0 N2U3MjhhZGI4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTI5ICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgYSBjcmFz aCBpbiBQbGF0Zm9ybUNBTGF5ZXI6OmRyYXdMYXllckNvbnRlbnRzIHdoZW4gY2FsbGVkIHdpdGgg YSBkaXNwbGF5IGxpc3QgcmVjb3JkaW5nIEdyYXBoaWNzQ29udGV4dC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTIyNAorICAgICAgICA8cmRhcjov Lzc2MzU5MDI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIHNldElzQ0FMYXllckNvbnRleHQgYW5kIHNldElzQWNjZWxlcmF0ZWRDb250ZXh0IGJvdGgg YXNzdW1lIChhbmQgYXNzZXJ0KQorICAgICAgICB0aGF0IHRoZSBHcmFwaGljc0NvbnRleHQgaGFz IGEgcGxhdGZvcm0gY29udGV4dCBkaXJlY3RseSBpbiBtX2RhdGEsCisgICAgICAgIGJ1dCBtX2Rh dGEgaXMgbnVsbCB3aGVuIHRoZSBHcmFwaGljc0NvbnRleHQgYSBkaXNwbGF5IGxpc3QgcmVjb3Jk aW5nCisgICAgICAgIGNvbnRleHQuICBUaGVzZSBjYWxscyBhcmUgdW5uZWNlc3Nhcnkgd2hlbiBu b3Qgd29ya2luZyB3aXRoIGEKKyAgICAgICAgQ0ctYmFja2VkIEdyYXBoaWNzQ29udGV4dCwgc28g anVzdCBza2lwIHRoZW0gaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2EvY29jb2EvUGxhdGZvcm1DQUxheWVyQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpQ bGF0Zm9ybUNBTGF5ZXI6OmRyYXdMYXllckNvbnRlbnRzKToKKwogMjAyMS0wNC0yOCAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgYSBXZWFrSGFzaFNldCBm b3IgRG9jdW1lbnQ6Om1fbWVkaWFFbGVtZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29jb2EvUGxhdGZvcm1DQUxheWVyQ29jb2EubW0gYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2Nv YS5tbQppbmRleCA5NDljNzM3YWUwN2UzODIyYTZmM2JhNDAxMzJhNDUzMjZlOTUyZmFkLi5hOGQz OGUyNGQxMWUxN2NkZWYwMWQyZmNiMzI0MjA1MjA5Njk2ZTEwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9y bUNBTGF5ZXJDb2NvYS5tbQpAQCAtMTIwNSwxMiArMTIwNSwxMSBAQCB2b2lkIFBsYXRmb3JtQ0FM YXllcjo6ZHJhd0xheWVyQ29udGVudHMoR3JhcGhpY3NDb250ZXh0JiBncmFwaGljc0NvbnRleHQs IFdlYkNvcgogICAgICAgICAgICAgZm9udEFudGlhbGlhc2luZ1N0YXRlLmVtcGxhY2UoY29udGV4 dCwgISFbcGxhdGZvcm1DQUxheWVyLT5wbGF0Zm9ybUxheWVyKCkgaXNPcGFxdWVdKTsKICAgICAg ICAgICAgIGZvbnRBbnRpYWxpYXNpbmdTdGF0ZS0+c2V0dXAoW1dBS1dpbmRvdyBoYXNMYW5kc2Nh cGVPcmllbnRhdGlvbl0pOwogI2VuZGlmCi0gICAgICAgIH0KLSAgICAgICAgCi0gICAgICAgIHsK ICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC5zZXRJc0NBTGF5ZXJDb250ZXh0KHRydWUpOwog ICAgICAgICAgICAgZ3JhcGhpY3NDb250ZXh0LnNldElzQWNjZWxlcmF0ZWRDb250ZXh0KHBsYXRm b3JtQ0FMYXllci0+YWNjZWxlcmF0ZXNEcmF3aW5nKCkpOworICAgICAgICB9CiAKKyAgICAgICAg ewogICAgICAgICAgICAgaWYgKCFsYXllckNvbnRlbnRzLT5wbGF0Zm9ybUNBTGF5ZXJDb250ZW50 c09wYXF1ZSgpICYmICFwbGF0Zm9ybUNBTGF5ZXItPnN1cHBvcnRzU3VicGl4ZWxBbnRpYWxpYXNl ZFRleHQoKSAmJiBGb250Q2FzY2FkZTo6aXNTdWJwaXhlbEFudGlhbGlhc2luZ0F2YWlsYWJsZSgp KSB7CiAgICAgICAgICAgICAgICAgLy8gVHVybiBvZmYgZm9udCBzbW9vdGhpbmcgdG8gaW1wcm92 ZSB0aGUgYXBwZWFyYW5jZSBvZiB0ZXh0IHJlbmRlcmVkIG9udG8gYSB0cmFuc3BhcmVudCBiYWNr Z3JvdW5kLgogICAgICAgICAgICAgICAgIGdyYXBoaWNzQ29udGV4dC5zZXRTaG91bGRTbW9vdGhG b250cyhmYWxzZSk7Cg== 427452 2021-04-30 14:50:26 -0700 2021-04-30 18:19:28 -0700 Patch bug-225250-20210501075025.patch text/plain 2452 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTJlZDkxYjJkM2UwZjA4 MGI1MGMzYjdmNzczOTY0N2U3MjhhZGI4MC4uMDQ0ZDkwODU1Zjk1YTZlNWRhZTQyN2ZiNThmOTRl YzgwODE1ODJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTMwICBDYW1l cm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisKKyAgICAgICAgRGVmZW5kIGZ1cnRo ZXIgYWdhaW5zdCBhIFBsYXRmb3JtQ0FMYXllcidzIG93bmVyIGJlY29taW5nIG51bGwgaW4gUGxh dGZvcm1DQUxheWVyQ29jb2E6OmRyYXdMYXllckNvbnRlbnRzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MjUwCisgICAgICAgIDxyZGFyOi8vMzc2 MDg4ODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QXQgdGhlIGVuZCBvZiBQbGF0Zm9ybUNBTGF5ZXI6OmRyYXdMYXllckNvbnRlbnRzLCB3ZSBudWxs IGNoZWNrCisgICAgICAgIGxheWVyQ29udGVudHMgZm9yIHRoZSBwbGF0Zm9ybUNBTGF5ZXJTaG93 UmVwYWludENvdW50ZXIgY2FsbCBidXQgbm90CisgICAgICAgIHRoZSBwbGF0Zm9ybUNBTGF5ZXJJ bmNyZW1lbnRSZXBhaW50Q291bnQgY2FsbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NhL2NvY29hL1BsYXRmb3JtQ0FMYXllckNvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6UGxh dGZvcm1DQUxheWVyOjpkcmF3TGF5ZXJDb250ZW50cyk6CisKIDIwMjEtMDQtMjkgIENhbWVyb24g TWNDb3JtYWNrICA8aGV5Y2FtQGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9pZCBhIGNyYXNoIGlu IFBsYXRmb3JtQ0FMYXllcjo6ZHJhd0xheWVyQ29udGVudHMgd2hlbiBjYWxsZWQgd2l0aCBhIGRp c3BsYXkgbGlzdCByZWNvcmRpbmcgR3JhcGhpY3NDb250ZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvY29jb2EvUGxhdGZvcm1DQUxheWVyQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNB TGF5ZXJDb2NvYS5tbQppbmRleCBhOGQzOGUyNGQxMWUxN2NkZWYwMWQyZmNiMzI0MjA1MjA5Njk2 ZTEwLi44YTU0OTViZDM1NTQ4OTJjYTEwNmFjNDRjY2NjZmY3NDdmMzVmNzQ0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2NvYS9QbGF0Zm9ybUNBTGF5 ZXJDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9jb2Nv YS9QbGF0Zm9ybUNBTGF5ZXJDb2NvYS5tbQpAQCAtMTIzNywxMiArMTIzNywxNSBAQCB2b2lkIFBs YXRmb3JtQ0FMYXllcjo6ZHJhd0xheWVyQ29udGVudHMoR3JhcGhpY3NDb250ZXh0JiBncmFwaGlj c0NvbnRleHQsIFdlYkNvcgogICAgIC8vIFJlLWZldGNoIHRoZSBsYXllciBvd25lciwgc2luY2Ug PHJkYXI6Ly9wcm9ibGVtLzkxMjUxNTE+IGluZGljYXRlcyB0aGF0IGl0IG1pZ2h0IGhhdmUgYmVl biBkZXN0cm95ZWQgZHVyaW5nIHBhaW50aW5nLgogICAgIGxheWVyQ29udGVudHMgPSBwbGF0Zm9y bUNBTGF5ZXItPm93bmVyKCk7CiAgICAgQVNTRVJUKGxheWVyQ29udGVudHMpOwotICAgIAorCisg ICAgaWYgKCFsYXllckNvbnRlbnRzKQorICAgICAgICByZXR1cm47CisKICAgICAvLyBBbHdheXMg dXBkYXRlIHRoZSByZXBhaW50IGNvdW50IHNvIHRoYXQgaXQncyBhY2N1cmF0ZSBldmVuIGlmIHRo ZSBjb3VudCBpdHNlbGYgaXMgbm90IHNob3duLiBUaGlzIHdpbGwgYmUgdXNlZnVsCiAgICAgLy8g Zm9yIHRoZSBXZWIgSW5zcGVjdG9yIGZlZWRpbmcgdGhpcyBpbmZvcm1hdGlvbiB0aHJvdWdoIHRo ZSBMYXllclRyZWVBZ2VudC4KICAgICBpbnQgcmVwYWludENvdW50ID0gbGF5ZXJDb250ZW50cy0+ cGxhdGZvcm1DQUxheWVySW5jcmVtZW50UmVwYWludENvdW50KHBsYXRmb3JtQ0FMYXllcik7CiAK LSAgICBpZiAoIXBsYXRmb3JtQ0FMYXllci0+dXNlc1RpbGVkQmFja2luZ0xheWVyKCkgJiYgbGF5 ZXJDb250ZW50cyAmJiBsYXllckNvbnRlbnRzLT5wbGF0Zm9ybUNBTGF5ZXJTaG93UmVwYWludENv dW50ZXIocGxhdGZvcm1DQUxheWVyKSkKKyAgICBpZiAoIXBsYXRmb3JtQ0FMYXllci0+dXNlc1Rp bGVkQmFja2luZ0xheWVyKCkgJiYgbGF5ZXJDb250ZW50cy0+cGxhdGZvcm1DQUxheWVyU2hvd1Jl cGFpbnRDb3VudGVyKHBsYXRmb3JtQ0FMYXllcikpCiAgICAgICAgIGRyYXdSZXBhaW50SW5kaWNh dG9yKGdyYXBoaWNzQ29udGV4dCwgcGxhdGZvcm1DQUxheWVyLCByZXBhaW50Q291bnQpOwogfQog Cg==