225249 2021-04-30 14:07:10 -0700 Make the JIT pool smaller on AS 2021-04-30 14:53:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1755797 0 fpizlo 2021-04-30 14:07:10 -0700 It improves perf a bit. 1755799 1 427445 fpizlo 2021-04-30 14:08:46 -0700 Created attachment 427445 the patch 1755803 2 427445 saam 2021-04-30 14:23:27 -0700 Comment on attachment 427445 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=427445&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:336 > + if (Options::executablePoolSizeOverride()) > + reservation.size = Options::executablePoolSizeOverride(); this already exists right below. Just remove the ENABLE 1755804 3 427445 saam 2021-04-30 14:25:39 -0700 Comment on attachment 427445 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=427445&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:409 > + , m_numAllocators(numberOfRegions) maybe we should rename numberOfRegions to maxNumberOfRegions 1755807 4 fpizlo 2021-04-30 14:29:41 -0700 *** Bug 209037 has been marked as a duplicate of this bug. *** 1755819 5 fpizlo 2021-04-30 14:52:13 -0700 Landed in https://trac.webkit.org/changeset/276855/webkit 1755822 6 webkit-bug-importer 2021-04-30 14:53:31 -0700 <rdar://problem/77400108> 427445 2021-04-30 14:08:46 -0700 2021-04-30 14:23:27 -0700 the patch 512.patch text/plain 6262 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc2ODUxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIxLTA0LTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg TWFrZSB0aGUgSklUIHBvb2wgc21hbGxlciBvbiBBUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MjQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBhZGRzIHRocmVlIHJlbGF0ZWQgZmVhdHVyZXM6 CisKKyAgICAgICAgLSBNYWtlcyBpdCBlYXN5IHRvIGR1bXAgd2hlcmUgdGhlIEpJVCBwb29sIHdh cyBhbGxvY2F0ZWQuCisKKyAgICAgICAgLSBNYWtlcyBpdCBwb3NzaWJsZSB0byBvdmVycmlkZSB0 aGUgSklUIHBvb2wgc2l6ZSB3aXRoIE9wdGlvbnMuCisKKyAgICAgICAgLSBDaGFuZ2VzIHRoZSBk ZWZhdWx0IEpJVCBwb29sIHNpemUgb24gQVMgdG8gNTEyTUIuCisKKyAgICAgICAgRXN0aW1hdGVk IDIlIHNwZWVkLXVwIG9uIEpldFN0cmVhbTIsIDEuNSUgc3BlZWQtdXAgb24gU3BlZWRvbWV0ZXIy LgorCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwOgorICAgICAgICAoSlND Ojppbml0aWFsaXplSklUUGFnZVJlc2VydmF0aW9uKToKKyAgICAgICAgKiBydW50aW1lL09wdGlv bnNMaXN0Lmg6CisKIDIwMjEtMDQtMjkgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgSW5saW5pbmcgcHJvcGVydHkgYWNjZXNzZXMgaW5zaWRlIGNvbnN0YW50IGZv bGRpbmcgc2hvdWxkIGNoZWNrIE9wdGlvbnM6OnVzZUFjY2Vzc0lubGluaW5nCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAJKHJl dmlzaW9uIDI3NjY0OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFs bG9jYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk1LDcgKzk1LDcgQEAgc3RhdGljIGNvbnN0 ZXhwciBzaXplX3QgZml4ZWRFeGVjdXRhYmxlTQogc3RhdGljIGNvbnN0ZXhwciBzaXplX3QgZml4 ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbFNpemUgPSAxNiAqIE1COwogI2VsaWYgQ1BVKEFSTTY0KQog I2lmIEVOQUJMRShKVU1QX0lTTEFORFMpCi1zdGF0aWMgY29uc3RleHByIHNpemVfdCBmaXhlZEV4 ZWN1dGFibGVNZW1vcnlQb29sU2l6ZSA9IDEgKiBHQjsKK3N0YXRpYyBjb25zdGV4cHIgc2l6ZV90 IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0gNTEyICogTUI7CiAvLyBUaGVzZSBzaXpl cyBndWFyYW50ZWUgdGhhdCBhbnkganVtcCB3aXRoaW4gYW4gaXNsYW5kIGNhbiBqdW1wIGZvcndh cmRzIG9yIGJhY2t3YXJkcwogLy8gdG8gdGhlIGFkamFjZW50IGlzbGFuZCBpbiBhIHNpbmdsZSBp bnN0cnVjdGlvbi4KIHN0YXRpYyBjb25zdGV4cHIgc2l6ZV90IHJlZ2lvblNpemUgPSAxMTIgKiBN QjsKQEAgLTMzMSw2ICszMzEsMTAgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgSklUUmVzZXJ2YXRp b24gaW5pdAogICAgICAgICByZXR1cm4gcmVzZXJ2YXRpb247CiAKICAgICByZXNlcnZhdGlvbi5z aXplID0gZml4ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbFNpemU7CisKKyAgICBpZiAoT3B0aW9uczo6 ZXhlY3V0YWJsZVBvb2xTaXplT3ZlcnJpZGUoKSkKKyAgICAgICAgcmVzZXJ2YXRpb24uc2l6ZSA9 IE9wdGlvbnM6OmV4ZWN1dGFibGVQb29sU2l6ZU92ZXJyaWRlKCk7CisgICAgCiAjaWYgIUVOQUJM RShKVU1QX0lTTEFORFMpCiAgICAgLy8gRklYTUU6IENvbnNpZGVyIG1ha2luZyBqdW1wIGlzbGFu ZHMgd29yayB3aXRoIE9wdGlvbnM6OmppdE1lbW9yeVJlc2VydmF0aW9uU2l6ZQogICAgIC8vIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDkwMzcKQEAgLTM1MSw2ICsz NTUsMTAgQEAgc3RhdGljIEFMV0FZU19JTkxJTkUgSklUUmVzZXJ2YXRpb24gaW5pdAogICAgIH07 CiAKICAgICByZXNlcnZhdGlvbi5wYWdlUmVzZXJ2YXRpb24gPSB0cnlDcmVhdGVQYWdlUmVzZXJ2 YXRpb24ocmVzZXJ2YXRpb24uc2l6ZSk7CisKKyAgICBpZiAoT3B0aW9uczo6dmVyYm9zZUV4ZWN1 dGFibGVQb29sQWxsb2NhdGlvbigpKQorICAgICAgICBkYXRhTG9nKGdldHBpZCgpLCAiOiBHb3Qg ZXhlY3V0YWJsZSBwb29sIHJlc2VydmF0aW9uIGF0ICIsIFJhd1BvaW50ZXIocmVzZXJ2YXRpb24u cGFnZVJlc2VydmF0aW9uLmJhc2UoKSksICIuLi4iLCBSYXdQb2ludGVyKGJpdHdpc2VfY2FzdDxj aGFyKj4ocmVzZXJ2YXRpb24ucGFnZVJlc2VydmF0aW9uLmJhc2UoKSkgKyByZXNlcnZhdGlvbi5w YWdlUmVzZXJ2YXRpb24uc2l6ZSgpKSwgIiwgd2hpbGUgSSdtIGF0ICIsIFJhd1BvaW50ZXIoYml0 d2lzZV9jYXN0PHZvaWQqPihpbml0aWFsaXplSklUUGFnZVJlc2VydmF0aW9uKSksICJcbiIpOwor ICAgIAogICAgIGlmIChyZXNlcnZhdGlvbi5wYWdlUmVzZXJ2YXRpb24pIHsKICAgICAgICAgQVNT RVJUKHJlc2VydmF0aW9uLnBhZ2VSZXNlcnZhdGlvbi5zaXplKCkgPT0gcmVzZXJ2YXRpb24uc2l6 ZSk7CiAgICAgICAgIHJlc2VydmF0aW9uLmJhc2UgPSByZXNlcnZhdGlvbi5wYWdlUmVzZXJ2YXRp b24uYmFzZSgpOwpAQCAtMzk4LDYgKzQwNiw3IEBAIHB1YmxpYzoKICAgICBGaXhlZFZNUG9vbEV4 ZWN1dGFibGVBbGxvY2F0b3IoKQogI2lmIEVOQUJMRShKVU1QX0lTTEFORFMpCiAgICAgICAgIDog bV9hbGxvY2F0b3JzKGNvbnN0cnVjdEZpeGVkU2l6ZUFycmF5V2l0aEFyZ3VtZW50czxSZWdpb25B bGxvY2F0b3IsIG51bWJlck9mUmVnaW9ucz4oKnRoaXMpKQorICAgICAgICAsIG1fbnVtQWxsb2Nh dG9ycyhudW1iZXJPZlJlZ2lvbnMpCiAjZWxzZQogICAgICAgICA6IG1fYWxsb2NhdG9yKCp0aGlz KQogI2VuZGlmCkBAIC00MDksMTIgKzQxOCwxNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICB1aW50 cHRyX3Qgc3RhcnQgPSBiaXR3aXNlX2Nhc3Q8dWludHB0cl90PihtZW1vcnlTdGFydCgpKTsKICAg ICAgICAgICAgIHVpbnRwdHJfdCByZXNlcnZhdGlvbkVuZCA9IGJpdHdpc2VfY2FzdDx1aW50cHRy X3Q+KG1lbW9yeUVuZCgpKTsKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbnVt YmVyT2ZSZWdpb25zOyArK2kpIHsKLSAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChzdGFy dCA8IHJlc2VydmF0aW9uRW5kKTsKKyAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChzdGFy dCA8IHJlc2VydmF0aW9uRW5kIHx8IE9wdGlvbnM6OmV4ZWN1dGFibGVQb29sU2l6ZU92ZXJyaWRl KCkpOworICAgICAgICAgICAgICAgIGlmIChzdGFydCA+PSByZXNlcnZhdGlvbkVuZCkgeworICAg ICAgICAgICAgICAgICAgICBtX251bUFsbG9jYXRvcnMgPSBpOworICAgICAgICAgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgbV9hbGxvY2F0b3Jz W2ldLm1fc3RhcnQgPSB0YWdDb2RlUHRyPEV4ZWN1dGFibGVNZW1vcnlQdHJUYWc+KGJpdHdpc2Vf Y2FzdDx2b2lkKj4oc3RhcnQpKTsKICAgICAgICAgICAgICAgICBtX2FsbG9jYXRvcnNbaV0ubV9l bmQgPSB0YWdDb2RlUHRyPEV4ZWN1dGFibGVNZW1vcnlQdHJUYWc+KGJpdHdpc2VfY2FzdDx2b2lk Kj4oc3RhcnQgKyByZWdpb25TaXplKSk7CiAgICAgICAgICAgICAgICAgaWYgKG1fYWxsb2NhdG9y c1tpXS5lbmQoKSA+IHJlc2VydmF0aW9uRW5kKSB7CiAgICAgICAgICAgICAgICAgICAgIC8vIFdl IG1heSBoYXZlIHRha2VuIGEgcGFnZSBmb3IgdGhlIGV4ZWN1dGFibGUgb25seSBjb3B5IHRodW5r LgotICAgICAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChpID09IG51bWJlck9mUmVnaW9u cyAtIDEpOworICAgICAgICAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChpID09IG51bWJlck9m UmVnaW9ucyAtIDEgfHwgT3B0aW9uczo6ZXhlY3V0YWJsZVBvb2xTaXplT3ZlcnJpZGUoKSk7CiAg ICAgICAgICAgICAgICAgICAgIG1fYWxsb2NhdG9yc1tpXS5tX2VuZCA9IHRhZ0NvZGVQdHI8RXhl Y3V0YWJsZU1lbW9yeVB0clRhZz4oYml0d2lzZV9jYXN0PHZvaWQqPihyZXNlcnZhdGlvbkVuZCkp OwogICAgICAgICAgICAgICAgIH0KIApAQCAtNDUwLDE0ICs0NjMsMTQgQEAgcHVibGljOgogCiAg ICAgICAgIHVuc2lnbmVkIHN0YXJ0ID0gMDsKICAgICAgICAgaWYgKE9wdGlvbnM6OnVzZVJhbmRv bWl6aW5nRXhlY3V0YWJsZUlzbGFuZEFsbG9jYXRpb24oKSkKLSAgICAgICAgICAgIHN0YXJ0ID0g Y3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIoKSAlIG1fYWxsb2NhdG9ycy5zaXplKCk7Cisg ICAgICAgICAgICBzdGFydCA9IGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyKCkgJSBtX251 bUFsbG9jYXRvcnM7CiAKICAgICAgICAgdW5zaWduZWQgaSA9IHN0YXJ0OwogICAgICAgICB3aGls ZSAodHJ1ZSkgewogICAgICAgICAgICAgUmVnaW9uQWxsb2NhdG9yJiBhbGxvY2F0b3IgPSBtX2Fs bG9jYXRvcnNbaV07CiAgICAgICAgICAgICBpZiAoUmVmUHRyPEV4ZWN1dGFibGVNZW1vcnlIYW5k bGU+IHJlc3VsdCA9IGFsbG9jYXRvci5hbGxvY2F0ZShsb2NrZXIsIHNpemVJbkJ5dGVzKSkKICAg ICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0OwotICAgICAgICAgICAgaSA9IChpICsgMSkgJSBt X2FsbG9jYXRvcnMuc2l6ZSgpOworICAgICAgICAgICAgaSA9IChpICsgMSkgJSBtX251bUFsbG9j YXRvcnM7CiAgICAgICAgICAgICBpZiAoaSA9PSBzdGFydCkKICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgfQpAQCAtODMzLDYgKzg0Niw3IEBAIHByaXZhdGU6CiAgICAgUGFnZVJlc2Vy dmF0aW9uIG1fcmVzZXJ2YXRpb247CiAjaWYgRU5BQkxFKEpVTVBfSVNMQU5EUykKICAgICBzdGQ6 OmFycmF5PFJlZ2lvbkFsbG9jYXRvciwgbnVtYmVyT2ZSZWdpb25zPiBtX2FsbG9jYXRvcnM7Cisg ICAgdW5zaWduZWQgbV9udW1BbGxvY2F0b3JzOwogICAgIFJlZEJsYWNrVHJlZTxJc2xhbmRzLCB2 b2lkKj4gbV9pc2xhbmRzRm9ySnVtcFNvdXJjZUxvY2F0aW9uOwogI2Vsc2UKICAgICBBbGxvY2F0 b3IgbV9hbGxvY2F0b3I7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRp b25zTGlzdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09w dGlvbnNMaXN0LmgJKHJldmlzaW9uIDI3NjY0OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnNMaXN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTU0NCw2ICs1NDQsMTAgQEAg Y29uc3RleHByIHVuc2lnbmVkIGpzY1Jlc2VydmVkWm9uZVNpemUgPQogICAgIHYoQm9vbCwgdXNl RXJyb3JDYXVzZSwgdHJ1ZSwgTm9ybWFsLCAiQWxsb3cgYSBjYXVzZSB0byBiZSBwcm92aWRlZCB3 aGVuIGNvbnN0cnVjdGluZyBhbiBFcnJvciwgX05hdGl2ZUVycm9yXywgb3IgQWdncmVnYXRlRXJy b3IuIikgXAogICAgIHYoQm9vbCwgdXNlU2hhcmVkQXJyYXlCdWZmZXIsIGZhbHNlLCBOb3JtYWws IG51bGxwdHIpIFwKICAgICB2KEJvb2wsIHVzZVRvcExldmVsQXdhaXQsIHRydWUsIE5vcm1hbCwg ImFsbG93IHRoZSBhd2FpdCBrZXl3b3JkIGF0IHRoZSB0b3AgbGV2ZWwgb2YgYSBtb2R1bGUuIikg XAorICAgIHYoQm9vbCwgZHVtcExpbmtpbmcsIGZhbHNlLCBOb3JtYWwsIG51bGxwdHIpIFwKKyAg ICB2KEJvb2wsIHZlcmlmeVNhbWU0R0JMaW5rLCBmYWxzZSwgTm9ybWFsLCBudWxscHRyKSBcCisg ICAgdihTaXplLCBleGVjdXRhYmxlUG9vbFNpemVPdmVycmlkZSwgMCwgTm9ybWFsLCBudWxscHRy KSBcCisgICAgdihCb29sLCB2ZXJib3NlRXhlY3V0YWJsZVBvb2xBbGxvY2F0aW9uLCBmYWxzZSwg Tm9ybWFsLCBudWxscHRyKSBcCiAKIAogZW51bSBPcHRpb25FcXVpdmFsZW5jZSB7Cg==