225238 2021-04-30 11:07:00 -0700 Can't decode empty formdata with fetch 2022-08-02 12:51:46 -0700 1 1 1 Unclassified WebKit DOM Safari 14 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jimmy achristensen achristensen ahmad.saleem792 ap beidson bfulgham cdumez clopez ews-watchlist rniwa webkit-bug-importer youennf oldest_to_newest 1755747 0 jimmy 2021-04-30 11:07:00 -0700 Safari TP Version: 14.2 OS Version: OS X 10.15.7 Safari: FAIL Firefox: OK IE/Edge: FAIL What steps will reproduce the problem? 1. new Response(new FormData()).formData() What is the expected result? Get back a empty formdata... It can work if you append at least one item into the FormData. What happens instead of that? TypeError: Type error https://github.com/web-platform-tests/wpt/issues/28607 (plz, switch to github issues instead of using bugzilla) 1756301 1 427594 achristensen 2021-05-03 13:32:36 -0700 Created attachment 427594 Patch 1756302 2 ews-watchlist 2021-05-03 13:33:27 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1756304 3 achristensen 2021-05-03 13:35:20 -0700 @Jimmy, I added two of these lines to your test to verify it returns a FormData that is indeed empty: for (const pair of fd.entries()) { assert_true(false); } You may consider this in your upstream PR. Also, I removed an extra one space indent that crept into all but one line of your test. 1756449 4 427594 youennf 2021-05-03 23:07:19 -0700 Comment on attachment 427594 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427594&action=review > LayoutTests/imported/w3c/web-platform-tests/fetch/api/body/formdata.any.js:5 > + for (const pair of fd.entries()) { assert_true(false); } assert_unreached would be clearer. > LayoutTests/imported/w3c/web-platform-tests/fetch/api/body/formdata.any.js:15 > + for (const pair of fd.entries()) { assert_true(false); } Ditto here. 1757923 5 webkit-bug-importer 2021-05-07 11:07:37 -0700 <rdar://problem/77663677> 1888141 6 ahmad.saleem792 2022-08-01 12:57:17 -0700 I think this didn't landed yet despite r+ because Safari still fail these tests (matched from within patch to WPT): https://wpt.fyi/results/fetch/api/body?label=master&label=experimental&aligned&view=subtest&q=formdata Please ignore my comment, if I am wrong. Thanks! 1888457 7 achristensen 2022-08-02 11:47:32 -0700 Pull request: https://github.com/WebKit/WebKit/pull/2956 1888468 8 ews-feeder 2022-08-02 12:51:43 -0700 Committed 253047@main (0cd625839811): <https://commits.webkit.org/253047@main> Reviewed commits have been landed. Closing PR #2956 and removing active labels. 427594 2021-05-03 13:32:36 -0700 2021-05-03 23:07:19 -0700 Patch bug-225238-20210503133235.patch text/plain 6489 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY0OTEwM2NhY2UzZWIx ZmE0ZjhmYTRiYzBhNTNjNzA0YWZiZDRjZi4uNDQ0YTBlNjRiYzA2OTUwZmZjYzhhNjFhY2IzMjEw OThhZjk5ZjVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA1LTAzICBBbGV4 IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQ2FuJ3Qg ZGVjb2RlIGVtcHR5IGZvcm1kYXRhIHdpdGggZmV0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTIzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgaW5pdGlhbGx5IGltcGxlbWVudGVkIGl0IGxpa2Ug Q2hyb21lIGRpZC4gIElmIHRoZXJlIGFyZSBubyBlbnRyaWVzLCB3ZSB0aHJldyBhIFR5cGVFcnJv ciBiYXNlZCBvbiB0aGlzIHByZWNpc2VseSBkZWZpbmVkIGJlaGF2aW9yOgorCisgICAgICAgIGh0 dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cub3JnLyNjb25jZXB0LWJvZHktcGFja2FnZS1kYXRhIHN0 ZXAgMjoKKyAgICAgICAgIklmIHRoYXQgZmFpbHMgZm9yIHNvbWUgcmVhc29uLCB0aGVuIHRocm93 IGEgVHlwZUVycm9yLiIKKworICAgICAgICBBcHBhcmVudGx5LCBub3QgZmluZGluZyBhIHNlY29u ZCBib3VuZGFyeSBpcyBub3QgY292ZXJlZCBieSAic29tZSByZWFzb24iIGFuZCB3ZSBzaG91bGQg cmV0dXJuIGFuIGVtcHR5IEZvcm1EYXRhLgorICAgICAgICBJIGxpa2UgdGhpcyBiZWhhdmlvciBi ZXR0ZXIgYW5kIGl0IG1hdGNoZXMgRmlyZWZveCBhbmQgbWFueSBwZW9wbGUncyBpbnRlcnByZXRh dGlvbiBvZiB0aGUgc3BlYy4KKworICAgICAgICBUZXN0czogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnkuaHRtbAorICAgICAgICAgICAg ICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0 YS5hbnkud29ya2VyLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvZmV0Y2gvRmV0Y2hCb2R5Q29u c3VtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFja2FnZUZvcm1EYXRhKToKKwogMjAyMS0w NC0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTiAocjI3NjYzMyk6IEFTU0VSVElPTiBGQUlMRUQ6ICFmb3JiaWRNYWxsb2NVc2VTY29wZUNv dW50IHx8IGRpc2FibGVNYWxsb2NSZXN0cmljdGlvblNjb3BlQ291bnQgdW5kZXIgV2ViQ29yZTo6 QXVkaW9TYW1wbGVEYXRhU291cmNlOjpjcmVhdGUoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9mZXRjaC9GZXRjaEJvZHlDb25zdW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2ZldGNoL0ZldGNoQm9keUNvbnN1bWVyLmNwcAppbmRleCAxZDE3MTU4ZDI4Y2UzOWU5 ZTcwYzgzNDcwMzM5YTZmNzc0NzEzMDQ0Li40MGQ4OWEwN2Q5Yjk1YWU2MDQ2NTY2YTBjZDM1YzBi NTllNTdmMDM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNo Qm9keUNvbnN1bWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNo Qm9keUNvbnN1bWVyLmNwcApAQCAtMTk3LDggKzE5Nyw2IEBAIHN0YXRpYyBSZWZQdHI8RE9NRm9y bURhdGE+IHBhY2thZ2VGb3JtRGF0YShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBj b25zCiAgICAgICAgIGlmICghY3VycmVudEJvdW5kYXJ5KQogICAgICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAgICAgICAgIGNvbnN0IGNoYXIqIG5leHRCb3VuZGFyeSA9IHN0YXRpY19jYXN0PGNv bnN0IGNoYXIqPihtZW1tZW0oY3VycmVudEJvdW5kYXJ5ICsgYm91bmRhcnlMZW5ndGgsIGxlbmd0 aCAtIChjdXJyZW50Qm91bmRhcnkgKyBib3VuZGFyeUxlbmd0aCAtIGRhdGEpLCBib3VuZGFyeS5k YXRhKCksIGJvdW5kYXJ5TGVuZ3RoKSk7Ci0gICAgICAgIGlmICghbmV4dEJvdW5kYXJ5KQotICAg ICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgICAgIHdoaWxlIChuZXh0Qm91bmRhcnkpIHsK ICAgICAgICAgICAgIHBhcnNlTXVsdGlwYXJ0UGFydChjdXJyZW50Qm91bmRhcnkgKyBib3VuZGFy eUxlbmd0aCwgbmV4dEJvdW5kYXJ5IC0gY3VycmVudEJvdW5kYXJ5IC0gYm91bmRhcnlMZW5ndGgg LSBzdHJsZW4oIlxyXG4iKSwgZm9ybS5nZXQoKSk7CiAgICAgICAgICAgICBjdXJyZW50Qm91bmRh cnkgPSBuZXh0Qm91bmRhcnk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwppbmRleCBiZTVm NmEwY2NmNmFmYTQ1ZTg3YjllMWE4OWRiYTZhOTE3NmNlNzY1Li4wYTE1NzdmZWE3MjdmZTJiZmFl MTE4ZDQyOGE5YzY5M2JlMDZhNmZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNyBAQAorMjAyMS0wNS0wMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgorCisgICAgICAgIENhbid0IGRlY29kZSBlbXB0eSBmb3JtZGF0YSB3aXRo IGZldGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjUyMzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHdlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnktZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2JvZHkv Zm9ybWRhdGEuYW55Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9m ZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnkuanM6IEFkZGVkLgorICAgICAgICAocHJvbWlzZV90 ZXN0LmFzeW5jIHQpOgorICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9k eS9mb3JtZGF0YS5hbnkud29ya2VyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogd2Vi LXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9ib2R5L2Zvcm1kYXRhLmFueS53b3JrZXIuaHRtbDog QWRkZWQuCisKIDIwMjEtMDQtMzAgIE9yaW9sIEJydWZhdSAgPG9icnVmYXVAaWdhbGlhLmNvbT4K IAogICAgICAgICBbY3NzLWxvZ2ljYWxdIEZpeCBsb2dpY2FsIHNob3J0aGFuZHMgd2l0aCB2YXIo KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5h bnktZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmRhNjk4ZTkwZGIzNTVmNzA4MzNjNDExNWIzMmJi ZDJmNzFiYTlhN2EKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9ib2R5L2Zvcm1kYXRhLmFueS1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSw0IEBACisKK1BBU1MgQ29uc3VtZSBlbXB0eSByZXNwb25zZS5mb3JtRGF0 YSgpIGFzIEZvcm1EYXRhCitQQVNTIENvbnN1bWUgZW1wdHkgcmVxdWVzdC5mb3JtRGF0YSgpIGFz IEZvcm1EYXRhCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2JvZHkvZm9ybWRhdGEuYW55Lmh0bWwgYi9MYXlvdXRUZXN0 cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9ib2R5L2Zvcm1kYXRh LmFueS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjIzODI5MTM1MjhlNjkzYjNhNWQ1NmM2NjBhNDUwNjA5ODBi NTQ4YzMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2ZldGNoL2FwaS9ib2R5L2Zvcm1kYXRhLmFueS5odG1sCkBAIC0wLDAgKzEg QEAKKzwhLS0gVGhpcyBmaWxlIGlzIHJlcXVpcmVkIGZvciBXZWJLaXQgdGVzdCBpbmZyYXN0cnVj dHVyZSB0byBydW4gdGhlIHRlbXBsYXRlZCB0ZXN0IC0tPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9m IGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvZmV0Y2gvYXBpL2JvZHkvZm9ybWRhdGEuYW55LmpzIGIvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnkuanMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uM2FkNTRhMWVlNTY2MzBiZDdjYjExYTU4ZDYwMzg3NGJmNTljNzUxMAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvZmV0Y2gvYXBpL2JvZHkvZm9ybWRhdGEuYW55LmpzCkBAIC0wLDAgKzEsMTYgQEAKK3Byb21p c2VfdGVzdChhc3luYyB0ID0+IHsKKyAgY29uc3QgcmVzID0gbmV3IFJlc3BvbnNlKG5ldyBGb3Jt RGF0YSgpKTsKKyAgY29uc3QgZmQgPSBhd2FpdCByZXMuZm9ybURhdGEoKTsKKyAgYXNzZXJ0X3Ry dWUoZmQgaW5zdGFuY2VvZiBGb3JtRGF0YSk7CisgIGZvciAoY29uc3QgcGFpciBvZiBmZC5lbnRy aWVzKCkpIHsgYXNzZXJ0X3RydWUoZmFsc2UpOyB9Cit9LCAnQ29uc3VtZSBlbXB0eSByZXNwb25z ZS5mb3JtRGF0YSgpIGFzIEZvcm1EYXRhJyk7CisKK3Byb21pc2VfdGVzdChhc3luYyB0ID0+IHsK KyAgY29uc3QgcmVxID0gbmV3IFJlcXVlc3QoJ2Fib3V0OmJsYW5rJywgeworICAgIG1ldGhvZDog J1BPU1QnLAorICAgIGJvZHk6IG5ldyBGb3JtRGF0YSgpCisgIH0pOworICBjb25zdCBmZCA9IGF3 YWl0IHJlcS5mb3JtRGF0YSgpOworICBhc3NlcnRfdHJ1ZShmZCBpbnN0YW5jZW9mIEZvcm1EYXRh KTsKKyAgZm9yIChjb25zdCBwYWlyIG9mIGZkLmVudHJpZXMoKSkgeyBhc3NlcnRfdHJ1ZShmYWxz ZSk7IH0KK30sICdDb25zdW1lIGVtcHR5IHJlcXVlc3QuZm9ybURhdGEoKSBhcyBGb3JtRGF0YScp OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnkud29ya2VyLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2JvZHkvZm9y bWRhdGEuYW55Lndvcmtlci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGE2OThlOTBkYjM1NWY3 MDgzM2M0MTE1YjMyYmJkMmY3MWJhOWE3YQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2JvZHkvZm9ybWRhdGEu YW55Lndvcmtlci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACisKK1BBU1MgQ29uc3VtZSBl bXB0eSByZXNwb25zZS5mb3JtRGF0YSgpIGFzIEZvcm1EYXRhCitQQVNTIENvbnN1bWUgZW1wdHkg cmVxdWVzdC5mb3JtRGF0YSgpIGFzIEZvcm1EYXRhCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2JvZHkvZm9ybWRhdGEu YW55Lndvcmtlci5odG1sIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9mZXRjaC9hcGkvYm9keS9mb3JtZGF0YS5hbnkud29ya2VyLmh0bWwKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u MjM4MjkxMzUyOGU2OTNiM2E1ZDU2YzY2MGE0NTA2MDk4MGI1NDhjMwotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBp L2JvZHkvZm9ybWRhdGEuYW55Lndvcmtlci5odG1sCkBAIC0wLDAgKzEgQEAKKzwhLS0gVGhpcyBm aWxlIGlzIHJlcXVpcmVkIGZvciBXZWJLaXQgdGVzdCBpbmZyYXN0cnVjdHVyZSB0byBydW4gdGhl IHRlbXBsYXRlZCB0ZXN0IC0tPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK