225225 2021-04-30 01:01:55 -0700 REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing 2021-05-04 11:35:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham jiewen_tan webkit-bug-importer youennf oldest_to_newest 1755631 0 jiewen_tan 2021-04-30 01:01:55 -0700 REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing. 1755632 1 jiewen_tan 2021-04-30 01:02:41 -0700 rdar://77074618 1755633 2 427400 jiewen_tan 2021-04-30 01:25:00 -0700 Created attachment 427400 Patch 1756129 3 427400 youennf 2021-05-03 02:37:44 -0700 Comment on attachment 427400 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489 > + runPresenterInternal(transports); Instead of introducing another virtual method, can we use something like: if (isMock()) return; 1756599 4 427400 jiewen_tan 2021-05-04 11:08:58 -0700 Comment on attachment 427400 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489 >> + runPresenterInternal(transports); > > Instead of introducing another virtual method, can we use something like: > if (isMock()) > return; The design of the testing infrastructure here is to make the authenticator manager unaware of whether or not it's mocking. That's why we have all kinds of different virtual methods. 1756605 5 427400 bfulgham 2021-05-04 11:16:45 -0700 Comment on attachment 427400 Patch r=me 1756608 6 427400 jiewen_tan 2021-05-04 11:25:05 -0700 Comment on attachment 427400 Patch Thanks Brent for r+ this patch. 1756609 7 ews-feeder 2021-05-04 11:35:05 -0700 Committed r276972 (237301@main): <https://commits.webkit.org/237301@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427400. 427400 2021-04-30 01:25:00 -0700 2021-05-04 11:35:06 -0700 Patch bug-225225-20210430012459.patch text/plain 3445 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkzOTk5ZmYxOTI3YTZlNGQw OTllOTVmOGNiNGEwN2ViMTM5NjJjODEuLjY2YzgwZGRmZTM4NGVmZjM5OWI4NWZhNWU2YzkwNzMx MzcxMGU1MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDQtMzAgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbIGlPUyBd IDExIGh0dHAvd3B0L3dlYmF1dGhuLyB0ZXN0cyBhcmUgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTIyNQorICAgICAgICByZGFyOi8v NzcwNzQ2MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXNpdGluZyB0ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJB dXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkF1dGhlbnRpY2F0b3JNYW5hZ2VyOjpydW5QcmVzZW50ZXIpOgorICAgICAgICAoV2ViS2l0OjpB dXRoZW50aWNhdG9yTWFuYWdlcjo6cnVuUHJlc2VudGVySW50ZXJuYWwpOgorICAgICAgICAqIFVJ UHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Nb2NrL01vY2tBdXRoZW50aWNhdG9yTWFu YWdlci5oOgorICAgICAgICBEaXNhYmxlcyB0aGUgbW9kZXJuIFVJIGluIHRoZSBtb2NrIHRlc3Rp bmcgZW52aXJvbm1lbnQuCisKIDIwMjEtMDQtMjkgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVtb3ZlIHVudXNlZCBsb2dkLWRpYWdub3N0aWMt Y2xpZW50IHJ1bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRo ZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5jcHAKaW5kZXggNjdm MWRiZTcxZDFmM2E1ZmI0MzA0NzFlZTVhYWY3NTdiNzY5NTYyYS4uN2E5MzQ4NDc1OWYyZGI4NGYy NWI0ZDlkOTdiOTgyYjI0MWE3ODJlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRvck1hbmFnZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0b3JNYW5hZ2Vy LmNwcApAQCAtNDg2LDYgKzQ4NiwxMSBAQCB2b2lkIEF1dGhlbnRpY2F0b3JNYW5hZ2VyOjpydW5Q cmVzZW50ZXIoKQogICAgIGlmIChtX21vZGUgPT0gTW9kZTo6TmF0aXZlKQogICAgICAgICByZXR1 cm47CiAKKyAgICBydW5QcmVzZW50ZXJJbnRlcm5hbCh0cmFuc3BvcnRzKTsKK30KKwordm9pZCBB dXRoZW50aWNhdG9yTWFuYWdlcjo6cnVuUHJlc2VudGVySW50ZXJuYWwoY29uc3QgVHJhbnNwb3J0 U2V0JiB0cmFuc3BvcnRzKQorewogICAgIGF1dG8mIG9wdGlvbnMgPSBtX3BlbmRpbmdSZXF1ZXN0 RGF0YS5vcHRpb25zOwogICAgIG1fcHJlc2VudGVyID0gbWFrZVVuaXF1ZTxBdXRoZW50aWNhdG9y UHJlc2VudGVyQ29vcmRpbmF0b3I+KCp0aGlzLCBnZXRScElkKG9wdGlvbnMpLCB0cmFuc3BvcnRz LCBnZXRDbGllbnREYXRhVHlwZShvcHRpb25zKSwgZ2V0VXNlck5hbWUob3B0aW9ucykpOwogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQXV0 aGVudGljYXRvck1hbmFnZXIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRp Y2F0aW9uL0F1dGhlbnRpY2F0b3JNYW5hZ2VyLmgKaW5kZXggNDE4Mjk1YmUzZDZjM2IyOWQyNDMy NzUxYTQxMmUzNTZmODEyNTU4NS4uZjdmMzQzMGNhYWQ3YjcyMDk4YzgyMWFmNzMyNDk1MzQ3ZDFl NDJlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRp b24vQXV0aGVudGljYXRvck1hbmFnZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJBdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdG9yTWFuYWdlci5oCkBAIC0xMDUsNiArMTA1LDcg QEAgcHJpdmF0ZToKICAgICAvLyBPdmVycmlkZW4gdG8gcmV0dXJuIGV2ZXJ5IGV4Y2VwdGlvbiBm b3IgdGVzdHMgdG8gY29uZmlybS4KICAgICB2aXJ0dWFsIHZvaWQgcmVzcG9uZFJlY2VpdmVkSW50 ZXJuYWwoUmVzcG9uZCYmKSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZmlsdGVyVHJhbnNwb3J0cyhU cmFuc3BvcnRTZXQmKSBjb25zdDsKKyAgICB2aXJ0dWFsIHZvaWQgcnVuUHJlc2VudGVySW50ZXJu YWwoY29uc3QgVHJhbnNwb3J0U2V0Jik7CiAKICAgICB2b2lkIHN0YXJ0RGlzY292ZXJ5KGNvbnN0 IFRyYW5zcG9ydFNldCYpOwogICAgIHZvaWQgaW5pdFRpbWVPdXRUaW1lcigpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vTW9jay9Nb2NrQXV0 aGVudGljYXRvck1hbmFnZXIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRp Y2F0aW9uL01vY2svTW9ja0F1dGhlbnRpY2F0b3JNYW5hZ2VyLmgKaW5kZXggMzE1ZjI1MTUzOWMy OTdlMDVkN2JlOTU0YWRlNTg3NzU1ZDI1MWJjNC4uOGE4ZDU3MjFhNjA5ZDE1NjdkYzI0MDQ0ZDIz MTIzZDRlNjliNTYyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vTW9jay9Nb2NrQXV0aGVudGljYXRvck1hbmFnZXIuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNhdGlvbi9Nb2NrL01vY2tBdXRoZW50aWNhdG9y TWFuYWdlci5oCkBAIC00Myw2ICs0Myw3IEBAIHByaXZhdGU6CiAgICAgVW5pcXVlUmVmPEF1dGhl bnRpY2F0b3JUcmFuc3BvcnRTZXJ2aWNlPiBjcmVhdGVTZXJ2aWNlKFdlYkNvcmU6OkF1dGhlbnRp Y2F0b3JUcmFuc3BvcnQsIEF1dGhlbnRpY2F0b3JUcmFuc3BvcnRTZXJ2aWNlOjpPYnNlcnZlciYp IGNvbnN0IGZpbmFsOwogICAgIHZvaWQgcmVzcG9uZFJlY2VpdmVkSW50ZXJuYWwoUmVzcG9uZCYm KSBmaW5hbDsKICAgICB2b2lkIGZpbHRlclRyYW5zcG9ydHMoVHJhbnNwb3J0U2V0JikgY29uc3Q7 CisgICAgdm9pZCBydW5QcmVzZW50ZXJJbnRlcm5hbChjb25zdCBUcmFuc3BvcnRTZXQmKSBmaW5h bCB7IH0KIAogICAgIFdlYkNvcmU6Ok1vY2tXZWJBdXRoZW50aWNhdGlvbkNvbmZpZ3VyYXRpb24g bV90ZXN0Q29uZmlndXJhdGlvbjsKIH07Cg==