225220 2021-04-29 17:25:55 -0700 [webkitscpy] Support arguments to TaskPool setup and teardown 2021-04-30 09:26:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225221 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain dewei_zhu gsnedders slewis webkit-bug-importer oldest_to_newest 1755593 0 jbedard 2021-04-29 17:25:55 -0700 webkitcorepy's TaskPool should let the user pass arguments to setup and teardown methods run by it's child processes. 1755594 1 webkit-bug-importer 2021-04-29 17:26:12 -0700 <rdar://problem/77352340> 1755599 2 427390 jbedard 2021-04-29 17:32:18 -0700 Created attachment 427390 Patch 1755713 3 427390 dewei_zhu 2021-04-30 09:21:36 -0700 Comment on attachment 427390 Patch r=me 1755715 4 ews-feeder 2021-04-30 09:26:23 -0700 Committed r276841 (237192@main): <https://commits.webkit.org/237192@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427390. 427390 2021-04-29 17:32:18 -0700 2021-04-30 09:26:23 -0700 Patch bug-225220-20210429173217.patch text/plain 7291 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NjgyNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDIxLTA0LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NweV0gU3VwcG9ydCBhcmd1bWVudHMgdG8gVGFza1Bvb2wg c2V0dXAgYW5kIHRlYXJkb3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjUyMjAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc3MzUyMzQwPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9s aWJyYXJpZXMvd2Via2l0Y29yZXB5L3NldHVwLnB5OiBCdW1wIHZlcnNpb24uCisgICAgICAgICog U2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weTog RGl0dG8uCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNv cmVweS90YXNrX3Bvb2wucHk6CisgICAgICAgIChQcm9jZXNzLm1haW4pOiBBY2NlcHQgc2V0dXAg YW5kIHRlYXJkb3duIGFyZ3VtZW50cyB0byBjaGlsZCBwcm9jZXNzZXMuCisgICAgICAgIChUYXNr UG9vbC5fX2luaXRfXyk6IFBhc3Mgc2V0dXAgYW5kIHRlYXJkb3duIGFyZ3VtZW50cyB0byBjaGls ZCBwcm9jZXNzZXMuCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dl YmtpdGNvcmVweS90ZXN0cy90YXNrX3Bvb2xfdW5pdHRlc3QucHk6CisgICAgICAgIChzZXR1cCk6 IEFjY2VwdGlvbiBvcHRpb25hbCBhcmd1bWVudC4KKyAgICAgICAgKHRlYXJkb3duKTogRGl0dG8u CisgICAgICAgIChUYXNrUG9vbFVuaXR0ZXN0LnRlc3Rfc2V0dXBfYXJndW1lbnRzKToKKyAgICAg ICAgKFRhc2tQb29sVW5pdHRlc3QudGVzdF90ZWFyZG93bl9hcmd1bWVudHMpOgorCiAyMDIxLTA0 LTI5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBFeHRlbmQgU29y dGVkQXJyYXlNYXAgZnVydGhlciB0byB3b3JrIG9uIGNhc2UtZm9sZGVkIHN0cmluZ3MsIHVzZSBp biBNSU1FVHlwZVJlZ2lzdHJ5CkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRj b3JlcHkvc2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0Y29yZXB5L3NldHVwLnB5CShyZXZpc2lvbiAyNzY4MjIpCisrKyBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTMwLDcgKzMw LDcgQEAgZGVmIHJlYWRtZSgpOgogCiBzZXR1cCgKICAgICBuYW1lPSd3ZWJraXRjb3JlcHknLAot ICAgIHZlcnNpb249JzAuNS4xMCcsCisgICAgdmVyc2lvbj0nMC41LjExJywKICAgICBkZXNjcmlw dGlvbj0nTGlicmFyeSBjb250YWluaW5nIHZhcmlvdXMgUHl0aG9uIHN1cHBvcnQgY2xhc3NlcyBh bmQgZnVuY3Rpb25zLicsCiAgICAgbG9uZ19kZXNjcmlwdGlvbj1yZWFkbWUoKSwKICAgICBjbGFz c2lmaWVycz1bCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Vi a2l0Y29yZXB5L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI3Njgy MikKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkv X19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3LDcgKzM3LDcgQEAgZnJvbSB3ZWJraXRj b3JlcHkub3V0cHV0X2NhcHR1cmUgaW1wb3J0IAogZnJvbSB3ZWJraXRjb3JlcHkudGFza19wb29s IGltcG9ydCBUYXNrUG9vbAogZnJvbSB3ZWJraXRjb3JlcHkuY3JlZGVudGlhbHMgaW1wb3J0IGNy ZWRlbnRpYWxzCiAKLXZlcnNpb24gPSBWZXJzaW9uKDAsIDUsIDEwKQordmVyc2lvbiA9IFZlcnNp b24oMCwgNSwgMTEpCiAKIGZyb20gd2Via2l0Y29yZXB5LmF1dG9pbnN0YWxsIGltcG9ydCBQYWNr YWdlLCBBdXRvSW5zdGFsbAogaWYgc3lzLnZlcnNpb25faW5mbyA+ICgzLCAwKToKSW5kZXg6IFRv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGFza19wb29s LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93 ZWJraXRjb3JlcHkvdGFza19wb29sLnB5CShyZXZpc2lvbiAyNzY4MjIpCisrKyBUb29scy9TY3Jp cHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rhc2tfcG9vbC5weQkod29y a2luZyBjb3B5KQpAQCAtMjMxLDEyICsyMzEsMTggQEAgY2xhc3MgUHJvY2VzcyhvYmplY3QpOgog ICAgICAgICAgICAgY2xzLndvcmtpbmcgPSBGYWxzZQogCiAgICAgQGNsYXNzbWV0aG9kCi0gICAg ZGVmIG1haW4oY2xzLCBuYW1lLCBzZXR1cCwgcXVldWUsIHRlYXJkb3duKToKKyAgICBkZWYgbWFp bihjbHMsIG5hbWUsIHNldHVwLCBzZXR1cGFyZ3MsIHNldHVwa3dhcmdzLCBxdWV1ZSwgdGVhcmRv d24sIHRlYXJkb3duYXJncywgdGVhcmRvd25rd2FyZ3MpOgogICAgICAgICBmcm9tIHRibGliIGlt cG9ydCBwaWNrbGluZ19zdXBwb3J0CiAKICAgICAgICAgY2xzLm5hbWUgPSBuYW1lCiAgICAgICAg IGNscy53b3JraW5nID0gVHJ1ZQogCisgICAgICAgIHNldHVwYXJncyA9IHNldHVwYXJncyBvciBb XQorICAgICAgICBzZXR1cGt3YXJncyA9IHNldHVwa3dhcmdzIG9yIHt9CisKKyAgICAgICAgdGVh cmRvd25hcmdzID0gdGVhcmRvd25hcmdzIG9yIFtdCisgICAgICAgIHRlYXJkb3dua3dhcmdzID0g dGVhcmRvd25rd2FyZ3Mgb3Ige30KKwogICAgICAgICBpZiBnZXRhdHRyKHNpZ25hbCwgJ1NJR1RF Uk0nKToKICAgICAgICAgICAgIHNpZ25hbC5zaWduYWwoc2lnbmFsLlNJR1RFUk0sIGNscy5oYW5k bGVyKQogCkBAIC0yNTEsNyArMjU3LDcgQEAgY2xhc3MgUHJvY2VzcyhvYmplY3QpOgogICAgICAg ICAgICAgdHJ5OgogICAgICAgICAgICAgICAgIHBpY2tsaW5nX3N1cHBvcnQuaW5zdGFsbCgpCiAg ICAgICAgICAgICAgICAgaWYgc2V0dXA6Ci0gICAgICAgICAgICAgICAgICAgIHNldHVwKCkKKyAg ICAgICAgICAgICAgICAgICAgc2V0dXAoKnNldHVwYXJncywgKipzZXR1cGt3YXJncykKIAogICAg ICAgICAgICAgICAgIHdoaWxlIGNscy53b3JraW5nOgogICAgICAgICAgICAgICAgICAgICB0YXNr ID0gcXVldWUucmVjZWl2ZSgpCkBAIC0yNjcsNyArMjczLDcgQEAgY2xhc3MgUHJvY2VzcyhvYmpl Y3QpOgogCiAgICAgICAgICAgICBmaW5hbGx5OgogICAgICAgICAgICAgICAgIGlmIHRlYXJkb3du OgotICAgICAgICAgICAgICAgICAgICB0ZWFyZG93bigpCisgICAgICAgICAgICAgICAgICAgIHRl YXJkb3duKCp0ZWFyZG93bmFyZ3MsICoqdGVhcmRvd25rd2FyZ3MpCiAgICAgICAgICAgICAgICAg c3lzLnN0ZG91dC5mbHVzaCgpCiAgICAgICAgICAgICAgICAgc3lzLnN0ZGVyci5mbHVzaCgpCiAg ICAgICAgICAgICAgICAgcXVldWUuc2VuZChTdGF0ZShTdGF0ZS5TVE9QUElORykpCkBAIC0yNzgs NyArMjg0LDExIEBAIGNsYXNzIFRhc2tQb29sKG9iamVjdCk6CiAgICAgY2xhc3MgRXhjZXB0aW9u KFJ1bnRpbWVFcnJvcik6CiAgICAgICAgIHBhc3MKIAotICAgIGRlZiBfX2luaXRfXyhzZWxmLCB3 b3JrZXJzPTEsIG5hbWU9Tm9uZSwgc2V0dXA9Tm9uZSwgdGVhcmRvd249Tm9uZSwgZ3JhY2VfcGVy aW9kPTUsIGJsb2NrX3NpemU9MTAwMCk6CisgICAgZGVmIF9faW5pdF9fKAorICAgICAgICBzZWxm LCB3b3JrZXJzPTEsIG5hbWU9Tm9uZSwgc2V0dXA9Tm9uZSwgdGVhcmRvd249Tm9uZSwgZ3JhY2Vf cGVyaW9kPTUsIGJsb2NrX3NpemU9MTAwMCwKKyAgICAgICAgc2V0dXBhcmdzPU5vbmUsIHNldHVw a3dhcmdzPU5vbmUsCisgICAgICAgIHRlYXJkb3duYXJncz1Ob25lLCB0ZWFyZG93bmt3YXJncz1O b25lLAorICAgICk6CiAgICAgICAgICMgRW5zdXJlIHRibGliIGlzIGluc3RhbGxlZCBiZWZvcmUg Y3JlYXRpbmcgY2hpbGQgcHJvY2Vzc2VzCiAgICAgICAgIGltcG9ydCB0YmxpYgogCkBAIC0yOTMs MTAgKzMwMywxMiBAQCBjbGFzcyBUYXNrUG9vbChvYmplY3QpOgogCiAgICAgICAgIHNlbGYud29y a2VycyA9IFttdWx0aXByb2Nlc3NpbmcuUHJvY2VzcygKICAgICAgICAgICAgIHRhcmdldD1Qcm9j ZXNzLm1haW4sCi0gICAgICAgICAgICBhcmdzPSgne30ve30nLmZvcm1hdChuYW1lLCBjb3VudCks IHNldHVwLCBCaURpcmVjdGlvbmFsUXVldWUoCi0gICAgICAgICAgICAgICAgb3V0Z29pbmc9c2Vs Zi5xdWV1ZS5pbmNvbWluZywKLSAgICAgICAgICAgICAgICBpbmNvbWluZz1zZWxmLnF1ZXVlLm91 dGdvaW5nLAotICAgICAgICAgICAgKSwgdGVhcmRvd24pLAorICAgICAgICAgICAgYXJncz0oCisg ICAgICAgICAgICAgICAgJ3t9L3t9Jy5mb3JtYXQobmFtZSwgY291bnQpLAorICAgICAgICAgICAg ICAgIHNldHVwLCBzZXR1cGFyZ3MsIHNldHVwa3dhcmdzLAorICAgICAgICAgICAgICAgIEJpRGly ZWN0aW9uYWxRdWV1ZShvdXRnb2luZz1zZWxmLnF1ZXVlLmluY29taW5nLCBpbmNvbWluZz1zZWxm LnF1ZXVlLm91dGdvaW5nKSwKKyAgICAgICAgICAgICAgICB0ZWFyZG93biwgdGVhcmRvd25hcmdz LCB0ZWFyZG93bmt3YXJncywKKyAgICAgICAgICAgICksCiAgICAgICAgICkgZm9yIGNvdW50IGlu IHJhbmdlKHdvcmtlcnMpXQogICAgICAgICBzZWxmLl9zdGFydGVkID0gMAogCkluZGV4OiBUb29s cy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL3Rhc2tf cG9vbF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93 ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L3Rlc3RzL3Rhc2tfcG9vbF91bml0dGVzdC5weQkocmV2 aXNpb24gMjc2ODIyKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dl YmtpdGNvcmVweS90ZXN0cy90YXNrX3Bvb2xfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTI3LDEyICsyNywxMiBAQCBpbXBvcnQgdW5pdHRlc3QKIGZyb20gd2Via2l0Y29yZXB5IGltcG9y dCBPdXRwdXRDYXB0dXJlLCBUYXNrUG9vbCwgbG9nIGFzIGxvZ2dlcgogCiAKLWRlZiBzZXR1cCgp OgotICAgIGxvZ2dlci53YXJuaW5nKCdTZXR0aW5nIHVwJykKK2RlZiBzZXR1cChhcmc9J1NldHRp bmcgdXAnKToKKyAgICBsb2dnZXIud2FybmluZyhhcmcpCiAKIAotZGVmIHRlYXJkb3duKCk6Ci0g ICAgbG9nZ2VyLndhcm5pbmcoJ1RlYXJpbmcgZG93bicpCitkZWYgdGVhcmRvd24oYXJnPSdUZWFy aW5nIGRvd24nKToKKyAgICBsb2dnZXIud2FybmluZyhhcmcpCiAKIAogZGVmIGFjdGlvbihhcmd1 bWVudCk6CkBAIC0xMTgsNiArMTE4LDE3IEBAIGNsYXNzIFRhc2tQb29sVW5pdHRlc3QodW5pdHRl c3QuVGVzdENhc2UKICAgICAgICAgICAgIFsnd29ya2VyL3t9IFNldHRpbmcgdXAnLmZvcm1hdCh4 KSBmb3IgeCBpbiByYW5nZSg0KV0sCiAgICAgICAgICkKIAorICAgIGRlZiB0ZXN0X3NldHVwX2Fy Z3VtZW50cyhzZWxmKToKKyAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCkgYXMgY2FwdHVyZWQ6 CisgICAgICAgICAgICB3aXRoIFRhc2tQb29sKHdvcmtlcnM9NCwgc2V0dXA9c2V0dXAsIHNldHVw YXJncz1bJ1NldHVwIGFyZ3VtZW50J10pIGFzIHBvb2w6CisgICAgICAgICAgICAgICAgZm9yIGNo YXJhY3RlciBpbiBzZWxmLmFscGhhYmV0OgorICAgICAgICAgICAgICAgICAgICBwb29sLmRvKGFj dGlvbiwgY2hhcmFjdGVyKQorICAgICAgICAgICAgICAgIHBvb2wud2FpdCgpCisgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoCisgICAgICAgICAgICBzb3J0ZWQoY2FwdHVyZWQud2Via2l0Y29yZXB5 LmxvZy5nZXR2YWx1ZSgpLnNwbGl0bGluZXMoKSksCisgICAgICAgICAgICBbJ3dvcmtlci97fSBT ZXR1cCBhcmd1bWVudCcuZm9ybWF0KHgpIGZvciB4IGluIHJhbmdlKDQpXSwKKyAgICAgICAgKQor CiAgICAgZGVmIHRlc3RfdGVhcmRvd24oc2VsZik6CiAgICAgICAgIHdpdGggT3V0cHV0Q2FwdHVy ZSgpIGFzIGNhcHR1cmVkOgogICAgICAgICAgICAgd2l0aCBUYXNrUG9vbCh3b3JrZXJzPTQsIHRl YXJkb3duPXRlYXJkb3duKSBhcyBwb29sOgpAQCAtMTI5LDYgKzE0MCwxNyBAQCBjbGFzcyBUYXNr UG9vbFVuaXR0ZXN0KHVuaXR0ZXN0LlRlc3RDYXNlCiAgICAgICAgICAgICBbJ3dvcmtlci97fSBU ZWFyaW5nIGRvd24nLmZvcm1hdCh4KSBmb3IgeCBpbiByYW5nZSg0KV0sCiAgICAgICAgICkKIAor ICAgIGRlZiB0ZXN0X3RlYXJkb3duX2FyZ3VtZW50cyhzZWxmKToKKyAgICAgICAgd2l0aCBPdXRw dXRDYXB0dXJlKCkgYXMgY2FwdHVyZWQ6CisgICAgICAgICAgICB3aXRoIFRhc2tQb29sKHdvcmtl cnM9NCwgdGVhcmRvd249dGVhcmRvd24sIHRlYXJkb3duYXJncz1bJ1RlYXJkb3duIGFyZ3VtZW50 J10pIGFzIHBvb2w6CisgICAgICAgICAgICAgICAgZm9yIGNoYXJhY3RlciBpbiBzZWxmLmFscGhh YmV0OgorICAgICAgICAgICAgICAgICAgICBwb29sLmRvKGFjdGlvbiwgY2hhcmFjdGVyKQorICAg ICAgICAgICAgICAgIHBvb2wud2FpdCgpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoCisgICAg ICAgICAgICBzb3J0ZWQoY2FwdHVyZWQud2Via2l0Y29yZXB5LmxvZy5nZXR2YWx1ZSgpLnNwbGl0 bGluZXMoKSksCisgICAgICAgICAgICBbJ3dvcmtlci97fSBUZWFyZG93biBhcmd1bWVudCcuZm9y bWF0KHgpIGZvciB4IGluIHJhbmdlKDQpXSwKKyAgICAgICAgKQorCiAgICAgZGVmIHRlc3RfaW52 YWxpZF9zaHV0ZG93bihzZWxmKToKICAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCk6CiAgICAg ICAgICAgICB3aXRoIHNlbGYuYXNzZXJ0UmFpc2VzKFRhc2tQb29sLkV4Y2VwdGlvbik6Cg==