225218 2021-04-29 16:47:08 -0700 _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext 2021-04-30 13:17:10 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan bfulgham jiewen_tan webkit-bug-importer oldest_to_newest 1755578 0 jiewen_tan 2021-04-29 16:47:08 -0700 _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext. 1755579 1 jiewen_tan 2021-04-29 16:47:27 -0700 rdar://76969220 1755580 2 427387 jiewen_tan 2021-04-29 16:50:13 -0700 Created attachment 427387 Patch 1755777 3 427387 bfulgham 2021-04-30 12:43:34 -0700 Comment on attachment 427387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146 > + if (shouldUseAlternateAttributes() && !context) { Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good. 1755780 4 427387 jiewen_tan 2021-04-30 13:11:35 -0700 Comment on attachment 427387 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146 >> + if (shouldUseAlternateAttributes() && !context) { > > Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good. Yup, look over that there are now two architectures in macOS. 1755781 5 ews-feeder 2021-04-30 13:17:09 -0700 Committed r276851 (237202@main): <https://commits.webkit.org/237202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427387. 427387 2021-04-29 16:50:13 -0700 2021-04-30 13:17:09 -0700 Patch bug-225218-20210429165012.patch text/plain 2946 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBlMjJkNjhkZDA3NjdmYjk4 M2VlODM4YzYyNWRiMzEyZjFmN2FlZTQuLjA4ZDE4YWM1OTRlMGQ2ZjUyODIwYzQ4OWUxZDk0NDJh ODU3ZmM4ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDQtMjkgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBfV0tXZWJBdXRoZW50aWNhdGlv blBhbmVsRGVsZWdhdGUgcmVnaXN0cmF0aW9uIGFuZCBhc3NlcnRpb24gU1BJIGRvZXNuJ3Qgd29y ayB3aXRob3V0IGFuIExBQ29udGV4dCAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyNTIxOAorICAgICAgICA8cmRhcjovLzc2OTY5MjIwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgbWFu dWFsIHRlc3RzLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29h L0xvY2FsQ29ubmVjdGlvbi5tbToKKyAgICAgICAgKFdlYktpdDo6TG9jYWxDb25uZWN0aW9uOjp2 ZXJpZnlVc2VyKToKKyAgICAgICAgQWRkcyBhIGNhc2UgZm9yIG5pbCBMQUNvbnRleHQuCisKIDIw MjEtMDQtMjAgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAg ICBbQ01ha2VdIERvbid0IHVzZSBGT1JXQVJESU5HX0hFQURFUlNfRElSIGZvciBKU0MgR0xpYiBo ZWFkZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJBdXRoZW50aWNh dGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJBdXRoZW50aWNhdGlvbi9Db2NvYS9Mb2NhbENvbm5lY3Rpb24ubW0KaW5kZXggNDYzNWNiN2Fl NzA5NzM1YTA1NTg0NmFiYTNmMjc1YmY0MGYyOTFmMC4uOTc1Y2MxYWRhNWU4MDYyMWFhMDZmMGVj NTU2OGYyMzgzN2VkYjMyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi QXV0aGVudGljYXRpb24vQ29jb2EvTG9jYWxDb25uZWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0aW9uL0NvY29hL0xvY2FsQ29ubmVjdGlvbi5tbQpA QCAtMTI0LDcgKzEyNCw3IEBAIHZvaWQgTG9jYWxDb25uZWN0aW9uOjp2ZXJpZnlVc2VyKFNlY0Fj Y2Vzc0NvbnRyb2xSZWYgYWNjZXNzQ29udHJvbCwgTEFDb250ZXh0ICpjCiAgICAgYXV0byBvcHRp b25zID0gYWRvcHROUyhbW05TTXV0YWJsZURpY3Rpb25hcnkgYWxsb2NdIGluaXRdKTsKICAgICBb b3B0aW9ucyBzZXRPYmplY3Q6QFlFUyBmb3JLZXk6QChMQU9wdGlvbk5vdEludGVyYWN0aXZlKV07 CiAKLSAgICBhdXRvIHJlcGx5ID0gbWFrZUJsb2NrUHRyKFtjb21wbGV0aW9uSGFuZGxlciA9IFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoTlNEaWN0aW9uYXJ5ICosIE5TRXJyb3IgKmVycm9y KSBtdXRhYmxlIHsKKyAgICBhdXRvIHJlcGx5ID0gbWFrZUJsb2NrUHRyKFtjb21wbGV0aW9uSGFu ZGxlciA9IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpXSAoTlNEaWN0aW9uYXJ5ICppbmZvcm1h dGlvbiwgTlNFcnJvciAqZXJyb3IpIG11dGFibGUgewogICAgICAgICBVc2VyVmVyaWZpY2F0aW9u IHZlcmlmaWNhdGlvbiA9IFVzZXJWZXJpZmljYXRpb246OlllczsKICAgICAgICAgaWYgKGVycm9y KSB7CiAgICAgICAgICAgICBMT0dfRVJST1IoIkNvdWxkbid0IGF1dGhlbnRpY2F0ZSB3aXRoIGJp b21ldHJpY3M6ICVAIiwgZXJyb3IpOwpAQCAtMTMyLDYgKzEzMiw4IEBAIHZvaWQgTG9jYWxDb25u ZWN0aW9uOjp2ZXJpZnlVc2VyKFNlY0FjY2Vzc0NvbnRyb2xSZWYgYWNjZXNzQ29udHJvbCwgTEFD b250ZXh0ICpjCiAgICAgICAgICAgICBpZiAoZXJyb3IuY29kZSA9PSBMQUVycm9yVXNlckNhbmNl bCkKICAgICAgICAgICAgICAgICB2ZXJpZmljYXRpb24gPSBVc2VyVmVyaWZpY2F0aW9uOjpDYW5j ZWw7CiAgICAgICAgIH0KKyAgICAgICAgaWYgKGluZm9ybWF0aW9uW0AiVXNlclByZXNlbmNlIl0p CisgICAgICAgICAgICB2ZXJpZmljYXRpb24gPSBVc2VyVmVyaWZpY2F0aW9uOjpQcmVzZW5jZTsK IAogICAgICAgICAvLyBUaGlzIGJsb2NrIGNhbiBiZSBleGVjdXRlZCBpbiBhbm90aGVyIHRocmVh ZC4KICAgICAgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtjb21wbGV0aW9uSGFuZGxlciA9 IFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpLCB2ZXJpZmljYXRpb25dICgpIG11dGFibGUgewpA QCAtMTM5LDYgKzE0MSwxNCBAQCB2b2lkIExvY2FsQ29ubmVjdGlvbjo6dmVyaWZ5VXNlcihTZWNB Y2Nlc3NDb250cm9sUmVmIGFjY2Vzc0NvbnRyb2wsIExBQ29udGV4dCAqYwogICAgICAgICB9KTsK ICAgICB9KTsKIAorI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCisgICAgLy8gRGVwZW5kaW5n IG9uIGNlcnRhaW4gaW50ZXJuYWwgcmVxdWlyZW1lbnRzLCBjb250ZXh0IG1pZ2h0IGJlIG5pbC4g SW4gdGhhdCBjYXNlLCBqdXN0IGNoZWNrIHVzZXIgcHJlc2VuY2UuCisgICAgaWYgKHNob3VsZFVz ZUFsdGVybmF0ZUF0dHJpYnV0ZXMoKSAmJiAhY29udGV4dCkgeworICAgICAgICByZXBseShAeyBA IlVzZXJQcmVzZW5jZSI6IEBZRVMgfSwgbnVsbHB0cik7CisgICAgICAgIHJldHVybjsKKyAgICB9 CisjZW5kaWYKKwogICAgIFtjb250ZXh0IGV2YWx1YXRlQWNjZXNzQ29udHJvbDphY2Nlc3NDb250 cm9sIG9wZXJhdGlvbjpMQUFjY2Vzc0NvbnRyb2xPcGVyYXRpb25Vc2VLZXlTaWduIG9wdGlvbnM6 b3B0aW9ucy5nZXQoKSByZXBseTpyZXBseS5nZXQoKV07CiB9CiAK