225205 2021-04-29 13:04:32 -0700 -Wpessimizing-move warnings in LocaleICU.cpp 2021-04-29 15:35:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro sam webkit-bug-importer oldest_to_newest 1755510 0 mcatanzaro 2021-04-29 13:04:32 -0700 It looks like GCC 11 has improved its -Wpessimizing-move warning: [2866/5471] Building CXX object Source/WebCore/CMakeFiles...edSources/unified-sources/UnifiedSource-3c72abbe-58.cpp.o In file included from WTF/Headers/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:56, from ../../Source/WebCore/platform/text/TextEncodingRegistry.cpp:27, from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-58.cpp:1: ../../Source/WebCore/platform/text/LocaleICU.cpp: In member function ‘std::unique_ptr<WTF::Vector<WTF::String> > WebCore::LocaleICU::createLabelVector(void* const*, UDateFormatSymbolType, int32_t, int32_t)’: WTF/Headers/wtf/StdLibExtras.h:563:58: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:185:12: note: in expansion of macro ‘WTFMove’ 185 | return WTFMove(labels); | ^~~~~~~ WTF/Headers/wtf/StdLibExtras.h:563:58: note: remove ‘std::move’ call 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:185:12: note: in expansion of macro ‘WTFMove’ 185 | return WTFMove(labels); | ^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp: In function ‘std::unique_ptr<WTF::Vector<WTF::String> > WebCore::createFallbackMonthLabels()’: WTF/Headers/wtf/StdLibExtras.h:563:58: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:194:12: note: in expansion of macro ‘WTFMove’ 194 | return WTFMove(labels); | ^~~~~~~ WTF/Headers/wtf/StdLibExtras.h:563:58: note: remove ‘std::move’ call 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:194:12: note: in expansion of macro ‘WTFMove’ 194 | return WTFMove(labels); | ^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp: In function ‘std::unique_ptr<WTF::Vector<WTF::String> > WebCore::createFallbackAMPMLabels()’: WTF/Headers/wtf/StdLibExtras.h:563:58: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:216:12: note: in expansion of macro ‘WTFMove’ 216 | return WTFMove(labels); | ^~~~~~~ WTF/Headers/wtf/StdLibExtras.h:563:58: note: remove ‘std::move’ call 563 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ ../../Source/WebCore/platform/text/LocaleICU.cpp:216:12: note: in expansion of macro ‘WTFMove’ 216 | return WTFMove(labels); | ^~~~~~~ This case is a little interesting because the return value is a std::unique_ptr, which is noncopyable. I can see why using WTFMove for that would be tempting. But it's not needed for a return value. 1755511 1 427371 mcatanzaro 2021-04-29 13:05:33 -0700 Created attachment 427371 Patch 1755554 2 ews-feeder 2021-04-29 15:34:13 -0700 Committed r276813 (237173@main): <https://commits.webkit.org/237173@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427371. 1755557 3 webkit-bug-importer 2021-04-29 15:35:18 -0700 <rdar://problem/77346730> 427371 2021-04-29 13:05:33 -0700 2021-04-29 15:34:13 -0700 Patch bug-225205-20210429150532.patch text/plain 2082 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2Nzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdiZGE2OTNjMzY0OWEz MzNkNDViNGIwM2QzZWU1NTM4NTY5M2RlYy4uMjNkYzFiMjk5NjA4M2RkNTg0NzJjYTUxMGVjZTg0 YmQyOGE4ODZkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA0LTI5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XcGVzc2lt aXppbmctbW92ZSB3YXJuaW5ncyBpbiBMb2NhbGVJQ1UuY3BwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUyMDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsZUlDVTo6Y3JlYXRlTGFiZWxWZWN0b3IpOgorICAg ICAgICAoV2ViQ29yZTo6Y3JlYXRlRmFsbGJhY2tNb250aExhYmVscyk6CisgICAgICAgIChXZWJD b3JlOjpjcmVhdGVGYWxsYmFja0FNUE1MYWJlbHMpOgorCiAyMDIxLTA0LTI5ICBEYXJpbiBBZGxl ciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBFeHRlbmQgU29ydGVkQXJyYXlNYXAgZnVy dGhlciB0byB3b3JrIG9uIGNhc2UtZm9sZGVkIHN0cmluZ3MsIHVzZSBpbiBNSU1FVHlwZVJlZ2lz dHJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5jcHAKaW5kZXggYThl OTE3NDBhY2MyMjgxZjMzNzllZDg2NDJkNzg2YmE3MDJlZWUwNC4uM2U1OGI3ZjA2YmU2NDgyZmYy ZDY0ODNlYzFmMjc3ZTNhZGEwZmUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv TG9jYWxlSUNVLmNwcApAQCAtMTgyLDcgKzE4Miw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3I8 U3RyaW5nPj4gTG9jYWxlSUNVOjpjcmVhdGVMYWJlbFZlY3Rvcihjb25zdCBVRGF0ZUZvcm1hdCoK ICAgICAgICAgICAgIHJldHVybiBtYWtlVW5pcXVlPFZlY3RvcjxTdHJpbmc+PigpOwogICAgICAg ICBsYWJlbHMtPmFwcGVuZChTdHJpbmc6OmFkb3B0KFdURk1vdmUoYnVmZmVyKSkpOwogICAgIH0K LSAgICByZXR1cm4gV1RGTW92ZShsYWJlbHMpOworICAgIHJldHVybiBsYWJlbHM7CiB9CiAKIHN0 YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFN0cmluZz4+IGNyZWF0ZUZhbGxiYWNrTW9udGhM YWJlbHMoKQpAQCAtMTkxLDcgKzE5MSw3IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9y PFN0cmluZz4+IGNyZWF0ZUZhbGxiYWNrTW9udGhMYWJlbHMoKQogICAgIGxhYmVscy0+cmVzZXJ2 ZUNhcGFjaXR5KFdURl9BUlJBWV9MRU5HVEgoV1RGOjptb250aEZ1bGxOYW1lKSk7CiAgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IFdURl9BUlJBWV9MRU5HVEgoV1RGOjptb250aEZ1bGxOYW1l KTsgKytpKQogICAgICAgICBsYWJlbHMtPmFwcGVuZChXVEY6Om1vbnRoRnVsbE5hbWVbaV0pOwot ICAgIHJldHVybiBXVEZNb3ZlKGxhYmVscyk7CisgICAgcmV0dXJuIGxhYmVsczsKIH0KIAogY29u c3QgVmVjdG9yPFN0cmluZz4mIExvY2FsZUlDVTo6bW9udGhMYWJlbHMoKQpAQCAtMjEzLDcgKzIx Myw3IEBAIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFN0cmluZz4+IGNyZWF0ZUZhbGxi YWNrQU1QTUxhYmVscygpCiAgICAgbGFiZWxzLT5yZXNlcnZlQ2FwYWNpdHkoMik7CiAgICAgbGFi ZWxzLT5hcHBlbmQoIkFNIik7CiAgICAgbGFiZWxzLT5hcHBlbmQoIlBNIik7Ci0gICAgcmV0dXJu IFdURk1vdmUobGFiZWxzKTsKKyAgICByZXR1cm4gbGFiZWxzOwogfQogCiB2b2lkIExvY2FsZUlD VTo6aW5pdGlhbGl6ZURhdGVUaW1lRm9ybWF0KCkK