22520 2008-11-26 16:25:36 -0800 REGRESSION(r38768?): Two animation tests crashing on buildbot 2008-12-03 14:21:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED LayoutTestFailure, Regression P2 Normal --- 22499 1 mrowe cmarrin ap simon.fraser oldest_to_newest 100483 0 mrowe 2008-11-26 16:25:36 -0800 See <http://build.webkit.org/results/trunk-mac-intel-release/6243/results.html> for the failing tests. They appear to have started with <http://build.webkit.org/changes/2756>. A crash log can be seen at <http://build.webkit.org/results/trunk-mac-intel-release/6243/DumpRenderTree.crash.log>. 100485 1 mrowe 2008-11-26 16:27:39 -0800 Leopard is showing a different test crashing on <http://build.webkit.org/results/trunk-mac-intel-pixel/568/results.html>. 100893 2 cmarrin 2008-12-01 15:06:41 -0800 All these bugs are fixed by the patches for 22046 and 22052 100928 3 simon.fraser 2008-12-01 17:46:10 -0800 This test is still crashing on the bot: <http://build.webkit.org/builders/trunk-mac-intel-pixel/builds/647/steps/pixel-layout-test/logs/stdio> animations/transform-animation-event-destroy-element.html -> crashed 100929 4 simon.fraser 2008-12-01 17:52:21 -0800 Debug builds assert: (/Volumes/InternalData/Development/webkit/WebKit.git/JavaScriptCore/wtf/ThreadingPthreads.cpp:205 void WTF::Mutex::lock()) 100932 5 25649 levin 2008-12-01 18:21:16 -0800 Created attachment 25649 Disable the transform-animation-event-destroy-element while the animation lifetime issue is being investigated. 100987 6 ap 2008-12-02 01:14:18 -0800 For me, the crash reproduces on Tiger/PPC, but not on Leopard/Intel. Looks like an animation lifetime issue indeed, and not something directly related to mutex locking. 101022 7 25675 cmarrin 2008-12-02 10:53:46 -0800 Created attachment 25675 Patch to fix bug Sorry, I should not have closed this. The other two patches are needed for this fix, but it needs one more thing, which is included in this patch. 101229 8 25675 hyatt 2008-12-03 11:24:31 -0800 Comment on attachment 25675 Patch to fix bug r=me 101261 9 cmarrin 2008-12-03 14:21:28 -0800 Sending WebCore/ChangeLog Sending WebCore/page/animation/AnimationBase.cpp Transmitting file data .. Committed revision 38968. 25649 2008-12-01 18:21:16 -0800 2008-12-02 10:53:46 -0800 Disable the transform-animation-event-destroy-element while the animation lifetime issue is being investigated. disable_test_for_bug22520.txt text/plain 4436 levin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM4ODg3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTItMDEgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL2F0dGFjaG1lbnQuY2dpP2J1Z2lkPTIy NTIwCisgICAgICAgIERpc2FibGluZyB0aGUgdGVzdCB1bnRpbCB0aGUgcHJvYmxlbSBjYW4gYmUg aW52ZXN0aWdhdGVkLgorCisgICAgICAgICogYW5pbWF0aW9ucy90cmFuc2Zvcm0tYW5pbWF0aW9u LWV2ZW50LWRlc3Ryb3ktZWxlbWVudC5odG1sOiBSZW1vdmVkLgorICAgICAgICAqIGFuaW1hdGlv bnMvdHJhbnNmb3JtLWFuaW1hdGlvbi1ldmVudC1kZXN0cm95LWVsZW1lbnQuaHRtbC1kaXNhYmxl ZDogQ29waWVkIGZyb20gTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy90cmFuc2Zvcm0tYW5pbWF0aW9u LWV2ZW50LWRlc3Ryb3ktZWxlbWVudC5odG1sLgorCiAyMDA4LTEyLTAxICBQaWVycmUtT2xpdmll ciBMYXRvdXIgIDxwb2xAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93 ZS4KSW5kZXg6IExheW91dFRlc3RzL2FuaW1hdGlvbnMvdHJhbnNmb3JtLWFuaW1hdGlvbi1ldmVu dC1kZXN0cm95LWVsZW1lbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hbmltYXRp b25zL3RyYW5zZm9ybS1hbmltYXRpb24tZXZlbnQtZGVzdHJveS1lbGVtZW50Lmh0bWwJKHJldmlz aW9uIDM4ODgyKQorKysgTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy90cmFuc2Zvcm0tYW5pbWF0aW9u LWV2ZW50LWRlc3Ryb3ktZWxlbWVudC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xLDU0ICswLDAg QEAKLTxodG1sPgotPGhlYWQ+Ci0gIDx0aXRsZT5EZXN0cm95IFJlbmRlcmVyIGluIEFuaW1hdGlv biBFbmQgRXZlbnQ8L3RpdGxlPgotICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3Jl ZW4iPgotICAgICNib3gxIHsKLSAgICAgIHBvc2l0aW9uOiByZWxhdGl2ZTsKLSAgICAgIGxlZnQ6 IDA7Ci0gICAgICBoZWlnaHQ6IDEwMHB4OwotICAgICAgd2lkdGg6IDEwMHB4OwotICAgICAgbWFy Z2luOiAxMHB4OwotICAgICAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKLSAgICAgIC13ZWJraXQt YW5pbWF0aW9uLW5hbWU6IG1vdmU7Ci0gICAgICAtd2Via2l0LWFuaW1hdGlvbi1kdXJhdGlvbjog MC4yczsKLSAgICB9Ci0gICAgCi0gICAgQC13ZWJraXQta2V5ZnJhbWVzIG1vdmUgewotICAgICAg ZnJvbSB7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUoMHB4LCAwcHgpOyB9Ci0gICAgICB0 byB7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGUoMTAwcHgsIDBweCk7IH0KLSAgICB9Ci0g IDwvc3R5bGU+Ci0gIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBjaGFyc2V0PSJ1dGYt OCI+Ci0gICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewotICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Ci0gICAgICAgIGxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKLSAgICB9Ci0KLSAgICBmdW5jdGlvbiB0cmFuc2l0aW9uRW5k ZWQoKQotICAgIHsKLSAgICAgIHZhciBib3ggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94 MScpOwotICAgICAgYm94LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQoYm94KTsKLSAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKLSAgICB9Ci0KLSAgICBmdW5jdGlvbiBzdGFydFRyYW5zaXRpb24oKQot ICAgIHsKLSAgICAgIHZhciBib3ggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94MScpOwot ICAgICAgYm94LmFkZEV2ZW50TGlzdGVuZXIoIndlYmtpdEFuaW1hdGlvbkVuZCIsIHRyYW5zaXRp b25FbmRlZCwgZmFsc2UpOwotICAgICAgYm94LnN0eWxlLndlYmtpdEFuaW1hdGlvbk5hbWUgPSAn bW92ZSc7Ci0gICAgfQotICAgIAotICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywg c3RhcnRUcmFuc2l0aW9uLCBmYWxzZSk7Ci0gIDwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHk+Ci0K LTxwPlRlc3Qgc2V0cyBkaXNwbGF5Om5vbmUgb24gdGhlIGVsZW1lbnQgd2l0aGluIHRoZSB3ZWJr aXRBbmltYXRpb25FbmQgZXZlbnQgaGFuZGxlci4gU2hvdWxkIG5vdCBjcmFzaC48L3A+Ci0KLTxk aXYgaWQ9ImNvbnRhaW5lciI+Ci0gIDxkaXYgaWQ9ImJveDEiIGNsYXNzPSJib3giPjwvZGl2Pgot PC9kaXY+Ci0KLTwvYm9keT4KLTwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2FuaW1hdGlvbnMv dHJhbnNmb3JtLWFuaW1hdGlvbi1ldmVudC1kZXN0cm95LWVsZW1lbnQuaHRtbC1kaXNhYmxlZAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hbmltYXRpb25zL3RyYW5zZm9ybS1hbmltYXRpb24t ZXZlbnQtZGVzdHJveS1lbGVtZW50Lmh0bWwtZGlzYWJsZWQJKHJldmlzaW9uIDM4ODgyKQkoZnJv bSBMYXlvdXRUZXN0cy9hbmltYXRpb25zL3RyYW5zZm9ybS1hbmltYXRpb24tZXZlbnQtZGVzdHJv eS1lbGVtZW50Lmh0bWw6Mzg4ODIpCisrKyBMYXlvdXRUZXN0cy9hbmltYXRpb25zL3RyYW5zZm9y bS1hbmltYXRpb24tZXZlbnQtZGVzdHJveS1lbGVtZW50Lmh0bWwtZGlzYWJsZWQJKHdvcmtpbmcg Y29weSkKQEAgLTAsMCArMSw1NCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgPHRpdGxlPkRlc3Ryb3kg UmVuZGVyZXIgaW4gQW5pbWF0aW9uIEVuZCBFdmVudDwvdGl0bGU+CisgIDxzdHlsZSB0eXBlPSJ0 ZXh0L2NzcyIgbWVkaWE9InNjcmVlbiI+CisgICAgI2JveDEgeworICAgICAgcG9zaXRpb246IHJl bGF0aXZlOworICAgICAgbGVmdDogMDsKKyAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICB3aWR0 aDogMTAwcHg7CisgICAgICBtYXJnaW46IDEwcHg7CisgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBi bHVlOworICAgICAgLXdlYmtpdC1hbmltYXRpb24tbmFtZTogbW92ZTsKKyAgICAgIC13ZWJraXQt YW5pbWF0aW9uLWR1cmF0aW9uOiAwLjJzOworICAgIH0KKyAgICAKKyAgICBALXdlYmtpdC1rZXlm cmFtZXMgbW92ZSB7CisgICAgICBmcm9tIHsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgw cHgsIDBweCk7IH0KKyAgICAgIHRvIHsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSgxMDBw eCwgMHB4KTsgfQorICAgIH0KKyAgPC9zdHlsZT4KKyAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgIH0KKworICAgIGZ1 bmN0aW9uIHRyYW5zaXRpb25FbmRlZCgpCisgICAgeworICAgICAgdmFyIGJveCA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdib3gxJyk7CisgICAgICBib3gucGFyZW50Tm9kZS5yZW1vdmVDaGls ZChib3gpOworICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAg bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgIH0KKworICAgIGZ1bmN0aW9u IHN0YXJ0VHJhbnNpdGlvbigpCisgICAgeworICAgICAgdmFyIGJveCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdib3gxJyk7CisgICAgICBib3guYWRkRXZlbnRMaXN0ZW5lcigid2Via2l0QW5p bWF0aW9uRW5kIiwgdHJhbnNpdGlvbkVuZGVkLCBmYWxzZSk7CisgICAgICBib3guc3R5bGUud2Vi a2l0QW5pbWF0aW9uTmFtZSA9ICdtb3ZlJzsKKyAgICB9CisgICAgCisgICAgd2luZG93LmFkZEV2 ZW50TGlzdGVuZXIoJ2xvYWQnLCBzdGFydFRyYW5zaXRpb24sIGZhbHNlKTsKKyAgPC9zY3JpcHQ+ Cis8L2hlYWQ+Cis8Ym9keT4KKworPHA+VGVzdCBzZXRzIGRpc3BsYXk6bm9uZSBvbiB0aGUgZWxl bWVudCB3aXRoaW4gdGhlIHdlYmtpdEFuaW1hdGlvbkVuZCBldmVudCBoYW5kbGVyLiBTaG91bGQg bm90IGNyYXNoLjwvcD4KKworPGRpdiBpZD0iY29udGFpbmVyIj4KKyAgPGRpdiBpZD0iYm94MSIg Y2xhc3M9ImJveCI+PC9kaXY+Cis8L2Rpdj4KKworPC9ib2R5PgorPC9odG1sPgo= 25675 2008-12-02 10:53:46 -0800 2008-12-03 11:24:31 -0800 Patch to fix bug 22520.patch text/plain 1974 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODkwNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDgtMTItMDIgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MjAKKworICAgICAg ICBUaGlzIGlzIGEgcmVncmVzc2lvbiAoY2F1c2VzIGEgY3Jhc2ggb2YgTGF5b3V0VGVzdHMvYW5p bWF0aW9ucy90cmFuc2Zvcm0tYW5pbWF0aW9uLWV2ZW50LWRlc3Ryb3ktZWxlbWVudC5odG1sKS4K KyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGUgdGVzdGNhc2UuCisKKyAgICAgICAgVGhpcyBp cyBhbm90aGVyIGNhc2Ugb2YgYW5pbWF0aW9ucyBnZXR0aW5nIGRlc3Ryb3llZCBpbiB0aGUgZW5k IGFuaW1hdGlvbiBjYWxsYmFjayBhbmQgY2F1c2luZyBkYW5nbGluZworICAgICAgICBwb2ludGVy cyBvbiByZXR1cm4uIFRoaXMgb25lIGludm9sdmVzIGl0ZXJhdGluZyBvdmVyIHRoZSBDb21wb3Np dGVBbmltYXRpb24sIHdoaWNoIGhhcyBiZWVuIGRlc3Ryb3llZC4KKyAgICAgICAgU28gSSBub3cg Y2hlY2sgZm9yIGEgbnVsbCBtX29iamVjdCBwb2ludGVyICh3aGljaCBpcyBudWxsaWZpZWQgd2hl biB0aGUgQ29tcG9zaXRlQW5pbWF0aW9uIGlzIGRlc3Ryb3llZCkKKyAgICAgICAgYW5kIHNraXAg dGhhdCBjYWxsLgorCisgICAgICAgICogcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25CYXNlOjp1cGRhdGVTdGF0ZU1hY2hpbmUpOgor CiAyMDA4LTEyLTAxIExhc3psbyBHb21ib3MgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgVG9yIEFybmUgVmVzdGLDuC4KSW5kZXg6IFdlYkNvcmUvcGFn ZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdl L2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAkocmV2aXNpb24gMzg5MDQpCisrKyBXZWJDb3Jl L3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDMs MTEgKzY0MywxMiBAQCB2b2lkIEFuaW1hdGlvbkJhc2U6OnVwZGF0ZVN0YXRlTWFjaGluZShBCiAg ICAgICAgICAgICAgICAgLy8gRW5kIHRpbWVyIGZpcmVkLCBmaW5pc2ggdXAKICAgICAgICAgICAg ICAgICBvbkFuaW1hdGlvbkVuZChwYXJhbSk7CiAKLSAgICAgICAgICAgICAgICByZXN1bWVPdmVy cmlkZGVuQW5pbWF0aW9ucygpOwotCi0gICAgICAgICAgICAgICAgLy8gRmlyZSBvZmYgYW5vdGhl ciBzdHlsZSBjaGFuZ2Ugc28gd2UgY2FuIHNldCB0aGUgZmluYWwgdmFsdWUKICAgICAgICAgICAg ICAgICBtX2FuaW1TdGF0ZSA9IEFuaW1hdGlvblN0YXRlRG9uZTsKKyAgICAgICAgICAgICAgICAK ICAgICAgICAgICAgICAgICBpZiAobV9vYmplY3QpIHsKKyAgICAgICAgICAgICAgICAgICAgcmVz dW1lT3ZlcnJpZGRlbkFuaW1hdGlvbnMoKTsKKworICAgICAgICAgICAgICAgICAgICAvLyBGaXJl IG9mZiBhbm90aGVyIHN0eWxlIGNoYW5nZSBzbyB3ZSBjYW4gc2V0IHRoZSBmaW5hbCB2YWx1ZQog ICAgICAgICAgICAgICAgICAgICBzZXRDaGFuZ2VkKG1fb2JqZWN0LT5lbGVtZW50KCkpOwogICAg ICAgICAgICAgICAgICAgICBtX29iamVjdC0+YW5pbWF0aW9uKCktPnN0YXJ0VXBkYXRlUmVuZGVy aW5nRGlzcGF0Y2hlcigpOwogICAgICAgICAgICAgICAgIH0K