225194 2021-04-29 10:22:47 -0700 Inlining property accesses inside constant folding should check Options::useAccessInlining 2021-04-29 17:13:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1755436 0 saam 2021-04-29 10:22:47 -0700 ... 1755460 1 427358 saam 2021-04-29 10:55:23 -0700 Created attachment 427358 patch 1755584 2 ews-feeder 2021-04-29 17:12:07 -0700 Committed r276823 (237178@main): <https://commits.webkit.org/237178@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427358. 1755586 3 webkit-bug-importer 2021-04-29 17:13:16 -0700 <rdar://problem/77351750> 427358 2021-04-29 10:55:23 -0700 2021-04-29 17:12:08 -0700 patch a-backup.diff text/plain 5152 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc2Nzg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIxLTA0LTI5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IElubGluaW5nIHByb3BlcnR5IGFjY2Vzc2VzIGluc2lkZSBjb25zdGFudCBmb2xkaW5nIHNob3Vs ZCBjaGVjayBPcHRpb25zOjp1c2VBY2Nlc3NJbmxpbmluZworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MTk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklu bGluZXMuaDoKKyAgICAgICAgKEpTQzo6REZHOjpBYnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0 U3RhdGVUeXBlPjo6ZXhlY3V0ZUVmZmVjdHMpOgorICAgICAgICAqIGRmZy9ERkdCeXRlQ29kZVBh cnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sp OgorICAgICAgICAqIGRmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHA6CisgICAgICAgIChK U0M6OkRGRzo6Q29uc3RhbnRGb2xkaW5nUGhhc2U6OmZvbGRDb25zdGFudHMpOgorICAgICAgICAo SlNDOjpERkc6OkNvbnN0YW50Rm9sZGluZ1BoYXNlOjp0cnlGb2xkQXNQdXRCeU9mZnNldCk6CisK IDIwMjEtMDQtMjkgIFNhYW0gQmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAg U2FtcGxpbmcgcHJvZmlsZXIgc2hvdWxkIGR1bXAgYSB0aWVyIGJyZWFrZG93biwgYW5kIGFkZCBh YmlsaXR5IHRvIHNlZSB0aW1lIHNwZW50IGluIEMgY29kZSB3aXRoIHNhbXBsZUNDb2RlPTAsIGFu ZCBmaXggYnVncyB3aXRoIGZyYW1lcyBoYXZpbmcgdGhlIHdyb25nIGppdFR5cGUgaWYgdGhleSdy ZSBpbmxpbmVkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50 ZXJwcmV0ZXJJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCShyZXZpc2lvbiAyNzY2NDYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTM0MTEsNyArMzQxMSw5IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnBy ZXRlcjxBYnN0cmFjdFN0YXRlVHkKICAgICBjYXNlIEdldEJ5SWQ6CiAgICAgY2FzZSBHZXRCeUlk Rmx1c2g6IHsKICAgICAgICAgQWJzdHJhY3RWYWx1ZSYgdmFsdWUgPSBmb3JOb2RlKG5vZGUtPmNo aWxkMSgpKTsKLSAgICAgICAgaWYgKHZhbHVlLm1fc3RydWN0dXJlLmlzRmluaXRlKCkKKworICAg ICAgICBpZiAoT3B0aW9uczo6dXNlQWNjZXNzSW5saW5pbmcoKQorICAgICAgICAgICAgJiYgdmFs dWUubV9zdHJ1Y3R1cmUuaXNGaW5pdGUoKQogICAgICAgICAgICAgJiYgKG5vZGUtPmNoaWxkMSgp LnVzZUtpbmQoKSA9PSBDZWxsVXNlIHx8ICEodmFsdWUubV90eXBlICYgflNwZWNDZWxsKSkpIHsK ICAgICAgICAgICAgIFVuaXF1ZWRTdHJpbmdJbXBsKiB1aWQgPSBub2RlLT5jYWNoZWFibGVJZGVu dGlmaWVyKCkudWlkKCk7CiAgICAgICAgICAgICBHZXRCeVN0YXR1cyBzdGF0dXMgPSBHZXRCeVN0 YXR1czo6Y29tcHV0ZUZvcih2YWx1ZS5tX3N0cnVjdHVyZS50b1N0cnVjdHVyZVNldCgpLCB1aWQp OwpAQCAtNDExMCw3ICs0MTEyLDcgQEAgYm9vbCBBYnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0 U3RhdGVUeQogICAgIGNhc2UgUHV0QnlJZEZsdXNoOgogICAgIGNhc2UgUHV0QnlJZERpcmVjdDog ewogICAgICAgICBBYnN0cmFjdFZhbHVlJiB2YWx1ZSA9IGZvck5vZGUobm9kZS0+Y2hpbGQxKCkp OwotICAgICAgICBpZiAodmFsdWUubV9zdHJ1Y3R1cmUuaXNGaW5pdGUoKSkgeworICAgICAgICBp ZiAoT3B0aW9uczo6dXNlQWNjZXNzSW5saW5pbmcoKSAmJiB2YWx1ZS5tX3N0cnVjdHVyZS5pc0Zp bml0ZSgpKSB7CiAgICAgICAgICAgICBib29sIGlzRGlyZWN0ID0gbm9kZS0+b3AoKSA9PSBQdXRC eUlkRGlyZWN0IHx8IG5vZGUtPm9wKCkgPT0gUHV0UHJpdmF0ZU5hbWVCeUlkOwogICAgICAgICAg ICAgYXV0byBwcml2YXRlRmllbGRQdXRLaW5kID0gbm9kZS0+b3AoKSA9PSBQdXRQcml2YXRlTmFt ZUJ5SWQgPyBub2RlLT5wcml2YXRlRmllbGRQdXRLaW5kKCkgOiBQcml2YXRlRmllbGRQdXRLaW5k Ojpub25lKCk7CiAgICAgICAgICAgICBQdXRCeUlkU3RhdHVzIHN0YXR1cyA9IFB1dEJ5SWRTdGF0 dXM6OmNvbXB1dGVGb3IoCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0J5dGVD b2RlUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R0J5dGVDb2RlUGFyc2VyLmNwcAkocmV2aXNpb24gMjc2NjQ2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU5NDks NyArNTk0OSw4IEBAIHZvaWQgQnl0ZUNvZGVQYXJzZXI6OnBhcnNlQmxvY2sodW5zaWduZWQKICAg ICAgICAgICAgIC8vIGluc3RhbmNlb2YgSUNzIGJlY2F1c2UgdGhlIHByb2ZpdCBvZiB0aGlzIG9w dGltaXphdGlvbiBpcyBmYWlybHkgbG93LiBTbywgaW4gdGhlCiAgICAgICAgICAgICAvLyBhYnNl bmNlIG9mIGFueSBpbmZvcm1hdGlvbiwgaXQncyBiZXR0ZXIgdG8gYXZvaWQgbWFraW5nIHRoaXMg YmUgdGhlIGNhdXNlIG9mIGEKICAgICAgICAgICAgIC8vIHJlY29tcGlsYXRpb24uCi0gICAgICAg ICAgICBpZiAoSlNPYmplY3QqIGNvbW1vblByb3RvdHlwZSA9IHN0YXR1cy5jb21tb25Qcm90b3R5 cGUoKSkgeworICAgICAgICAgICAgSlNPYmplY3QqIGNvbW1vblByb3RvdHlwZSA9IHN0YXR1cy5j b21tb25Qcm90b3R5cGUoKTsKKyAgICAgICAgICAgIGlmIChjb21tb25Qcm90b3R5cGUgJiYgT3B0 aW9uczo6dXNlQWNjZXNzSW5saW5pbmcoKSkgewogICAgICAgICAgICAgICAgIGFkZFRvR3JhcGgo Q2hlY2tJc0NvbnN0YW50LCBPcEluZm8obV9ncmFwaC5mcmVlemUoY29tbW9uUHJvdG90eXBlKSks IHByb3RvdHlwZSk7CiAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgYm9vbCBhbGxP SyA9IHRydWU7CkBAIC04MjQ1LDcgKzgyNDYsNyBAQCB2b2lkIEJ5dGVDb2RlUGFyc2VyOjpwYXJz ZUJsb2NrKHVuc2lnbmVkCiAgICAgICAgICAgICAgICAgbV9pbmxpbmVTdGFja1RvcC0+bV9iYXNl bGluZU1hcCwgbV9pY0NvbnRleHRTdGFjaywKICAgICAgICAgICAgICAgICBjdXJyZW50Q29kZU9y aWdpbigpLCB1aWQpOwogCi0gICAgICAgICAgICBpZiAoc3RhdHVzLmlzU2ltcGxlKCkpIHsKKyAg ICAgICAgICAgIGlmIChzdGF0dXMuaXNTaW1wbGUoKSAmJiBPcHRpb25zOjp1c2VBY2Nlc3NJbmxp bmluZygpKSB7CiAgICAgICAgICAgICAgICAgYm9vbCBhbGxPSyA9IHRydWU7CiAgICAgICAgICAg ICAgICAgTWF0Y2hTdHJ1Y3R1cmVEYXRhKiBkYXRhID0gbV9ncmFwaC5tX21hdGNoU3RydWN0dXJl RGF0YS5hZGQoKTsKICAgICAgICAgICAgICAgICBmb3IgKGNvbnN0IEluQnlJZFZhcmlhbnQmIHZh cmlhbnQgOiBzdGF0dXMudmFyaWFudHMoKSkgewpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdDb25zdGFudEZvbGRpbmdQaGFzZS5jcHAJKHJldmlzaW9uIDI3 NjY0NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQ29uc3RhbnRGb2xkaW5nUGhh c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MTAsNiArNjEwLDkgQEAgcHJpdmF0ZToKICAgICAg ICAgICAgICAgICBtX2ludGVycHJldGVyLmV4ZWN1dGUoaW5kZXhJbkJsb2NrKTsgLy8gUHVzaCBD RkEgb3ZlciB0aGlzIG5vZGUgYWZ0ZXIgd2UgZ2V0IHRoZSBzdGF0ZSBiZWZvcmUuCiAgICAgICAg ICAgICAgICAgYWxyZWFkeUhhbmRsZWQgPSB0cnVlOyAvLyBEb24ndCBhbGxvdyB0aGUgZGVmYXVs dCBjb25zdGFudCBmb2xkZXIgdG8gZG8gdGhpbmdzIHRvIHRoaXMuCiAKKyAgICAgICAgICAgICAg ICBpZiAoIU9wdGlvbnM6OnVzZUFjY2Vzc0lubGluaW5nKCkpCisgICAgICAgICAgICAgICAgICAg IGJyZWFrOworCiAgICAgICAgICAgICAgICAgaWYgKCFiYXNlVmFsdWUubV9zdHJ1Y3R1cmUuaXNG aW5pdGUoKQogICAgICAgICAgICAgICAgICAgICB8fCAobm9kZS0+Y2hpbGQxKCkudXNlS2luZCgp ID09IFVudHlwZWRVc2UgfHwgKGJhc2VWYWx1ZS5tX3R5cGUgJiB+U3BlY0NlbGwpKSkKICAgICAg ICAgICAgICAgICAgICAgYnJlYWs7CkBAIC0xMzg4LDYgKzEzOTEsOSBAQCBwcml2YXRlOgogICAg IAogICAgIHZvaWQgdHJ5Rm9sZEFzUHV0QnlPZmZzZXQoTm9kZSogbm9kZSwgdW5zaWduZWQgaW5k ZXhJbkJsb2NrLCBFZGdlIGJhc2VFZGdlLCBFZGdlIHZhbHVlRWRnZSwgYm9vbCBpc0RpcmVjdCwg UHJpdmF0ZUZpZWxkUHV0S2luZCBwcml2YXRlRmllbGRQdXRLaW5kLCBib29sJiBjaGFuZ2VkLCBi b29sJiBhbHJlYWR5SGFuZGxlZCkKICAgICB7CisgICAgICAgIGlmICghT3B0aW9uczo6dXNlQWNj ZXNzSW5saW5pbmcoKSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBOb2RlT3JpZ2lu IG9yaWdpbiA9IG5vZGUtPm9yaWdpbjsKICAgICAgICAgTm9kZSogYmFzZU5vZGUgPSBiYXNlRWRn ZS5ub2RlKCk7CiAgICAgICAgIFVuaXF1ZWRTdHJpbmdJbXBsKiB1aWQgPSBub2RlLT5jYWNoZWFi bGVJZGVudGlmaWVyKCkudWlkKCk7Cg==