<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225185</bug_id>
          
          <creation_ts>2021-04-29 02:13:55 -0700</creation_ts>
          <short_desc>[Image-Set]: Support Resolution and Type as optional arguments</short_desc>
          <delta_ts>2023-02-27 08:14:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>Safari 14</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=251811</see_also>
          <bug_file_loc>https://wpt.fyi/results/css/css-images/image-set/image-set-computed.sub.html?label=master&amp;label=experimental&amp;product=chrome&amp;product=firefox&amp;product=safari&amp;aligned&amp;view=interop&amp;q=label%3Ainterop-2023-webcompat</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>BrowserCompat, InRadar, WPTImpact</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Williams">oliverwilliams345</reporter>
          <assigned_to name="Ryan Reno">rreno</assigned_to>
          <cc>dev</cc>
    
    <cc>karlcow</cc>
    
    <cc>ntim</cc>
    
    <cc>rreno</cc>
    
    <cc>sabouhallawa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1755320</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Williams">oliverwilliams345</who>
    <bug_when>2021-04-29 02:13:55 -0700</bug_when>
    <thetext>Safari seems to not currently support the type option, which allows new image formats like webp to be used while specifying a fall-back image in a more well supported format like jpeg or png. 

background-image: image-set( &quot;foo.avif&quot; type(&quot;image/avif&quot;), &quot;foo.jpg&quot; type(&quot;image/jpeg&quot;) );

The relevant part of spec is here: https://drafts.csswg.org/css-images-4/#image-set-notation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1757311</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-05-06 02:14:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/77598590&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1928539</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-01-25 23:34:17 -0800</bug_when>
    <thetext>This is failing a couple of tests in 
http://wpt.live/css/css-images/image-set/image-set-computed.sub.html

and has impact on Interop 2023.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1928564</commentid>
    <comment_count>3</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-01-26 03:40:40 -0800</bug_when>
    <thetext>Also:

http://wpt.live/css/css-images/image-set/image-set-type-first-match-rendering.html 
http://wpt.live/css/css-images/image-set/image-set-type-rendering-2.html
http://wpt.live/css/css-images/image-set/image-set-type-rendering-3.html
http://wpt.live/css/css-images/image-set/image-set-type-rendering.html
http://wpt.live/css/css-images/image-set/image-set-type-skip-unsupported-rendering.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1936358</commentid>
    <comment_count>4</comment_count>
    <who name="Ryan Reno">rreno</who>
    <bug_when>2023-02-23 15:20:27 -0800</bug_when>
    <thetext>Resolution is also an optional parameter. As of right now we require resolution like the -webkit-image-set function did.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1936360</commentid>
    <comment_count>5</comment_count>
    <who name="Ryan Reno">rreno</who>
    <bug_when>2023-02-23 15:21:15 -0800</bug_when>
    <thetext>*** Bug 251197 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1936368</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Reno">rreno</who>
    <bug_when>2023-02-23 15:38:32 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/10623</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1936546</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-02-24 09:20:48 -0800</bug_when>
    <thetext>Committed 260796@main (e3554c53fff0): &lt;https://commits.webkit.org/260796@main&gt;

Reviewed commits have been landed. Closing PR #10623 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>