<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225175</bug_id>
          
          <creation_ts>2021-04-28 17:17:43 -0700</creation_ts>
          <short_desc>[GPU Process] REGRESSION(r272888): Don&apos;t assert the validity of the dataURL mimeType inside GPU Process</short_desc>
          <delta_ts>2021-04-29 01:27:21 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=221885</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>dino</cc>
    
    <cc>graouts</cc>
    
    <cc>kkinnunen</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1755246</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 17:17:43 -0700</bug_when>
    <thetext>We disabled image decoding inside GPUProcess in r272888. MIMETypeRegistry::isSupportedImageMIMETypeForEncoding() will return false for any mimeType if it is called inside GPUProcess. So ImageBufferCGBackend::toCFData() should not assert the validity of the mimeType in this case.

Note: If for any reason the mimeType is altered while sending the message RemoteRenderingBackend.GetDataURLForImageBuffer to GPU Process, ImageBufferCGBackend::toCFData() will fail peacefully if the &quot;system&quot; frameworks do not support the mimeType.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755249</commentid>
    <comment_count>1</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 17:18:23 -0700</bug_when>
    <thetext>&lt;rdar://76286963&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755270</commentid>
    <comment_count>2</comment_count>
      <attachid>427317</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 18:02:48 -0700</bug_when>
    <thetext>Created attachment 427317
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755273</commentid>
    <comment_count>3</comment_count>
      <attachid>427319</attachid>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 18:07:33 -0700</bug_when>
    <thetext>Created attachment 427319
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755284</commentid>
    <comment_count>4</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 18:54:50 -0700</bug_when>
    <thetext>If this is too much to fix an assertion, I can remove it altogether.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755288</commentid>
    <comment_count>5</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-28 19:08:51 -0700</bug_when>
    <thetext>This is the call stack we hit when GPUP for 2D canvas is enabled and toDataURL() is called:

ASSERTION FAILED: MIMETypeRegistry::isSupportedImageMIMETypeForEncoding(mimeType)
./platform/graphics/cg/ImageBufferCGBackend.cpp(169) : virtual RetainPtr&lt;CFDataRef&gt; WebCore::ImageBufferCGBackend::toCFData(const WTF::String &amp;, Optional&lt;double&gt;, WebCore::PreserveResolution) const
1   0x131ea1879 WTFCrash
2   0x142d26e0b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x146c83a27 WebCore::ImageBufferCGBackend::toCFData(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution) const
4   0x146c86212 WebCore::ImageBufferIOSurfaceBackend::toCFData(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution) const
5   0x146c8457a WebCore::ImageBufferCGBackend::toDataURL(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution) const
6   0x11b7e8dbe WebCore::ConcreteImageBuffer&lt;WebKit::ImageBufferShareableMappedIOSurfaceBackend&gt;::toDataURL(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution) const
7   0x11b7daf88 WebKit::RemoteRenderingBackend::getDataURLForImageBuffer(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::CompletionHandler&lt;void (WTF::String&amp;&amp;)&gt;&amp;&amp;)
8   0x11b7a276c void IPC::callMemberFunctionImpl&lt;WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::CompletionHandler&lt;void (WTF::String&amp;&amp;)&gt;&amp;&amp;), void (WTF::String const&amp;), std::1::tuple&lt;WTF::String, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, 0ul, 1ul, 2ul, 3ul&gt;(WebKit::RemoteRenderingBackend*, void (WebKit::RemoteRenderingBackend::*)(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::CompletionHandler&lt;void (WTF::String&amp;&amp;)&gt;&amp;&amp;), WTF::CompletionHandler&lt;void (WTF::String const&amp;)&gt;&amp;&amp;, std::1::tuple&lt;WTF::String, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;&amp;&amp;, std::__1::integer_sequence&lt;unsigned long, 0ul, 1ul, 2ul, 3ul&gt;)
9   0x11b79ffb2 void IPC::callMemberFunction&lt;WebKit::RemoteRenderingBackend, void (WebKit::RemoteRenderingBackend::*)(WTF::String const&amp;, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt;, WTF::CompletionHandler&lt;void (WTF::String&amp;&amp;)&gt;&amp;&amp;), void (WTF::String const&amp;), std::1::tuple&lt;WTF::String, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;, std::1::integer_sequence&lt;unsigned long, 0ul, 1ul, 2ul, 3ul&gt; &gt;(std::__1::tuple&lt;WTF::String, WTF::Optional&lt;double&gt;, WebCore::PreserveResolution, WTF::ObjectIdentifier&lt;WebCore::RenderingResourceIdentifierType&gt; &gt;&amp;&amp;, WTF::CompletionHandler&lt;void (WTF::String const&amp;)&gt;&amp;&amp;, WebKi</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755307</commentid>
    <comment_count>6</comment_count>
      <attachid>427319</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2021-04-29 00:31:49 -0700</bug_when>
    <thetext>Comment on attachment 427319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427319&amp;action=review

&gt; Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:178
&gt; +    ASSERT_IMPLIES(!isInGPUProcess(), MIMETypeRegistry::isSupportedImageMIMETypeForEncoding(mimeType));

Wenson suggested that having a `isInGPUProcess()` check in WebCore platform code was probably not a good idea.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755308</commentid>
    <comment_count>7</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2021-04-29 00:32:54 -0700</bug_when>
    <thetext>(In reply to Antoine Quint from comment #6)
&gt; Comment on attachment 427319 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=427319&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp:178
&gt; &gt; +    ASSERT_IMPLIES(!isInGPUProcess(), MIMETypeRegistry::isSupportedImageMIMETypeForEncoding(mimeType));
&gt; 
&gt; Wenson suggested that having a `isInGPUProcess()` check in WebCore platform
&gt; code was probably not a good idea.

Although I suppose this merely checks that this can only be false when in the GPU process.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755310</commentid>
    <comment_count>8</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-29 00:45:54 -0700</bug_when>
    <thetext>Committed r276753 (237149@main): &lt;https://commits.webkit.org/237149@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427319.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755312</commentid>
    <comment_count>9</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2021-04-29 01:27:21 -0700</bug_when>
    <thetext>A follow-up patch: r276758: &lt;https://commits.webkit.org/r276758&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427317</attachid>
            <date>2021-04-28 18:02:48 -0700</date>
            <delta_ts>2021-04-28 18:07:31 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225175-20210428180247.patch</filename>
            <type>text/plain</type>
            <size>5004</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZiYzhjNWZjNjc5ZjA2
Yzc1M2E3Yjc3MmZiODc5YmY2ODk0M2YyOC4uMGJlN2U2OWYyMzZhYmYzYzA1MGYwNDJkYjZkNTU3
OTM5ZmNhNTFiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTI4ICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
RG9uJ3QgYXNzZXJ0IHRoZSB2YWxpZGl0eSBvZiB0aGUgZGF0YVVSTCBtaW1lVHlwZSBpbnNpZGUg
R1BVIFByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTIyNTE3NQorICAgICAgICA8cmRhcjovLzc2Mjg2OTYzPgorCisgICAgICAgIFJldmlld2Vk
IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3Ry
eS5oOgorICAgICAgICBFeHBvcnQgaXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2Rpbmco
KSBzbyBpdCBjYW4gYmUgY2FsbGVkIGluIFdlYktpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dy
YXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0dCYWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oklt
YWdlQnVmZmVyQ0dCYWNrZW5kOjp0b0NGRGF0YSBjb25zdCk6CisgICAgICAgIERvIG5vdCBhc3Nl
cnQgaWYgd2UgYXJlIGluc2lkZSB0aGUgR1BVIFByb2Nlc3MuCisKIDIwMjEtMDQtMjggIE1hcmsg
TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBleGNlcHRpb24gYXNzZXJ0
aW9ucyBpbiBsaWdodCBvZiB0aGUgVGVybWluYXRpb25FeGNlcHRpb24uCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZi
Y2QwYTE1YTg2YjFiNDMxMTgxYWQ2NjQ1YTg3ZDZmMzU4NjJlMzIuLmFhY2I1OGQ0ODllOGNkZDc0
ODM2NzA5ZDNjOGYwZTI5YjA2YTBlM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdl
TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEt
MDQtMjggIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQ
VSBQcm9jZXNzXSBEb24ndCBhc3NlcnQgdGhlIHZhbGlkaXR5IG9mIHRoZSBkYXRhVVJMIG1pbWVU
eXBlIGluc2lkZSBHUFUgUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjI1MTc1CisgICAgICAgIDxyZGFyOi8vNzYyODY5NjM+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQ
VS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5Lmg6CisgICAgICAgIEFzc2VydCB0aGUg
dmFsaWRpdHkgb2YgdGhlIG1pbWVUeXBlIGJlZm9yZSBzZW5kaW5nIGl0IHRvIEdQVSBQcm9jZXNz
LgorCiAyMDIxLTA0LTI4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg
ICAgICAgIFtpT1NdIFtHUFVdIFRoZSBVSSBwcm9jZXNzIHNob3VsZCBpc3N1ZSBtYWNoIHNhbmRi
b3ggZXh0ZW5zaW9ucyB0byAnaWNvbnNlcnZpY2VzJwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
TUlNRVR5cGVSZWdpc3RyeS5oCmluZGV4IDIzMzdiMGYzZjg2ODBlN2M5ZWY0MWJjZDk4NzE1OGZm
MjAyMzUxY2YuLmEzNDkwMmEyYTM2ZTQ5ZDAwYmFiZWQ4ZWY2MmVhZTRlNmYzMmU4OTMgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuaAorKysgYi9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgKQEAgLTcxLDcgKzcxLDcg
QEAgcHVibGljOgogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBib29sIGlzU3VwcG9ydGVkSW1h
Z2VWaWRlb09yU1ZHTUlNRVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7CiAKICAgICAvLyBD
aGVjayB0byBzZWUgaWYgYSBNSU1FIHR5cGUgaXMgc3VpdGFibGUgZm9yIGJlaW5nIGVuY29kZWQu
Ci0gICAgc3RhdGljIGJvb2wgaXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcoY29u
c3QgU3RyaW5nJiBtaW1lVHlwZSk7CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIGJvb2wgaXNT
dXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7
CiAKICAgICAvLyBDaGVjayB0byBzZWUgaWYgYSBNSU1FIHR5cGUgaXMgc3VpdGFibGUgZm9yIGJl
aW5nIGxvYWRlZCBhcyBhIEphdmFTY3JpcHQgb3IgSlNPTiByZXNvdXJjZS4KICAgICBXRUJDT1JF
X0VYUE9SVCBzdGF0aWMgYm9vbCBpc1N1cHBvcnRlZEphdmFTY3JpcHRNSU1FVHlwZShjb25zdCBT
dHJpbmcmIG1pbWVUeXBlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0dCYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0dCYWNrZW5kLmNwcAppbmRleCBjNGEzOTIxZjQ2
ZDQzZDcyOTE0ZWY1N2IzYTY3MjgyNzBjZGMwMDYwLi45YTkxMGZkYjVkNDdlNzU5ODY4NzQ0NGYx
MTkwNTFiNjI0ZjcyZWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy9jZy9JbWFnZUJ1ZmZlckNHQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDR0JhY2tlbmQuY3BwCkBAIC0zNCw2ICszNCw3
IEBACiAjaW5jbHVkZSAiSW1hZ2VEYXRhLmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1
ZGUgIk1JTUVUeXBlUmVnaXN0cnkuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVj
a3MuaCIKIAogI2lmIFVTRShBQ0NFTEVSQVRFKQogI2luY2x1ZGUgPEFjY2VsZXJhdGUvQWNjZWxl
cmF0ZS5oPgpAQCAtMTczLDcgKzE3NCwxMSBAQCB2b2lkIEltYWdlQnVmZmVyQ0dCYWNrZW5kOjpj
bGlwVG9NYXNrKEdyYXBoaWNzQ29udGV4dCYgZGVzdENvbnRleHQsIGNvbnN0IEZsb2F0UgogCiBS
ZXRhaW5QdHI8Q0ZEYXRhUmVmPiBJbWFnZUJ1ZmZlckNHQmFja2VuZDo6dG9DRkRhdGEoY29uc3Qg
U3RyaW5nJiBtaW1lVHlwZSwgT3B0aW9uYWw8ZG91YmxlPiBxdWFsaXR5LCBQcmVzZXJ2ZVJlc29s
dXRpb24gcHJlc2VydmVSZXNvbHV0aW9uKSBjb25zdAogeworI2lmIEVOQUJMRShHUFVfUFJPQ0VT
UykKKyAgICBBU1NFUlRfSU1QTElFUyghaXNJbkdQVVByb2Nlc3MoKSwgTUlNRVR5cGVSZWdpc3Ry
eTo6aXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsKKyNlbHNl
CiAgICAgQVNTRVJUKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZUZv
ckVuY29kaW5nKG1pbWVUeXBlKSk7CisjZW5kaWYKIAogICAgIGF1dG8gdXRpID0gdXRpRnJvbUlt
YWdlQnVmZmVyTUlNRVR5cGUobWltZVR5cGUpOwogICAgIEFTU0VSVCh1dGkpOwpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZl
clByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUlt
YWdlQnVmZmVyUHJveHkuaAppbmRleCA4MzE1ZGRjMWFhNjdlNDNkZjM2YTk3ZDg0NjA0NWUxNDc1
MzJhYjc1Li41NTUyMDUwOGNkZjljYWM4ODBjZjhhMjQxMGJhNWNjMjNmOTIxMjcyIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVm
ZmVyUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1Jl
bW90ZUltYWdlQnVmZmVyUHJveHkuaApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgPFdlYkNv
cmUvRGlzcGxheUxpc3RJdGVtcy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRGlzcGxheUxpc3RSZWNv
cmRlci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRGlzcGxheUxpc3RSZXBsYXllci5oPgorI2luY2x1
ZGUgPFdlYkNvcmUvTUlNRVR5cGVSZWdpc3RyeS5oPgogI2luY2x1ZGUgPHd0Zi9Db25kaXRpb24u
aD4KICNpbmNsdWRlIDx3dGYvTG9jay5oPgogI2luY2x1ZGUgPHd0Zi9TeXN0ZW1UcmFjaW5nLmg+
CkBAIC0xNTEsNiArMTUyLDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBpZiAoVU5MSUtFTFkoIW1f
cmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KSkKICAgICAgICAgICAgIHJldHVybiB7IH07CiAK
KyAgICAgICAgQVNTRVJUKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlw
ZUZvckVuY29kaW5nKG1pbWVUeXBlKSk7CiAgICAgICAgIHJldHVybiBtX3JlbW90ZVJlbmRlcmlu
Z0JhY2tlbmRQcm94eS0+Z2V0RGF0YVVSTEZvckltYWdlQnVmZmVyKG1pbWVUeXBlLCBxdWFsaXR5
LCBwcmVzZXJ2ZVJlc29sdXRpb24sIG1fcmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyKTsKICAg
ICB9CiAKQEAgLTE1OSw2ICsxNjEsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIGlmIChVTkxJS0VM
WSghbV9yZW1vdGVSZW5kZXJpbmdCYWNrZW5kUHJveHkpKQogICAgICAgICAgICAgcmV0dXJuIHsg
fTsKIAorICAgICAgICBBU1NFUlQoTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1J
TUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsKICAgICAgICAgcmV0dXJuIG1fcmVtb3RlUmVu
ZGVyaW5nQmFja2VuZFByb3h5LT5nZXREYXRhRm9ySW1hZ2VCdWZmZXIobWltZVR5cGUsIHF1YWxp
dHksIG1fcmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyKTsKICAgICB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427319</attachid>
            <date>2021-04-28 18:07:33 -0700</date>
            <delta_ts>2021-04-29 00:45:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225175-20210428180732.patch</filename>
            <type>text/plain</type>
            <size>5046</size>
            <attacher name="Said Abou-Hallawa">sabouhallawa</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZiYzhjNWZjNjc5ZjA2
Yzc1M2E3Yjc3MmZiODc5YmY2ODk0M2YyOC4uMmY0M2Y2NGRkNTQ0MDRjMGY1ZGRiZDQwNDlmZmRh
ZDNmOTVjNmIyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTI4ICBTYWlk
IEFib3UtSGFsbGF3YSAgPHNhaWRAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFUgUHJvY2Vzc10g
UkVHUkVTU0lPTihyMjcyODg4KTogRG9uJ3QgYXNzZXJ0IHRoZSB2YWxpZGl0eSBvZiB0aGUgZGF0
YVVSTCBtaW1lVHlwZSBpbnNpZGUgR1BVIFByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTE3NQorICAgICAgICA8cmRhcjovLzc2Mjg2OTYz
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxh
dGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5oOgorICAgICAgICBFeHBvcnQgaXNTdXBwb3J0ZWRJbWFn
ZU1JTUVUeXBlRm9yRW5jb2RpbmcoKSBzbyBpdCBjYW4gYmUgY2FsbGVkIGluIFdlYktpdC4KKwor
ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0dCYWNrZW5kLmNwcDoK
KyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyQ0dCYWNrZW5kOjp0b0NGRGF0YSBjb25zdCk6
CisgICAgICAgIERvIG5vdCBhc3NlcnQgaWYgd2UgYXJlIGluc2lkZSB0aGUgR1BVIFByb2Nlc3Mu
CisKIDIwMjEtMDQtMjggIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg
IEZpeCBleGNlcHRpb24gYXNzZXJ0aW9ucyBpbiBsaWdodCBvZiB0aGUgVGVybWluYXRpb25FeGNl
cHRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCmluZGV4IGZiY2QwYTE1YTg2YjFiNDMxMTgxYWQ2NjQ1YTg3ZDZmMzU4NjJl
MzIuLmE3NjMyNWFiMDNiMmE4N2JkMmQ4YjI1ZmMwYTU5MzQ4MTU2OTgwYWEgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMjEtMDQtMjggIFNhaWQgQWJvdS1IYWxsYXdhICA8c2FpZEBhcHBs
ZS5jb20+CisKKyAgICAgICAgW0dQVSBQcm9jZXNzXSBSRUdSRVNTSU9OKHIyNzI4ODgpOiBEb24n
dCBhc3NlcnQgdGhlIHZhbGlkaXR5IG9mIHRoZSBkYXRhVVJMIG1pbWVUeXBlIGluc2lkZSBHUFUg
UHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MjI1MTc1CisgICAgICAgIDxyZGFyOi8vNzYyODY5NjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1v
dGVJbWFnZUJ1ZmZlclByb3h5Lmg6CisgICAgICAgIEFzc2VydCB0aGUgdmFsaWRpdHkgb2YgdGhl
IG1pbWVUeXBlIGJlZm9yZSBzZW5kaW5nIGl0IHRvIEdQVSBQcm9jZXNzLgorCiAyMDIxLTA0LTI4
ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFtH
UFVdIFRoZSBVSSBwcm9jZXNzIHNob3VsZCBpc3N1ZSBtYWNoIHNhbmRib3ggZXh0ZW5zaW9ucyB0
byAnaWNvbnNlcnZpY2VzJwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlN
RVR5cGVSZWdpc3RyeS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3Ry
eS5oCmluZGV4IDIzMzdiMGYzZjg2ODBlN2M5ZWY0MWJjZDk4NzE1OGZmMjAyMzUxY2YuLmEzNDkw
MmEyYTM2ZTQ5ZDAwYmFiZWQ4ZWY2MmVhZTRlNmYzMmU4OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmgKQEAgLTcxLDcgKzcxLDcgQEAgcHVibGljOgogICAg
IFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBib29sIGlzU3VwcG9ydGVkSW1hZ2VWaWRlb09yU1ZHTUlN
RVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7CiAKICAgICAvLyBDaGVjayB0byBzZWUgaWYg
YSBNSU1FIHR5cGUgaXMgc3VpdGFibGUgZm9yIGJlaW5nIGVuY29kZWQuCi0gICAgc3RhdGljIGJv
b2wgaXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcoY29uc3QgU3RyaW5nJiBtaW1l
VHlwZSk7CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIGJvb2wgaXNTdXBwb3J0ZWRJbWFnZU1J
TUVUeXBlRm9yRW5jb2RpbmcoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSk7CiAKICAgICAvLyBDaGVj
ayB0byBzZWUgaWYgYSBNSU1FIHR5cGUgaXMgc3VpdGFibGUgZm9yIGJlaW5nIGxvYWRlZCBhcyBh
IEphdmFTY3JpcHQgb3IgSlNPTiByZXNvdXJjZS4KICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMg
Ym9vbCBpc1N1cHBvcnRlZEphdmFTY3JpcHRNSU1FVHlwZShjb25zdCBTdHJpbmcmIG1pbWVUeXBl
KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdl
QnVmZmVyQ0dCYWNrZW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nn
L0ltYWdlQnVmZmVyQ0dCYWNrZW5kLmNwcAppbmRleCBjNGEzOTIxZjQ2ZDQzZDcyOTE0ZWY1N2Iz
YTY3MjgyNzBjZGMwMDYwLi45YTkxMGZkYjVkNDdlNzU5ODY4NzQ0NGYxMTkwNTFiNjI0ZjcyZWI5
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1
ZmZlckNHQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
Y2cvSW1hZ2VCdWZmZXJDR0JhY2tlbmQuY3BwCkBAIC0zNCw2ICszNCw3IEBACiAjaW5jbHVkZSAi
SW1hZ2VEYXRhLmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIk1JTUVUeXBlUmVn
aXN0cnkuaCIKKyNpbmNsdWRlICJSdW50aW1lQXBwbGljYXRpb25DaGVja3MuaCIKIAogI2lmIFVT
RShBQ0NFTEVSQVRFKQogI2luY2x1ZGUgPEFjY2VsZXJhdGUvQWNjZWxlcmF0ZS5oPgpAQCAtMTcz
LDcgKzE3NCwxMSBAQCB2b2lkIEltYWdlQnVmZmVyQ0dCYWNrZW5kOjpjbGlwVG9NYXNrKEdyYXBo
aWNzQ29udGV4dCYgZGVzdENvbnRleHQsIGNvbnN0IEZsb2F0UgogCiBSZXRhaW5QdHI8Q0ZEYXRh
UmVmPiBJbWFnZUJ1ZmZlckNHQmFja2VuZDo6dG9DRkRhdGEoY29uc3QgU3RyaW5nJiBtaW1lVHlw
ZSwgT3B0aW9uYWw8ZG91YmxlPiBxdWFsaXR5LCBQcmVzZXJ2ZVJlc29sdXRpb24gcHJlc2VydmVS
ZXNvbHV0aW9uKSBjb25zdAogeworI2lmIEVOQUJMRShHUFVfUFJPQ0VTUykKKyAgICBBU1NFUlRf
SU1QTElFUyghaXNJbkdQVVByb2Nlc3MoKSwgTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJ
bWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsKKyNlbHNlCiAgICAgQVNTRVJUKE1J
TUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZUZvckVuY29kaW5nKG1pbWVU
eXBlKSk7CisjZW5kaWYKIAogICAgIGF1dG8gdXRpID0gdXRpRnJvbUltYWdlQnVmZmVyTUlNRVR5
cGUobWltZVR5cGUpOwogICAgIEFTU0VSVCh1dGkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5LmggYi9Tb3Vy
Y2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHku
aAppbmRleCA4MzE1ZGRjMWFhNjdlNDNkZjM2YTk3ZDg0NjA0NWUxNDc1MzJhYjc1Li41NTUyMDUw
OGNkZjljYWM4ODBjZjhhMjQxMGJhNWNjMjNmOTIxMjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
S2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaAorKysg
Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVy
UHJveHkuaApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvRGlzcGxheUxpc3RJ
dGVtcy5oPgogI2luY2x1ZGUgPFdlYkNvcmUvRGlzcGxheUxpc3RSZWNvcmRlci5oPgogI2luY2x1
ZGUgPFdlYkNvcmUvRGlzcGxheUxpc3RSZXBsYXllci5oPgorI2luY2x1ZGUgPFdlYkNvcmUvTUlN
RVR5cGVSZWdpc3RyeS5oPgogI2luY2x1ZGUgPHd0Zi9Db25kaXRpb24uaD4KICNpbmNsdWRlIDx3
dGYvTG9jay5oPgogI2luY2x1ZGUgPHd0Zi9TeXN0ZW1UcmFjaW5nLmg+CkBAIC0xNTEsNiArMTUy
LDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBpZiAoVU5MSUtFTFkoIW1fcmVtb3RlUmVuZGVyaW5n
QmFja2VuZFByb3h5KSkKICAgICAgICAgICAgIHJldHVybiB7IH07CiAKKyAgICAgICAgQVNTRVJU
KE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZUZvckVuY29kaW5nKG1p
bWVUeXBlKSk7CiAgICAgICAgIHJldHVybiBtX3JlbW90ZVJlbmRlcmluZ0JhY2tlbmRQcm94eS0+
Z2V0RGF0YVVSTEZvckltYWdlQnVmZmVyKG1pbWVUeXBlLCBxdWFsaXR5LCBwcmVzZXJ2ZVJlc29s
dXRpb24sIG1fcmVuZGVyaW5nUmVzb3VyY2VJZGVudGlmaWVyKTsKICAgICB9CiAKQEAgLTE1OSw2
ICsxNjEsNyBAQCBwcm90ZWN0ZWQ6CiAgICAgICAgIGlmIChVTkxJS0VMWSghbV9yZW1vdGVSZW5k
ZXJpbmdCYWNrZW5kUHJveHkpKQogICAgICAgICAgICAgcmV0dXJuIHsgfTsKIAorICAgICAgICBB
U1NFUlQoTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2Rp
bmcobWltZVR5cGUpKTsKICAgICAgICAgcmV0dXJuIG1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFBy
b3h5LT5nZXREYXRhRm9ySW1hZ2VCdWZmZXIobWltZVR5cGUsIHF1YWxpdHksIG1fcmVuZGVyaW5n
UmVzb3VyY2VJZGVudGlmaWVyKTsKICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>