<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225171</bug_id>
          
          <creation_ts>2021-04-28 16:26:26 -0700</creation_ts>
          <short_desc>[Cocoa] Always extend access to local process HTTP/3 cache directory</short_desc>
          <delta_ts>2021-04-30 16:33:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=225239</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Brent Fulgham">bfulgham</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>koivisto</cc>
    
    <cc>mjs</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1755225</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-28 16:26:26 -0700</bug_when>
    <thetext>I&apos;ve seen a number of sandbox violations triggered by the UIProcess not extending access to the cache path used for HTTP/3 negotiations. This seems to happen when the OS overrides the user Safari user setting, or toggles it externally without restarting the process.

Rather than trigger failures, lets just extend the path for all users (even if HTTP/3 is off), since it will eventually be on for everyone, and it doesn&apos;t expand the sandbox anywhere interesting.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755226</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-28 16:28:07 -0700</bug_when>
    <thetext>&lt;rdar://problem/76287224&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755228</commentid>
    <comment_count>2</comment_count>
      <attachid>427306</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-28 16:32:57 -0700</bug_when>
    <thetext>Created attachment 427306
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755548</commentid>
    <comment_count>3</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-04-29 15:13:58 -0700</bug_when>
    <thetext>At the same time we should probably make defaultAlternativeServicesDirectory return the same directory as something else, like defaultNetworkCacheDirectory.  Otherwise, we will have a startup performance regression from additional directory operations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755573</commentid>
    <comment_count>4</comment_count>
      <attachid>427386</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-29 16:18:09 -0700</bug_when>
    <thetext>Created attachment 427386
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755589</commentid>
    <comment_count>5</comment_count>
      <attachid>427386</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-04-29 17:19:50 -0700</bug_when>
    <thetext>Comment on attachment 427386
Patch

I think we should just return defaultNetworkCacheDirectory() instead of this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755663</commentid>
    <comment_count>6</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2021-04-30 06:30:48 -0700</bug_when>
    <thetext>I don&apos;t think we should have anything under NetworkCache directory that is not under control of the NetworkCache code. NetworkCache has habit of wiping out stuff that it doesn&apos;t recognize so it is pretty risky.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755686</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-30 08:15:47 -0700</bug_when>
    <thetext>Committed r276838 (237189@main): &lt;https://commits.webkit.org/237189@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427306.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755720</commentid>
    <comment_count>8</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-30 09:36:37 -0700</bug_when>
    <thetext>Wow -- how did this get landed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755723</commentid>
    <comment_count>9</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2021-04-30 09:41:35 -0700</bug_when>
    <thetext>I r+ cq+ your original patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755729</commentid>
    <comment_count>10</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-30 09:52:24 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #9)
&gt; I r+ cq+ your original patch.

Oh! Good. I was terrified I had somehow clobbered your and Antti&apos;s review stuff. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755752</commentid>
    <comment_count>11</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-04-30 11:27:05 -0700</bug_when>
    <thetext>(In reply to EWS from comment #7)
&gt; Committed r276838 (237189@main): &lt;https://commits.webkit.org/237189@main&gt;
This broke api test on iOS: TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation

History: https://results.webkit.org/?suite=api-tests&amp;test=TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755754</commentid>
    <comment_count>12</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-04-30 11:28:22 -0700</bug_when>
    <thetext>(In reply to Aakash Jain from comment #11)
&gt; (In reply to EWS from comment #7)
&gt; &gt; Committed r276838 (237189@main): &lt;https://commits.webkit.org/237189@main&gt;
&gt; This broke api test on iOS:
&gt; TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation
&gt; 
&gt; History:
&gt; https://results.webkit.org/?suite=api-tests&amp;test=TestWebKitAPI.WebKit.
&gt; AlternativeServicesDefaultDirectoryCreation
I just filed https://bugs.webkit.org/show_bug.cgi?id=225239 about this</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755778</commentid>
    <comment_count>13</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2021-04-30 12:51:47 -0700</bug_when>
    <thetext>Reverted r276838 for reason:

Caused TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation to fail

Committed r276850 (237201@main): &lt;https://commits.webkit.org/237201@main&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755802</commentid>
    <comment_count>14</comment_count>
      <attachid>427446</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-04-30 14:22:16 -0700</bug_when>
    <thetext>Created attachment 427446
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755862</commentid>
    <comment_count>15</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-30 16:33:16 -0700</bug_when>
    <thetext>Committed r276862 (237210@main): &lt;https://commits.webkit.org/237210@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427446.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427306</attachid>
            <date>2021-04-28 16:32:57 -0700</date>
            <delta_ts>2021-04-30 14:22:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225171-20210428163256.patch</filename>
            <type>text/plain</type>
            <size>2666</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjOWQwOWY0ZGVkMThjYTVh
NGRmNWZkMDgxMDcxZDllYTQ5ZjQ4MjEuLmU2NWExMGUyZGViNWUxYTUzNmZmY2I2NmNkZDJiYTBh
NDcwZGJhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDQtMjggIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBbHdheXMgZXh0
ZW5kIGFjY2VzcyB0byBsb2NhbCBwcm9jZXNzIEhUVFAvMyBjYWNoZSBkaXJlY3RvcnkKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTE3MQorICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzYyODcyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQWx3YXlzIHBhc3MgdGhlIGNhY2hlIGRpcmVjdG9yeSBmb3Ig
SFRUUC8zIHVzZSwgcmVnYXJkbGVzcyBvZiB0aGUgY3VycmVudCBzZXR0aW5nIG9mCisgICAgICAg
IHRoZSBmbGFnLiBXZSBzdGlsbCBwYXNzIHRoZSBmbGFnIHNvIHRoYXQgdXNlcnMgY2FuIHR1cm4g
dGhlIGZlYXR1cmUgb24gYW5kIG9mZiwgc28gdGhlcmUKKyAgICAgICAgaXMgbm8gY2hhbmdlIGlu
IGV4cGVjdGVkIGJlaGF2aW9yLiBIb3dldmVyLCBjZXJ0YWluIE9TIHNldHRpbmdzIGNhbiBvdmVy
cmlkZSB0aGUgdXNlcgorICAgICAgICBzZXR0aW5nIGluIHRoZSBicm93c2VyLCBzbyBpdCdzIGhl
bHBmdWwgdG8gaGF2ZSB0aGUgcGF0aCBwZXJtaXNzaW9uIGZvciBjYXNlcyB3aGVyZSBhIHVzZXIK
KyAgICAgICAgdG9nZ2xlcyBzdGF0ZSBvdXRzaWRlIG9mIHRoZSBicm93c2VyLgorCisgICAgICAg
ICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbToK
KyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6cGxhdGZvcm1TZXROZXR3b3JrUGFy
YW1ldGVycyk6CisKIDIwMjEtMDQtMjggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+
CiAKICAgICAgICAgV2hlbiBJUEMgdGVzdGluZyBBUEkgaXMgZW5hYmxlZCwgR1BVIHByb2Nlc3Mg
c2hvdWxkbid0IGtpbGwgV2ViIFByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQ
cm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbSBiL1NvdXJj
ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2Nv
YS5tbQppbmRleCBlNzZmMTA4ZGUyNDU2YTQ1OTRjOTc4NGM1MzdmOTgxZDY3ZGZhZmRmLi5jNDE5
NzVmZWE4YTg2Yzc0ZTY2YzkyMDA1N2Q2MWM3ZjU4ZmYxMmI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
V2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2Eu
bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0
ZURhdGFTdG9yZUNvY29hLm1tCkBAIC0xNTMsMTMgKzE1MywxMCBAQCB2b2lkIFdlYnNpdGVEYXRh
U3RvcmU6OnBsYXRmb3JtU2V0TmV0d29ya1BhcmFtZXRlcnMoV2Vic2l0ZURhdGFTdG9yZVBhcmFt
ZXRlcnMmCiAKICNpZiBIQVZFKENGTkVUV09SS19BTFRFUk5BVElWRV9TRVJWSUNFKQogICAgIGJv
b2wgaHR0cDNFbmFibGVkID0gV2Vic2l0ZURhdGFTdG9yZTo6aHR0cDNFbmFibGVkKCk7Ci0gICAg
U3RyaW5nIGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3Rvcnk7CiAgICAgU2FuZGJveEV4
dGVuc2lvbjo6SGFuZGxlIGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3RvcnlFeHRlbnNp
b25IYW5kbGU7Ci0gICAgaWYgKGh0dHAzRW5hYmxlZCkgewotICAgICAgICBhbHRlcm5hdGl2ZVNl
cnZpY2VTdG9yYWdlRGlyZWN0b3J5ID0gcmVzb2x2ZWRBbHRlcm5hdGl2ZVNlcnZpY2VzU3RvcmFn
ZURpcmVjdG9yeSgpOwotICAgICAgICBpZiAoIWFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJl
Y3RvcnkuaXNFbXB0eSgpKQotICAgICAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFu
ZGxlRm9yUmVhZFdyaXRlRGlyZWN0b3J5KGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3Rv
cnksIGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3RvcnlFeHRlbnNpb25IYW5kbGUpOwot
ICAgIH0KKyAgICBTdHJpbmcgYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeSA9IHJl
c29sdmVkQWx0ZXJuYXRpdmVTZXJ2aWNlc1N0b3JhZ2VEaXJlY3RvcnkoKTsKKyAgICBpZiAoIWFs
dGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3RvcnkuaXNFbXB0eSgpKQorICAgICAgICBTYW5k
Ym94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JSZWFkV3JpdGVEaXJlY3RvcnkoYWx0ZXJuYXRp
dmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeSwgYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVj
dG9yeUV4dGVuc2lvbkhhbmRsZSk7CiAjZW5kaWYKIAogICAgIGJvb2wgc2hvdWxkSW5jbHVkZUxv
Y2FsaG9zdEluUmVzb3VyY2VMb2FkU3RhdGlzdGljcyA9IGlzU2FmYXJpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427386</attachid>
            <date>2021-04-29 16:18:09 -0700</date>
            <delta_ts>2021-04-30 14:22:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225171-20210429161808.patch</filename>
            <type>text/plain</type>
            <size>3244</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjOWQwOWY0ZGVkMThjYTVh
NGRmNWZkMDgxMDcxZDllYTQ5ZjQ4MjEuLmM3OGFlMDdlNDQ2ZDA1MmNiODI5YzE4YjI2Y2IwMWJj
YzU5MjcyN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDQtMjggIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBbHdheXMgZXh0
ZW5kIGFjY2VzcyB0byBsb2NhbCBwcm9jZXNzIEhUVFAvMyBjYWNoZSBkaXJlY3RvcnkKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTE3MQorICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzYyODcyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQWx3YXlzIHBhc3MgdGhlIGNhY2hlIGRpcmVjdG9yeSBmb3Ig
SFRUUC8zIHVzZSwgcmVnYXJkbGVzcyBvZiB0aGUgY3VycmVudCBzZXR0aW5nIG9mCisgICAgICAg
IHRoZSBmbGFnLiBXZSBzdGlsbCBwYXNzIHRoZSBmbGFnIHNvIHRoYXQgdXNlcnMgY2FuIHR1cm4g
dGhlIGZlYXR1cmUgb24gYW5kIG9mZiwgc28gdGhlcmUKKyAgICAgICAgaXMgbm8gY2hhbmdlIGlu
IGV4cGVjdGVkIGJlaGF2aW9yLiBIb3dldmVyLCBjZXJ0YWluIE9TIHNldHRpbmdzIGNhbiBvdmVy
cmlkZSB0aGUgdXNlcgorICAgICAgICBzZXR0aW5nIGluIHRoZSBicm93c2VyLCBzbyBpdCdzIGhl
bHBmdWwgdG8gaGF2ZSB0aGUgcGF0aCBwZXJtaXNzaW9uIGZvciBjYXNlcyB3aGVyZSBhIHVzZXIK
KyAgICAgICAgdG9nZ2xlcyBzdGF0ZSBvdXRzaWRlIG9mIHRoZSBicm93c2VyLgorCisgICAgICAg
ICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbToK
KyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdEFsdGVybmF0aXZlU2Vy
dmljZXNEaXJlY3RvcnkpOiBTZXQgdG8gdXNlIHRoZSBzYW1lCisgICAgICAgIGRpcmVjdG9yeSBh
cyB0aGUgTmV0d29ya0NhY2hlIHRvIGF2b2lkIGxhdW5jaCByZWdyZXNzaW9uLgorICAgICAgICAo
V2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwbGF0Zm9ybVNldE5ldHdvcmtQYXJhbWV0ZXJzKToK
KwogMjAyMS0wNC0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg
ICBXaGVuIElQQyB0ZXN0aW5nIEFQSSBpcyBlbmFibGVkLCBHUFUgcHJvY2VzcyBzaG91bGRuJ3Qg
a2lsbCBXZWIgUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi
c2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tIGIvU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tCmluZGV4
IGU3NmYxMDhkZTI0NTZhNDU5NGM5Nzg0YzUzN2Y5ODFkNjdkZmFmZGYuLmJkNjk3ZWE1NmI3ZTBl
NWE2MzMzMDBmZTJhZmE4OGUzZDJiYWU0NzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ
cm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbQorKysgYi9T
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3Jl
Q29jb2EubW0KQEAgLTE1MywxMyArMTUzLDEwIEBAIHZvaWQgV2Vic2l0ZURhdGFTdG9yZTo6cGxh
dGZvcm1TZXROZXR3b3JrUGFyYW1ldGVycyhXZWJzaXRlRGF0YVN0b3JlUGFyYW1ldGVycyYKIAog
I2lmIEhBVkUoQ0ZORVRXT1JLX0FMVEVSTkFUSVZFX1NFUlZJQ0UpCiAgICAgYm9vbCBodHRwM0Vu
YWJsZWQgPSBXZWJzaXRlRGF0YVN0b3JlOjpodHRwM0VuYWJsZWQoKTsKLSAgICBTdHJpbmcgYWx0
ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeTsKICAgICBTYW5kYm94RXh0ZW5zaW9uOjpI
YW5kbGUgYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeUV4dGVuc2lvbkhhbmRsZTsK
LSAgICBpZiAoaHR0cDNFbmFibGVkKSB7Ci0gICAgICAgIGFsdGVybmF0aXZlU2VydmljZVN0b3Jh
Z2VEaXJlY3RvcnkgPSByZXNvbHZlZEFsdGVybmF0aXZlU2VydmljZXNTdG9yYWdlRGlyZWN0b3J5
KCk7Ci0gICAgICAgIGlmICghYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeS5pc0Vt
cHR5KCkpCi0gICAgICAgICAgICBTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JSZWFk
V3JpdGVEaXJlY3RvcnkoYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeSwgYWx0ZXJu
YXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9yeUV4dGVuc2lvbkhhbmRsZSk7Ci0gICAgfQorICAg
IFN0cmluZyBhbHRlcm5hdGl2ZVNlcnZpY2VTdG9yYWdlRGlyZWN0b3J5ID0gcmVzb2x2ZWRBbHRl
cm5hdGl2ZVNlcnZpY2VzU3RvcmFnZURpcmVjdG9yeSgpOworICAgIGlmICghYWx0ZXJuYXRpdmVT
ZXJ2aWNlU3RvcmFnZURpcmVjdG9yeS5pc0VtcHR5KCkpCisgICAgICAgIFNhbmRib3hFeHRlbnNp
b246OmNyZWF0ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVjdG9yeShhbHRlcm5hdGl2ZVNlcnZpY2VT
dG9yYWdlRGlyZWN0b3J5LCBhbHRlcm5hdGl2ZVNlcnZpY2VTdG9yYWdlRGlyZWN0b3J5RXh0ZW5z
aW9uSGFuZGxlKTsKICNlbmRpZgogCiAgICAgYm9vbCBzaG91bGRJbmNsdWRlTG9jYWxob3N0SW5S
ZXNvdXJjZUxvYWRTdGF0aXN0aWNzID0gaXNTYWZhcmk7CkBAIC0yODIsNyArMjc5LDcgQEAgV1RG
OjpTdHJpbmcgV2Vic2l0ZURhdGFTdG9yZTo6ZGVmYXVsdE5ldHdvcmtDYWNoZURpcmVjdG9yeSgp
CiAKIFdURjo6U3RyaW5nIFdlYnNpdGVEYXRhU3RvcmU6OmRlZmF1bHRBbHRlcm5hdGl2ZVNlcnZp
Y2VzRGlyZWN0b3J5KCkKIHsKLSAgICByZXR1cm4gY2FjaGVEaXJlY3RvcnlGaWxlU3lzdGVtUmVw
cmVzZW50YXRpb24oIkFsdGVybmF0aXZlU2VydmljZXMiLCBTaG91bGRDcmVhdGVEaXJlY3Rvcnk6
Ok5vKTsKKyAgICByZXR1cm4gY2FjaGVEaXJlY3RvcnlGaWxlU3lzdGVtUmVwcmVzZW50YXRpb24o
Ik5ldHdvcmtDYWNoZSIsIFNob3VsZENyZWF0ZURpcmVjdG9yeTo6Tm8pOwogfQogCiBXVEY6OlN0
cmluZyBXZWJzaXRlRGF0YVN0b3JlOjpkZWZhdWx0TWVkaWFDYWNoZURpcmVjdG9yeSgpCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>427446</attachid>
            <date>2021-04-30 14:22:16 -0700</date>
            <delta_ts>2021-04-30 16:33:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225171-20210430142216.patch</filename>
            <type>text/plain</type>
            <size>4807</size>
            <attacher name="Brent Fulgham">bfulgham</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2ODUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4YjNlMTVhMWE0NjIxNTZi
OTJmMWQwNzYzYjY3MjNhMDIzNzg4ODguLjBjN2IxMzNmODc0ZDIzMWU5ZjJlMGEyMmVjYWU0YWNk
NzRkZDc3OTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDQtMzAgIEJyZW50IEZ1
bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBBbHdheXMgZXh0
ZW5kIGFjY2VzcyB0byBsb2NhbCBwcm9jZXNzIEhUVFAvMyBjYWNoZSBkaXJlY3RvcnkKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTE3MQorICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vNzYyODcyMjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBD
aHJpc3RlbnNlbi4KKworICAgICAgICBBbHdheXMgcGFzcyB0aGUgY2FjaGUgZGlyZWN0b3J5IGZv
ciBIVFRQLzMgdXNlLCByZWdhcmRsZXNzIG9mIHRoZSBjdXJyZW50IHNldHRpbmcgb2YKKyAgICAg
ICAgdGhlIGZsYWcuIFdlIHN0aWxsIHBhc3MgdGhlIGZsYWcgc28gdGhhdCB1c2VycyBjYW4gdHVy
biB0aGUgZmVhdHVyZSBvbiBhbmQgb2ZmLCBzbyB0aGVyZQorICAgICAgICBpcyBubyBjaGFuZ2Ug
aW4gZXhwZWN0ZWQgYmVoYXZpb3IuIEhvd2V2ZXIsIGNlcnRhaW4gT1Mgc2V0dGluZ3MgY2FuIG92
ZXJyaWRlIHRoZSB1c2VyCisgICAgICAgIHNldHRpbmcgaW4gdGhlIGJyb3dzZXIsIHNvIGl0J3Mg
aGVscGZ1bCB0byBoYXZlIHRoZSBwYXRoIHBlcm1pc3Npb24gZm9yIGNhc2VzIHdoZXJlIGEgdXNl
cgorICAgICAgICB0b2dnbGVzIHN0YXRlIG91dHNpZGUgb2YgdGhlIGJyb3dzZXIuCisKKyAgICAg
ICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1t
OgorICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpwbGF0Zm9ybVNldE5ldHdvcmtQ
YXJhbWV0ZXJzKToKKwogMjAyMS0wNC0zMCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgcHJlZmVycy1yZWR1Y2VkLW1vdGlvbiBpcyBub3QgcmVhY3RpdmUg
b24gaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9D
b2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X
ZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0KaW5kZXggZTc2ZjEwOGRl
MjQ1NmE0NTk0Yzk3ODRjNTM3Zjk4MWQ2N2RmYWZkZi4uYzQxOTc1ZmVhOGE4NmM3NGU2NmM5MjAw
NTdkNjFjN2Y1OGZmMTJiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi
c2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJL
aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL0NvY29hL1dlYnNpdGVEYXRhU3RvcmVDb2NvYS5tbQpA
QCAtMTUzLDEzICsxNTMsMTAgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpwbGF0Zm9ybVNldE5l
dHdvcmtQYXJhbWV0ZXJzKFdlYnNpdGVEYXRhU3RvcmVQYXJhbWV0ZXJzJgogCiAjaWYgSEFWRShD
Rk5FVFdPUktfQUxURVJOQVRJVkVfU0VSVklDRSkKICAgICBib29sIGh0dHAzRW5hYmxlZCA9IFdl
YnNpdGVEYXRhU3RvcmU6Omh0dHAzRW5hYmxlZCgpOwotICAgIFN0cmluZyBhbHRlcm5hdGl2ZVNl
cnZpY2VTdG9yYWdlRGlyZWN0b3J5OwogICAgIFNhbmRib3hFeHRlbnNpb246OkhhbmRsZSBhbHRl
cm5hdGl2ZVNlcnZpY2VTdG9yYWdlRGlyZWN0b3J5RXh0ZW5zaW9uSGFuZGxlOwotICAgIGlmICho
dHRwM0VuYWJsZWQpIHsKLSAgICAgICAgYWx0ZXJuYXRpdmVTZXJ2aWNlU3RvcmFnZURpcmVjdG9y
eSA9IHJlc29sdmVkQWx0ZXJuYXRpdmVTZXJ2aWNlc1N0b3JhZ2VEaXJlY3RvcnkoKTsKLSAgICAg
ICAgaWYgKCFhbHRlcm5hdGl2ZVNlcnZpY2VTdG9yYWdlRGlyZWN0b3J5LmlzRW1wdHkoKSkKLSAg
ICAgICAgICAgIFNhbmRib3hFeHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvclJlYWRXcml0ZURpcmVj
dG9yeShhbHRlcm5hdGl2ZVNlcnZpY2VTdG9yYWdlRGlyZWN0b3J5LCBhbHRlcm5hdGl2ZVNlcnZp
Y2VTdG9yYWdlRGlyZWN0b3J5RXh0ZW5zaW9uSGFuZGxlKTsKLSAgICB9CisgICAgU3RyaW5nIGFs
dGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3RvcnkgPSByZXNvbHZlZEFsdGVybmF0aXZlU2Vy
dmljZXNTdG9yYWdlRGlyZWN0b3J5KCk7CisgICAgaWYgKCFhbHRlcm5hdGl2ZVNlcnZpY2VTdG9y
YWdlRGlyZWN0b3J5LmlzRW1wdHkoKSkKKyAgICAgICAgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRl
SGFuZGxlRm9yUmVhZFdyaXRlRGlyZWN0b3J5KGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJl
Y3RvcnksIGFsdGVybmF0aXZlU2VydmljZVN0b3JhZ2VEaXJlY3RvcnlFeHRlbnNpb25IYW5kbGUp
OwogI2VuZGlmCiAKICAgICBib29sIHNob3VsZEluY2x1ZGVMb2NhbGhvc3RJblJlc291cmNlTG9h
ZFN0YXRpc3RpY3MgPSBpc1NhZmFyaTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rv
b2xzL0NoYW5nZUxvZwppbmRleCA1NTY5ODg1ODk3ZTZiNGUxMDYxMTgwODVmNTY0YzY3NzU1ODRl
MGE3Li5jM2I0MDg1YTVlYmU4YzE1YTk1NWZiNzVlNzM0MzI4ZDRkZDI0ZDY5IDEwMDY0NAotLS0g
YS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK
KzIwMjEtMDQtMzAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAg
ICAgW0NvY29hXSBBbHdheXMgZXh0ZW5kIGFjY2VzcyB0byBsb2NhbCBwcm9jZXNzIEhUVFAvMyBj
YWNoZSBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIyNTE3MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzYyODcyMjQ+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKworICAgICAgICBTaW5jZSB3ZSBhbHdh
eXMgY3JlYXRlIHRoZSBkaXJlY3RvcnkgKGV2ZW4gaWYgSFRUUC8zIGlzIHR1cm5lZCBvZmYpIHdl
IHNob3VsZCBleHBlY3QgdGhhdCBpdCBpcworICAgICAgICBjcmVhdGVkIGFmdGVyIGxvYWRpbmcg
YSBwYWdlLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJz
aXRlRGF0YVN0b3JlQ3VzdG9tUGF0aHMubW06CisgICAgICAgIChURVNUKToKKwogMjAyMS0wNC0z
MCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y
ZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzY4NDYuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0
QVBJL1Rlc3RzL1dlYktpdENvY29hL1dlYnNpdGVEYXRhU3RvcmVDdXN0b21QYXRocy5tbSBiL1Rv
b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUN1c3Rv
bVBhdGhzLm1tCmluZGV4IDVhMGRkODgzYzhiZTJjYzNiZGFlNTMxMzlhNzM4NTc3YjVkNjNjNzgu
LmZkYzVkNmNhY2U2ODQ3Y2E2NjQxZjQ5MTk0MjY1NGQxOTJlNjkzYzggMTAwNjQ0Ci0tLSBhL1Rv
b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUN1c3Rv
bVBhdGhzLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vi
c2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzLm1tCkBAIC0zOTUsMTMgKzM5NSwxNCBAQCBURVNUKFdl
YktpdCwgQWx0ZXJuYXRpdmVTZXJ2aWNlc0RlZmF1bHREaXJlY3RvcnlDcmVhdGlvbikKIHsKICAg
ICBOU1VSTCAqZGVmYXVsdERpcmVjdG9yeSA9IFtOU1VSTCBmaWxlVVJMV2l0aFBhdGg6W0Aifi9M
aWJyYXJ5L0NhY2hlcy9jb20uYXBwbGUuV2ViS2l0LlRlc3RXZWJLaXRBUEkvV2ViS2l0L0FsdGVy
bmF0aXZlU2VydmljZXMiIHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJblBhdGhdIGlzRGlyZWN0b3J5
OllFU107CiAgICAgW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSByZW1vdmVJdGVtQXRV
Ukw6ZGVmYXVsdERpcmVjdG9yeSBlcnJvcjpuaWxdOwotICAgIAorICAgIEVYUEVDVF9GQUxTRShb
W05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGZpbGVFeGlzdHNBdFBhdGg6ZGVmYXVsdERp
cmVjdG9yeS5wYXRoXSk7CisKICAgICBhdXRvIHdlYlZpZXcxID0gYWRvcHROUyhbW1Rlc3RXS1dl
YlZpZXcgYWxsb2NdIGluaXRdKTsKICAgICBbd2ViVmlldzEgc3luY2hyb25vdXNseUxvYWRIVE1M
U3RyaW5nOkAic3RhcnQgYXV4aWxpYXJ5IHByb2Nlc3NlcyIgYmFzZVVSTDpuaWxdOwogCi0gICAg
RVhQRUNUX0ZBTFNFKFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmlsZUV4aXN0c0F0
UGF0aDpkZWZhdWx0RGlyZWN0b3J5LnBhdGhdKTsKLSAgICAKICNpZiBIQVZFKENGTkVUV09SS19B
TFRFUk5BVElWRV9TRVJWSUNFKQorICAgIC8vIFdlIGFsd2F5cyBjcmVhdGUgdGhlIHBhdGgsIGV2
ZW4gaWYgSFRUUC8zIGlzIHR1cm5lZCBvZmYuCisgICAgRVhQRUNUX1RSVUUoW1tOU0ZpbGVNYW5h
Z2VyIGRlZmF1bHRNYW5hZ2VyXSBmaWxlRXhpc3RzQXRQYXRoOmRlZmF1bHREaXJlY3RvcnkucGF0
aF0pOwogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIE5TU3RyaW5nICprZXkgPSBAIkV4cGVyaW1l
bnRhbEhUVFAzRW5hYmxlZCI7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>