<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225167</bug_id>
          
          <creation_ts>2021-04-28 15:50:10 -0700</creation_ts>
          <short_desc>Sampled Page Top Color: hook into painting logic instead of taking snapshots</short_desc>
          <delta_ts>2021-05-18 16:45:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=225942</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>224987</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Devin Rousso">hi</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bdakin</cc>
    
    <cc>hi</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1755198</commentid>
    <comment_count>0</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2021-04-28 15:50:10 -0700</bug_when>
    <thetext>Review feedback of Bug 224987 suggested that rather than using `snapshotFrameRect` (and `Document::hitTest` to check if that location is 3rd party) to get the color of pixels in the page, which can be expensive, we should hook into painting logic.

Doing so will also (likely) make it easier to support non-sRGB color spaces, as right now `snapshotFrameRect` always uses sRGB.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1755267</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-28 18:00:07 -0700</bug_when>
    <thetext>&lt;rdar://problem/77295389&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760249</commentid>
    <comment_count>2</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2021-05-14 15:21:00 -0700</bug_when>
    <thetext>Compositing makes this ... hard.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>