225158 2021-04-28 11:40:39 -0700 [webkitpy] Refactor SimulatorDevice 2021-05-26 15:08:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ews-watchlist glenn slewis webkit-bug-importer oldest_to_newest 1755093 0 jbedard 2021-04-28 11:40:39 -0700 Clean up some simulator management code. 1755095 1 427284 jbedard 2021-04-28 11:42:43 -0700 Created attachment 427284 Patch 1755187 2 ews-feeder 2021-04-28 15:32:06 -0700 Committed r276735 (237136@main): <https://commits.webkit.org/237136@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427284. 1755189 3 webkit-bug-importer 2021-04-28 15:33:14 -0700 <rdar://problem/77288673> 1764073 4 jbedard 2021-05-26 15:08:10 -0700 Committed r278127 (238177@main): <https://commits.webkit.org/238177@main> 427284 2021-04-28 11:42:43 -0700 2021-04-28 16:43:31 -0700 Patch bug-225158-20210428114242.patch text/plain 3249 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NjcyMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA0LTI4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIFJlZmFjdG9yIFNpbXVsYXRvckRldmljZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MTU4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWREZXZpY2VN YW5hZ2VyLl9nZXRfZGV2aWNlX2lkZW50aWZpZXJfZm9yX3R5cGUpOiBIYW5kbGUgcGFydGlhbGx5 IGRlZmluZWQgZGV2aWNlIHR5cGVzLgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlLmlzX3VzYWJs ZSk6IFBsYWNlIEhvbWUgU2NyZWVuIHNlcnZpY2VzIGludG8gZGljdGlvbmFyeS4KKwogMjAyMS0w NC0yOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2Nv bmZpZ3VyZS14Y29kZS1mb3ItZW1iZWRkZWQtZGV2ZWxvcG1lbnRdIFN1cHBvcnQgWGNvZGUgMTIu NQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2Rl dmljZS5weQkocmV2aXNpb24gMjc2NzIxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS94Y29k ZS9zaW11bGF0ZWRfZGV2aWNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNTAsNyArMjUwLDEwIEBA IGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0KToKIAogICAgIEBzdGF0aWNtZXRo b2QKICAgICBkZWYgX2dldF9kZXZpY2VfaWRlbnRpZmllcl9mb3JfdHlwZShkZXZpY2VfdHlwZSk6 Ci0gICAgICAgIHR5cGVfbmFtZV9mb3JfcmVxdWVzdCA9IHUne30ge30nLmZvcm1hdChkZXZpY2Vf dHlwZS5oYXJkd2FyZV9mYW1pbHkubG93ZXIoKSwgZGV2aWNlX3R5cGUuc3RhbmRhcmRpemVkX2hh cmR3YXJlX3R5cGUubG93ZXIoKSkKKyAgICAgICAgdHlwZV9uYW1lX2Zvcl9yZXF1ZXN0ID0gdSd7 fXt9Jy5mb3JtYXQoCisgICAgICAgICAgICBkZXZpY2VfdHlwZS5oYXJkd2FyZV9mYW1pbHkubG93 ZXIoKSwKKyAgICAgICAgICAgICcge30nLmZvcm1hdChkZXZpY2VfdHlwZS5zdGFuZGFyZGl6ZWRf aGFyZHdhcmVfdHlwZS5sb3dlcigpKSBpZiBkZXZpY2VfdHlwZS5zdGFuZGFyZGl6ZWRfaGFyZHdh cmVfdHlwZSBlbHNlICcnLAorICAgICAgICApCiAgICAgICAgIGZvciB0eXBlX2lkLCB0eXBlX25h bWUgaW4gU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fZGV2aWNlX2lkZW50aWZpZXJfdG9fbmFtZS5p dGVtcygpOgogICAgICAgICAgICAgaWYgdHlwZV9uYW1lLmxvd2VyKCkgPT0gdHlwZV9uYW1lX2Zv cl9yZXF1ZXN0OgogICAgICAgICAgICAgICAgIHJldHVybiB0eXBlX2lkCkBAIC01MjUsNiArNTI4 LDExIEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmplY3QpOgogICAgICAgICAnU0hVVFRJTkcg RE9XTicsCiAgICAgXQogCisgICAgVUlfTUFOQUdFUl9TRVJWSUNFID0geworICAgICAgICAnaU9T JzogJ2NvbS5hcHBsZS5zcHJpbmdib2FyZC5zZXJ2aWNlcycsCisgICAgICAgICd3YXRjaE9TJzog J2NvbS5hcHBsZS5jYXJvdXNlbC5zZXNzaW9uc2VydmljZScsCisgICAgfQorCiAgICAgZGVmIF9f aW5pdF9fKHNlbGYsIG5hbWUsIHVkaWQsIGhvc3QsIGRldmljZV90eXBlLCBidWlsZF92ZXJzaW9u KToKICAgICAgICAgYXNzZXJ0IGRldmljZV90eXBlLnNvZnR3YXJlX3ZlcnNpb24KIApAQCAtNTYy LDE2ICs1NzAsMTMgQEAgY2xhc3MgU2ltdWxhdGVkRGV2aWNlKG9iamVjdCk6CiAgICAgICAgIGlm IHNlbGYuc3RhdGUoZm9yY2VfdXBkYXRlPWZvcmNlX3VwZGF0ZSkgIT0gU2ltdWxhdGVkRGV2aWNl LkRldmljZVN0YXRlLkJPT1RFRDoKICAgICAgICAgICAgIHJldHVybiBGYWxzZQogCi0gICAgICAg IGlmIHNlbGYuZGV2aWNlX3R5cGUuc29mdHdhcmVfdmFyaWFudCA9PSAnaU9TJzoKLSAgICAgICAg ICAgIGhvbWVfc2NyZWVuX3NlcnZpY2UgPSAnY29tLmFwcGxlLnNwcmluZ2JvYXJkLnNlcnZpY2Vz JwotICAgICAgICBlbGlmIHNlbGYuZGV2aWNlX3R5cGUuc29mdHdhcmVfdmFyaWFudCA9PSAnd2F0 Y2hPUyc6Ci0gICAgICAgICAgICBob21lX3NjcmVlbl9zZXJ2aWNlID0gJ2NvbS5hcHBsZS5jYXJv dXNlbC5zZXNzaW9uc2VydmljZScKLSAgICAgICAgZWxzZToKKyAgICAgICAgc2VydmljZSA9IHNl bGYuVUlfTUFOQUdFUl9TRVJWSUNFLmdldChzZWxmLmRldmljZV90eXBlLnNvZnR3YXJlX3Zhcmlh bnQpCisgICAgICAgIGlmIHNlcnZpY2U6CiAgICAgICAgICAgICBfbG9nLmRlYnVnKHUne30gaGFz IG5vIHNlcnZpY2UgdG8gY2hlY2sgaWYgdGhlIGRldmljZSBpcyB1c2FibGUnLmZvcm1hdChzZWxm LmRldmljZV90eXBlLnNvZnR3YXJlX3ZhcmlhbnQpKQogICAgICAgICAgICAgcmV0dXJuIFRydWUK IAogICAgICAgICBzeXN0ZW1fcHJvY2Vzc2VzID0gc2VsZi5leGVjdXRpdmUucnVuX2NvbW1hbmQo W1NpbXVsYXRlZERldmljZU1hbmFnZXIueGNydW4sICdzaW1jdGwnLCAnc3Bhd24nLCBzZWxmLnVk aWQsICdsYXVuY2hjdGwnLCAncHJpbnQnLCAnc3lzdGVtJ10sIGRlY29kZV9vdXRwdXQ9VHJ1ZSwg cmV0dXJuX3N0ZGVycj1GYWxzZSkKLSAgICAgICAgaWYgcmUuc2VhcmNoKHInInt9IicuZm9ybWF0 KGhvbWVfc2NyZWVuX3NlcnZpY2UpLCBzeXN0ZW1fcHJvY2Vzc2VzKSBvciByZS5zZWFyY2gocidB XHMre30nLmZvcm1hdChob21lX3NjcmVlbl9zZXJ2aWNlKSwgc3lzdGVtX3Byb2Nlc3Nlcyk6Cisg ICAgICAgIGlmIHJlLnNlYXJjaChyJyJ7fSInLmZvcm1hdChzZXJ2aWNlKSwgc3lzdGVtX3Byb2Nl c3Nlcykgb3IgcmUuc2VhcmNoKHInQVxzK3t9Jy5mb3JtYXQoc2VydmljZSksIHN5c3RlbV9wcm9j ZXNzZXMpOgogICAgICAgICAgICAgcmV0dXJuIFRydWUKICAgICAgICAgcmV0dXJuIEZhbHNlCiAK