225139 2021-04-27 22:25:48 -0700 [clang] Remove implicit cast related warnings 2021-04-28 11:54:19 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224797 InRadar P2 Normal --- 1 basuke basuke basuke darin webkit-bug-importer oldest_to_newest 1754915 0 basuke 2021-04-27 22:25:48 -0700 Only happens when building debug. 1754916 1 427239 basuke 2021-04-27 22:27:35 -0700 Created attachment 427239 PATCH 1755088 2 427239 darin 2021-04-28 11:25:44 -0700 Comment on attachment 427239 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review > Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 > + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); The cast here is OK, but this code is really strange. 1755089 3 427239 darin 2021-04-28 11:27:01 -0700 Comment on attachment 427239 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=427239&action=review >> Source/WebCore/layout/inlineformatting/InlineLine.cpp:490 >> + ASSERT(logicalWidth() > 0 || (!logicalWidth() && style().letterSpacing() >= static_cast<float>(intMaxForLayoutUnit))); > > The cast here is OK, but this code is really strange. I would like someone to explain this assertion at some point. 1755102 4 ews-feeder 2021-04-28 11:53:20 -0700 Committed r276726 (237127@main): <https://commits.webkit.org/237127@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427239. 1755105 5 webkit-bug-importer 2021-04-28 11:54:19 -0700 <rdar://problem/77277039> 427239 2021-04-27 22:27:35 -0700 2021-04-28 11:53:20 -0700 PATCH patch.diff text/plain 1512 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMjkwZmFhMWVlYjcuLmNjYjU5MmVhNmQ5MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIxLTA0LTI3ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbY2xhbmddIFJlbW92ZSBpbXBsaWNpdCBjYXN0IHJlbGF0ZWQg d2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNTEzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZGVkIGV4cGxpY2l0IGNhc3QgdG8gc3VwcHJlc3Mgd2FybmluZy4KKyAgICAgICAgQmVoYXZp b3IgaXMgbm90IGNoYW5nZWQgZnJvbSBpbXBsaWNpdCBjYXN0LgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyBiZWNhdXNlIHRoZXJlJ3Mgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM YXlvdXQ6OkxpbmU6OlJ1bjo6cmVtb3ZlVHJhaWxpbmdMZXR0ZXJTcGFjaW5nKToKKwogMjAyMS0w NC0yNyAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U11bRkNSXSBBZGQgYm9yZGVycyBmb3IgYmV0dGVyIGNvbnRyb2wgdmlzaWJpbGl0eQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNw cAppbmRleCAyYmEzNzQ3YjYxODcuLjViMzM1YmM0MGVlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAKQEAgLTQ4Nyw3 ICs0ODcsNyBAQCB2b2lkIExpbmU6OlJ1bjo6cmVtb3ZlVHJhaWxpbmdMZXR0ZXJTcGFjaW5nKCkK IHsKICAgICBBU1NFUlQoaGFzVHJhaWxpbmdMZXR0ZXJTcGFjaW5nKCkpOwogICAgIHNocmlua0hv cml6b250YWxseSh0cmFpbGluZ0xldHRlclNwYWNpbmcoKSk7Ci0gICAgQVNTRVJUKGxvZ2ljYWxX aWR0aCgpID4gMCB8fCAoIWxvZ2ljYWxXaWR0aCgpICYmIHN0eWxlKCkubGV0dGVyU3BhY2luZygp ID49IGludE1heEZvckxheW91dFVuaXQpKTsKKyAgICBBU1NFUlQobG9naWNhbFdpZHRoKCkgPiAw IHx8ICghbG9naWNhbFdpZHRoKCkgJiYgc3R5bGUoKS5sZXR0ZXJTcGFjaW5nKCkgPj0gc3RhdGlj X2Nhc3Q8ZmxvYXQ+KGludE1heEZvckxheW91dFVuaXQpKSk7CiB9CiAKIHZvaWQgTGluZTo6UnVu OjpyZW1vdmVUcmFpbGluZ1doaXRlc3BhY2UoKQ0K