22512 2008-11-26 10:57:08 -0800 Add a test to check for crashes in attaching an event to a created document. 2008-12-09 17:35:19 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 levin webkit-unassigned levin pam oldest_to_newest 100414 0 levin 2008-11-26 10:57:08 -0800 Need to add the test. 100415 1 25521 levin 2008-11-26 11:01:10 -0800 Created attachment 25521 A patch to add the test. 100419 2 25521 eric 2008-11-26 11:23:41 -0800 Comment on attachment 25521 A patch to add the test. This is an interesting combination of the old single-file .html style tests, and the new .js tests which use the fast/js/resources .js files and a TEMPLATE.html file. :) Sadly none of this is very well documented, but what I think in an ideal world what you would have wanted to do was to add a fast/events/resources/create-document-crash-on-attach-event.js file with just the <script> section of your test, and then run make-js-test-wrappers to generate the corresponding .html file from the template (which likely already exists as fast/events/resources/TEMPLATE.html). make-js-test-wrappers also automatically makes sure your .js file ends with var successfulllyParsed = true; etc. Also, I think it's a bad idea to check for document.implementation and document.implementation.createDocument and allow the test to "pass" (or at least not do anything) if they're not found. Do you have any information as to when this last crashed? Was this only ever a crash for Chromium? 100428 3 25525 levin 2008-11-26 12:07:24 -0800 Created attachment 25525 Addressed the comments by Eric. The crash only happened in Chromium. 102016 4 25525 eric 2008-12-09 14:49:39 -0800 Comment on attachment 25525 Addressed the comments by Eric. Looks fine. 102050 5 pam 2008-12-09 17:35:19 -0800 Landed in r39159. 25521 2008-11-26 11:01:10 -0800 2008-11-26 12:07:24 -0800 A patch to add the test. patch-for-bug22512.txt text/plain 2509 levin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM4Nzg1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMjYgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUxMgor ICAgICAgICBBZGQgYSB0ZXN0IHRvIGNoZWNrIGZvciBjaGVja3Mgd2hlbiBhdHRhY2hpbmcgYW4g ZXZlbnQgdG8gYSBkb2N1bWVudCBjcmVhdGVkIGJ5CisgICAgICAgICdkb2N1bWVudC5pbXBsZW1l bnRhdGlvbi5jcmVhdGVEb2N1bWVudCcuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9jcmVhdGUt ZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9ldmVudHMvY3JlYXRlLWRvY3VtZW50LWNyYXNoLW9uLWF0dGFjaC1ldmVudC5o dG1sOiBBZGRlZC4KKwogMjAwOC0xMS0yNiAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9A d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNo LWV2ZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50LWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NyZWF0ZS1kb2N1bWVudC1jcmFz aC1vbi1hdHRhY2gtZXZlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEw IEBACitUaGlzIHRlc3QgY2hlY2tzIHRoYXQgc2V0dGluZyBhbiBldmVudCBoYW5kbGVyIG9uIGEg ZG9jdW1lbnQgZWxlbWVudCBjcmVhdGVkIGJ5IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0 ZURvY3VtZW50IGRvZXMgbm90IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisK KworUEFTUyBBdHRhY2hlZCBvbmxvYWQgZXZlbnQgaGFuZGxlciB0byBjcmVhdGVkIGRvY3VtZW50 LgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5k ZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NyZWF0ZS1kb2N1bWVudC1jcmFzaC1vbi1hdHRh Y2gtZXZlbnQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jcmVh dGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50Lmh0bWwJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2 ZW50Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjMgQEAKKzxodG1sPgorPGhlYWQ+Cis8 bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxl LmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Nj cmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlvbignVGhpcyB0ZXN0IGNoZWNr cyB0aGF0IHNldHRpbmcgYW4gZXZlbnQgaGFuZGxlciBvbiBhIGRvY3VtZW50IGVsZW1lbnQgY3Jl YXRlZCBieSAnCisgICAgICAgICAgICArICdkb2N1bWVudC5pbXBsZW1lbnRhdGlvbi5jcmVhdGVE b2N1bWVudCBkb2VzIG5vdCBjcmFzaC4nKTsKKworaWYgKGRvY3VtZW50LmltcGxlbWVudGF0aW9u ICYmIGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KSB7CisgICAgdmFyIGRv YyA9IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KCcnLCAnJywgbnVsbCk7 CisgICAgZG9jLm9ubG9hZCA9IGZ1bmN0aW9uKCkgeyB9OworICAgIHRlc3RQYXNzZWQoJ0F0dGFj aGVkIG9ubG9hZCBldmVudCBoYW5kbGVyIHRvIGNyZWF0ZWQgZG9jdW1lbnQuJyk7Cit9CisKK3Zh ciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg== 25525 2008-11-26 12:07:24 -0800 2008-12-09 14:49:39 -0800 Addressed the comments by Eric. patch-for-bug22512-rev2.txt text/plain 2970 levin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM4Nzg3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMTEtMjYgIERhdmlkIExldmluICA8bGV2 aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUxMgor CisgICAgICAgIEFkZCBhIHRlc3QgdG8gY2hlY2sgZm9yIGNoZWNrcyB3aGVuIGF0dGFjaGluZyBh biBldmVudCB0byBhIGRvY3VtZW50IGNyZWF0ZWQgYnkKKyAgICAgICAgJ2RvY3VtZW50LmltcGxl bWVudGF0aW9uLmNyZWF0ZURvY3VtZW50Jy4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2NyZWF0 ZS1kb2N1bWVudC1jcmFzaC1vbi1hdHRhY2gtZXZlbnQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2V2ZW50cy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50 Lmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL3Jlc291cmNlcy9jcmVhdGUtZG9j dW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50LmpzOiBBZGRlZC4KKyAgICAgICAgKGRvYy5vbmxv YWQpOgorCiAyMDA4LTExLTI2ICBKYW4gTWljaGFlbCBBbG9uem8gIDxqbWFsb256b0B3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEhvbGdlciBGcmV5dGhlci4KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2NyZWF0ZS1kb2N1bWVudC1jcmFzaC1vbi1hdHRhY2gtZXZlbnQt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NyZWF0 ZS1kb2N1bWVudC1jcmFzaC1vbi1hdHRhY2gtZXZlbnQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY3JlYXRlLWRvY3VtZW50LWNyYXNoLW9uLWF0 dGFjaC1ldmVudC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKK1Ro aXMgdGVzdCBjaGVja3MgZm9yIGNyYXNoZXMgaW4gc2V0dGluZyBhbiBldmVudCBoYW5kbGVyIG9u IGEgZG9jdW1lbnQgZWxlbWVudCBjcmVhdGVkIGJ5IGRvY3VtZW50LmltcGxlbWVudGF0aW9uLmNy ZWF0ZURvY3VtZW50LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBBdHRh Y2hlZCBvbmxvYWQgZXZlbnQgaGFuZGxlciB0byBjcmVhdGVkIGRvY3VtZW50LgorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2NyZWF0ZS1kb2N1bWVudC1jcmFzaC1vbi1hdHRhY2gtZXZlbnQuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jcmVhdGUtZG9jdW1lbnQt Y3Jhc2gtb24tYXR0YWNoLWV2ZW50Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0YWNoLWV2ZW50Lmh0bWwJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVU Ri8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQi IGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0i Li4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5 PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxz Y3JpcHQgc3JjPSJyZXNvdXJjZXMvY3JlYXRlLWRvY3VtZW50LWNyYXNoLW9uLWF0dGFjaC1ldmVu dC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy9yZXNvdXJjZXMvY3JlYXRlLWRvY3VtZW50LWNyYXNoLW9uLWF0dGFjaC1ldmVudC5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9yZXNvdXJjZXMvY3JlYXRl LWRvY3VtZW50LWNyYXNoLW9uLWF0dGFjaC1ldmVudC5qcwkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL3Jlc291cmNlcy9jcmVhdGUtZG9jdW1lbnQtY3Jhc2gtb24tYXR0 YWNoLWV2ZW50LmpzCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDggQEAKK2Rlc2NyaXB0aW9uKCdU aGlzIHRlc3QgY2hlY2tzIGZvciBjcmFzaGVzIGluIHNldHRpbmcgYW4gZXZlbnQgaGFuZGxlciBv biBhIGRvY3VtZW50IGVsZW1lbnQgY3JlYXRlZCBieSAnCisgICAgICAgICAgICArICdkb2N1bWVu dC5pbXBsZW1lbnRhdGlvbi5jcmVhdGVEb2N1bWVudC4nKTsKKwordmFyIGRvYyA9IGRvY3VtZW50 LmltcGxlbWVudGF0aW9uLmNyZWF0ZURvY3VtZW50KCcnLCAnJywgbnVsbCk7Citkb2Mub25sb2Fk ID0gZnVuY3Rpb24oKSB7IH07Cit0ZXN0UGFzc2VkKCdBdHRhY2hlZCBvbmxvYWQgZXZlbnQgaGFu ZGxlciB0byBjcmVhdGVkIGRvY3VtZW50LicpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0g dHJ1ZTsK