225115 2021-04-27 11:23:19 -0700 Optimise Port._expected_baselines_for_suffixes 2021-04-27 15:07:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224989 InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1754712 0 gsnedders 2021-04-27 11:23:19 -0700 This function is hot in the Port.reference_files case on platforms like Big Sur with WebKit2, as we're calling it with a long baseline search path and with many suffixes. A lot of the cost is in the repeated calls of os.path.join which notably only differ by the suffix. 1754714 1 427176 gsnedders 2021-04-27 11:26:24 -0700 Created attachment 427176 Patch 1754800 2 ews-feeder 2021-04-27 15:06:41 -0700 Committed r276669 (237088@main): <https://commits.webkit.org/237088@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427176. 1754801 3 webkit-bug-importer 2021-04-27 15:07:24 -0700 <rdar://problem/77232724> 427176 2021-04-27 11:26:24 -0700 2021-04-27 15:06:42 -0700 Patch bug-225115-20210427192623.patch text/plain 2558 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NjMxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjc1MGIyZmNkOGM1OTY5ZjlkYzJiMzljZDkzNTFhMmE5 MjQ0MWEzMC4uZDg0ZGFjY2M1OTBkMjlmYTY2ODlhZTdiYTI5ZWYzZDE2NGY3ODZlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDIxLTA0LTI3ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgT3B0aW1pemUgUG9ydC5fZXhwZWN0ZWRfYmFzZWxpbmVzX2Zvcl9zdWZmaXhlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MTE1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0YWtlcyBv dXQgdGhlIGpvaW4oKSBhbmQgc3BsaXRleHQoKSBjYWxscyBmcm9tIHRoZSBpbm5lciBsb29wIGFz CisgICAgICAgIHRoZXkgYXJlIGxvb3AgaW52YXJpYW50LCBhbmQgYWNjb3VudCBmb3IgYSBsYXJn ZSBwcm9wb3J0aW9uIG9mIHRoZQorICAgICAgICBmdW5jdGlvbidzIGV4ZWN1dGlvbiB0aW1lLiBB ZnRlciB0aGlzLCBleGlzdHMoKSBhY2NvdW50IGZvciBhbG1vc3QKKyAgICAgICAgYWxsLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHk6CisgICAgICAgIChQb3J0Ll9l eHBlY3RlZF9iYXNlbGluZXNfZm9yX3N1ZmZpeGVzKToKKwogMjAyMS0wNC0yNiAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBTdWJkaXZpZGUgaW1hZ2Ug b3ZlcmxheSB0ZXh0IGludG8gb25lIG9yIG1vcmUgZWxlbWVudHMgcGVyIGxpbmUKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXggZDNiYzE5MmMxNTQwZTdhNDEzMGZiZTU3YWRkNDM2 ZGYxNTYwMDcwOC4uMjdkNzU3Y2E2ZTE0NzBhZGQ3NTAxOWU3YmQ1Y2IxMzFmZjkyMTM4MyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKQEAgLTM4NCwxMiArMzg0LDE1IEBAIGNsYXNz IFBvcnQob2JqZWN0KToKIAogICAgIGRlZiBfZXhwZWN0ZWRfYmFzZWxpbmVzX2Zvcl9zdWZmaXhl cyhzZWxmLCB0ZXN0X25hbWUsIHN1ZmZpeGVzLCBhbGxfYmFzZWxpbmVzPUZhbHNlLCBkZXZpY2Vf dHlwZT1Ob25lKToKICAgICAgICAgYmFzZWxpbmVfc2VhcmNoX3BhdGggPSBzZWxmLmJhc2VsaW5l X3NlYXJjaF9wYXRoKGRldmljZV90eXBlPWRldmljZV90eXBlKSArIFtzZWxmLmxheW91dF90ZXN0 c19kaXIoKV0KKyAgICAgICAgZnMgPSBzZWxmLl9maWxlc3lzdGVtCisgICAgICAgIGJhc2VsaW5l X25hbWVfcm9vdCA9IGZzLnNwbGl0ZXh0KHRlc3RfbmFtZSlbMF0gKyAnLWV4cGVjdGVkJwogCiAg ICAgICAgIGJhc2VsaW5lcyA9IFtdCiAgICAgICAgIGZvciBwbGF0Zm9ybV9kaXIgaW4gYmFzZWxp bmVfc2VhcmNoX3BhdGg6CisgICAgICAgICAgICB1bnN1ZmZpeGVkID0gZnMuam9pbihwbGF0Zm9y bV9kaXIsIGJhc2VsaW5lX25hbWVfcm9vdCkKICAgICAgICAgICAgIGZvciBzdWZmaXggaW4gc3Vm Zml4ZXM6Ci0gICAgICAgICAgICAgICAgYmFzZWxpbmVfZmlsZW5hbWUgPSBzZWxmLl9maWxlc3lz dGVtLnNwbGl0ZXh0KHRlc3RfbmFtZSlbMF0gKyAnLWV4cGVjdGVkJyArIHN1ZmZpeAotICAgICAg ICAgICAgICAgIGlmIHNlbGYuX2ZpbGVzeXN0ZW0uZXhpc3RzKHNlbGYuX2ZpbGVzeXN0ZW0uam9p bihwbGF0Zm9ybV9kaXIsIGJhc2VsaW5lX2ZpbGVuYW1lKSk6CisgICAgICAgICAgICAgICAgaWYg ZnMuZXhpc3RzKHVuc3VmZml4ZWQgKyBzdWZmaXgpOgorICAgICAgICAgICAgICAgICAgICBiYXNl bGluZV9maWxlbmFtZSA9IGJhc2VsaW5lX25hbWVfcm9vdCArIHN1ZmZpeAogICAgICAgICAgICAg ICAgICAgICBiYXNlbGluZXMuYXBwZW5kKChwbGF0Zm9ybV9kaXIsIGJhc2VsaW5lX2ZpbGVuYW1l KSkKIAogICAgICAgICAgICAgaWYgbm90IGFsbF9iYXNlbGluZXMgYW5kIGJhc2VsaW5lczoKQEAg LTM5OSw3ICs0MDIsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgICAgICByZXR1cm4g YmFzZWxpbmVzCiAKICAgICAgICAgZm9yIHN1ZmZpeCBpbiBzdWZmaXhlczoKLSAgICAgICAgICAg IGJhc2VsaW5lcy5hcHBlbmQoKE5vbmUsIHNlbGYuX2ZpbGVzeXN0ZW0uc3BsaXRleHQodGVzdF9u YW1lKVswXSArICctZXhwZWN0ZWQnICsgc3VmZml4KSkKKyAgICAgICAgICAgIGJhc2VsaW5lcy5h cHBlbmQoKE5vbmUsIGJhc2VsaW5lX25hbWVfcm9vdCArIHN1ZmZpeCkpCiAgICAgICAgIHJldHVy biBiYXNlbGluZXMKIAogICAgIGRlZiBleHBlY3RlZF9iYXNlbGluZXMoc2VsZiwgdGVzdF9uYW1l LCBzdWZmaXgsIGFsbF9iYXNlbGluZXM9RmFsc2UsIGRldmljZV90eXBlPU5vbmUpOgo=