225097 2021-04-27 04:15:00 -0700 [css-flexbox] Fix expectations of a WPT test that works fine 2021-04-27 21:51:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar svillar clopez darin ews-watchlist pnormand rbuis rego svillar webkit-bug-importer youennf zalan oldest_to_newest 1754548 0 svillar 2021-04-27 04:15:00 -0700 [css-flexbox] Fix expectations of a WPT test that works fine 1754549 1 427135 svillar 2021-04-27 04:17:08 -0700 Created attachment 427135 Patch 1754550 2 ews-watchlist 2021-04-27 04:18:29 -0700 This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess 1754552 3 427135 rego 2021-04-27 04:27:20 -0700 Comment on attachment 427135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427135&action=review r=me, please wait for having green EWSs before landing. > LayoutTests/imported/w3c/ChangeLog:9 > + Fixed the paths of some images that were not properly converted during import. Is there a bug reported for the import script so this doesn't happen in the future? It looks like next time we use the script to re-import things, this change might be overwritten. Can we change the test in a way that we workaround the import script? Maybe using full paths from "/" or something like that. And export that change into WPT. Mostly to avoid having the same issue next time we re-sync the tests. 1754553 4 svillar 2021-04-27 04:33:50 -0700 (In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 427135 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427135&action=review > > r=me, please wait for having green EWSs before landing. > > > LayoutTests/imported/w3c/ChangeLog:9 > > + Fixed the paths of some images that were not properly converted during import. > > Is there a bug reported for the import script so this doesn't happen in the > future? > > It looks like next time we use the script to re-import things, this change > might be overwritten. > Can we change the test in a way that we workaround the import script? Maybe > using full paths from "/" or something like that. And export that change > into WPT. > Mostly to avoid having the same issue next time we re-sync the tests. Good point. There is however a ../support but also a support/. So the test might have been moved upstream in between directories. I'll keep an eye in the next import and report any issue related to that I might encounter. 1754908 5 ews-feeder 2021-04-27 21:50:46 -0700 Committed r276690 (237104@main): <https://commits.webkit.org/237104@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427135. 1754909 6 webkit-bug-importer 2021-04-27 21:51:16 -0700 <rdar://problem/77248259> 427135 2021-04-27 04:17:08 -0700 2021-04-27 21:50:48 -0700 Patch bug-225097-20210427131707.patch text/plain 3694 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NjM0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjcwNmY2MDY4OTFmNjk4YjczNDRk NjU0NGE5NWM4ZTY4MzNjOGMzOS4uYjhlY2EzNWNiNzdiZjJkZjA5MTFjYzYzZDE4YjRkODk3NjJl YWFmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA0LTI3ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxleGJveF0gRml4IGV4 cGVjdGF0aW9ucyBvZiBhIFdQVCB0ZXN0IHRoYXQgd29ya3MgZmluZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MDk3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0RXhwZWN0YXRpb25zOiBVbnNr aXBwZWQgYSB0ZXN0IHRoYXQgd29ya3MgZmluZSBub3cuCisKIDIwMjEtMDQtMjEgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1mbGV4Ym94 XSBwZXJjZW50IGNoaWxkcmVuIGRvbid0IHJlc29sdmUgYWdhaW5zdCB0aGUgZmxleCBiYXNpcyBv biBhIGZ1bGx5IGluZmxleGlibGUgaXRlbSB3aXRoIGZpeGVkIGZsZXgtYmFzaXMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBv cnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDBkZWQ0M2Q3MDdiNDIyMzVjZTg0OWIzMjZhMzdkM2I5 ZjgwZjQ5YTYuLmVmMWE3MTc2ZTkyMDc0MzY1ZmI5MzM5ZmRiNTFhZjBkZDFmM2NjN2IgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA0LTI3ICBT ZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3Mt ZmxleGJveF0gRml4IGV4cGVjdGF0aW9ucyBvZiBhIFdQVCB0ZXN0IHRoYXQgd29ya3MgZmluZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI1MDk3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2Nzcy1mbGV4Ym94LWltZy1leHBhbmQtZXZlbmx5 LWV4cGVjdGVkLmh0bWw6CisgICAgICAgIEZpeGVkIHRoZSBwYXRocyBvZiBzb21lIGltYWdlcyB0 aGF0IHdlcmUgbm90IHByb3Blcmx5IGNvbnZlcnRlZCBkdXJpbmcgaW1wb3J0LgorCiAyMDIxLTA0 LTI2ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3JlYXRlIGEgY29u dGFpbmluZyBibG9jayB3aGVuIHJlbGV2YW50IHByb3BlcnRpZXMgYXJlIHNldCBpbiB0aGUgY3Vy cmVudCBlbGVtZW50IHdpbGwtY2hhbmdlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA2YTQyMTYyOTM5 ZjIwOTRjNjI1YWI5YzMyN2MzMDg4OTQ1MWE0ZjJmLi5hY2JhZTYwNTMwMGUxNjRiMDc3MWE1NDA5 NDFjY2Q3YzRmZjY0MzdiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25z CisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTExOTYsNyArMTE5Niw2IEBA IHdlYmtpdC5vcmcvYi8xMzY3NTQgY3NzMy9mbGV4Ym94L2Nzc3dnL3R0d2YtcmVmdGVzdC1mbGV4 LW9yZGVyLmh0bWwgWyBJbWFnZU9ubHlGCiB3ZWJraXQub3JnL2IvMTM2NzU0IGNzczMvZmxleGJv eC9jc3N3Zy90dHdmLXJlZnRlc3QtZmxleC13cmFwLXJldmVyc2UuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzEzNjc1NCBjc3MzL2ZsZXhib3gvY3Nzd2cvdHR3Zi1yZWZ0 ZXN0LWZsZXgtd3JhcC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM2 NzU0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2NhbnZh cy1keW5hbWljLWNoYW5nZS0wMDEuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzEzNjc1 NCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9jc3MtZmxl eGJveC1pbWctZXhwYW5kLWV2ZW5seS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMTM2NzU0IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4 Ym94L2ZsZXgtYXNwZWN0LXJhdGlvLWltZy1yb3ctMDE1Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xMzY3NTQgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9j c3MvY3NzLWZsZXhib3gvZmxleGJveC1zYWZlLW92ZXJmbG93LXBvc2l0aW9uLTAwMS5odG1sIFsg SW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM2NzU0IGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3BlcmNlbnRhZ2UtbWF4LWhlaWdodC0wMDIu aHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvY3NzLWZsZXhib3gtaW1n LWV4cGFuZC1ldmVubHktZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2Nzcy1mbGV4Ym94LWltZy1leHBhbmQt ZXZlbmx5LWV4cGVjdGVkLmh0bWwKaW5kZXggMTQ2MjQyMDc0YjIyM2I1MzkzNmVjZWNkODJkMGE0 MGM0ZDRjYzk1Yy4uM2VjOWQ4NmQ3NTBlZWNiMTI4NmFhZWY4YzU2M2I3ODcwZjg5NWMyMCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mv Y3NzLWZsZXhib3gvY3NzLWZsZXhib3gtaW1nLWV4cGFuZC1ldmVubHktZXhwZWN0ZWQuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt ZmxleGJveC9jc3MtZmxleGJveC1pbWctZXhwYW5kLWV2ZW5seS1leHBlY3RlZC5odG1sCkBAIC0y OCw3ICsyOCw3IEBACiAgICAgICAgIDwhLS0gSXQgaXMgaW1wb3J0YW50IHRoYXQgdGhlcmUgaXMg bm8gbGluZWJyZWFrIGJldHdlZW4gdGhlIDxpbWc+IHRhZ3MuCiAgICAgICAgICAgICAgVGhlIGxp bmUgYnJlYWsgd291bGQgYmUgcmVuZGVyZWQgYXMgd2hpdGVzcGFjZSwgYnJlYWtpbmcgdGhlIHRl c3QuCiAgICAgICAgICAgLS0+Ci0gICAgICAgIDxpbWcgc3JjPSIuLi9zdXBwb3J0L3NvbGlkYmx1 ZS5wbmciIC8+PGltZyBzcmM9Ii4uL3N1cHBvcnQvc29saWRibHVlLnBuZyIgLz48aW1nIHNyYz0i Li4vc3VwcG9ydC9zb2xpZGJsdWUucG5nIiAvPgorICAgICAgICA8aW1nIHNyYz0ic3VwcG9ydC9z b2xpZGJsdWUucG5nIiAvPjxpbWcgc3JjPSJzdXBwb3J0L3NvbGlkYmx1ZS5wbmciIC8+PGltZyBz cmM9InN1cHBvcnQvc29saWRibHVlLnBuZyIgLz4KICAgICA8L2Rpdj4KIAogCg==