225096 2021-04-27 03:04:24 -0700 SWContextManager::postMessageToServiceWorker should check for valid service worker 2021-04-27 11:39:12 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez webkit-bug-importer oldest_to_newest 1754536 0 youennf 2021-04-27 03:04:24 -0700 SWContextManager::postMessageToServiceWorker should check for valid service worker 1754538 1 youennf 2021-04-27 03:04:34 -0700 <rdar://76718162> 1754539 2 427131 youennf 2021-04-27 03:07:28 -0700 Created attachment 427131 Patch 1754604 3 427131 cdumez 2021-04-27 07:39:26 -0700 Comment on attachment 427131 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427131&action=review > Source/WebCore/workers/service/context/SWContextManager.cpp:87 > + if (!serviceWorker) Should we also return early in the isTerminatingOrTerminated() case? 1754611 4 youennf 2021-04-27 08:00:45 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 427131 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427131&action=review > > > Source/WebCore/workers/service/context/SWContextManager.cpp:87 > > + if (!serviceWorker) > > Should we also return early in the isTerminatingOrTerminated() case? We probably could since enqueuing the task will be useless work in that case. I went this way to align this message event to other events like install or activate. 1754612 5 427131 cdumez 2021-04-27 08:01:33 -0700 Comment on attachment 427131 Patch Ok. If this is consistent with others, let's go this way. 1754719 6 ews-feeder 2021-04-27 11:39:10 -0700 Committed r276649 (237076@main): <https://commits.webkit.org/237076@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427131. 427131 2021-04-27 03:07:28 -0700 2021-04-27 11:39:11 -0700 Patch bug-225096-20210427120726.patch text/plain 1957 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkyZDc4YWY4NGIzODg3 ZGY2YzY1YzQzYjBjZGM3OWRkMTMxNzk2NS4uN2IxNGU1NTIyYzkxMWU0NDA2Y2M0MDEwMWMyMDll ZTNmZmZlOTk5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTI3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBTV0NvbnRleHRNYW5hZ2Vy Ojpwb3N0TWVzc2FnZVRvU2VydmljZVdvcmtlciBzaG91bGQgY2hlY2sgZm9yIHZhbGlkIHNlcnZp Y2Ugd29ya2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjUwOTYKKyAgICAgICAgPHJkYXI6Ly83NjcxODE2Mj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBz ZXJ2aWNlV29ya2VyIGlzIG5vdCBudWxsLgorICAgICAgICBGb3IgaW5zdGFuY2UgVUlQcm9jZXNz IG1heSBhc2sgV2ViUHJvY2VzcyB0byB0ZXJtaW5hdGUgYWxsIHNlcnZpY2Ugd29ya2VycyBpbiBw YXJhbGxlbCB0byBuZXR3b3JrIHByb2Nlc3Mgc2VuZGluZyBhIG1lc3NhZ2UgdG8gaXQuCisKKyAg ICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNXQ29udGV4dE1hbmFnZXI6OnBvc3RNZXNzYWdlVG9TZXJ2aWNlV29y a2VyKToKKwogMjAyMS0wNC0yNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgQWRkIG1lbW9yeSBhbGxvY2F0aW9uIGNoZWNrcyBpbiBtb3JlIHJlYWx0aW1lIGF1 ZGlvIGNhcHR1cmUvcmVuZGVyaW5nIHBsYWNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcAppbmRleCAy OGQwYWJjNDA1MzhkZWY4NzA5NDYwOGNlY2ZmNDIwNGI2Y2UyYWI0Li4xOGM4MjljNDhlNzhjMzkz ZDNmMWY1ZDhmOTA0ZDE4MTM1YTI1YjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2UvY29udGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcApAQCAtODQs OCArODQsOCBAQCBTZXJ2aWNlV29ya2VyVGhyZWFkUHJveHkqIFNXQ29udGV4dE1hbmFnZXI6OnNl cnZpY2VXb3JrZXJUaHJlYWRQcm94eShTZXJ2aWNlV29yawogdm9pZCBTV0NvbnRleHRNYW5hZ2Vy Ojpwb3N0TWVzc2FnZVRvU2VydmljZVdvcmtlcihTZXJ2aWNlV29ya2VySWRlbnRpZmllciBkZXN0 aW5hdGlvbiwgTWVzc2FnZVdpdGhNZXNzYWdlUG9ydHMmJiBtZXNzYWdlLCBTZXJ2aWNlV29ya2Vy T3JDbGllbnREYXRhJiYgc291cmNlRGF0YSkKIHsKICAgICBhdXRvKiBzZXJ2aWNlV29ya2VyID0g bV93b3JrZXJNYXAuZ2V0KGRlc3RpbmF0aW9uKTsKLSAgICBBU1NFUlQoc2VydmljZVdvcmtlcik7 Ci0gICAgQVNTRVJUKCFzZXJ2aWNlV29ya2VyLT5pc1Rlcm1pbmF0aW5nT3JUZXJtaW5hdGVkKCkp OworICAgIGlmICghc2VydmljZVdvcmtlcikKKyAgICAgICAgcmV0dXJuOwogCiAgICAgLy8gRklY TUU6IFdlIHNob3VsZCBwYXNzIHZhbGlkIE1lc3NhZ2VQb3J0Q2hhbm5lbHMuCiAgICAgc2Vydmlj ZVdvcmtlci0+cG9zdE1lc3NhZ2VUb1NlcnZpY2VXb3JrZXIoV1RGTW92ZShtZXNzYWdlKSwgV1RG TW92ZShzb3VyY2VEYXRhKSk7Cg==