<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>225030</bug_id>
          
          <creation_ts>2021-04-25 02:13:17 -0700</creation_ts>
          <short_desc>Bump CeilingOnPageSize to 16KB on MIPS</short_desc>
          <delta_ts>2021-05-17 06:59:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Angelos Oikonomopoulos">angelos</reporter>
          <assigned_to name="Angelos Oikonomopoulos">angelos</assigned_to>
          <cc>aperez</cc>
    
    <cc>benjamin</cc>
    
    <cc>berto</cc>
    
    <cc>cdumez</cc>
    
    <cc>clopez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1753992</commentid>
    <comment_count>0</comment_count>
    <who name="Angelos Oikonomopoulos">angelos</who>
    <bug_when>2021-04-25 02:13:17 -0700</bug_when>
    <thetext>Bump CeilingOnPageSize to 16KB on MIPS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1753993</commentid>
    <comment_count>1</comment_count>
      <attachid>426998</attachid>
    <who name="Angelos Oikonomopoulos">angelos</who>
    <bug_when>2021-04-25 02:15:01 -0700</bug_when>
    <thetext>Created attachment 426998
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1753999</commentid>
    <comment_count>2</comment_count>
      <attachid>426998</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2021-04-25 05:45:09 -0700</bug_when>
    <thetext>Comment on attachment 426998
Patch

MIPS64 uses a smaller page size than original MIPS? OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1754128</commentid>
    <comment_count>3</comment_count>
    <who name="Angelos Oikonomopoulos">angelos</who>
    <bug_when>2021-04-26 01:38:47 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #2)
&gt; Comment on attachment 426998 [details]
&gt; Patch
&gt; 
&gt; MIPS64 uses a smaller page size than original MIPS? OK.

AFAIK the choice of page size is up to the kernel -- for non-embedded mips64 systems, some distributions choose a 16KB. Not sure what counts as &quot;original MIPS&quot;, but I expect most embedded MIPS systems prefer 4KB pages (which is the previous value for CeilingOnPageSize for MIPS).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1754130</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-26 02:04:10 -0700</bug_when>
    <thetext>Committed r276583 (237019@main): &lt;https://commits.webkit.org/237019@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426998.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1754131</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-26 02:05:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/77143561&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760467</commentid>
    <comment_count>6</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2021-05-15 14:10:07 -0700</bug_when>
    <thetext>(In reply to Angelos Oikonomopoulos from comment #3)
&gt; &gt; MIPS64 uses a smaller page size than original MIPS? OK.
&gt;
&gt; AFAIK the choice of page size is up to the kernel -- for non-embedded mips64
&gt; systems, some distributions choose a 16KB. Not sure what counts as &quot;original
&gt; MIPS&quot;, but I expect most embedded MIPS systems prefer 4KB pages (which is
&gt; the previous value for CeilingOnPageSize for MIPS).

FWIW in Debian we have a downstream patch to use 16KB pages in MIPS64,
it seems that Loongson CPUs don&apos;t support 4KB pages.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760736</commentid>
    <comment_count>7</comment_count>
    <who name="Angelos Oikonomopoulos">angelos</who>
    <bug_when>2021-05-17 06:59:57 -0700</bug_when>
    <thetext>(In reply to Alberto Garcia from comment #6)
[...]
&gt; FWIW in Debian we have a downstream patch to use 16KB pages in MIPS64,
&gt; it seems that Loongson CPUs don&apos;t support 4KB pages.

Good to know, thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>426998</attachid>
            <date>2021-04-25 02:15:01 -0700</date>
            <delta_ts>2021-04-26 02:04:12 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-225030-20210425091500.patch</filename>
            <type>text/plain</type>
            <size>1549</size>
            <attacher name="Angelos Oikonomopoulos">angelos</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n
ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVhN2VhYmJmMjQwOWQ2OTFlZWM1ZGNk
ZjI2NTUyZmEzYmRiYzA2MDAuLjI3N2I4ZjZlM2JkZTg2YWNjYzZkZjdiMjA3MDVjYWUyNTlmY2U4
YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDQtMjUgIEFuZ2Vsb3MgT2lrb25vbW9wb3Vs
b3MgIDxhbmdlbG9zQGlnYWxpYS5jb20+CisKKyAgICAgICAgQnVtcCBDZWlsaW5nT25QYWdlU2l6
ZSB0byAxNktCIG9uIE1JUFMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIyNTAzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogd3RmL1BhZ2VCbG9jay5oOgorCiAyMDIxLTA0LTE0ICBBbGV4IENocmlzdGVu
c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IGltcG9ydGFu
dCBwYXJ0IG9mIHIyNzU5NDgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BhZ2VCbG9jay5o
IGIvU291cmNlL1dURi93dGYvUGFnZUJsb2NrLmgKaW5kZXggYzY1NWE1MGMyYzg5ZDNmN2FiYzBi
NmIzZWE0ZDAwMWE0YWU4ZTEzYi4uNDM0MzAwMzVhMTU4ZDYwMDM5ZjZkY2Y5ZjBmNjM4MzIyOTU4
MGRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFnZUJsb2NrLmgKKysrIGIvU291cmNl
L1dURi93dGYvUGFnZUJsb2NrLmgKQEAgLTQ3LDExICs0NywxMSBAQCBuYW1lc3BhY2UgV1RGIHsK
IC8vIDY0IEtpQi4gKEFwcGxlIHVzZXMgMTYgS2lCLikKIC8vCiAvLyBVc2UgNjQgS2lCIGZvciBh
bnkgdW5rbm93biBDUFVzIHRvIGJlIGNvbnNlcnZhdGl2ZS4KLSNpZiBPUyhEQVJXSU4pIHx8IFBM
QVRGT1JNKFBMQVlTVEFUSU9OKQorI2lmIE9TKERBUldJTikgfHwgUExBVEZPUk0oUExBWVNUQVRJ
T04pIHx8IENQVShNSVBTKQogY29uc3RleHByIHNpemVfdCBDZWlsaW5nT25QYWdlU2l6ZSA9IDE2
ICogS0I7CiAjZWxpZiBVU0UoNjRLQl9QQUdFX0JMT0NLKSB8fCBDUFUoUFBDKSB8fCBDUFUoUFBD
NjQpIHx8IENQVShQUEM2NExFKSB8fCBDUFUoVU5LTk9XTikKIGNvbnN0ZXhwciBzaXplX3QgQ2Vp
bGluZ09uUGFnZVNpemUgPSA2NCAqIEtCOwotI2VsaWYgT1MoV0lORE9XUykgfHwgQ1BVKE1JUFMp
IHx8IENQVShNSVBTNjQpIHx8IENQVShYODYpIHx8IENQVShYODZfNjQpIHx8IENQVShBUk0pIHx8
IENQVShBUk02NCkKKyNlbGlmIE9TKFdJTkRPV1MpIHx8IENQVShNSVBTNjQpIHx8IENQVShYODYp
IHx8IENQVShYODZfNjQpIHx8IENQVShBUk0pIHx8IENQVShBUk02NCkKIGNvbnN0ZXhwciBzaXpl
X3QgQ2VpbGluZ09uUGFnZVNpemUgPSA0ICogS0I7CiAjZWxzZQogI2Vycm9yIE11c3Qgc2V0IENl
aWxpbmdPblBhZ2VTaXplIGluIFBhZ2VCbG9jay5oIHdoZW4gYWRkaW5nIGEgbmV3IENQVSBhcmNo
aXRlY3R1cmUhCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>