22503 2008-11-25 16:29:57 -0800 createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL 2008-11-25 16:54:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 pol webkit-unassigned oldest_to_newest 100328 0 pol 2008-11-25 16:29:57 -0800 createFontCustomPlatformData() crashes if CGFontCreateWithPlatformFont() returns NULL: CGFontRef cgFontRef = CGFontCreateWithPlatformFont(&fontRef); #ifndef BUILDING_ON_TIGER // Workaround for <rdar://problem/5675504>. if (!CGFontGetNumberOfGlyphs(cgFontRef)) { CFRelease(cgFontRef); <----- CRASH cgFontRef = 0; } #endif Original problem is here: <rdar://problem/6401604> 10A222 + r38744: WebCore crashes in demo that uses custom font 100331 1 25511 pol 2008-11-25 16:40:16 -0800 Created attachment 25511 Patch v1 100333 2 25511 mrowe 2008-11-25 16:43:46 -0800 Comment on attachment 25511 Patch v1 r=me 100337 3 pol 2008-11-25 16:54:37 -0800 Sending WebCore/ChangeLog Sending WebCore/platform/graphics/mac/FontCustomPlatformData.cpp Transmitting file data .. Committed revision 38770. 25511 2008-11-25 16:40:16 -0800 2008-11-25 16:43:46 -0800 Patch v1 Patch.txt text/plain 1303 pol ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmNhNzJhZC4uMDExNDk0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOC0xMS0yNSAgUGllcnJlLU9saXZp ZXIgTGF0b3VyICA8cG9sQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBjcmVhdGVGb250Q3VzdG9tUGxhdGZvcm1EYXRhKCkgY3Jhc2hl cyBpZiBDR0ZvbnRDcmVhdGVXaXRoUGxhdGZvcm1Gb250KCkgcmV0dXJucyBOVUxMCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNTAzCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpjcmVhdGVGb250Q3VzdG9tUGxhdGZvcm1EYXRhKToKKwogMjAwOC0x MS0yNCAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bmlrb2xhcy56aW1tZXJtYW5uQHRvcmNobW9iaWxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvRm9udEN1c3RvbVBsYXRmb3JtRGF0YS5jcHAgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcApp bmRleCAxZmIxNDRjLi45YWE0OTk3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL21hYy9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL21hYy9Gb250Q3VzdG9tUGxhdGZvcm1EYXRhLmNwcApAQCAtNjgsNyArNjgsNyBA QCBGb250Q3VzdG9tUGxhdGZvcm1EYXRhKiBjcmVhdGVGb250Q3VzdG9tUGxhdGZvcm1EYXRhKFNo YXJlZEJ1ZmZlciogYnVmZmVyKQogICAgIENHRm9udFJlZiBjZ0ZvbnRSZWYgPSBDR0ZvbnRDcmVh dGVXaXRoUGxhdGZvcm1Gb250KCZmb250UmVmKTsKICNpZm5kZWYgQlVJTERJTkdfT05fVElHRVIK ICAgICAvLyBXb3JrYXJvdW5kIGZvciA8cmRhcjovL3Byb2JsZW0vNTY3NTUwND4uCi0gICAgaWYg KCFDR0ZvbnRHZXROdW1iZXJPZkdseXBocyhjZ0ZvbnRSZWYpKSB7CisgICAgaWYgKGNnRm9udFJl ZiAmJiAhQ0dGb250R2V0TnVtYmVyT2ZHbHlwaHMoY2dGb250UmVmKSkgewogICAgICAgICBDRlJl bGVhc2UoY2dGb250UmVmKTsKICAgICAgICAgY2dGb250UmVmID0gMDsKICAgICB9Cg==