225010 2021-04-23 16:52:36 -0700 PCM: debug mode should send the second report on a 10 second delay after the first 2021-04-23 17:48:00 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney webkit-bug-importer wilander oldest_to_newest 1753802 0 katherine_cheney 2021-04-23 16:52:36 -0700 In PCM debug mode, the first report for an attribution gets sent at the expected 10 seconds. However, the second gets sent at the non-debug mode timing of 24-48 hours. We should fix this. 1753803 1 webkit-bug-importer 2021-04-23 16:52:55 -0700 <rdar://problem/77092303> 1753806 2 426968 katherine_cheney 2021-04-23 17:02:22 -0700 Created attachment 426968 Patch 1753807 3 426968 wilander 2021-04-23 17:07:16 -0700 Comment on attachment 426968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426968&action=review r=me with small comments. I think it's fine to land this without full EWS feedback since it only affects the opt-in debug mode setting. It could theoretically break regression tests but that is very unlikely. > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:401 > + // mode is enabled, this should be every 10 seconds for easy testing. I would avoid stating the 10 seconds since it's a constant that may change, making the comment obsolete. You can say "… this should be much shorter for easy testing." > Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:413 > + // Or, if debug mode is enabled, we should send the second report on a 10 second delay for easy testing. Ditto. I suggest "… we should send the second report on a much shorter delay for easy testing." 1753808 4 426969 katherine_cheney 2021-04-23 17:12:44 -0700 Created attachment 426969 Patch for landing 1753814 5 ews-feeder 2021-04-23 17:47:58 -0700 Committed r276545 (236985@main): <https://commits.webkit.org/236985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426969. 426968 2021-04-23 17:02:22 -0700 2021-04-23 17:12:41 -0700 Patch bug-225010-20210423170221.patch text/plain 3576 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFmYmE5MzgyZDFkYjViZjc1 MmRlNDFjZjc0NmZlNjgxMTQwYTFiNDUuLjBiYjY4NTQ5MjUyZDU4N2Q3YjY3NWU1OTNjMjMxNWQ4 YWI5MDkzZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMDQtMjMgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgUENNOiBkZWJ1ZyBt b2RlIHNob3VsZCBzZW5kIHRoZSBzZWNvbmQgcmVwb3J0IG9uIGEgMTAgc2Vjb25kIGRlbGF5IGFm dGVyIHRoZSBmaXJzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI1MDEwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NzA5MjMwMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBidWcgaW4gUENN IGRlYnVnIG1vZGUgd2hlcmUgd2UgZG9uJ3Qgc2V0IHRoZSB0aW1lciBmb3IgMTBfcworICAgICAg ICBhZnRlciBzZW5kaW5nIHRoZSBmaXJzdCByZXBvcnQgZm9yIGFuIGF0dHJpYnV0aW9uLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBkZWJ1ZyBtb2RlIG9ubHkuIE5vbi1kZWJ1ZyBt b2RlIGJlaGF2aW9yIGlzCisgICAgICAgIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMsIGFuZCBJ IHRlc3RlZCBkZWJ1ZyBtb2RlIG1hbnVhbGx5LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyOjpmaXJlUGVuZGluZ0F0dHJpYnV0aW9uUmVxdWVz dHMpOgorICAgICAgICBJZiB0aGUgYXR0cmlidXRpb24gaGFzIGJlZW4gc2VudCB0byBvbmx5IG9u ZSBlbmRwb2ludCwgaW5kaWNhdGVkIGJ5CisgICAgICAgIGEgbm9uLW51bGwgbGF0ZXJUaW1lVG9T ZW5kIHZhbHVlLCB3ZSBzaG91bGQgc2V0IHRoZSB0aW1lciB0byBiZSAxMAorICAgICAgICBzZWNv bmRzIGlmIGRlYnVnIG1vZGUgaXMgZW5hYmxlZC4KKworICAgICAgICBBbHNvLCBjaGFuZ2UgdGhl IGludGVydmFsIHRpbWUgZnJvbSAxIG1pbnV0ZSB0byAxMCBzZWNvbmRzLCBiZWNhdXNlCisgICAg ICAgIHRoZXJlIHdhcyBubyBnb29kIHJlYXNvbiB0aGF0IGl0IHdhcyAxIG1pbnV0ZSBhbmQgd2Ug c2hvdWxkIGJlCisgICAgICAgIGNvbnNpc3RlbnQuIEFsc28gMSBtaW51dGUgaXMgYSBsb25nIHRp bWUgdG8gd2FpdCBkdXJpbmcgYSB0ZXN0LgorCiAyMDIxLTA0LTIxICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFRleHQgc2VsZWN0aW9uIGlu IGltYWdlIG92ZXJsYXlzIHNob3VsZCBub3QgYmUgbGltaXRlZCB0byByZWN0aWxpbmVhciBxdWFk cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2YXRlQ2xpY2tN ZWFzdXJlbWVudE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2 YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwCmluZGV4IDYwNTI2OTI3MzI0ZjFjN2FlNzBk YjQxZmU1Njk1MGQ2YTFmMjljMzIuLjcyZTRiOGM0MWFjYjI0NmZkYmNiNWMxZmU3ZGI3MjM5ZGEx Njk2ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJpdmF0ZUNs aWNrTWVhc3VyZW1lbnRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL1ByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlci5jcHAKQEAgLTM5OCw4ICszOTgsOCBA QCB2b2lkIFByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6ZmlyZVBlbmRpbmdBdHRyaWJ1 dGlvblJlcXVlc3RzKCkKICAgICAgICAgICAgICAgICBpZiAoaGFzU2VudEF0dHJpYnV0aW9uKSB7 CiAgICAgICAgICAgICAgICAgICAgIC8vIFdlJ3ZlIGFscmVhZHkgc2VudCBhbiBhdHRyaWJ1dGlv biB0aGlzIHJvdW5kLiBXZSBzaG91bGQgc2VuZCBhZGRpdGlvbmFsIG92ZXJkdWUgYXR0cmlidXRp b25zIGF0CiAgICAgICAgICAgICAgICAgICAgIC8vIGEgcmFuZG9tIHRpbWUgYmV0d2VlbiAxNSBh bmQgMzAgbWludXRlcyB0byBhdm9pZCBhIGJ1cnN0IG9mIHNpbXVsdGFuZW91cyBhdHRyaWJ1dGlv bnMuIElmIGRlYnVnCi0gICAgICAgICAgICAgICAgICAgIC8vIG1vZGUgaXMgZW5hYmxlZCwgdGhp cyBzaG91bGQgYmUgZXZlcnkgbWludXRlIGZvciBlYXN5IHRlc3RpbmcuCi0gICAgICAgICAgICAg ICAgICAgIGF1dG8gaW50ZXJ2YWwgPSBkZWJ1Z01vZGVFbmFibGVkKCkgPyAxX21pbiA6IDE1X21p biArIFNlY29uZHMoY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIoKSAlIDkwMCk7CisgICAg ICAgICAgICAgICAgICAgIC8vIG1vZGUgaXMgZW5hYmxlZCwgdGhpcyBzaG91bGQgYmUgZXZlcnkg MTAgc2Vjb25kcyBmb3IgZWFzeSB0ZXN0aW5nLgorICAgICAgICAgICAgICAgICAgICBhdXRvIGlu dGVydmFsID0gZGVidWdNb2RlRW5hYmxlZCgpID8gZGVidWdNb2RlU2Vjb25kc1VudGlsU2VuZCA6 IDE1X21pbiArIFNlY29uZHMoY3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIoKSAlIDkwMCk7 CiAgICAgICAgICAgICAgICAgICAgIHN0YXJ0VGltZXIoaW50ZXJ2YWwpOwogICAgICAgICAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQpAQCAtNDEwLDggKzQxMCw5IEBAIHZv aWQgUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyOjpmaXJlUGVuZGluZ0F0dHJpYnV0aW9u UmVxdWVzdHMoKQogICAgICAgICAgICAgICAgIGhhc1NlbnRBdHRyaWJ1dGlvbiA9IHRydWU7CiAK ICAgICAgICAgICAgICAgICAvLyBVcGRhdGUgbmV4dFRpbWVUb0ZpcmUgaW4gY2FzZSB0aGUgbGF0 ZXIgcmVwb3J0IHRpbWUgZm9yIHRoaXMgYXR0cmlidXRpb24gaXMgc29vbmVyIHRoYW4gdGhlIHNj aGVkdWxlZCBuZXh0IHRpbWUgdG8gZmlyZS4KKyAgICAgICAgICAgICAgICAvLyBPciwgaWYgZGVi dWcgbW9kZSBpcyBlbmFibGVkLCB3ZSBzaG91bGQgc2VuZCB0aGUgc2Vjb25kIHJlcG9ydCBvbiBh IDEwIHNlY29uZCBkZWxheSBmb3IgZWFzeSB0ZXN0aW5nLgogICAgICAgICAgICAgICAgIGlmIChs YXRlclRpbWVUb1NlbmQpCi0gICAgICAgICAgICAgICAgICAgIG5leHRUaW1lVG9GaXJlID0gc3Rk OjptaW4obmV4dFRpbWVUb0ZpcmUsIGxhdGVyVGltZVRvU2VuZC52YWx1ZSgpLnNlY29uZHNTaW5j ZUVwb2NoKCkpOworICAgICAgICAgICAgICAgICAgICBuZXh0VGltZVRvRmlyZSA9IGRlYnVnTW9k ZUVuYWJsZWQoKSA/IGRlYnVnTW9kZVNlY29uZHNVbnRpbFNlbmQgOiBzdGQ6Om1pbihuZXh0VGlt ZVRvRmlyZSwgbGF0ZXJUaW1lVG9TZW5kLnZhbHVlKCkuc2Vjb25kc1NpbmNlRXBvY2goKSk7CiAK ICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgIH0K 426969 2021-04-23 17:12:44 -0700 2021-04-23 17:47:59 -0700 Patch for landing bug-225010-20210423171243.patch text/plain 3574 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFmYmE5MzgyZDFkYjViZjc1 MmRlNDFjZjc0NmZlNjgxMTQwYTFiNDUuLmU1N2M5OGEwMjQ5YTY3NTMxY2UzOTBmN2NkMWRhOTM3 MGRmZmRkZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjEtMDQtMjMgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgUENNOiBkZWJ1ZyBt b2RlIHNob3VsZCBzZW5kIHRoZSBzZWNvbmQgcmVwb3J0IG9uIGEgMTAgc2Vjb25kIGRlbGF5IGFm dGVyIHRoZSBmaXJzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI1MDEwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NzA5MjMwMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBKb2huIFdpbGFuZGVyLgorCisgICAgICAgIEZpeCBhIGJ1ZyBpbiBQQ00g ZGVidWcgbW9kZSB3aGVyZSB3ZSBkb24ndCBzZXQgdGhlIHRpbWVyIGZvciAxMF9zCisgICAgICAg IGFmdGVyIHNlbmRpbmcgdGhlIGZpcnN0IHJlcG9ydCBmb3IgYW4gYXR0cmlidXRpb24uCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGRlYnVnIG1vZGUgb25seS4gTm9uLWRlYnVnIG1v ZGUgYmVoYXZpb3IgaXMKKyAgICAgICAgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cywgYW5kIEkg dGVzdGVkIGRlYnVnIG1vZGUgbWFudWFsbHkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9Q cml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcml2 YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXI6OmZpcmVQZW5kaW5nQXR0cmlidXRpb25SZXF1ZXN0 cyk6CisgICAgICAgIElmIHRoZSBhdHRyaWJ1dGlvbiBoYXMgYmVlbiBzZW50IHRvIG9ubHkgb25l IGVuZHBvaW50LCBpbmRpY2F0ZWQgYnkKKyAgICAgICAgYSBub24tbnVsbCBsYXRlclRpbWVUb1Nl bmQgdmFsdWUsIHdlIHNob3VsZCBzZXQgdGhlIHRpbWVyIHRvIGJlIDEwCisgICAgICAgIHNlY29u ZHMgaWYgZGVidWcgbW9kZSBpcyBlbmFibGVkLgorCisgICAgICAgIEFsc28sIGNoYW5nZSB0aGUg aW50ZXJ2YWwgdGltZSBmcm9tIDEgbWludXRlIHRvIDEwIHNlY29uZHMsIGJlY2F1c2UKKyAgICAg ICAgdGhlcmUgd2FzIG5vIGdvb2QgcmVhc29uIHRoYXQgaXQgd2FzIDEgbWludXRlIGFuZCB3ZSBz aG91bGQgYmUKKyAgICAgICAgY29uc2lzdGVudC4gQWxzbyAxIG1pbnV0ZSBpcyBhIGxvbmcgdGlt ZSB0byB3YWl0IGR1cmluZyBhIHRlc3QuCisKIDIwMjEtMDQtMjEgIFdlbnNvbiBIc2llaCAgPHdl bnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVGV4dCBzZWxlY3Rpb24gaW4g aW1hZ2Ugb3ZlcmxheXMgc2hvdWxkIG5vdCBiZSBsaW1pdGVkIHRvIHJlY3RpbGluZWFyIHF1YWRz CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1ByaXZhdGVDbGlja01l YXN1cmVtZW50TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL1ByaXZh dGVDbGlja01lYXN1cmVtZW50TWFuYWdlci5jcHAKaW5kZXggNjA1MjY5MjczMjRmMWM3YWU3MGRi NDFmZTU2OTUwZDZhMWYyOWMzMi4uZGFlY2M3NmNmMDMyMGYwZmI2YzgyMzUzZjE5MzJjOGI4MWYx ZDYwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2YXRlQ2xp Y2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nl c3MvUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyLmNwcApAQCAtMzk4LDggKzM5OCw4IEBA IHZvaWQgUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyOjpmaXJlUGVuZGluZ0F0dHJpYnV0 aW9uUmVxdWVzdHMoKQogICAgICAgICAgICAgICAgIGlmIChoYXNTZW50QXR0cmlidXRpb24pIHsK ICAgICAgICAgICAgICAgICAgICAgLy8gV2UndmUgYWxyZWFkeSBzZW50IGFuIGF0dHJpYnV0aW9u IHRoaXMgcm91bmQuIFdlIHNob3VsZCBzZW5kIGFkZGl0aW9uYWwgb3ZlcmR1ZSBhdHRyaWJ1dGlv bnMgYXQKICAgICAgICAgICAgICAgICAgICAgLy8gYSByYW5kb20gdGltZSBiZXR3ZWVuIDE1IGFu ZCAzMCBtaW51dGVzIHRvIGF2b2lkIGEgYnVyc3Qgb2Ygc2ltdWx0YW5lb3VzIGF0dHJpYnV0aW9u cy4gSWYgZGVidWcKLSAgICAgICAgICAgICAgICAgICAgLy8gbW9kZSBpcyBlbmFibGVkLCB0aGlz IHNob3VsZCBiZSBldmVyeSBtaW51dGUgZm9yIGVhc3kgdGVzdGluZy4KLSAgICAgICAgICAgICAg ICAgICAgYXV0byBpbnRlcnZhbCA9IGRlYnVnTW9kZUVuYWJsZWQoKSA/IDFfbWluIDogMTVfbWlu ICsgU2Vjb25kcyhjcnlwdG9ncmFwaGljYWxseVJhbmRvbU51bWJlcigpICUgOTAwKTsKKyAgICAg ICAgICAgICAgICAgICAgLy8gbW9kZSBpcyBlbmFibGVkLCB0aGlzIHNob3VsZCBiZSBtdWNoIHNo b3J0ZXIgZm9yIGVhc3kgdGVzdGluZy4KKyAgICAgICAgICAgICAgICAgICAgYXV0byBpbnRlcnZh bCA9IGRlYnVnTW9kZUVuYWJsZWQoKSA/IGRlYnVnTW9kZVNlY29uZHNVbnRpbFNlbmQgOiAxNV9t aW4gKyBTZWNvbmRzKGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tTnVtYmVyKCkgJSA5MDApOwogICAg ICAgICAgICAgICAgICAgICBzdGFydFRpbWVyKGludGVydmFsKTsKICAgICAgICAgICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICAgICAgICAgIH0KQEAgLTQxMCw4ICs0MTAsOSBAQCB2b2lkIFBy aXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6ZmlyZVBlbmRpbmdBdHRyaWJ1dGlvblJlcXVl c3RzKCkKICAgICAgICAgICAgICAgICBoYXNTZW50QXR0cmlidXRpb24gPSB0cnVlOwogCiAgICAg ICAgICAgICAgICAgLy8gVXBkYXRlIG5leHRUaW1lVG9GaXJlIGluIGNhc2UgdGhlIGxhdGVyIHJl cG9ydCB0aW1lIGZvciB0aGlzIGF0dHJpYnV0aW9uIGlzIHNvb25lciB0aGFuIHRoZSBzY2hlZHVs ZWQgbmV4dCB0aW1lIHRvIGZpcmUuCisgICAgICAgICAgICAgICAgLy8gT3IsIGlmIGRlYnVnIG1v ZGUgaXMgZW5hYmxlZCwgd2Ugc2hvdWxkIHNlbmQgdGhlIHNlY29uZCByZXBvcnQgb24gYSBtdWNo IHNob3J0ZXIgZGVsYXkgZm9yIGVhc3kgdGVzdGluZy4KICAgICAgICAgICAgICAgICBpZiAobGF0 ZXJUaW1lVG9TZW5kKQotICAgICAgICAgICAgICAgICAgICBuZXh0VGltZVRvRmlyZSA9IHN0ZDo6 bWluKG5leHRUaW1lVG9GaXJlLCBsYXRlclRpbWVUb1NlbmQudmFsdWUoKS5zZWNvbmRzU2luY2VF cG9jaCgpKTsKKyAgICAgICAgICAgICAgICAgICAgbmV4dFRpbWVUb0ZpcmUgPSBkZWJ1Z01vZGVF bmFibGVkKCkgPyBkZWJ1Z01vZGVTZWNvbmRzVW50aWxTZW5kIDogc3RkOjptaW4obmV4dFRpbWVU b0ZpcmUsIGxhdGVyVGltZVRvU2VuZC52YWx1ZSgpLnNlY29uZHNTaW5jZUVwb2NoKCkpOwogCiAg ICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICB9Cg==