225003 2021-04-23 15:41:43 -0700 ANGLE X11 build fixes 2021-04-26 08:05:16 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead dino ews-watchlist graouts jdarpinian kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1753763 0 don.olmstead 2021-04-23 15:41:43 -0700 See https://bugs.webkit.org/show_bug.cgi?id=223577 1753769 1 426957 don.olmstead 2021-04-23 15:48:45 -0700 Created attachment 426957 Patch 1753816 2 426957 kbr 2021-04-23 17:56:23 -0700 Comment on attachment 426957 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426957&action=review Seems fine. r+ > Source/WebCore/platform/graphics/angle/ANGLEHeaders.h:52 > +#if defined(None) Would it be possible to put some guard around this entire block so it only applies to X11 platforms? If not, that's OK. 1753826 3 don.olmstead 2021-04-23 20:30:24 -0700 (In reply to Kenneth Russell from comment #2) > Comment on attachment 426957 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426957&action=review > > Seems fine. r+ > > > Source/WebCore/platform/graphics/angle/ANGLEHeaders.h:52 > > +#if defined(None) > > Would it be possible to put some guard around this entire block so it only > applies to X11 platforms? If not, that's OK. It seemed to be dragging in X11 headers on Linux even when `angle_use_x11` and `ENABLE_X11_TARGET` were OFF. 1754187 4 426957 don.olmstead 2021-04-26 08:01:19 -0700 Comment on attachment 426957 Patch Talked to mcatanzaro and there doesn't seem to be a good way to guard the set of checks. The other file using it also does the same unconditionally. 1754188 5 ews-feeder 2021-04-26 08:04:49 -0700 Committed r276591 (237027@main): <https://commits.webkit.org/237027@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426957. 1754189 6 webkit-bug-importer 2021-04-26 08:05:16 -0700 <rdar://problem/77157618> 426957 2021-04-23 15:48:45 -0700 2021-04-26 08:04:50 -0700 Patch bug-225003.diff text/plain 2009 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlY2UwNmRhYjY4YTMuLjA5OTg5NTdhYWRjYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIxLTA0LTIzICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29u eS5jb20+CisKKyAgICAgICAgQU5HTEUgWDExIGJ1aWxkIGZpeGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjUwMDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBYMTEgaGVhZGVycyBkZWZpbmUgYSBidW5j aCBvZiBtYWNyb3Mgd2l0aCBjb21tb24gdGVybXMsIGludGVyZmVyaW5nIHdpdGggV2ViQ29yZSBh bmQgV1RGCisgICAgICAgIGVudW0gdmFsdWVzLiBBcyBhIHdvcmthcm91bmQsIHdlIGV4cGxpY2l0 bHkgdW5kZWYgdGhlbS4KKworICAgICAgICBUaGlzIGlzIHRoZSBzYW1lIGZpeCBhcyB0aGUgb25l IHRvIEdMQ29udGV4dC5oIGluIHIyNzQ4NjkgYnV0IGFwcGxpZWQgdG8gdGhlIEFOR0xFIGhlYWRl cnMKKyAgICAgICAgdGhhdCBhcmUgaW5jbHVkaW5nIFgxMS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2FuZ2xlL0FOR0xFSGVhZGVycy5oOgorCiAyMDIxLTA0LTIzICBNaWNoYWVsIENh dGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgdmlydHVh bCBmdW5jdGlvbiBjYWxscyBpbiBHcmFwaGljc0xheWVyIGRlc3RydWN0b3JzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9BTkdMRUhlYWRlcnMuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2FuZ2xlL0FOR0xFSGVhZGVycy5oCmlu ZGV4IDE2YTI1YjAwNjMxNy4uYzQ1ZDliMDg4NmY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9BTkdMRUhlYWRlcnMuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hbmdsZS9BTkdMRUhlYWRlcnMuaApAQCAtNDcsNiArNDcs NDIgQEAKICNpbmNsdWRlIDxBTkdMRS9lbnRyeV9wb2ludHNfZ2xlc18zXzBfYXV0b2dlbi5oPgog I2luY2x1ZGUgPEFOR0xFL2VudHJ5X3BvaW50c19nbGVzX2V4dF9hdXRvZ2VuLmg+CiAKKy8vIFgx MSBoZWFkZXJzIGRlZmluZSBhIGJ1bmNoIG9mIG1hY3JvcyB3aXRoIGNvbW1vbiB0ZXJtcywgaW50 ZXJmZXJpbmcgd2l0aCBXZWJDb3JlIGFuZCBXVEYgZW51bSB2YWx1ZXMuCisvLyBBcyBhIHdvcmth cm91bmQsIHdlIGV4cGxpY2l0bHkgdW5kZWYgdGhlbSBoZXJlLgorI2lmIGRlZmluZWQoTm9uZSkK KyN1bmRlZiBOb25lCisjZW5kaWYKKyNpZiBkZWZpbmVkKEFib3ZlKQorI3VuZGVmIEFib3ZlCisj ZW5kaWYKKyNpZiBkZWZpbmVkKEJlbG93KQorI3VuZGVmIEJlbG93CisjZW5kaWYKKyNpZiBkZWZp bmVkKFN1Y2Nlc3MpCisjdW5kZWYgU3VjY2VzcworI2VuZGlmCisjaWYgZGVmaW5lZChGYWxzZSkK KyN1bmRlZiBGYWxzZQorI2VuZGlmCisjaWYgZGVmaW5lZChUcnVlKQorI3VuZGVmIFRydWUKKyNl bmRpZgorI2lmIGRlZmluZWQoQm9vbCkKKyN1bmRlZiBCb29sCisjZW5kaWYKKyNpZiBkZWZpbmVk KEFsd2F5cykKKyN1bmRlZiBBbHdheXMKKyNlbmRpZgorI2lmIGRlZmluZWQoU3RhdHVzKQorI3Vu ZGVmIFN0YXR1cworI2VuZGlmCisjaWYgZGVmaW5lZChDb250aW51ZSkKKyN1bmRlZiBDb250aW51 ZQorI2VuZGlmCisjaWYgZGVmaW5lZChSZWdpb24pCisjdW5kZWYgUmVnaW9uCisjZW5kaWYKKwog Ly8gTm90ZTogdGhpcyBmaWxlIGNhbid0IGJlIGNvbXBpbGVkIGluIHRoZSBzYW1lIHVuaWZpZWQg c291cmNlIGZpbGUKIC8vIGFzIG90aGVycyB3aGljaCBpbmNsdWRlIHRoZSBzeXN0ZW0ncyBPcGVu R0wgaGVhZGVycy4KIAo=