224996 2021-04-23 14:21:02 -0700 [RenderTreeBuilder] Subtree moving should clear the floats on all the descendants 2021-04-24 06:42:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr simon.fraser zalan oldest_to_newest 1753727 0 zalan 2021-04-23 14:21:02 -0700 <rdar://76837320> and not only on the root of the move. 1753761 1 426955 zalan 2021-04-23 15:27:49 -0700 Created attachment 426955 Patch 1753829 2 426955 koivisto 2021-04-23 21:47:08 -0700 Comment on attachment 426955 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426955&action=review > Source/WebCore/ChangeLog:9 > + While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout). We should really stop moving subtrees. Also spelling. 1753845 3 zalan 2021-04-24 06:37:31 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 426955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426955&action=review > > > Source/WebCore/ChangeLog:9 > > + While moving a subtre, we invalidate the floating object list so that we don't end up with incorrectly placed floats (they'll get regenerated during the subsequent layout). > > We should really stop moving subtrees. Also spelling. Yes and yes. I wonder what we'll come up with for LFC where the layout nodes (renderers) don't store layout states so moving subtrees is nothing but a simple re-parenting activity, while we have to run invalidation on the formatting state objects. 1753846 4 426979 zalan 2021-04-24 06:40:07 -0700 Created attachment 426979 [fast-cq] Patch 1753847 5 ews-feeder 2021-04-24 06:42:13 -0700 Committed r276549 (236989@main): <https://commits.webkit.org/236989@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426979. 426955 2021-04-23 15:27:49 -0700 2021-04-24 06:40:05 -0700 Patch bug-224996-20210423152748.patch text/plain 6251 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVjYmU3ZGZlZGFkMzA1 ZDM4YzhmZjk4YWFiZTdkMmI2OWJkMDllNi4uZGJiZWI0MjI1M2FkNzllMWE3ZWM5MzQwMzJlYjA3 N2I3OTMwM2I5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTA0LTIzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBTdWJ0cmVlIG1vdmluZyBzaG91bGQgY2xlYXIgdGhlIGZsb2F0cyBvbiBhbGwgdGhlIGRlc2Nl bmRhbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjQ5OTYKKyAgICAgICAgPHJkYXI6Ly83NjgzNzMyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGlsZSBtb3ZpbmcgYSBzdWJ0cmUsIHdlIGludmFs aWRhdGUgdGhlIGZsb2F0aW5nIG9iamVjdCBsaXN0IHNvIHRoYXQgd2UgZG9uJ3QgZW5kIHVwIHdp dGggaW5jb3JyZWN0bHkgcGxhY2VkIGZsb2F0cyAodGhleSdsbCBnZXQgcmVnZW5lcmF0ZWQgZHVy aW5nIHRoZSBzdWJzZXF1ZW50IGxheW91dCkuCisgICAgICAgIEEgZmxvYXQgY2FuIGJlICJhc3Np Z25lZCIgdG8gbW9yZSB0aGFuIG9uZSBSZW5kZXJCbG9ja0Zsb3cgKGUuZyBpbnRydWRpbmcgZmxv YXRzKS4gSXQncyB2ZXJ5IGNvbW1vbiB0aGF0IGEgc2V0IG9mIGRlc2NlbmRhbnQgUmVuZGVyQmxv Y2tGbG93CisgICAgICAgIHJlbmRlcmVycyAic2VlIiB0aGUgc2FtZSBzZXQgb2YgZmxvYXRzIChl YWNoIFJlbmRlckJsb2NrRmxvdyBoYXMgaXRzIG93biBsaXN0IG9mIGZsb2F0aW5nIG9iamVjdHMp LgorICAgICAgICBOb3cgdGhlIGludmFsaWRhdGlvbiBpcyBiYXNlZCBvbiBhbmNlc3Rvci10by1k ZXNjZW5kYW50IGRpcmVjdGlvbiBzdGFydGluZyB3aXRoIGZpbmRpbmcgdGhlIG91dGVyIG1vc3Qg Y29udGFpbmluZyBibG9jayBmb3IgYSBwYXJ0aWN1bGFyIGZsb2F0IChzZWUgb3V0ZXJtb3N0Qmxv Y2tDb250YWluaW5nRmxvYXRpbmdPYmplY3QpCisgICAgICAgIFRoZSBpbnZhbGlkYXRpb24gbG9n aWMgYWxzbyBleHBlY3RzIG5vIGdhcHMgaW4gdGhlIGFuY2VzdG9yIGNoYWluIGUuZy4KKworICAg ICAgICAgICBSZW5kZXJCbG9ja0Zsb3cgKEEpIC0+IGZsb2F0IFgKKyAgICAgICAgICAgICBSZW5k ZXJCbG9ja0Zsb3cgKEIpIC0+IGZsb2F0IFgKKyAgICAgICAgICAgICAgIFJlbmRlckJsb2NrRmxv dyAoQykgLT4gZmxvYXQgWAorICAgICAgICAgICBpZiBmbG9hdCBYIGlzIGFzc2lnbmVkIHRvIGJv dGggQSBhbmQgQywgdGhlbiBpdCBtdXN0IGJlIGFzc2lnbmVkIHRvIEIgYXMgd2VsbC4KKworICAg ICAgICBSZW5kZXJCbG9ja0Zsb3c6OnJlbW92ZUZsb2F0aW5nT2JqZWN0cygpIHNpbXBseSByZW1v dmVzIHRoZSBmbG9hdCBmcm9tIHRoZSByZW5kZXJlci4gSXQgZG9lcyBub3QgaW52YWxpZGF0ZSB0 aGUgYW5jZXN0b3IvZGVzY2VuZGFudCBjaGFpbi4KKyAgICAgICAgZS5nLiBjYWxsaW5nIEIucmVt b3ZlRmxvYXRpbmdPYmplY3RzKCkgd291bGQganVzdCByZW1vdmUgZmxvYXQgWCBmcm9tIFJlbmRl ckJsb2NrRmxvdyAoQikKKworICAgICAgICAgICBSZW5kZXJCbG9ja0Zsb3cgKEEpIC0+IGZsb2F0 IFgKKyAgICAgICAgICAgICBSZW5kZXJCbG9ja0Zsb3cgKEIpCisgICAgICAgICAgICAgICBSZW5k ZXJCbG9ja0Zsb3cgKEMpIC0+IGZsb2F0IFgKKworICAgICAgICBhbmQgYW55IHN1YnNlcXVlbnQg aW52YWxpZGF0aW9uIGF0dGVtcHQgd291bGQgZmFpbCB0byBjbGVhciB1cCBBIG9yIEMgKGRlcGVu ZGluZyBvbiB3aGV0aGVyIGl0IGlzIGluaXRpYXRlZCBvbiBBIG9yIEMpLgorCisgICAgICAgIFRl c3Q6IGZhc3QvbXVsdGljb2wvZmxvYXRpbmctYm94ZXMtbW92ZWQtdW5kZXItbXVsdGktY29sdW1u Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUcmVlQnVpbGRlcjo6bW92ZUNoaWxkcmVuKToK KwogMjAyMS0wNC0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtSZW5kZXJUcmVlQnVpbGRlcl0gTXVsdGktY29sdW1uIHNwYW5uZXJzIGFyZSBub3QgcGFydCBv ZiB0aGUgZW5jbG9zaW5nIG11bHRpLWNvbHVtbiByZW5kZXJlcidzIHN1YnRyZWUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwCmluZGV4IDgyYTJiYmYwODllYmZjNjk2ZmVkNDI2NjU2NzMwYjc5ODMxNTViMTYuLjcxNWQ0 ODQ5ZDNlNWY5OGMxYTkwNTI4NjAxNWJjYjVjNTNlZjExZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcApAQCAt NTMxLDggKzUzMSwyMiBAQCB2b2lkIFJlbmRlclRyZWVCdWlsZGVyOjptb3ZlQ2hpbGRyZW4oUmVu ZGVyQm94TW9kZWxPYmplY3QmIGZyb20sIFJlbmRlckJveE1vZGVsTwogICAgIC8vIG9yIHdoZW4g ZnVsbFJlbW92ZUluc2VydCBpcyBmYWxzZS4KICAgICBpZiAobm9ybWFsaXplQWZ0ZXJJbnNlcnRp b24gPT0gTm9ybWFsaXplQWZ0ZXJJbnNlcnRpb246OlllcyAmJiBpczxSZW5kZXJCbG9jaz4oZnJv bSkpIHsKICAgICAgICAgZG93bmNhc3Q8UmVuZGVyQmxvY2s+KGZyb20pLnJlbW92ZVBvc2l0aW9u ZWRPYmplY3RzKG51bGxwdHIpOwotICAgICAgICBpZiAoaXM8UmVuZGVyQmxvY2tGbG93Pihmcm9t KSkKLSAgICAgICAgICAgIGRvd25jYXN0PFJlbmRlckJsb2NrRmxvdz4oZnJvbSkucmVtb3ZlRmxv YXRpbmdPYmplY3RzKCk7CisgICAgICAgIGF1dG8gcmVtb3ZlRmxvYXRpbmdPYmplY3RzSWZBcHBs aWNhYmxlID0gWyZdIHsKKyAgICAgICAgICAgIGlmIChmcm9tLnJlbmRlclRyZWVCZWluZ0Rlc3Ry b3llZCgpKQorICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIGlmICghaXM8UmVu ZGVyQmxvY2tGbG93Pihmcm9tKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAg ICBhdXRvKiBmbG9hdGluZ09iamVjdHMgPSBkb3duY2FzdDxSZW5kZXJCbG9ja0Zsb3c+KGZyb20p LmZsb2F0aW5nT2JqZWN0U2V0KCk7CisgICAgICAgICAgICBpZiAoIWZsb2F0aW5nT2JqZWN0cykK KyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAvLyBIZXJlIHdlIHJlbW92ZSB0 aGUgZmxvYXRpbmcgb2JqZWN0cyBmcm9tIHRoZSBkZXNjZW5kYW50cyBhcyB3ZWxsLgorICAgICAg ICAgICAgYXV0byBjb3B5T2ZGbG9hdGluZ09iamVjdHMgPSBXVEY6Om1hcCgqZmxvYXRpbmdPYmpl Y3RzLCBbXShhdXRvJiBmbG9hdGluZ09iamVjdCkgeyAKKyAgICAgICAgICAgICAgICByZXR1cm4g ZmxvYXRpbmdPYmplY3QuZ2V0KCk7CisgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIGZvciAo YXV0byogZmxvYXRpbmdPYmplY3QgOiBjb3B5T2ZGbG9hdGluZ09iamVjdHMpCisgICAgICAgICAg ICAgICAgZmxvYXRpbmdPYmplY3QtPnJlbmRlcmVyKCkucmVtb3ZlRmxvYXRpbmdPclBvc2l0aW9u ZWRDaGlsZEZyb21CbG9ja0xpc3RzKCk7CisgICAgICAgIH07CisgICAgICAgIHJlbW92ZUZsb2F0 aW5nT2JqZWN0c0lmQXBwbGljYWJsZSgpOwogICAgIH0KIAogICAgIEFTU0VSVCghYmVmb3JlQ2hp bGQgfHwgJnRvID09IGJlZm9yZUNoaWxkLT5wYXJlbnQoKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTU1MjliYWI3ZGQz M2U0NzZhOWNjOWNjYzY0ODk0NDBhMjY1MTA4MC4uNGRjZTMzNmUwMDA3YjI1ZTY5YjI5MTRmZWM0 OTRjMWU3MGUyOTI3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTIzICBaYWxhbiBC dWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVyXSBT dWJ0cmVlIG1vdmluZyBzaG91bGQgY2xlYXIgdGhlIGZsb2F0cyBvbiBhbGwgdGhlIGRlc2NlbmRh bnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5 OTYKKyAgICAgICAgPHJkYXI6Ly83NjgzNzMyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbXVsdGljb2wvZmxvYXRpbmctYm94ZXMtbW92 ZWQtdW5kZXItbXVsdGktY29sdW1uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC9tdWx0aWNvbC9mbG9hdGluZy1ib3hlcy1tb3ZlZC11bmRlci1tdWx0aS1jb2x1bW4uaHRtbDog QWRkZWQuCisKIDIwMjEtMDQtMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbUmVuZGVyVHJlZUJ1aWxkZXJdIE11bHRpLWNvbHVtbiBzcGFubmVycyBhcmUgbm90 IHBhcnQgb2YgdGhlIGVuY2xvc2luZyBtdWx0aS1jb2x1bW4gcmVuZGVyZXIncyBzdWJ0cmVlCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVzLW1vdmVk LXVuZGVyLW11bHRpLWNvbHVtbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L211bHRp Y29sL2Zsb2F0aW5nLWJveGVzLW1vdmVkLXVuZGVyLW11bHRpLWNvbHVtbi1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOGIxMzc4OTE3OTFmZTk2OTI3YWQ3OGU2NGIwYWFkN2JkZWQwOGJkYwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvZmxvYXRpbmctYm94ZXMt bW92ZWQtdW5kZXItbXVsdGktY29sdW1uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvZmxvYXRpbmctYm94ZXMtbW92ZWQt dW5kZXItbXVsdGktY29sdW1uLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0 aW5nLWJveGVzLW1vdmVkLXVuZGVyLW11bHRpLWNvbHVtbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNjODFi MGE3OTkwZGRhNmJjNWVhMTA4MTQ3ODZlNDI1YWM5YzRhYWEKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVzLW1vdmVkLXVuZGVyLW11bHRp LWNvbHVtbi5odG1sCkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgor ICA6Zm9jdXMtd2l0aGluIHsKKyAgICBjb2x1bW4td2lkdGg6IDFweDsKKyAgICB3aWR0aDogMDsK KyAgfQorICA6bnRoLWxhc3QtY2hpbGQoMykgeworICAgIG1hcmdpbi1ibG9jay1lbmQ6IDFweDsK KyAgICBmbG9hdDogcmlnaHQ7CisgIH0KKyAgOm50aC1sYXN0LWNoaWxkKDMpOjpmaXJzdC1sZXR0 ZXIgeworICAgIGJhY2tncm91bmQ6IGdyZXk7CisgIH0KKzwvc3R5bGU+Cis8c2NyaXB0PgorICBp ZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgIAor ICBvbmxvYWQgPSAoKSA9PiB7CisgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCdzcGFuJykpOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQo ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2JykpOworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc3BhbicpKTsKKyAgICBkb2N1bWVudC5kZXNp Z25Nb2RlID0gJ29uJzsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnU2VsZWN0QWxsJyk7Cisg ICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYn KSk7CisgIH07Cis8L3NjcmlwdD4KKzxib2R5PgorPC9ib2R5Pgo= 426979 2021-04-24 06:40:07 -0700 2021-04-24 06:42:14 -0700 [fast-cq] Patch bug-224996-20210424064007.patch text/plain 6252 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVjYmU3ZGZlZGFkMzA1 ZDM4YzhmZjk4YWFiZTdkMmI2OWJkMDllNi4uMjk2MjNmYWRmZjk0OTVmZDg4NGY3ZWZhZWY0NTdk ZTQ5MGIyODg1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDIxLTA0LTIzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVy XSBTdWJ0cmVlIG1vdmluZyBzaG91bGQgY2xlYXIgdGhlIGZsb2F0cyBvbiBhbGwgdGhlIGRlc2Nl bmRhbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjQ5OTYKKyAgICAgICAgPHJkYXI6Ly83NjgzNzMyMD4KKworICAgICAgICBSZXZpZXdlZCBieSBB bnR0aSBLb2l2aXN0by4KKworICAgICAgICBXaGlsZSBtb3ZpbmcgYSBzdWJ0cmVlLCB3ZSBpbnZh bGlkYXRlIHRoZSBmbG9hdGluZyBvYmplY3QgbGlzdCBzbyB0aGF0IHdlIGRvbid0IGVuZCB1cCB3 aXRoIGluY29ycmVjdGx5IHBsYWNlZCBmbG9hdHMgKHRoZXknbGwgZ2V0IHJlZ2VuZXJhdGVkIGR1 cmluZyB0aGUgc3Vic2VxdWVudCBsYXlvdXQpLgorICAgICAgICBBIGZsb2F0IGNhbiBiZSAiYXNz aWduZWQiIHRvIG1vcmUgdGhhbiBvbmUgUmVuZGVyQmxvY2tGbG93IChlLmcgaW50cnVkaW5nIGZs b2F0cykuIEl0J3MgdmVyeSBjb21tb24gdGhhdCBhIHNldCBvZiBkZXNjZW5kYW50IFJlbmRlckJs b2NrRmxvdworICAgICAgICByZW5kZXJlcnMgInNlZSIgdGhlIHNhbWUgc2V0IG9mIGZsb2F0cyAo ZWFjaCBSZW5kZXJCbG9ja0Zsb3cgaGFzIGl0cyBvd24gbGlzdCBvZiBmbG9hdGluZyBvYmplY3Rz KS4KKyAgICAgICAgTm93IHRoZSBpbnZhbGlkYXRpb24gaXMgYmFzZWQgb24gYW5jZXN0b3ItdG8t ZGVzY2VuZGFudCBkaXJlY3Rpb24gc3RhcnRpbmcgd2l0aCBmaW5kaW5nIHRoZSBvdXRlciBtb3N0 IGNvbnRhaW5pbmcgYmxvY2sgZm9yIGEgcGFydGljdWxhciBmbG9hdCAoc2VlIG91dGVybW9zdEJs b2NrQ29udGFpbmluZ0Zsb2F0aW5nT2JqZWN0KQorICAgICAgICBUaGUgaW52YWxpZGF0aW9uIGxv Z2ljIGFsc28gZXhwZWN0cyBubyBnYXBzIGluIHRoZSBhbmNlc3RvciBjaGFpbiBlLmcuCisKKyAg ICAgICAgICAgUmVuZGVyQmxvY2tGbG93IChBKSAtPiBmbG9hdCBYCisgICAgICAgICAgICAgUmVu ZGVyQmxvY2tGbG93IChCKSAtPiBmbG9hdCBYCisgICAgICAgICAgICAgICBSZW5kZXJCbG9ja0Zs b3cgKEMpIC0+IGZsb2F0IFgKKyAgICAgICAgICAgaWYgZmxvYXQgWCBpcyBhc3NpZ25lZCB0byBi b3RoIEEgYW5kIEMsIHRoZW4gaXQgbXVzdCBiZSBhc3NpZ25lZCB0byBCIGFzIHdlbGwuCisKKyAg ICAgICAgUmVuZGVyQmxvY2tGbG93OjpyZW1vdmVGbG9hdGluZ09iamVjdHMoKSBzaW1wbHkgcmVt b3ZlcyB0aGUgZmxvYXQgZnJvbSB0aGUgcmVuZGVyZXIuIEl0IGRvZXMgbm90IGludmFsaWRhdGUg dGhlIGFuY2VzdG9yL2Rlc2NlbmRhbnQgY2hhaW4uCisgICAgICAgIGUuZy4gY2FsbGluZyBCLnJl bW92ZUZsb2F0aW5nT2JqZWN0cygpIHdvdWxkIGp1c3QgcmVtb3ZlIGZsb2F0IFggZnJvbSBSZW5k ZXJCbG9ja0Zsb3cgKEIpCisKKyAgICAgICAgICAgUmVuZGVyQmxvY2tGbG93IChBKSAtPiBmbG9h dCBYCisgICAgICAgICAgICAgUmVuZGVyQmxvY2tGbG93IChCKQorICAgICAgICAgICAgICAgUmVu ZGVyQmxvY2tGbG93IChDKSAtPiBmbG9hdCBYCisKKyAgICAgICAgYW5kIGFueSBzdWJzZXF1ZW50 IGludmFsaWRhdGlvbiBhdHRlbXB0IHdvdWxkIGZhaWwgdG8gY2xlYXIgdXAgQSBvciBDIChkZXBl bmRpbmcgb24gd2hldGhlciBpdCBpcyBpbml0aWF0ZWQgb24gQSBvciBDKS4KKworICAgICAgICBU ZXN0OiBmYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVzLW1vdmVkLXVuZGVyLW11bHRpLWNvbHVt bi5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxkZXI6Om1vdmVDaGlsZHJlbik6 CisKIDIwMjEtMDQtMjIgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbUmVuZGVyVHJlZUJ1aWxkZXJdIE11bHRpLWNvbHVtbiBzcGFubmVycyBhcmUgbm90IHBhcnQg b2YgdGhlIGVuY2xvc2luZyBtdWx0aS1jb2x1bW4gcmVuZGVyZXIncyBzdWJ0cmVlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy LmNwcAppbmRleCA4MmEyYmJmMDg5ZWJmYzY5NmZlZDQyNjY1NjczMGI3OTgzMTU1YjE2Li43MTVk NDg0OWQzZTVmOThjMWE5MDUyODYwMTViY2I1YzUzZWYxMWVhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAg LTUzMSw4ICs1MzEsMjIgQEAgdm9pZCBSZW5kZXJUcmVlQnVpbGRlcjo6bW92ZUNoaWxkcmVuKFJl bmRlckJveE1vZGVsT2JqZWN0JiBmcm9tLCBSZW5kZXJCb3hNb2RlbE8KICAgICAvLyBvciB3aGVu IGZ1bGxSZW1vdmVJbnNlcnQgaXMgZmFsc2UuCiAgICAgaWYgKG5vcm1hbGl6ZUFmdGVySW5zZXJ0 aW9uID09IE5vcm1hbGl6ZUFmdGVySW5zZXJ0aW9uOjpZZXMgJiYgaXM8UmVuZGVyQmxvY2s+KGZy b20pKSB7CiAgICAgICAgIGRvd25jYXN0PFJlbmRlckJsb2NrPihmcm9tKS5yZW1vdmVQb3NpdGlv bmVkT2JqZWN0cyhudWxscHRyKTsKLSAgICAgICAgaWYgKGlzPFJlbmRlckJsb2NrRmxvdz4oZnJv bSkpCi0gICAgICAgICAgICBkb3duY2FzdDxSZW5kZXJCbG9ja0Zsb3c+KGZyb20pLnJlbW92ZUZs b2F0aW5nT2JqZWN0cygpOworICAgICAgICBhdXRvIHJlbW92ZUZsb2F0aW5nT2JqZWN0c0lmQXBw bGljYWJsZSA9IFsmXSB7CisgICAgICAgICAgICBpZiAoZnJvbS5yZW5kZXJUcmVlQmVpbmdEZXN0 cm95ZWQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICBpZiAoIWlzPFJl bmRlckJsb2NrRmxvdz4oZnJvbSkpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgYXV0byogZmxvYXRpbmdPYmplY3RzID0gZG93bmNhc3Q8UmVuZGVyQmxvY2tGbG93Pihmcm9t KS5mbG9hdGluZ09iamVjdFNldCgpOworICAgICAgICAgICAgaWYgKCFmbG9hdGluZ09iamVjdHMp CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgLy8gSGVyZSB3ZSByZW1vdmUg dGhlIGZsb2F0aW5nIG9iamVjdHMgZnJvbSB0aGUgZGVzY2VuZGFudHMgYXMgd2VsbC4KKyAgICAg ICAgICAgIGF1dG8gY29weU9mRmxvYXRpbmdPYmplY3RzID0gV1RGOjptYXAoKmZsb2F0aW5nT2Jq ZWN0cywgW10oYXV0byYgZmxvYXRpbmdPYmplY3QpIHsgCisgICAgICAgICAgICAgICAgcmV0dXJu IGZsb2F0aW5nT2JqZWN0LmdldCgpOworICAgICAgICAgICAgfSk7CisgICAgICAgICAgICBmb3Ig KGF1dG8qIGZsb2F0aW5nT2JqZWN0IDogY29weU9mRmxvYXRpbmdPYmplY3RzKQorICAgICAgICAg ICAgICAgIGZsb2F0aW5nT2JqZWN0LT5yZW5kZXJlcigpLnJlbW92ZUZsb2F0aW5nT3JQb3NpdGlv bmVkQ2hpbGRGcm9tQmxvY2tMaXN0cygpOworICAgICAgICB9OworICAgICAgICByZW1vdmVGbG9h dGluZ09iamVjdHNJZkFwcGxpY2FibGUoKTsKICAgICB9CiAKICAgICBBU1NFUlQoIWJlZm9yZUNo aWxkIHx8ICZ0byA9PSBiZWZvcmVDaGlsZC0+cGFyZW50KCkpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU1NTI5YmFiN2Rk MzNlNDc2YTljYzljY2M2NDg5NDQwYTI2NTEwODAuLmQ2NTRmZDg4YTNkZTJhNzdjZDNkZGU0Nzky ZmQ4ZjVmMDY2MDc5YTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wNC0yMyAgWmFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFtSZW5kZXJUcmVlQnVpbGRlcl0g U3VidHJlZSBtb3Zpbmcgc2hvdWxkIGNsZWFyIHRoZSBmbG9hdHMgb24gYWxsIHRoZSBkZXNjZW5k YW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0 OTk2CisgICAgICAgIDxyZGFyOi8vNzY4MzczMjA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50 dGkgS29pdmlzdG8uCisKKyAgICAgICAgKiBmYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVzLW1v dmVkLXVuZGVyLW11bHRpLWNvbHVtbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvbXVsdGljb2wvZmxvYXRpbmctYm94ZXMtbW92ZWQtdW5kZXItbXVsdGktY29sdW1uLmh0bWw6 IEFkZGVkLgorCiAyMDIxLTA0LTIyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgW1JlbmRlclRyZWVCdWlsZGVyXSBNdWx0aS1jb2x1bW4gc3Bhbm5lcnMgYXJlIG5v dCBwYXJ0IG9mIHRoZSBlbmNsb3NpbmcgbXVsdGktY29sdW1uIHJlbmRlcmVyJ3Mgc3VidHJlZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9mbG9hdGluZy1ib3hlcy1tb3Zl ZC11bmRlci1tdWx0aS1jb2x1bW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9tdWx0 aWNvbC9mbG9hdGluZy1ib3hlcy1tb3ZlZC11bmRlci1tdWx0aS1jb2x1bW4tZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRiMGFhZDdiZGVkMDhiZGMKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVz LW1vdmVkLXVuZGVyLW11bHRpLWNvbHVtbi1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0aW5nLWJveGVzLW1vdmVk LXVuZGVyLW11bHRpLWNvbHVtbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9mbG9h dGluZy1ib3hlcy1tb3ZlZC11bmRlci1tdWx0aS1jb2x1bW4uaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jYzgx YjBhNzk5MGRkYTZiYzVlYTEwODE0Nzg2ZTQyNWFjOWM0YWFhCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9mbG9hdGluZy1ib3hlcy1tb3ZlZC11bmRlci1tdWx0 aS1jb2x1bW4uaHRtbApAQCAtMCwwICsxLDI5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4K KyAgOmZvY3VzLXdpdGhpbiB7CisgICAgY29sdW1uLXdpZHRoOiAxcHg7CisgICAgd2lkdGg6IDA7 CisgIH0KKyAgOm50aC1sYXN0LWNoaWxkKDMpIHsKKyAgICBtYXJnaW4tYmxvY2stZW5kOiAxcHg7 CisgICAgZmxvYXQ6IHJpZ2h0OworICB9CisgIDpudGgtbGFzdC1jaGlsZCgzKTo6Zmlyc3QtbGV0 dGVyIHsKKyAgICBiYWNrZ3JvdW5kOiBncmV5OworICB9Cis8L3N0eWxlPgorPHNjcmlwdD4KKyAg aWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAK KyAgb25sb2FkID0gKCkgPT4geworICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnc3BhbicpKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxk KGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NwYW4nKSk7CisgICAgZG9jdW1lbnQuZGVz aWduTW9kZSA9ICdvbic7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ1NlbGVjdEFsbCcpOwor ICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2 JykpOworICB9OworPC9zY3JpcHQ+Cis8Ym9keT4KKzwvYm9keT4K