224991 2021-04-23 13:25:24 -0700 [Metal ANGLE] Temporarily remove AST validation even for debug builds 2021-04-25 12:16:34 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 johncunningham webkit-unassigned dino ews-watchlist graouts kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1753701 0 johncunningham 2021-04-23 13:25:24 -0700 [Metal ANGLE] Temporarily remove AST validation even for debug builds 1753702 1 426937 johncunningham 2021-04-23 13:26:34 -0700 Created attachment 426937 Patch 1753703 2 johncunningham 2021-04-23 13:26:37 -0700 <rdar://problem/76299178> 1753704 3 ews-watchlist 2021-04-23 13:27:22 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1753710 4 kbr 2021-04-23 13:59:43 -0700 Could you please provide a description in this bug of why this is being done, and how temporarily this is being removed? 1753716 5 johncunningham 2021-04-23 14:08:36 -0700 Sure thing. We are seeing significant slow downs inside of the validateAST calls on debug builds leading to test timeouts. There are a significant number of transform passes as a part of the GLSL AST -> MSL translation, and currently each pass is validating the AST. Theses were mainly in place during development of the translator, and the correct fix is to move the validation to the very end after all of the transformations happen. To unblock further testing, we'd like to land this stopgap to run all of the debug testing, until we land the more correct fix (hopefully within the next few days.) 1753717 6 426937 kbr 2021-04-23 14:09:44 -0700 Comment on attachment 426937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426937&action=review Thanks for the explanation. r+ > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm:88 > +#if defined(ANGLE_ENABLE_ASSERTS) && 0 Please add some TODO here regarding moving this validation in the future so we don't forget it. 1753721 7 426942 johncunningham 2021-04-23 14:15:32 -0700 Created attachment 426942 Patch 1753723 8 426942 kbr 2021-04-23 14:16:31 -0700 Comment on attachment 426942 Patch Thanks, still looks good. r+ again 1754037 9 ews-feeder 2021-04-25 12:16:33 -0700 Committed r276568 (237004@main): <https://commits.webkit.org/237004@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426942. 426937 2021-04-23 13:26:34 -0700 2021-04-23 14:15:30 -0700 Patch bug-224991-20210423132634.patch text/plain 1416 johncunningham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZmYyMGZlY2Q0NTAxZmE3YTlmODQxN2Y0M2FhZDdiMGRlMmIxMTljNS4uZDA1NmY3MDFjNGVh NTNhZWM3ZTdmY2ZkNzAyNjUyZDE1YmExZWI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTIzICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vu bmluZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW01ldGFsIEFOR0xFXSBUZW1wb3JhcmlseSBy ZW1vdmUgQVNUIHZhbGlkYXRpb24gZXZlbiBmb3IgZGVidWcgYnVpbGRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5OTEKKyAgICAgICAgcmRhcjov Lzc2Mjk5MTc4CisgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbToKKyAgICAgICAg KHJ4OjpTaGFkZXJNdGw6OmNvbXBpbGVJbXBsTXRsKToKKwogMjAyMS0wNC0yMyAgVHJ1aXR0IFNh dmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGlu ZyByMjc2MTkwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFO R0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9TaGFkZXJNdGwubW0KaW5kZXggYWNkZTc2MDA1 MzliYTc0MWVlYzRhZThmMTJjMWVkYzY2MWQwNjIxMS4uYjEzYzYzNjhiMjhjMWViMmZjOTU2ZDg0 MzRiN2QxZmQxY2UxOTNlOSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvU2hhZGVyTXRsLm1tCkBAIC04 NSw3ICs4NSw3IEBAIHN0ZDo6c2hhcmVkX3B0cjxXYWl0YWJsZUNvbXBpbGVFdmVudD4gU2hhZGVy TXRsOjpjb21waWxlSW1wbE10bCgKICAgICBjb25zdCBzdGQ6OnN0cmluZyAmc291cmNlLAogICAg IFNoQ29tcGlsZU9wdGlvbnMgY29tcGlsZU9wdGlvbnMpCiB7Ci0jaWYgZGVmaW5lZChBTkdMRV9F TkFCTEVfQVNTRVJUUykKKyNpZiBkZWZpbmVkKEFOR0xFX0VOQUJMRV9BU1NFUlRTKSAmJiAwCiAg ICAgY29tcGlsZU9wdGlvbnMgfD0gU0hfVkFMSURBVEVfQVNUOwogI2VuZGlmCiAK 426942 2021-04-23 14:15:32 -0700 2021-04-25 12:16:33 -0700 Patch bug-224991-20210423141532.patch text/plain 1583 johncunningham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZmYyMGZlY2Q0NTAxZmE3YTlmODQxN2Y0M2FhZDdiMGRlMmIxMTljNS4uZDA1NmY3MDFjNGVh NTNhZWM3ZTdmY2ZkNzAyNjUyZDE1YmExZWI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTIzICBKb2huIEN1bm5pbmdoYW0gIDxqb2huY3Vu bmluZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW01ldGFsIEFOR0xFXSBUZW1wb3JhcmlseSBy ZW1vdmUgQVNUIHZhbGlkYXRpb24gZXZlbiBmb3IgZGVidWcgYnVpbGRzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5OTEKKyAgICAgICAgcmRhcjov Lzc2Mjk5MTc4CisgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbToKKyAgICAgICAg KHJ4OjpTaGFkZXJNdGw6OmNvbXBpbGVJbXBsTXRsKToKKwogMjAyMS0wNC0yMyAgVHJ1aXR0IFNh dmVsbCAgPHRzYXZlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGlu ZyByMjc2MTkwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFO R0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9TaGFkZXJNdGwubW0KaW5kZXggYWNkZTc2MDA1 MzliYTc0MWVlYzRhZThmMTJjMWVkYzY2MWQwNjIxMS4uY2U1OGY5ZDJhNTY4MTE1NDIwNjc4MTk5 OWY4MzQ1ODFhMWIzY2RmZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL1NoYWRlck10bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvU2hhZGVyTXRsLm1tCkBAIC04 NSw3ICs4NSw5IEBAIHN0ZDo6c2hhcmVkX3B0cjxXYWl0YWJsZUNvbXBpbGVFdmVudD4gU2hhZGVy TXRsOjpjb21waWxlSW1wbE10bCgKICAgICBjb25zdCBzdGQ6OnN0cmluZyAmc291cmNlLAogICAg IFNoQ29tcGlsZU9wdGlvbnMgY29tcGlsZU9wdGlvbnMpCiB7Ci0jaWYgZGVmaW5lZChBTkdMRV9F TkFCTEVfQVNTRVJUUykKKy8vIFRPRE8oamN1bm5pbmdoYW0pOiBSZW1vdmUgdGhpcyB3b3JrYXJv dW5kIG9uY2UgY29ycmVjdCBmaXggdG8gbW92ZSB2YWxpZGF0aW9uIHRvIHRoZSB2ZXJ5IGVuZCBp cyBpbiBwbGFjZS4KKy8vIFNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNDk5MQorI2lmIGRlZmluZWQoQU5HTEVfRU5BQkxFX0FTU0VSVFMpICYmIDAKICAgICBj b21waWxlT3B0aW9ucyB8PSBTSF9WQUxJREFURV9BU1Q7CiAjZW5kaWYKIAo=