224973 2021-04-23 07:04:31 -0700 REGRESSION(r276486): broke windows build 2021-04-24 15:03:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224964 1 commit-queue commit-queue aakash_jain fujii ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1753564 0 commit-queue 2021-04-23 07:04:31 -0700 https://trac.webkit.org/changeset/276486 broke the build: broke windows build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1753566 1 426903 commit-queue 2021-04-23 07:04:38 -0700 Created attachment 426903 REVERT of r276486 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1753569 2 aakash_jain 2021-04-23 07:07:41 -0700 *** Bug 224974 has been marked as a duplicate of this bug. *** 1753570 3 ews-feeder 2021-04-23 07:07:56 -0700 Committed r276496 (236955@main): <https://commits.webkit.org/236955@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426903. 1753904 4 webkit-bug-importer 2021-04-24 15:03:20 -0700 <rdar://problem/77110032> 426903 2021-04-23 07:04:38 -0700 2021-04-23 07:07:57 -0700 REVERT of r276486 bug-224973-20210423140437.patch text/plain 4382 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YmJmZmY0M2IwODcyMjY0NDhmYjQzYTlkMzk0ZTAwOThmNWQ3NTJmLi45MTMzMGQyMzZhMjljN2Y1 NzQ0NWIyMjU1NGE5ZjUwYjY5ODNhODU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMS0wNC0yMyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzY0ODYuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5NzMKKworICAgICAg ICBicm9rZSB3aW5kb3dzIGJ1aWxkCisKKyAgICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorCisg ICAgICAgICJbSlNDXVtXaW5dIGNhbGxPcGVyYXRpb25Ob0V4Y2VwdGlvbkNoZWNrKCkgYWxzbyBu ZWVkcyB0bworICAgICAgICBzdXBwb3J0IG9wZXJhdGlvbnMgdGhhdCByZXR1cm4gU2xvd1BhdGhS ZXR1cm5UeXBlIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI0OTY0CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNzY0 ODYKKwogMjAyMS0wNC0yMiAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNv bT4KIAogICAgICAgICBbSlNDXVtXaW5dIGNhbGxPcGVyYXRpb25Ob0V4Y2VwdGlvbkNoZWNrKCkg YWxzbyBuZWVkcyB0byBzdXBwb3J0IG9wZXJhdGlvbnMgdGhhdCByZXR1cm4gU2xvd1BhdGhSZXR1 cm5UeXBlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuaAppbmRleCA3OTA1NTEwYjhkMzM3MmNjYmE4N2Nm OWQ0ZTE4OWZjNDEwNDIzYjI2Li5lNTNmNTUxODAwMGEyNDYwOTUzNjZmM2ZkZjhkYWMwOGJjNjY2 MzQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmgKQEAgLTgyNCwxOCArODI0LDMyIEBAIG5hbWVz cGFjZSBKU0MgewogICAgICAgICB9CiAKICNpZiBPUyhXSU5ET1dTKSAmJiBDUFUoWDg2XzY0KQot ICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUeXBlPiBzdGF0aWMgY29uc3RleHByIGJvb2wgaXM2 NEJpdFR5cGUgPSBzaXplb2YoVHlwZSkgPD0gODsKLSAgICAgICAgdGVtcGxhdGU8PiBzdGF0aWMg Y29uc3RleHByIGJvb2wgaXM2NEJpdFR5cGU8dm9pZD4gPSB0cnVlOwotCiAgICAgICAgIHRlbXBs YXRlPHR5cGVuYW1lIE9wZXJhdGlvblR5cGUsIHR5cGVuYW1lLi4uIEFyZ3M+Ci0gICAgICAgIE1h Y3JvQXNzZW1ibGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oT3BlcmF0aW9uVHlwZSBvcGVyYXRpb24s IEFyZ3MuLi4gYXJncykKKyAgICAgICAgc3RkOjplbmFibGVfaWZfdDxzdGQ6OmlzX3NhbWU8dHlw ZW5hbWUgRnVuY3Rpb25UcmFpdHM8T3BlcmF0aW9uVHlwZT46OlJlc3VsdFR5cGUsIFNsb3dQYXRo UmV0dXJuVHlwZT46OnZhbHVlLCBNYWNyb0Fzc2VtYmxlcjo6Q2FsbD4KKyAgICAgICAgY2FsbE9w ZXJhdGlvbihPcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgQXJncy4uLiBhcmdzKQogICAgICAgICB7 CiAgICAgICAgICAgICBzZXR1cEFyZ3VtZW50czxPcGVyYXRpb25UeXBlPihhcmdzLi4uKTsKLSAg ICAgICAgICAgIC8vIHg2NCBXaW5kb3dzIGNhbm5vdCB1c2Ugc3RhbmRhcmQgY2FsbCB3aGVuIHRo ZSByZXR1cm4gdHlwZSBpcyBsYXJnZXIgdGhhbiA2NCBiaXRzLgotICAgICAgICAgICAgaWYgY29u c3RleHByIChpczY0Qml0VHlwZTx0eXBlbmFtZSBGdW5jdGlvblRyYWl0czxPcGVyYXRpb25UeXBl Pjo6UmVzdWx0VHlwZT4pCi0gICAgICAgICAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxXaXRoRXhj ZXB0aW9uQ2hlY2sob3BlcmF0aW9uKTsKICAgICAgICAgICAgIHJldHVybiBhcHBlbmRDYWxsV2l0 aEV4Y2VwdGlvbkNoZWNrQW5kU2xvd1BhdGhSZXR1cm5UeXBlKG9wZXJhdGlvbik7CiAgICAgICAg IH0KKworICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUeXBlPgorICAgICAgICBzdHJ1Y3QgaXM2 NEJpdFR5cGUgeworICAgICAgICAgICAgc3RhdGljIGNvbnN0ZXhwciBib29sIHZhbHVlID0gc2l6 ZW9mKFR5cGUpIDw9IDg7CisgICAgICAgIH07CisKKyAgICAgICAgdGVtcGxhdGU8PgorICAgICAg ICBzdHJ1Y3QgaXM2NEJpdFR5cGU8dm9pZD4geworICAgICAgICAgICAgc3RhdGljIGNvbnN0ZXhw ciBib29sIHZhbHVlID0gdHJ1ZTsKKyAgICAgICAgfTsKKworICAgICAgICB0ZW1wbGF0ZTx0eXBl bmFtZSBPcGVyYXRpb25UeXBlLCB0eXBlbmFtZS4uLiBBcmdzPgorICAgICAgICBzdGQ6OmVuYWJs ZV9pZl90PCFzdGQ6OmlzX3NhbWU8dHlwZW5hbWUgRnVuY3Rpb25UcmFpdHM8T3BlcmF0aW9uVHlw ZT46OlJlc3VsdFR5cGUsIFNsb3dQYXRoUmV0dXJuVHlwZT46OnZhbHVlLCBNYWNyb0Fzc2VtYmxl cjo6Q2FsbD4KKyAgICAgICAgY2FsbE9wZXJhdGlvbihPcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwg QXJncy4uLiBhcmdzKQorICAgICAgICB7CisgICAgICAgICAgICBzdGF0aWNfYXNzZXJ0KGlzNjRC aXRUeXBlPHR5cGVuYW1lIEZ1bmN0aW9uVHJhaXRzPE9wZXJhdGlvblR5cGU+OjpSZXN1bHRUeXBl Pjo6dmFsdWUsICJXaW42NCBjYW5ub3QgdXNlIHN0YW5kYXJkIGNhbGwgd2hlbiByZXR1cm4gdHlw ZSBpcyBsYXJnZXIgdGhhbiA2NCBiaXRzLiIpOworICAgICAgICAgICAgc2V0dXBBcmd1bWVudHM8 T3BlcmF0aW9uVHlwZT4oYXJncy4uLik7CisgICAgICAgICAgICByZXR1cm4gYXBwZW5kQ2FsbFdp dGhFeGNlcHRpb25DaGVjayhvcGVyYXRpb24pOworICAgICAgICB9CiAjZWxzZSAvLyBPUyhXSU5E T1dTKSAmJiBDUFUoWDg2XzY0KQogICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBPcGVyYXRpb25U eXBlLCB0eXBlbmFtZS4uLiBBcmdzPgogICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6Q2FsbCBjYWxs T3BlcmF0aW9uKE9wZXJhdGlvblR5cGUgb3BlcmF0aW9uLCBBcmdzLi4uIGFyZ3MpCkBAIC04NjIs MTggKzg3Niw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgcmV0dXJuIHJlc3VsdDsK ICAgICAgICAgfQogCi0jaWYgT1MoV0lORE9XUykgJiYgQ1BVKFg4Nl82NCkKLSAgICAgICAgdGVt cGxhdGU8dHlwZW5hbWUgT3BlcmF0aW9uVHlwZSwgdHlwZW5hbWUuLi4gQXJncz4KLSAgICAgICAg TWFjcm9Bc3NlbWJsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbk5vRXhjZXB0aW9uQ2hlY2soT3BlcmF0 aW9uVHlwZSBvcGVyYXRpb24sIEFyZ3MuLi4gYXJncykKLSAgICAgICAgewotICAgICAgICAgICAg c2V0dXBBcmd1bWVudHM8T3BlcmF0aW9uVHlwZT4oYXJncy4uLik7Ci0gICAgICAgICAgICB1cGRh dGVUb3BDYWxsRnJhbWUoKTsKLSAgICAgICAgICAgIC8vIHg2NCBXaW5kb3dzIGNhbm5vdCB1c2Ug c3RhbmRhcmQgY2FsbCB3aGVuIHRoZSByZXR1cm4gdHlwZSBpcyBsYXJnZXIgdGhhbiA2NCBiaXRz LgotICAgICAgICAgICAgaWYgY29uc3RleHByIChpczY0Qml0VHlwZTx0eXBlbmFtZSBGdW5jdGlv blRyYWl0czxPcGVyYXRpb25UeXBlPjo6UmVzdWx0VHlwZT4pCi0gICAgICAgICAgICAgICAgcmV0 dXJuIGFwcGVuZENhbGwob3BlcmF0aW9uKTsKLSAgICAgICAgICAgIHJldHVybiBhcHBlbmRDYWxs V2l0aFNsb3dQYXRoUmV0dXJuVHlwZShvcGVyYXRpb24pOwotICAgICAgICB9Ci0jZWxzZQogICAg ICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBPcGVyYXRpb25UeXBlLCB0eXBlbmFtZS4uLiBBcmdzPgog ICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6Q2FsbCBjYWxsT3BlcmF0aW9uTm9FeGNlcHRpb25DaGVj ayhPcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgQXJncy4uLiBhcmdzKQogICAgICAgICB7CkBAIC04 ODEsNyArODgzLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAgICB1cGRhdGVUb3BDYWxs RnJhbWUoKTsKICAgICAgICAgICAgIHJldHVybiBhcHBlbmRDYWxsKG9wZXJhdGlvbik7CiAgICAg ICAgIH0KLSNlbmRpZiAvLyBPUyhXSU5ET1dTKSAmJiBDUFUoWDg2XzY0KQogCiAgICAgICAgIHRl bXBsYXRlPHR5cGVuYW1lIE9wZXJhdGlvblR5cGUsIHR5cGVuYW1lLi4uIEFyZ3M+CiAgICAgICAg IE1hY3JvQXNzZW1ibGVyOjpDYWxsIGNhbGxPcGVyYXRpb25XaXRoQ2FsbEZyYW1lUm9sbGJhY2tP bkV4Y2VwdGlvbihPcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgQXJncy4uLiBhcmdzKQo=