224967 2021-04-22 20:15:17 -0700 [GTK] REGRESSION(r276448): imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html is failing 2022-01-02 21:42:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225659 InRadar P2 Normal --- 1 dpino dpino bugs-noreply cgarcia mrobinson rego webkit-bug-importer oldest_to_newest 1753446 0 dpino 2021-04-22 20:15:17 -0700 The test became a failure after r276448: https://results.webkit.org/?platform=GTK&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fselectors%2Ffocus-visible-002.html https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r276464%20%281341%29/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-diff.txt --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-actual.txt @@ -26,10 +26,10 @@ PASS Focus element INPUT#input6 via mouse should match :focus-visible as it supports keyboard input PASS Focus element INPUT#input7 via mouse should match :focus-visible as it supports keyboard input PASS Focus element INPUT#input8 via mouse should match :focus-visible as it supports keyboard input -PASS Focus element INPUT#input9 via mouse should match :focus-visible as it supports keyboard input -PASS Focus element INPUT#input10 via mouse should match :focus-visible as it supports keyboard input -PASS Focus element INPUT#input11 via mouse should match :focus-visible as it supports keyboard input -PASS Focus element INPUT#input12 via mouse should match :focus-visible as it supports keyboard input -PASS Focus element INPUT#input13 via mouse should match :focus-visible as it supports keyboard input +FAIL Focus element INPUT#input9 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input9 should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" +FAIL Focus element INPUT#input10 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input10 should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" +FAIL Focus element INPUT#input11 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input11 should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" +FAIL Focus element INPUT#input12 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input12 should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" +FAIL Focus element INPUT#input13 via mouse should match :focus-visible as it supports keyboard input assert_equals: outlineColor for INPUT#input13 should be green expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)" PASS Focus element TEXTAREA#input14 via mouse should match :focus-visible as it supports keyboard input The tests that are failing are related with input=date. r276448 turned on editable input=date for GTK. Perhaps it's enough with updating the test baseline to the new results. 1753546 1 rego 2021-04-23 03:39:09 -0700 I've been checking this, there's a kind of weird thing. For example if we have 2 inputs: <input> <input type="date"> If we focus the first one we see a blue outline, but not in the 2nd one, and as we don't have a date picker so far, it looks like we should. Now Element::isTextField() is false, and that's why we're not matching :focus-visible in Element::focus(). Anyway if we have plans to implement the date picker maybe current behavior is not a big deal and we can just update the -expected results. Otherwise we might want to do some other change. Dunno really. 1758846 2 dpino 2021-05-11 01:22:24 -0700 This test is now crashing since r277262. r277261 TEXT (Expected: FAIL) [r277262-r277264] CRASH (Expected: FAIL) [r277265-r277267] UNKNOWN Craslog: https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/r277315%20(1048)/imported/w3c/web-platform-tests/css/selectors/focus-visible-002-crash-log.txt Program terminated with signal SIGSEGV, Segmentation fault. #0 g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x561af58003d0, fundamental_type=fundamental_type@entry=80) at ../gobject/gtype.c:4082 4082 node = lookup_type_node_I (type_instance->g_class->g_type); [Current thread is 1 (Thread 0x7f97210a2200 (LWP 14256))] Thread 1 (Thread 0x7f97210a2200 (LWP 14256)): #0 g_type_check_instance_is_fundamentally_a (type_instance=type_instance@entry=0x561af58003d0, fundamental_type=fundamental_type@entry=0x50 [GObject]) at ../gobject/gtype.c:4082 #1 0x00007f9722962e82 in g_object_ref (_object=_object@entry=0x561af58003d0) at ../gobject/gobject.c:3389 #2 0x00007f97243aaddd in gtk_window_real_set_focus (window=<optimized out>, focus=0x561af55ed080 [WebKitWebViewBase]) at ../gtk/gtkwindow.c:8711 #9 0x00007f97229779c3 in <emit signal ??? on instance 0x561af55ed080 [WebKitWebViewBase] or 0x561af5882a50 [GtkWindow]> (instance=instance@entry=0x561af55ed080, signal_id=<optimized out>, detail=detail@entry=0) at ../gobject/gsignal.c:3553 #3 0x00007f972295df3f in g_closure_invoke (closure=closure@entry=0x561af506cef0, return_value=return_value@entry=0x0, n_param_values=2, param_values=param_values@entry=0x7ffe4d3fbd70, invocation_hint=invocation_hint@entry=0x7ffe4d3fbcf0) at ../gobject/gclosure.c:810 #4 0x00007f9722970769 in signal_emit_unlocked_R (node=node@entry=0x561af505bb70, detail=detail@entry=0, instance=instance@entry=0x561af5882a50, emission_return=emission_return@entry=0x0, instance_and_params=instance_and_params@entry=0x7ffe4d3fbd70) at ../gobject/gsignal.c:3780 #5 0x00007f9722977861 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>, var_args=var_args@entry=0x7ffe4d3fbf10) at ../gobject/gsignal.c:3497 #6 0x00007f97229779c3 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at ../gobject/gsignal.c:3553 #7 0x00007f972295e179 in _g_closure_invoke_va (closure=closure@entry=0x561af506dc60, return_value=return_value@entry=0x0, instance=instance@entry=0x561af55ed080, args=args@entry=0x7ffe4d3fc1e0, n_params=0, param_types=0x0) at ../gobject/gclosure.c:873 #8 0x00007f97229777df in g_signal_emit_valist (instance=0x561af55ed080, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7ffe4d3fc1e0) at ../gobject/gsignal.c:3406 #10 0x00007f972439762a in gtk_widget_grab_focus (widget=0x561af55ed080 [WebKitWebViewBase]) at ../gtk/gtkwidget.c:8097 #11 0x00007f972bb596b0 in webkitWebViewBaseSynthesizeMouseEvent(_WebKitWebViewBase*, MouseEventType, unsigned int, unsigned short, int, int, unsigned int, int, WTF::String const&) (webViewBase=0x561af55ed080 [WebKitWebViewBase], type=MouseEventType::Press, button=1, buttons=256, x=96, y=444, modifiers=0, clickCount=1, pointerType=...) at ../../Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2726 1827619 3 448204 dpino 2022-01-02 21:34:03 -0800 Created attachment 448204 [fast-cq] Patch 1827620 4 dpino 2022-01-02 21:38:18 -0800 Crash was fixed by https://bugs.webkit.org/show_bug.cgi?id=225659. I'm emitting a new baseline for GTK. The test will start failing again once `<form type=date>` is implemented. 1827621 5 ews-feeder 2022-01-02 21:41:28 -0800 Committed r287528 (245663@main): <https://commits.webkit.org/245663@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 448204. 1827622 6 webkit-bug-importer 2022-01-02 21:42:18 -0800 <rdar://problem/87058536> 448204 2022-01-02 21:34:03 -0800 2022-01-02 21:41:30 -0800 [fast-cq] Patch bug-224967-20220103133359.patch text/plain 4843 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg3NTI3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGE1NmJkZDZmZjE3NWM3Yjg0YzMz YTU2ZDc5OTlkMjMxZmM0NjdjZS4uMGI2YjM1NjhlM2QwYjM3MWNmYTk4MzQ1YmNlZWExMDZkYThj ZjFmZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDExIEBACisyMDIyLTAxLTAyICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVW5yZXZpZXdlZCB0ZXN0IGdh cmRlbmluZywgZW1pdCBiYXNlbGluZSBmb3IgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9jc3Mvc2VsZWN0b3JzL2ZvY3VzLXZpc2libGUtMDAyLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDk2NworCisgICAgICAgICogcGxhdGZv cm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12aXNpYmxlLTAwMi1l eHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDIyLTAxLTAyICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRw aW5vQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dQRV0gW0RlYnVnXSBVbnJldmlld2VkIHRlc3Qg Z2FyZGVuaW5nLCByZW1vdmUgV2ViWFIgdGVzdHMgZmFpbHVyZXMgbm8gbG9uZ2VyIGNyYXNoaW5n CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDU1MDczMjFh ZmFhNDM1NGRhMTBmN2ZhMDc4OTVkNGNhNTcwYWJhOTQuLjRhYTU4ZWJjMWU5Zjc1ZDU2MDk5NGI1 YzNjNjM3OGEzNDEyNDRhMDggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9U ZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0 YXRpb25zCkBAIC05NTQsOCArOTU0LDYgQEAgd2Via2l0Lm9yZy9iLzIxOTYxNCBpbnNwZWN0b3Iv bW9kZWwvZm9udC1jYWxjdWxhdGUtcHJvcGVydGllcy5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMjI0NTkwIGZhc3QvdGV4dC9saW5lLWJyZWFrLWJldHdlZW4tdGV4dC1ub2Rlcy1sYXRp bjEuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIyNDU5MCBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtdGV4dC93b3JkLWJyZWFrL3dvcmQtYnJl YWstYnJlYWstYWxsLWlubGluZS0wMDcuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogCi13ZWJr aXQub3JnL2IvMjI0OTY3IHdlYmtpdC5vcmcvYi8yMjU2NTkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9jc3Mvc2VsZWN0b3JzL2ZvY3VzLXZpc2libGUtMDAyLmh0bWwgWyBDcmFzaCBG YWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIyOTM0NyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3Jt LXRlc3RzL2Nzcy9jc3MtdGV4dC9vdmVyZmxvdy13cmFwL292ZXJmbG93LXdyYXAtYW55d2hlcmUt MDA5Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMjkzNDcgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXRleHQvb3ZlcmZsb3ctd3JhcC9vdmVy Zmxvdy13cmFwLWFueXdoZXJlLTAxMC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMjI5MzQ3IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10ZXh0 L292ZXJmbG93LXdyYXAvb3ZlcmZsb3ctd3JhcC1hbnl3aGVyZS1pbmxpbmUtMDAxLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9zZWxlY3RvcnMvZm9jdXMtdmlzaWJs ZS0wMDItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL3NlbGVjdG9ycy9mb2N1cy12aXNpYmxlLTAwMi1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uZWRlMTlkZDU0YzNiYjUxMTk1MWRiZTE5NTgwN2Y0OGJhYzVi MTFkNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9zZWxlY3RvcnMvZm9jdXMtdmlzaWJsZS0wMDIt ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMzUgQEAKK1RoaXMgdGVzdCBjaGVja3MgdGhhdCA6Zm9j dXMtdmlzaWJsZSBhbHdheXMgbWF0Y2hlcyBvbiA8aW5wdXQ+IGVsZW1lbnRzIHdoaWNoIHRha2Ug dGV4dCBpbnB1dCwgcmVnYXJkbGVzcyBvZiBmb2N1cyBtZWNoYW5pc20uCitJZiB0aGUgdXNlci1h Z2VudCBkb2VzIG5vdCBjbGFpbSB0byBzdXBwb3J0IHRoZSA6Zm9jdXMtdmlzaWJsZSBwc2V1ZG8t Y2xhc3MgdGhlbiBTS0lQIHRoaXMgdGVzdC4KK0NsaWNrIGVhY2ggZm9ybSBlbGVtZW50IGJlbG93 IHRvIGZvY3VzIGl0LgorSWYgdGhlIGVsZW1lbnQgaGFzIGEgcmVkIGJhY2tncm91bmQsIHRoZW4g dGhlIHRlc3QgcmVzdWx0IGlzIEZBSUxVUkUuIElmIHRoZSBlbGVtZW50IGhhcyBhIGdyZWVuIG91 dGxpbmUsIHRoZW4gdGhlIHRlc3QgcmVzdWx0IGlzIFNVQ0NFU1MuCisKKworCisKKworCisKKwor CisKKworCisKKworCisKK1BBU1MgRm9jdXMgZWxlbWVudCBJTlBVVCNpbnB1dDEgdmlhIG1vdXNl IHNob3VsZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2FyZCBpbnB1 dAorUEFTUyBGb2N1cyBlbGVtZW50IElOUFVUI2lucHV0MiB2aWEgbW91c2Ugc2hvdWxkIG1hdGNo IDpmb2N1cy12aXNpYmxlIGFzIGl0IHN1cHBvcnRzIGtleWJvYXJkIGlucHV0CitQQVNTIEZvY3Vz IGVsZW1lbnQgSU5QVVQjaW5wdXQzIHZpYSBtb3VzZSBzaG91bGQgbWF0Y2ggOmZvY3VzLXZpc2li bGUgYXMgaXQgc3VwcG9ydHMga2V5Ym9hcmQgaW5wdXQKK1BBU1MgRm9jdXMgZWxlbWVudCBJTlBV VCNpbnB1dDQgdmlhIG1vdXNlIHNob3VsZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBzdXBw b3J0cyBrZXlib2FyZCBpbnB1dAorUEFTUyBGb2N1cyBlbGVtZW50IElOUFVUI2lucHV0NSB2aWEg bW91c2Ugc2hvdWxkIG1hdGNoIDpmb2N1cy12aXNpYmxlIGFzIGl0IHN1cHBvcnRzIGtleWJvYXJk IGlucHV0CitQQVNTIEZvY3VzIGVsZW1lbnQgSU5QVVQjaW5wdXQ2IHZpYSBtb3VzZSBzaG91bGQg bWF0Y2ggOmZvY3VzLXZpc2libGUgYXMgaXQgc3VwcG9ydHMga2V5Ym9hcmQgaW5wdXQKK1BBU1Mg Rm9jdXMgZWxlbWVudCBJTlBVVCNpbnB1dDcgdmlhIG1vdXNlIHNob3VsZCBtYXRjaCA6Zm9jdXMt dmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2FyZCBpbnB1dAorUEFTUyBGb2N1cyBlbGVtZW50 IElOUFVUI2lucHV0OCB2aWEgbW91c2Ugc2hvdWxkIG1hdGNoIDpmb2N1cy12aXNpYmxlIGFzIGl0 IHN1cHBvcnRzIGtleWJvYXJkIGlucHV0CitGQUlMIEZvY3VzIGVsZW1lbnQgSU5QVVQjaW5wdXQ5 IHZpYSBtb3VzZSBzaG91bGQgbWF0Y2ggOmZvY3VzLXZpc2libGUgYXMgaXQgc3VwcG9ydHMga2V5 Ym9hcmQgaW5wdXQgYXNzZXJ0X2VxdWFsczogb3V0bGluZUNvbG9yIGZvciBJTlBVVCNpbnB1dDkg c2hvdWxkIGJlIGdyZWVuIGV4cGVjdGVkICJyZ2IoMCwgMTI4LCAwKSIgYnV0IGdvdCAicmdiKDAs IDAsIDApIgorRkFJTCBGb2N1cyBlbGVtZW50IElOUFVUI2lucHV0MTAgdmlhIG1vdXNlIHNob3Vs ZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2FyZCBpbnB1dCBhc3Nl cnRfZXF1YWxzOiBvdXRsaW5lQ29sb3IgZm9yIElOUFVUI2lucHV0MTAgc2hvdWxkIGJlIGdyZWVu IGV4cGVjdGVkICJyZ2IoMCwgMTI4LCAwKSIgYnV0IGdvdCAicmdiKDAsIDAsIDApIgorRkFJTCBG b2N1cyBlbGVtZW50IElOUFVUI2lucHV0MTEgdmlhIG1vdXNlIHNob3VsZCBtYXRjaCA6Zm9jdXMt dmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2FyZCBpbnB1dCBhc3NlcnRfZXF1YWxzOiBvdXRs aW5lQ29sb3IgZm9yIElOUFVUI2lucHV0MTEgc2hvdWxkIGJlIGdyZWVuIGV4cGVjdGVkICJyZ2Io MCwgMTI4LCAwKSIgYnV0IGdvdCAicmdiKDAsIDAsIDApIgorRkFJTCBGb2N1cyBlbGVtZW50IElO UFVUI2lucHV0MTIgdmlhIG1vdXNlIHNob3VsZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBz dXBwb3J0cyBrZXlib2FyZCBpbnB1dCBhc3NlcnRfZXF1YWxzOiBvdXRsaW5lQ29sb3IgZm9yIElO UFVUI2lucHV0MTIgc2hvdWxkIGJlIGdyZWVuIGV4cGVjdGVkICJyZ2IoMCwgMTI4LCAwKSIgYnV0 IGdvdCAicmdiKDAsIDAsIDApIgorRkFJTCBGb2N1cyBlbGVtZW50IElOUFVUI2lucHV0MTMgdmlh IG1vdXNlIHNob3VsZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2Fy ZCBpbnB1dCBhc3NlcnRfZXF1YWxzOiBvdXRsaW5lQ29sb3IgZm9yIElOUFVUI2lucHV0MTMgc2hv dWxkIGJlIGdyZWVuIGV4cGVjdGVkICJyZ2IoMCwgMTI4LCAwKSIgYnV0IGdvdCAicmdiKDAsIDAs IDApIgorUEFTUyBGb2N1cyBlbGVtZW50IFRFWFRBUkVBI2lucHV0MTQgdmlhIG1vdXNlIHNob3Vs ZCBtYXRjaCA6Zm9jdXMtdmlzaWJsZSBhcyBpdCBzdXBwb3J0cyBrZXlib2FyZCBpbnB1dAorCg==