224956 2021-04-22 16:15:05 -0700 [iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient method filter 2021-04-23 13:11:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211188 InRadar P2 Normal --- 1 bfulgham bfulgham pvollan oldest_to_newest 1753341 0 bfulgham 2021-04-22 16:15:05 -0700 In Bug 211188 we added message filter protections to the IOMobileFramebufferUserClient. These were not retained when the GPU Process sandbox was constructed, and need to be. <rdar://problem/68227590> 1753348 1 426863 bfulgham 2021-04-22 16:25:08 -0700 Created attachment 426863 Patch 1753352 2 426863 pvollan 2021-04-22 16:31:35 -0700 Comment on attachment 426863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426863&action=review R=me. > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:96 > + (allow (with telemetry) (with message "IOMobileFramebufferUserClient") Is the telemetry needed on the allow rule? Sometimes telemetry for frequently hit rules can cause a perf regression. 1753379 3 bfulgham 2021-04-22 17:08:57 -0700 (In reply to Per Arne Vollan from comment #2) > Comment on attachment 426863 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426863&action=review > > R=me. > > > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:96 > > + (allow (with telemetry) (with message "IOMobileFramebufferUserClient") > > Is the telemetry needed on the allow rule? Sometimes telemetry for > frequently hit rules can cause a perf regression. Good point -- I'll remove it. This telemetry is in the WebContent version of this (perhaps not used anymore). Maybe we should remove it there, too? 1753393 4 426875 bfulgham 2021-04-22 17:27:38 -0700 Created attachment 426875 Patch 1753402 5 426875 pvollan 2021-04-22 17:39:14 -0700 Comment on attachment 426875 Patch R=me. 1753685 6 426875 bfulgham 2021-04-23 12:59:26 -0700 Comment on attachment 426875 Patch Patch was also validated in manual testing on device. 1753698 7 ews-feeder 2021-04-23 13:11:47 -0700 Committed r276515 (236971@main): <https://commits.webkit.org/236971@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426875. 426863 2021-04-22 16:25:08 -0700 2021-04-22 17:27:37 -0700 Patch bug-224956-20210422162507.patch text/plain 2226 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFmYmE5MzgyZDFkYjViZjc1 MmRlNDFjZjc0NmZlNjgxMTQwYTFiNDUuLjNlNTFlMDY0ODM0ZTdhMDAyZTZlYThhNTE4ZTQwNTAw Y2YxNTgzN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDQtMjIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gR1BVIFByb2Nlc3Mg c2FuZGJveCBsYWNrcyBJT01vYmlsZUZyYW1lYnVmZmVyVXNlckNsaWVudCBtZXRob2QgZmlsdGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5NTYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY4MjI3NTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggdXBkYXRlcyB0aGUgR1BVIHBy b2Nlc3Mgc2FuZGJveCB0byBtYXRjaCB0aGUgbWV0aG9kIGZpbHRlciB1c2VkIGluIHRoZSBXZWJD b250ZW50IHByb2Nlc3MKKyAgICAgICAgc28gdGhhdCB3ZSB3aWxsIHJldGFpbiBjb25zaXN0ZW50 IHByb3RlY3Rpb25zIHdoZW4gYWN0aXZhdGluZyB0aGUgR1BVIFByb2Nlc3MuIFRoZXNlIGFyZSB0 aGUgc2FtZSBydWxlcworICAgICAgICBnb3Zlcm5pbmcgYWNjZXNzIHRvIHRoaXMgcmVzb3VyY2Ug d2hlbiB0aGUgR1BVIHByb2Nlc3MgaXMgZGlzYWJsZWQsIHNvIHNob3VsZCBub3QgY3JlYXRlIGEg Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2I6CisKIDIwMjEtMDQtMjEgIFdlbnNvbiBIc2ll aCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVGV4dCBzZWxlY3Rp b24gaW4gaW1hZ2Ugb3ZlcmxheXMgc2hvdWxkIG5vdCBiZSBsaW1pdGVkIHRvIHJlY3RpbGluZWFy IHF1YWRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmls ZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMv U2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYgppbmRleCAxYzJiZWIx ZDVmMzVlZDk0NDc1Y2I1ZTg1MTVjMTRjODkwY2IzNjI1Li5hYmVhNDA1OGZmOWUxNDUxM2U4YmJh MjZjNzkyM2FhNGNlMTFiZGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiCisrKyBiL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUu c2IKQEAgLTg3LDcgKzg3LDE3IEBACiAKIChkZWZpbmUtb25jZSAoZnJhbWVidWZmZXItYWNjZXNz KQogICAgIChhbGxvdyBpb2tpdC1vcGVuCi0gICAgICAgICAgIChpb2tpdC11c2VyLWNsaWVudC1j bGFzcyAiSU9Nb2JpbGVGcmFtZWJ1ZmZlclVzZXJDbGllbnQiKSkKKyAgICAgICAgICAgKGlva2l0 LXVzZXItY2xpZW50LWNsYXNzICJJT01vYmlsZUZyYW1lYnVmZmVyVXNlckNsaWVudCIpCisgICAg ICAgICAgICh3aGVuIChkZWZpbmVkPyAnaW9raXQtZXh0ZXJuYWwtbWV0aG9kKQorICAgICAgICAg ICAgICAgKGFwcGx5LW1lc3NhZ2UtZmlsdGVyCisgICAgICAgICAgICAgICAgICAgKGRlbnkgKHdp dGggdGVsZW1ldHJ5KQorICAgICAgICAgICAgICAgICAgICAgICBpb2tpdC1hc3luYy1leHRlcm5h bC1tZXRob2QKKyAgICAgICAgICAgICAgICAgICAgICAgaW9raXQtZXh0ZXJuYWwtdHJhcCkKKyAg ICAgICAgICAgICAgICAgICAoYWxsb3cgKHdpdGggdGVsZW1ldHJ5KSAod2l0aCBtZXNzYWdlICJJ T01vYmlsZUZyYW1lYnVmZmVyVXNlckNsaWVudCIpCisgICAgICAgICAgICAgICAgICAgICAgIGlv a2l0LWV4dGVybmFsLW1ldGhvZCkKKyAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgKQorICAg ICkKICAgICAobW9iaWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5pb2tpdC5JT01vYmls ZUdyYXBoaWNzRmFtaWx5IikpCiAKIChkZWZpbmUtb25jZSAoYXNzZXQtYWNjZXNzIC4gb3B0aW9u cykK 426875 2021-04-22 17:27:38 -0700 2021-04-23 13:11:47 -0700 Patch bug-224956-20210422172737.patch text/plain 3091 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2Mzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFmYmE5MzgyZDFkYjViZjc1 MmRlNDFjZjc0NmZlNjgxMTQwYTFiNDUuLmNlYmE2YmI0OTlhOTViY2QzZWM4ODIwOTBlMzRjZGRk NzgwODlmZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDQtMjIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gR1BVIFByb2Nlc3Mg c2FuZGJveCBsYWNrcyBJT01vYmlsZUZyYW1lYnVmZmVyVXNlckNsaWVudCBtZXRob2QgZmlsdGVy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ5NTYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY4MjI3NTkwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggdXBkYXRlcyB0aGUgR1BVIHBy b2Nlc3Mgc2FuZGJveCB0byBtYXRjaCB0aGUgbWV0aG9kIGZpbHRlciB1c2VkIGluIHRoZSBXZWJD b250ZW50IHByb2Nlc3MKKyAgICAgICAgc28gdGhhdCB3ZSB3aWxsIHJldGFpbiBjb25zaXN0ZW50 IHByb3RlY3Rpb25zIHdoZW4gYWN0aXZhdGluZyB0aGUgR1BVIFByb2Nlc3MuIFRoZXNlIGFyZSB0 aGUgc2FtZSBydWxlcworICAgICAgICBnb3Zlcm5pbmcgYWNjZXNzIHRvIHRoaXMgcmVzb3VyY2Ug d2hlbiB0aGUgR1BVIHByb2Nlc3MgaXMgZGlzYWJsZWQsIHNvIHNob3VsZCBub3QgY3JlYXRlIGEg Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgIFdlIGFsc28gcmVtb3ZlIHVubmVlZGVkIHRl bGVtZXRyeSB0byByZWR1Y2UgbWVzc2FnaW5nIGJ1cmRlbiBhbmQgYXZvaWQgcGVyZm9ybWFuY2Ug aXNzdWVzLgorCisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFw cGxlLldlYktpdC5HUFUuc2I6CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9p b3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiOgorCiAyMDIxLTA0LTIxICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFRleHQgc2Vs ZWN0aW9uIGluIGltYWdlIG92ZXJsYXlzIHNob3VsZCBub3QgYmUgbGltaXRlZCB0byByZWN0aWxp bmVhciBxdWFkcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFBy b2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3Vy Y2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2IKaW5kZXggMWMy YmViMWQ1ZjM1ZWQ5NDQ3NWNiNWU4NTE1YzE0Yzg5MGNiMzYyNS4uMzE4OWQzOTk1Mzk4NzhiMTVj Njg3MGNhNmM3YTJlMTE2Njk2MWNkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9SZXNvdXJj ZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYgorKysgYi9Tb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu R1BVLnNiCkBAIC04Nyw3ICs4NywxNyBAQAogCiAoZGVmaW5lLW9uY2UgKGZyYW1lYnVmZmVyLWFj Y2VzcykKICAgICAoYWxsb3cgaW9raXQtb3BlbgotICAgICAgICAgICAoaW9raXQtdXNlci1jbGll bnQtY2xhc3MgIklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xpZW50IikpCisgICAgICAgICAgIChp b2tpdC11c2VyLWNsaWVudC1jbGFzcyAiSU9Nb2JpbGVGcmFtZWJ1ZmZlclVzZXJDbGllbnQiKQor ICAgICAgICAgICAod2hlbiAoZGVmaW5lZD8gJ2lva2l0LWV4dGVybmFsLW1ldGhvZCkKKyAgICAg ICAgICAgICAgIChhcHBseS1tZXNzYWdlLWZpbHRlcgorICAgICAgICAgICAgICAgICAgIChkZW55 ICh3aXRoIHRlbGVtZXRyeSkKKyAgICAgICAgICAgICAgICAgICAgICAgaW9raXQtYXN5bmMtZXh0 ZXJuYWwtbWV0aG9kCisgICAgICAgICAgICAgICAgICAgICAgIGlva2l0LWV4dGVybmFsLXRyYXAp CisgICAgICAgICAgICAgICAgICAgKGFsbG93CisgICAgICAgICAgICAgICAgICAgICAgIGlva2l0 LWV4dGVybmFsLW1ldGhvZCkKKyAgICAgICAgICAgICAgICkKKyAgICAgICAgICAgKQorICAgICkK ICAgICAobW9iaWxlLXByZWZlcmVuY2VzLXJlYWQgImNvbS5hcHBsZS5pb2tpdC5JT01vYmlsZUdy YXBoaWNzRmFtaWx5IikpCiAKIChkZWZpbmUtb25jZSAoYXNzZXQtYWNjZXNzIC4gb3B0aW9ucykK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMv U2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKaW5kZXgg MzVkNzExMTdjZDM1Yjc1N2E0ZmUzMGYxNmQ3ZWM4MWQ5NGY3NTc4ZS4uODc1N2E1N2UwNTBmNjcz MzVkOWQxYzIyY2EwODM2ZDZmNjI3MjI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9SZXNv dXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IK KysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBw bGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKQEAgLTk2LDcgKzk2LDcgQEAKICAgICAgICAgICAgICAg ICAoZGVueSAod2l0aCB0ZWxlbWV0cnkpCiAgICAgICAgICAgICAgICAgICAgIGlva2l0LWFzeW5j LWV4dGVybmFsLW1ldGhvZAogICAgICAgICAgICAgICAgICAgICBpb2tpdC1leHRlcm5hbC10cmFw KQotICAgICAgICAgICAgICAgIChhbGxvdyAod2l0aCB0ZWxlbWV0cnkpICh3aXRoIG1lc3NhZ2Ug IklPTW9iaWxlRnJhbWVidWZmZXJVc2VyQ2xpZW50IikKKyAgICAgICAgICAgICAgICAoYWxsb3cK ICAgICAgICAgICAgICAgICAgICAgaW9raXQtZXh0ZXJuYWwtbWV0aG9kKQogICAgICAgICAgICAg KQogICAgICAgICApCg==