224942 2021-04-22 12:49:28 -0700 [WTF] Undefined behavior warning in StringBuilder::allocateBuffer 2021-04-23 01:17:11 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura aperez benjamin bugs-noreply cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1753259 0 lmoura 2021-04-22 12:49:28 -0700 ../../Source/WTF/wtf/text/StringBuilder.cpp:115:16: runtime error: null pointer passed as argument 2, which is declared to never be null This occurs 24 times running the TestWTF executable To reproduce: - Compile with usban enabled with the following cmake arg: -DENABLE_SANITIZERS=undefined" - ./Tools/Scripts/build-webkit --use-icecream --release --gtk --cmakeargs="-DENABLE_SANITIZERS=undefined" - Run the stringbuilder append check: - ./Tools/Scripts/webkit-flatpak --flatpak-verbose --release -c WebKitBuild/GTK/Release/bin/TestWebKitAPI/TestWTF --gtest_filter=StringBuilderTest.Append 1753267 1 426843 lmoura 2021-04-22 13:10:27 -0700 Created attachment 426843 Patch 1753269 2 426843 cdumez 2021-04-22 13:17:15 -0700 Comment on attachment 426843 Patch r=me 1753307 3 426843 darin 2021-04-22 14:58:52 -0700 Comment on attachment 426843 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426843&action=review > Source/WTF/wtf/text/StringBuilder.cpp:118 > + auto length = m_length.unsafeGet(); > + if (length) > + std::memcpy(m_bufferCharacters8, currentCharacters, length); OK as is, but can be done without the local variable: if (m_length) std::memcpy(m_bufferCharacters8, currentCharacters, m_length.unsafeGet()); If you really like the local, slightly nicer if it’s scoped: if (auto length = m_length.unsafeGet()) std::memcpy(m_bufferCharacters8, currentCharacters, length); 1753450 4 426886 lmoura 2021-04-22 21:38:52 -0700 Created attachment 426886 Patch for landing 1753456 5 ews-feeder 2021-04-22 22:06:50 -0700 Committed r276485 (236944@main): <https://commits.webkit.org/236944@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426886. 1753493 6 webkit-bug-importer 2021-04-23 01:17:11 -0700 <rdar://problem/77061394> 426843 2021-04-22 13:10:27 -0700 2021-04-22 21:38:47 -0700 Patch bug-224942-20210422171026.patch text/plain 1565 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDFlNmYxMWJmNzc2Y2E2ZGZkNzgwMzNi NzA4MGNmYmE2NmY1MDFhMDkuLjhjY2YxZTkzNzAxMTg1MjE0ZmRhZmNkYWZkMzdmMjlkMThhNjU4 ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDQtMjIgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dURl0gVW5kZWZpbmVkIGJlaGF2aW9yIHdhcm5pbmcg aW4gU3RyaW5nQnVpbGRlcjo6YWxsb2NhdGVCdWZmZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5jcHA6Cisg ICAgICAgIChXVEY6OlN0cmluZ0J1aWxkZXI6OmFsbG9jYXRlQnVmZmVyKTogQWRkIGNoZWNrIGJl Zm9yZSBjYWxsaW5nIG1lbWNweQorCiAyMDIxLTA0LTE5ICBLaW1tbyBLaW5udW5lbiAgPGtraW5u dW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIC1XdGhyZWFkLXNhZmV0eSwgYWRkIGF0 dHJpYnV0ZXMgdG8gY3VzdG9tIGxvY2sgY2xhc3NlcywgYW5kIHByb3ZpZGUgbWFjcm9zIHRvIGRl Y2xhcmUgZ3VhcmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxk ZXIuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNwcAppbmRleCBmODk5 ZTM5ZGU1OGIxODY5YTU0ODE1NTM4YTgxNTRiZDFjMTU2YzE2Li4zM2VlMTJmMGI5ZDkzMTkzZDM5 Mzc3Y2ZkYThlMmYzODU3NzA4MDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0J1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRlci5j cHAKQEAgLTExMiw3ICsxMTIsMTAgQEAgdm9pZCBTdHJpbmdCdWlsZGVyOjphbGxvY2F0ZUJ1ZmZl cihjb25zdCBMQ2hhciogY3VycmVudENoYXJhY3RlcnMsIHVuc2lnbmVkIHJlcXUKICAgICBhdXRv IGJ1ZmZlciA9IFN0cmluZ0ltcGw6OnRyeUNyZWF0ZVVuaW5pdGlhbGl6ZWQocmVxdWlyZWRMZW5n dGgsIG1fYnVmZmVyQ2hhcmFjdGVyczgpOwogICAgIGlmIChVTkxJS0VMWSghYnVmZmVyKSkKICAg ICAgICAgcmV0dXJuIGRpZE92ZXJmbG93KCk7Ci0gICAgc3RkOjptZW1jcHkobV9idWZmZXJDaGFy YWN0ZXJzOCwgY3VycmVudENoYXJhY3RlcnMsIG1fbGVuZ3RoLnVuc2FmZUdldCgpKTsKKworICAg IGF1dG8gbGVuZ3RoID0gbV9sZW5ndGgudW5zYWZlR2V0KCk7CisgICAgaWYgKGxlbmd0aCkKKyAg ICAgICAgc3RkOjptZW1jcHkobV9idWZmZXJDaGFyYWN0ZXJzOCwgY3VycmVudENoYXJhY3RlcnMs IGxlbmd0aCk7CiAgICAgCiAgICAgLy8gVXBkYXRlIHRoZSBidWlsZGVyIHN0YXRlLgogICAgIG1f YnVmZmVyID0gV1RGTW92ZShidWZmZXIpOwo= 426886 2021-04-22 21:38:52 -0700 2021-04-22 22:06:51 -0700 Patch for landing bug-224942-20210423013850.patch text/plain 1510 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGM1ODBlOGM5YjJlNTEyMDAzODM0YTdm ZjMxYTBkMDNhZTM2ZGFiN2QuLjlhZmIyOTBhNGJiMzM3NDQ0OWU0OTkwZDAzZWE1OGNmZTkxYjU3 ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDQtMjIgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dURl0gVW5kZWZpbmVkIGJlaGF2aW9yIHdhcm5pbmcg aW4gU3RyaW5nQnVpbGRlcjo6YWxsb2NhdGVCdWZmZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IENo cmlzIER1bWV6LgorCisgICAgICAgICogd3RmL3RleHQvU3RyaW5nQnVpbGRlci5jcHA6CisgICAg ICAgIChXVEY6OlN0cmluZ0J1aWxkZXI6OmFsbG9jYXRlQnVmZmVyKTogQWRkIGNoZWNrIGJlZm9y ZSBjYWxsaW5nIG1lbWNweQorCiAyMDIxLTA0LTIyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCB0cmFjZSBwb2ludHMgZm9yIFdLV2ViVmlldyBz bmFwc2hvdHRpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQnVpbGRl ci5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuY3BwCmluZGV4IGY4OTll MzlkZTU4YjE4NjlhNTQ4MTU1MzhhODE1NGJkMWMxNTZjMTYuLmExOWM1YWQ5ZmNmODM3OTU0Njk4 ZTBiZTM0MDcyYmZkNzc1MTFjY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmNw cApAQCAtMTEyLDggKzExMiwxMCBAQCB2b2lkIFN0cmluZ0J1aWxkZXI6OmFsbG9jYXRlQnVmZmVy KGNvbnN0IExDaGFyKiBjdXJyZW50Q2hhcmFjdGVycywgdW5zaWduZWQgcmVxdQogICAgIGF1dG8g YnVmZmVyID0gU3RyaW5nSW1wbDo6dHJ5Q3JlYXRlVW5pbml0aWFsaXplZChyZXF1aXJlZExlbmd0 aCwgbV9idWZmZXJDaGFyYWN0ZXJzOCk7CiAgICAgaWYgKFVOTElLRUxZKCFidWZmZXIpKQogICAg ICAgICByZXR1cm4gZGlkT3ZlcmZsb3coKTsKLSAgICBzdGQ6Om1lbWNweShtX2J1ZmZlckNoYXJh Y3RlcnM4LCBjdXJyZW50Q2hhcmFjdGVycywgbV9sZW5ndGgudW5zYWZlR2V0KCkpOwotICAgIAor CisgICAgaWYgKG1fbGVuZ3RoKQorICAgICAgICBzdGQ6Om1lbWNweShtX2J1ZmZlckNoYXJhY3Rl cnM4LCBjdXJyZW50Q2hhcmFjdGVycywgbV9sZW5ndGgudW5zYWZlR2V0KCkpOworCiAgICAgLy8g VXBkYXRlIHRoZSBidWlsZGVyIHN0YXRlLgogICAgIG1fYnVmZmVyID0gV1RGTW92ZShidWZmZXIp OwogICAgIG1fc3RyaW5nID0gU3RyaW5nKCk7Cg==