224937 2021-04-22 09:33:43 -0700 Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia() 2021-04-22 15:48:54 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez eric.carlson jer.noble peng.liu6 webkit-bug-importer oldest_to_newest 1753198 0 cdumez 2021-04-22 09:33:43 -0700 Call RemoteMediaEngineConfigurationFactory::registerFactory() in WebProcess::setUseGPUProcessForMedia(), like we used to done, instead of doing it in the GPUProcessConnection constructor. It is safer to register the factory before we have a GPUProcessConnection and we wouldn't want things to behave differently depending on whether or not the GPUProcess is already launched. I made sure that this does not eagerly launch the GPUProcess. 1753202 1 426824 cdumez 2021-04-22 09:37:40 -0700 Created attachment 426824 Patch 1753286 2 426824 eric.carlson 2021-04-22 13:50:48 -0700 Comment on attachment 426824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426824&action=review > Source/WebKit/ChangeLog:9 > + like we used to done, instead of doing it in the GPUProcessConnection constructor. It is safer to s/used to done/used to do/ 1753287 3 cdumez 2021-04-22 13:53:00 -0700 Committed r276460 (236920@main): <https://commits.webkit.org/236920@main> 1753327 4 webkit-bug-importer 2021-04-22 15:48:54 -0700 <rdar://problem/77042248> 426824 2021-04-22 09:37:40 -0700 2021-04-22 13:56:22 -0700 Patch bug-224937-20210422093740.patch text/plain 5480 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2NDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcyMDc2YWU2ZWNjMDgzMmQ2 OTRkMzFlNTVmN2ZjZTc4ZDY0N2IwNTIuLjdhNjhhNmFlMGNlZTA2ZDE4ZDg3ZmUxOWE4ZjYxMzRi OTk2MDBkYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDQtMjIgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDYWxsIFJlbW90ZU1lZGlhRW5naW5l Q29uZmlndXJhdGlvbkZhY3Rvcnk6OnJlZ2lzdGVyRmFjdG9yeSgpIGluIFdlYlByb2Nlc3M6OnNl dFVzZUdQVVByb2Nlc3NGb3JNZWRpYSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjQ5MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDYWxsIFJlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3Rv cnk6OnJlZ2lzdGVyRmFjdG9yeSgpIGluIFdlYlByb2Nlc3M6OnNldFVzZUdQVVByb2Nlc3NGb3JN ZWRpYSgpLAorICAgICAgICBsaWtlIHdlIHVzZWQgdG8gZG9uZSwgaW5zdGVhZCBvZiBkb2luZyBp dCBpbiB0aGUgR1BVUHJvY2Vzc0Nvbm5lY3Rpb24gY29uc3RydWN0b3IuIEl0IGlzIHNhZmVyIHRv CisgICAgICAgIHJlZ2lzdGVyIHRoZSBmYWN0b3J5IGJlZm9yZSB3ZSBoYXZlIGEgR1BVUHJvY2Vz c0Nvbm5lY3Rpb24gYW5kIHdlIHdvdWxkbid0IHdhbnQgdGhpbmdzIHRvIGJlaGF2ZQorICAgICAg ICBkaWZmZXJlbnRseSBkZXBlbmRpbmcgb24gd2hldGhlciBvciBub3QgdGhlIEdQVVByb2Nlc3Mg aXMgYWxyZWFkeSBsYXVuY2hlZC4gSSBtYWRlIHN1cmUgdGhhdCB0aGlzIGRvZXMKKyAgICAgICAg bm90IGVhZ2VybHkgbGF1bmNoIHRoZSBHUFVQcm9jZXNzLgorCisgICAgICAgICogV2ViUHJvY2Vz cy9HUFUvR1BVUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpHUFVQcm9j ZXNzQ29ubmVjdGlvbjo6R1BVUHJvY2Vzc0Nvbm5lY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpH UFVQcm9jZXNzQ29ubmVjdGlvbjo6bWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeSk6IERl bGV0ZWQuCisgICAgICAgICogV2ViUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc0Nvbm5lY3Rpb24uaDoK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzOjpzZXRVc2VHUFVQcm9jZXNzRm9yTWVkaWEpOgorICAgICAgICAoV2ViS2l0OjpX ZWJQcm9jZXNzOjptZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5KToKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlByb2Nlc3MuaDoKKwogMjAyMS0wNC0yMiAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIENhbGwgUmVtb3RlQ0RNRmFjdG9yeTo6cmVnaXN0ZXJG YWN0b3J5KCkgaW4gV2ViUHJvY2Vzczo6c2V0VXNlR1BVUHJvY2Vzc0Zvck1lZGlhKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc0Nvbm5lY3Rpb24u Y3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9HUFVQcm9jZXNzQ29ubmVjdGlvbi5j cHAKaW5kZXggNjgzZGM5Zjk1Mjc2NzllMTdkYmM3OTJlNzQzZGQ1ZjQyYTUxNGE0Zi4uODY1Zjgz M2JjZDQ2ZDVhZTliNGRmZjE2ODI4MzNiNTBhNWE5OTQ0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL0dQVS9HUFVQcm9jZXNzQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0dQVS9HUFVQcm9jZXNzQ29ubmVjdGlvbi5jcHAKQEAgLTEwMSw3 ICsxMDEsNiBAQCBHUFVQcm9jZXNzQ29ubmVjdGlvbjo6R1BVUHJvY2Vzc0Nvbm5lY3Rpb24oSVBD OjpDb25uZWN0aW9uOjpJZGVudGlmaWVyIGNvbm5lY3RpbwogICAgIGFkZExhbmd1YWdlQ2hhbmdl T2JzZXJ2ZXIodGhpcywgbGFuZ3VhZ2VzQ2hhbmdlZCk7CiAKICAgICBpZiAoV2ViUHJvY2Vzczo6 c2luZ2xldG9uKCkuc2hvdWxkVXNlUmVtb3RlUmVuZGVyaW5nRm9yKFJlbmRlcmluZ1B1cnBvc2U6 Ok1lZGlhUGFpbnRpbmcpKSB7Ci0gICAgICAgIG1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3Rv cnkoKS5yZWdpc3RlckZhY3RvcnkoKTsKICNpZiBFTkFCTEUoVlA5KQogICAgICAgICBlbmFibGVW UDlEZWNvZGVycyhQbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXI6OnNob3VsZEVuYWJsZVZQOERl Y29kZXIoKSwgUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpzaG91bGRFbmFibGVWUDlEZWNv ZGVyKCksIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6c2hvdWxkRW5hYmxlVlA5U1dEZWNv ZGVyKCkpOwogI2VuZGlmCkBAIC0xNTUsMTEgKzE1NCw2IEBAIFJlbW90ZUF1ZGlvU291cmNlUHJv dmlkZXJNYW5hZ2VyJiBHUFVQcm9jZXNzQ29ubmVjdGlvbjo6YXVkaW9Tb3VyY2VQcm92aWRlck1h bmFnCiB9CiAjZW5kaWYKIAotUmVtb3RlTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeSYg R1BVUHJvY2Vzc0Nvbm5lY3Rpb246Om1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkoKQot ewotICAgIHJldHVybiAqV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkuc3VwcGxlbWVudDxSZW1vdGVN ZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5PigpOwotfQotCiBib29sIEdQVVByb2Nlc3ND b25uZWN0aW9uOjpkaXNwYXRjaE1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiBjb25uZWN0aW9uLCBJ UEM6OkRlY29kZXImIGRlY29kZXIpCiB7CiAgICAgaWYgKGRlY29kZXIubWVzc2FnZVJlY2VpdmVy TmFtZSgpID09IE1lc3NhZ2VzOjpNZWRpYVBsYXllclByaXZhdGVSZW1vdGU6Om1lc3NhZ2VSZWNl aXZlck5hbWUoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9H UFVQcm9jZXNzQ29ubmVjdGlvbi5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9HUFVQ cm9jZXNzQ29ubmVjdGlvbi5oCmluZGV4IGI5NzY3MTM4NzQwOWQ5MjhiMmQ3MGQ4NDdmZDBjMWNh NjlhODUxNGMuLjE2NTNiNjdkZmQ0MjhhOTE0ZDMwMzgxMDZhYThhOGY4YjlmNzY5YTIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvR1BVUHJvY2Vzc0Nvbm5lY3Rpb24u aAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL0dQVVByb2Nlc3NDb25uZWN0aW9u LmgKQEAgLTQwLDcgKzQwLDYgQEAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBjbGFzcyBSZW1vdGVB dWRpb1NvdXJjZVByb3ZpZGVyTWFuYWdlcjsKLWNsYXNzIFJlbW90ZU1lZGlhRW5naW5lQ29uZmln dXJhdGlvbkZhY3Rvcnk7CiBjbGFzcyBSZW1vdGVNZWRpYVBsYXllck1hbmFnZXI7CiBjbGFzcyBX ZWJQYWdlOwogc3RydWN0IE92ZXJyaWRlU2NyZWVuRGF0YUZvclRlc3Rpbmc7CkBAIC03MSw4ICs3 MCw2IEBAIHB1YmxpYzoKICAgICBSZW1vdGVBdWRpb1NvdXJjZVByb3ZpZGVyTWFuYWdlciYgYXVk aW9Tb3VyY2VQcm92aWRlck1hbmFnZXIoKTsKICNlbmRpZgogCi0gICAgUmVtb3RlTWVkaWFFbmdp bmVDb25maWd1cmF0aW9uRmFjdG9yeSYgbWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeSgp OwotCiAgICAgdm9pZCB1cGRhdGVNZWRpYUNvbmZpZ3VyYXRpb24oKTsKIAogI2lmIEVOQUJMRShW UDkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAKaW5kZXggZjk5ZjdjMmY2 NjIzZDI3NmM1ZmIzMmU4MmYxYTQzZDIxY2MzOGJjOS4uYmI0Y2NkYjZmOTMzMTlhZTVkZWNiZDU2 YmQ2YTBlMDA1NWQ3NDY0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNw cApAQCAtMjAwMCw3ICsyMDAwLDkgQEAgdm9pZCBXZWJQcm9jZXNzOjpzZXRVc2VHUFVQcm9jZXNz Rm9yTWVkaWEoYm9vbCB1c2VHUFVQcm9jZXNzRm9yTWVkaWEpCiAgICAgICAgIExlZ2FjeUNETTo6 cmVzZXRGYWN0b3JpZXMoKTsKICNlbmRpZgogCi0gICAgaWYgKCF1c2VHUFVQcm9jZXNzRm9yTWVk aWEpCisgICAgaWYgKHVzZUdQVVByb2Nlc3NGb3JNZWRpYSkKKyAgICAgICAgbWVkaWFFbmdpbmVD b25maWd1cmF0aW9uRmFjdG9yeSgpLnJlZ2lzdGVyRmFjdG9yeSgpOworICAgIGVsc2UKICAgICAg ICAgTWVkaWFFbmdpbmVDb25maWd1cmF0aW9uRmFjdG9yeTo6cmVzZXRGYWN0b3JpZXMoKTsKIAog ICAgIGlmICh1c2VHUFVQcm9jZXNzRm9yTWVkaWEpCkBAIC0yMDg2LDYgKzIwODgsMTIgQEAgUmVt b3RlQ0RNRmFjdG9yeSYgV2ViUHJvY2Vzczo6Y2RtRmFjdG9yeSgpCiB9CiAjZW5kaWYKIAorI2lm IEVOQUJMRShHUFVfUFJPQ0VTUykKK1JlbW90ZU1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3Rv cnkmIFdlYlByb2Nlc3M6Om1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkoKQoreworICAg IHJldHVybiAqc3VwcGxlbWVudDxSZW1vdGVNZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5 PigpOworfQorI2VuZGlmCiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1dlYlByb2Nlc3MuaAppbmRleCBjOTkwNGU4ZTNmY2E3MDlkOGFlYjIzZGE4NzQzMTkz MjRiYzUxYjM1Li44MzA5ZGI4ZDUwNTUxMDcwMWU0ZWM4NTZmM2RjODdiNjAxMWVkODgzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKQEAgLTEyMCw2ICsxMjAsNyBAQCBjbGFz cyBPYmpDT2JqZWN0R3JhcGg7CiBjbGFzcyBQcm9jZXNzQXNzZXJ0aW9uOwogY2xhc3MgUmVtb3Rl Q0RNRmFjdG9yeTsKIGNsYXNzIFJlbW90ZUxlZ2FjeUNETUZhY3Rvcnk7CitjbGFzcyBSZW1vdGVN ZWRpYUVuZ2luZUNvbmZpZ3VyYXRpb25GYWN0b3J5Owogc3RydWN0IFNlcnZpY2VXb3JrZXJJbml0 aWFsaXphdGlvbkRhdGE7CiBjbGFzcyBTdG9yYWdlQXJlYU1hcDsKIGNsYXNzIFVzZXJEYXRhOwpA QCAtMjQ4LDYgKzI0OSw3IEBAIHB1YmxpYzoKICNpZiBFTkFCTEUoRU5DUllQVEVEX01FRElBKQog ICAgIFJlbW90ZUNETUZhY3RvcnkmIGNkbUZhY3RvcnkoKTsKICNlbmRpZgorICAgIFJlbW90ZU1l ZGlhRW5naW5lQ29uZmlndXJhdGlvbkZhY3RvcnkmIG1lZGlhRW5naW5lQ29uZmlndXJhdGlvbkZh Y3RvcnkoKTsKICNlbmRpZiAvLyBFTkFCTEUoR1BVX1BST0NFU1MpCiAKICNpZiBFTkFCTEUoV0VC X0FVVEhOKQo=