224927 2021-04-22 06:03:58 -0700 Handle rotation correctly in WebRTC GPUProcess rendering pipeline 2021-04-23 07:32:50 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson koivisto peng.liu6 simon.fraser thorton webkit-bug-importer youennf oldest_to_newest 1753122 0 youennf 2021-04-22 06:03:58 -0700 Handle rotation correctly in WebRTC GPUProcess rendering pipeline 1753123 1 youennf 2021-04-22 06:06:06 -0700 <rdar://76915991> 1753124 2 426802 youennf 2021-04-22 06:08:47 -0700 Created attachment 426802 Patch 1753234 3 426802 eric.carlson 2021-04-22 11:37:18 -0700 Comment on attachment 426802 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426802&action=review > Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:81 > - m_sampleBufferDisplayLayer->updateAffineTransform(transform); > + m_sampleBufferDisplayLayer->updateRootLayerAffineTransform(transform); Why don't we have to do this in the web process? What happens in the web process if `updateAffineTransform`to rotates the root layer? 1753571 4 youennf 2021-04-23 07:11:08 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 426802 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426802&action=review > > > Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:81 > > - m_sampleBufferDisplayLayer->updateAffineTransform(transform); > > + m_sampleBufferDisplayLayer->updateRootLayerAffineTransform(transform); > > Why don't we have to do this in the web process? > > What happens in the web process if `updateAffineTransform`to rotates the > root layer? I am not quite sure why doing it in the root layer and not the sample layer fixes the rotation issue in GPUProcess. If I use the root layer in WebProcess, rotation is fine but the internal sample buffer layer is being cropped. I asked around and it would be good to have additional analysis in that area. In the meantime, I am landing this patch now since it fixes the issue. 1753572 5 youennf 2021-04-23 07:11:37 -0700 iOS-wk2 failure is unrelated. 1753575 6 ews-feeder 2021-04-23 07:32:48 -0700 Committed r276497 (236956@main): <https://commits.webkit.org/236956@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426802. 426802 2021-04-22 06:08:47 -0700 2021-04-23 07:32:49 -0700 Patch bug-224927-20210422150846.patch text/plain 4403 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzk4MmQ4NDA5Zjk3NjEx ZGIxODY2ODRlYWQ1NDgwYjIwOTVmMTQ1NC4uMTJjNTViMzQ1ZWM4MTFkY2U2OThjZjc2ODZjZTg0 ZTg3YzU3NWJlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTIyICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgcm90YXRpb24g Y29ycmVjdGx5IGluIFdlYlJUQyBHUFVQcm9jZXNzIHJlbmRlcmluZyBwaXBlbGluZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0OTI3CisgICAgICAg IDxyZGFyOi8vNzY5MTU5OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGEgcm91dGluZSB0byB1cGRhdGUgdGhlIGFmZmluZSB0cmFuc2Zvcm1u IG9mIHRoZSByb290IGxheWVyLgorICAgICAgICBNYW51YWxseSB0ZXN0ZWQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Mb2NhbFNhbXBsZUJ1ZmZlckRp c3BsYXlMYXllci5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9v YmpjL0xvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLm1tOgorICAgICAgICAoV2ViQ29yZTo6 TG9jYWxTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXI6OnVwZGF0ZVJvb3RMYXllckFmZmluZVRyYW5z Zm9ybSk6CisKIDIwMjEtMDQtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgd2lsbC1jaGFuZ2U6IHRyYW5zZm9ybSBzaG91bGQgYWZmZWN0IG5lc3Rl ZCBwb3NpdGlvbjpmaXhlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAwNjYwODAyNTA2YmI3MzZhYjkwZjQ5M2Y5MjY0 Y2NiMTRlNGZlMWI5Li4wZGIzMWJlNTFlODRiN2ZlY2RjZWJiYmIyZGUxNDA3MmUwNjFmMDIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTIyICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgcm90YXRpb24gY29ycmVjdGx5IGluIFdl YlJUQyBHUFVQcm9jZXNzIHJlbmRlcmluZyBwaXBlbGluZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0OTI3CisgICAgICAgIDxyZGFyOi8vNzY5MTU5 OTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5z dGVhZCBvZiB1cGRhdGluZyB0aGUgaW5uZXIgbGF5ZXIsIHVwZGF0ZSB0aGUgcm9vdCBsYXllci4K KworICAgICAgICAqIEdQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZVNhbXBsZUJ1ZmZlckRpc3BsYXlM YXllci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZVNhbXBsZUJ1ZmZlckRpc3BsYXlMYXll cjo6dXBkYXRlQWZmaW5lVHJhbnNmb3JtKToKKwogMjAyMS0wNC0yMSAgS2F0ZSBDaGVuZXkgIDxr YXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBGb2xsb3d1cCBjaGFuZ2UgdG8g YnVnIDIyNDc3OSBiYXNlZCBvbiBwb3N0LWxhbmQgcmV2aWV3IGNvbW1lbnQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Mb2Nh bFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTG9jYWxTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIuaApp bmRleCBjMjU1ZTcyOTI5NDc1MmZiZTFkNmI5NTZiZGFmNzliZWU4OWM0YzFhLi5jMDEzYWM3M2M4 OTNjOTRlNGQxYjZiN2UzMDNiOTQ2ZjhkN2JiNjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Mb2NhbFNhbXBsZUJ1ZmZlckRp c3BsYXlMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL0xvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLmgKQEAgLTYwLDYgKzYw LDcgQEAgcHVibGljOgogCiAgICAgZW51bSBjbGFzcyBTaG91bGRVcGRhdGVSb290TGF5ZXIgeyBO bywgWWVzIH07CiAgICAgdm9pZCB1cGRhdGVSb290TGF5ZXJCb3VuZHNBbmRQb3NpdGlvbihDR1Jl Y3QsIE1lZGlhU2FtcGxlOjpWaWRlb1JvdGF0aW9uLCBTaG91bGRVcGRhdGVSb290TGF5ZXIpOwor ICAgIHZvaWQgdXBkYXRlUm9vdExheWVyQWZmaW5lVHJhbnNmb3JtKENHQWZmaW5lVHJhbnNmb3Jt KTsKIAogICAgIHZvaWQgaW5pdGlhbGl6ZShib29sIGhpZGVSb290TGF5ZXIsIEludFNpemUsIENv bXBsZXRpb25IYW5kbGVyPHZvaWQoYm9vbCBkaWRTdWNjZWVkKT4mJikgZmluYWw7CiAgICAgYm9v bCBkaWRGYWlsKCkgY29uc3QgZmluYWw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9Mb2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlM YXllci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9v YmpjL0xvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLm1tCmluZGV4IGMwOTQ2ZmU2YjVkYzU4 NGQ2NWEyYmY3MTQ5ZGQ0ODc5ZmE5MzcwMjguLjFhZDQzY2NmZjg0YzgzYTc2MzExYzAzNjU5NjU2 Y2IzZmJhZDQxZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL0xvY2FsU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL0xvY2Fs U2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLm1tCkBAIC0yNDgsNiArMjQ4LDEzIEBAIENHUmVjdCBM b2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllcjo6Ym91bmRzKCkgY29uc3QKICAgICByZXR1cm4g bV9yb290TGF5ZXIuZ2V0KCkuYm91bmRzOwogfQogCit2b2lkIExvY2FsU2FtcGxlQnVmZmVyRGlz cGxheUxheWVyOjp1cGRhdGVSb290TGF5ZXJBZmZpbmVUcmFuc2Zvcm0oQ0dBZmZpbmVUcmFuc2Zv cm0gdHJhbnNmb3JtKQoreworICAgIHJ1bldpdGhvdXRBbmltYXRpb25zKFsmXSB7CisgICAgICAg IG1fcm9vdExheWVyLmdldCgpLmFmZmluZVRyYW5zZm9ybSA9IHRyYW5zZm9ybTsKKyAgICB9KTsK K30KKwogdm9pZCBMb2NhbFNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllcjo6dXBkYXRlQWZmaW5lVHJh bnNmb3JtKENHQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybSkKIHsKICAgICBydW5XaXRob3V0QW5p bWF0aW9ucyhbJl0gewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL3dlYnJ0 Yy9SZW1vdGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIuY3BwIGIvU291cmNlL1dlYktpdC9HUFVQ cm9jZXNzL3dlYnJ0Yy9SZW1vdGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIuY3BwCmluZGV4IGI2 YWE1NWE0OGY5NWE1MjgzMDkxODc2ODE5YTY0NDVkZDQ0MmIzODkuLjhjYTQ2YjlkMjM4ZmI3OWJl ZDYyMmNiYTRkZTEwYzAyOWUwZWM4ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJv Y2Vzcy93ZWJydGMvUmVtb3RlU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZVNhbXBsZUJ1ZmZlckRpc3BsYXlMYXll ci5jcHAKQEAgLTc4LDcgKzc4LDcgQEAgdm9pZCBSZW1vdGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5 ZXI6OnVwZGF0ZURpc3BsYXlNb2RlKGJvb2wgaGlkZURpc3BsYXlMYXllciwgYm8KIAogdm9pZCBS ZW1vdGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXI6OnVwZGF0ZUFmZmluZVRyYW5zZm9ybShDR0Fm ZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm0pCiB7Ci0gICAgbV9zYW1wbGVCdWZmZXJEaXNwbGF5TGF5 ZXItPnVwZGF0ZUFmZmluZVRyYW5zZm9ybSh0cmFuc2Zvcm0pOworICAgIG1fc2FtcGxlQnVmZmVy RGlzcGxheUxheWVyLT51cGRhdGVSb290TGF5ZXJBZmZpbmVUcmFuc2Zvcm0odHJhbnNmb3JtKTsK IH0KIAogdm9pZCBSZW1vdGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXI6OnVwZGF0ZUJvdW5kc0Fu ZFBvc2l0aW9uKENHUmVjdCBib3VuZHMsIFdlYkNvcmU6Ok1lZGlhU2FtcGxlOjpWaWRlb1JvdGF0 aW9uIHJvdGF0aW9uKQo=