<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22491</bug_id>
          
          <creation_ts>2008-11-25 12:00:23 -0800</creation_ts>
          <short_desc>Add unit test skeleton for the WebKit/Gtk+ API</short_desc>
          <delta_ts>2008-12-07 11:17:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>21837</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Holger Freyther">zecke</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>100253</commentid>
    <comment_count>0</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-11-25 12:00:23 -0800</bug_when>
    <thetext>Use the glib testing classes to test our API.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100255</commentid>
    <comment_count>1</comment_count>
      <attachid>25493</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-11-25 12:03:03 -0800</bug_when>
    <thetext>Created attachment 25493
Add unit test skeletong for WebKit/Gtk+

Integrate unit testing into the build process. glib 2.16 introduced the testing classes and the code should cope with that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100355</commentid>
    <comment_count>2</comment_count>
      <attachid>25493</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-11-25 17:58:44 -0800</bug_when>
    <thetext>Comment on attachment 25493
Add unit test skeletong for WebKit/Gtk+

It seems silly to add this w/o any test at all.  How do we know it works if it doesn&apos;t actually test anything?  Also the pre 2.1.6 version shoudn&apos;t just return 0, it should probably at least write a message to the console, no?  and probably return 1?  Whatever tool is calling it should know the tests failed to run because it was built with an old gtk, no?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100398</commentid>
    <comment_count>3</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-11-26 04:50:01 -0800</bug_when>
    <thetext>Hmm. there is a test inside the Bug #21837 and it is blocked by the skeleton and build change to be added. It makes sense to do the split up. So I don&apos;t think it is silly at all.

As the skeleton/framework/buildsystem has nothing to do with the issue of #21837 I have done the split up...

And regarding pre glib 2.16 versions. I think people using it are stuck in the past and will not be able to run &quot;run-webkit-tests&quot; anyway. I don&apos;t mind adding a message that unit testing is not possible but I doubt anyone with older glib will see it.

So as there is a test in the queue as well would you please reconsider your &quot;silly&quot; statement?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100404</commentid>
    <comment_count>4</comment_count>
      <attachid>25519</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-11-26 08:11:35 -0800</bug_when>
    <thetext>Created attachment 25519
Add unit test skeleton for WebKit/Gtk+

This is about the questions:
  - Do we test the API?
  - How do we test (which framework to use)?
  - Where do we put the test(s)?

My answers:
  - Sure
  - We use the glib testing facilities
  - Like Gtk/Glib in a &quot;tests&quot; directory next to the source


What we test:
   - There is a first bug with test case in the referenced bug, so this bug actually has an impact. But in general that is a different question and depends on the actual bug and feature...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100430</commentid>
    <comment_count>5</comment_count>
      <attachid>25519</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-11-26 12:18:20 -0800</bug_when>
    <thetext>Comment on attachment 25519
Add unit test skeleton for WebKit/Gtk+

Looks fine.

You&apos;ll need a ChangeLog when you land of course.  Also, generally the copyright line includes the author&apos;s email, but I guess that&apos;s not required.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>100431</commentid>
    <comment_count>6</comment_count>
      <attachid>25527</attachid>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-11-26 12:18:38 -0800</bug_when>
    <thetext>Created attachment 25527
Reference of skeleton + test case

This is for reference to see how the skeleton is filled with content. I would prefer if the test case is landed together with the bugfix from bug #21837.

The skeleton should just be added before the landing of the fix...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>101754</commentid>
    <comment_count>7</comment_count>
    <who name="Holger Freyther">zecke</who>
    <bug_when>2008-12-07 11:17:35 -0800</bug_when>
    <thetext>Landed in r39082. The skeleton will be filled with content once we have a fix for Bug #21837.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25493</attachid>
            <date>2008-11-25 12:03:03 -0800</date>
            <delta_ts>2008-11-26 08:11:35 -0800</delta_ts>
            <desc>Add unit test skeletong for WebKit/Gtk+</desc>
            <filename>0002--Gtk-Use-glib-s-unit-test-facilities-to-test-the-W.patch</filename>
            <type>text/plain</type>
            <size>2827</size>
            <attacher name="Holger Freyther">zecke</attacher>
            
              <data encoding="base64">RnJvbSAyZGZkYjVmYjZjODg5YjRiNzQ0YzFiZGVlZmJmZmVmYTc3Njc5OGQ2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs
ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjUgTm92IDIwMDggMTc6MDA6MDUgKzAxMDAKU3ViamVjdDog
W1BBVENIXSBbR3RrK10gVXNlIGdsaWIncyB1bml0IHRlc3QgZmFjaWxpdGllcyB0byB0ZXN0IHRo
ZSBXZWJLaXQvR3RrKyBBUEkKCiAgICBBZGQgdGhlIHNrZWxldG9uIHRvIFdlYktpdC9ndGsvdGVz
dHMgYW5kIGludGVncmF0ZSB0aGF0IGludG8gdGhlCiAgICBidWlsZHN5c3RlbS4gVGVzdGluZyBz
dXBwb3J0IHdhcyBhZGRlZCBpbiBnbGliIDIuMTYuIEZvciB2ZXJzaW9ucwogICAgdXNpbmcgZ2xp
YiA8IDIuMTYgd2UgY29tcGlsZSBhbiBlbXB0eSBhcHBsaWNhdGlvbi4KLS0tCiBHTlVtYWtlZmls
ZS5hbSAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysrKwogV2ViS2l0L2d0ay90
ZXN0cy9tYWluLmMgfCAgIDQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrCiAyIGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBj
cmVhdGUgbW9kZSAxMDA2NDQgV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKCmRpZmYgLS1naXQgYS9H
TlVtYWtlZmlsZS5hbSBiL0dOVW1ha2VmaWxlLmFtCmluZGV4IDY5YjhjNzAuLjgwY2E3MGQgMTAw
NjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC00NTksNiAr
NDU5LDI4IEBAIGluY2x1ZGUgSmF2YVNjcmlwdENvcmUvR05VbWFrZWZpbGUuYW0KIGluY2x1ZGUg
V2ViQ29yZS9HTlVtYWtlZmlsZS5hbQogaW5jbHVkZSBXZWJLaXRUb29scy9HTlVtYWtlZmlsZS5h
bQogCisjIEJ1aWxkIHVuaXQgdGVzdAorbm9pbnN0X1BST0dSQU1TICs9IFByb2dyYW1zL1VuaXRU
ZXN0cworUHJvZ3JhbXNfVW5pdFRlc3RzX0NQUEZMQUdTID0gXAorCS1JJChzcmNkaXIpL1dlYktp
dC9ndGsgXAorCS1JJCh0b3BfYnVpbGRkaXIpL1dlYktpdC9ndGsgXAorCSQoZ2xvYmFsX2NwcGZs
YWdzKSBcCisJJChqYXZhc2NyaXB0Y29yZV9jcHBmbGFncykKKworUHJvZ3JhbXNfVW5pdFRlc3Rz
X1NPVVJDRVMgPSBcCisJV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKKworUHJvZ3JhbXNfVW5pdFRl
c3RzX0NGTEFHUyA9IFwKKwktZm5vLXN0cmljdC1hbGlhc2luZyBcCisJLU8yIFwKKwkkKGdsb2Jh
bF9jZmxhZ3MpIFwKKwkkKEdMSUJfQ0ZMQUdTKSBcCisJJChHVEtfQ0ZMQUdTKQorCitQcm9ncmFt
c19Vbml0VGVzdHNfTERBREQgPSBcCisJbGlid2Via2l0LTEuMC5sYSBcCisJJChHVEtfTElCUykK
KwogIyBBdXRvZ2VuZXJhdGVkIHNvdXJjZXMKIEJVSUxUX1NPVVJDRVMgOj0gXAogCSQoamF2YXNj
cmlwdGNvcmVfYnVpbHRfc291cmNlcykgXApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay90ZXN0cy9t
YWluLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL21haW4uYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl
eCAwMDAwMDAwLi5jZGYzYTczCi0tLSAvZGV2L251bGwKKysrIGIvV2ViS2l0L2d0ay90ZXN0cy9t
YWluLmMKQEAgLTAsMCArMSw0MSBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAwOCBIb2xnZXIg
SGFucyBQZXRlciBGcmV5dGhlcgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJl
OyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUg
dGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1
Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNp
b24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lv
bi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBp
dCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBl
dmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVT
UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5l
cmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBo
YXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGlj
ZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJ
Qi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu
Yy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEw
LTEzMDEsIFVTQS4KKyAqLworCisjaW5jbHVkZSA8Z2xpYi5oPgorI2luY2x1ZGUgPHdlYmtpdC93
ZWJraXQuaD4KKworI2lmIEdMSUJfQ0hFQ0tfVkVSU0lPTigyLCAxNiwgMCkKKworaW50IG1haW4o
aW50IGFyZ2MsIGNoYXIqKiBhcmd2KQoreworICAgIGdfdGhyZWFkX2luaXQoTlVMTCk7CisgICAg
Z3RrX3Rlc3RfaW5pdCgmYXJnYywgJmFyZ3YsIE5VTEwpOworCisgICAgZ190ZXN0X2J1Z19iYXNl
KCJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy8iKTsKKworICAgIHJldHVybiBnX3Rlc3RfcnVuICgp
OworfQorCisjZWxzZQoraW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQoreworICAgIHJl
dHVybiAwOworfQorCisjZW5kaWYKLS0gCjEuNS42LjMKCg==
</data>
<flag name="review"
          id="11844"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25519</attachid>
            <date>2008-11-26 08:11:35 -0800</date>
            <delta_ts>2008-11-26 12:18:20 -0800</delta_ts>
            <desc>Add unit test skeleton for WebKit/Gtk+</desc>
            <filename>0002--Gtk-Use-glib-s-unit-test-facilities-to-test-the-W.patch</filename>
            <type>text/plain</type>
            <size>2925</size>
            <attacher name="Holger Freyther">zecke</attacher>
            
              <data encoding="base64">RnJvbSAyOTQ2MmZkOTk3ZTIwZGQ3ZjY2ODU3ZTI2MDc1ZTMwY2U1ZWUyYjU2IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs
ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjUgTm92IDIwMDggMTc6MDA6MDUgKzAxMDAKU3ViamVjdDog
W1BBVENIXSBbR3RrK10gVXNlIGdsaWIncyB1bml0IHRlc3QgZmFjaWxpdGllcyB0byB0ZXN0IHRo
ZSBXZWJLaXQvR3RrKyBBUEkKCiAgICBBZGQgdGhlIHNrZWxldG9uIHRvIFdlYktpdC9ndGsvdGVz
dHMgYW5kIGludGVncmF0ZSB0aGF0IGludG8gdGhlCiAgICBidWlsZHN5c3RlbS4gVGVzdGluZyBz
dXBwb3J0IHdhcyBhZGRlZCBpbiBnbGliIDIuMTYuIEZvciB2ZXJzaW9ucwogICAgdXNpbmcgZ2xp
YiA8IDIuMTYgd2UgY29tcGlsZSBhbiBlbXB0eSBhcHBsaWNhdGlvbi4KLS0tCiBHTlVtYWtlZmls
ZS5hbSAgICAgICAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKysrKwogV2ViS2l0L2d0ay90
ZXN0cy9tYWluLmMgfCAgIDQyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr
KysrKwogMiBmaWxlcyBjaGFuZ2VkLCA2NCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQog
Y3JlYXRlIG1vZGUgMTAwNjQ0IFdlYktpdC9ndGsvdGVzdHMvbWFpbi5jCgpkaWZmIC0tZ2l0IGEv
R05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5hbQppbmRleCA2OWI4YzcwLi44MGNhNzBkIDEw
MDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtNDU5LDYg
KzQ1OSwyOCBAQCBpbmNsdWRlIEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCiBpbmNsdWRl
IFdlYkNvcmUvR05VbWFrZWZpbGUuYW0KIGluY2x1ZGUgV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUu
YW0KIAorIyBCdWlsZCB1bml0IHRlc3QKK25vaW5zdF9QUk9HUkFNUyArPSBQcm9ncmFtcy9Vbml0
VGVzdHMKK1Byb2dyYW1zX1VuaXRUZXN0c19DUFBGTEFHUyA9IFwKKwktSSQoc3JjZGlyKS9XZWJL
aXQvZ3RrIFwKKwktSSQodG9wX2J1aWxkZGlyKS9XZWJLaXQvZ3RrIFwKKwkkKGdsb2JhbF9jcHBm
bGFncykgXAorCSQoamF2YXNjcmlwdGNvcmVfY3BwZmxhZ3MpCisKK1Byb2dyYW1zX1VuaXRUZXN0
c19TT1VSQ0VTID0gXAorCVdlYktpdC9ndGsvdGVzdHMvbWFpbi5jCisKK1Byb2dyYW1zX1VuaXRU
ZXN0c19DRkxBR1MgPSBcCisJLWZuby1zdHJpY3QtYWxpYXNpbmcgXAorCS1PMiBcCisJJChnbG9i
YWxfY2ZsYWdzKSBcCisJJChHTElCX0NGTEFHUykgXAorCSQoR1RLX0NGTEFHUykKKworUHJvZ3Jh
bXNfVW5pdFRlc3RzX0xEQUREID0gXAorCWxpYndlYmtpdC0xLjAubGEgXAorCSQoR1RLX0xJQlMp
CisKICMgQXV0b2dlbmVyYXRlZCBzb3VyY2VzCiBCVUlMVF9TT1VSQ0VTIDo9IFwKIAkkKGphdmFz
Y3JpcHRjb3JlX2J1aWx0X3NvdXJjZXMpIFwKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvdGVzdHMv
bWFpbi5jIGIvV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k
ZXggMDAwMDAwMC4uN2QxYmJkZgotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdC9ndGsvdGVzdHMv
bWFpbi5jCkBAIC0wLDAgKzEsNDIgQEAKKy8qCisgKiBDb3B5cmlnaHQgKEMpIDIwMDggSG9sZ2Vy
IEhhbnMgUGV0ZXIgRnJleXRoZXIKKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2Fy
ZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiBtb2RpZnkgaXQgdW5kZXIgdGhl
IHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYworICogTGljZW5zZSBhcyBw
dWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0aGVyCisgKiB2ZXJz
aW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNp
b24uCisgKgorICogVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQg
aXQgd2lsbCBiZSB1c2VmdWwsCisgKiBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQg
ZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorICogTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5F
U1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUKKyAqIExpYnJhcnkgR2Vu
ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQg
aGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExp
Y2Vuc2UKKyAqIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUgdGhlIGZpbGUgQ09QWUlORy5M
SUIuICBJZiBub3QsIHdyaXRlIHRvCisgKiB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJ
bmMuLCA1MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAorICogQm9zdG9uLCBNQSAwMjEx
MC0xMzAxLCBVU0EuCisgKi8KKworI2luY2x1ZGUgPGdsaWIuaD4KKyNpbmNsdWRlIDx3ZWJraXQv
d2Via2l0Lmg+CisKKyNpZiBHTElCX0NIRUNLX1ZFUlNJT04oMiwgMTYsIDApCisKK2ludCBtYWlu
KGludCBhcmdjLCBjaGFyKiogYXJndikKK3sKKyAgICBnX3RocmVhZF9pbml0KE5VTEwpOworICAg
IGd0a190ZXN0X2luaXQoJmFyZ2MsICZhcmd2LCBOVUxMKTsKKworICAgIGdfdGVzdF9idWdfYmFz
ZSgiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvIik7CisKKyAgICByZXR1cm4gZ190ZXN0X3J1biAo
KTsKK30KKworI2Vsc2UKK2ludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKK3sKKyAgICBn
X2NyaXRpY2FsKCJZb3Ugd2lsbCBuZWVkIGF0IGxlYXN0IGdsaWItMi4xNi4wIHRvIHJ1biB0aGUg
dW5pdCB0ZXN0cy4gRG9pbmcgbm90aGluZyBub3cuIik7CisgICAgcmV0dXJuIDA7Cit9CisKKyNl
bmRpZgotLSAKMS41LjYuMwoK
</data>
<flag name="review"
          id="11859"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25527</attachid>
            <date>2008-11-26 12:18:38 -0800</date>
            <delta_ts>2008-11-26 12:18:38 -0800</delta_ts>
            <desc>Reference of skeleton + test case</desc>
            <filename>0001-For-reference-squashed-together.patch</filename>
            <type>text/plain</type>
            <size>4626</size>
            <attacher name="Holger Freyther">zecke</attacher>
            
              <data encoding="base64">RnJvbSA5MzZlMDkxMTc1MDhiZTE1ZWZkNWQ3NWE1Y2ZmYTUzNDNhZWNiYmUxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs
ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjUgTm92IDIwMDggMTc6MDA6MDUgKzAxMDAKU3ViamVjdDog
W1BBVENIXSBGb3IgcmVmZXJlbmNlIHNxdWFzaGVkIHRvZ2V0aGVyLi4uCgpbR3RrK10gVXNlIGds
aWIncyB1bml0IHRlc3QgZmFjaWxpdGllcyB0byB0ZXN0IHRoZSBXZWJLaXQvR3RrKyBBUEkKCiAg
ICBBZGQgdGhlIHNrZWxldG9uIHRvIFdlYktpdC9ndGsvdGVzdHMgYW5kIGludGVncmF0ZSB0aGF0
IGludG8gdGhlCiAgICBidWlsZHN5c3RlbS4gVGVzdGluZyBzdXBwb3J0IHdhcyBhZGRlZCBpbiBn
bGliIDIuMTYuIEZvciB2ZXJzaW9ucwogICAgdXNpbmcgZ2xpYiA8IDIuMTYgd2UgY29tcGlsZSBh
biBlbXB0eSBhcHBsaWNhdGlvbi4KCltHdGsrXSBBZGQgYSB0ZXN0IGZvciB0aGUgbGlmZSBjeWNs
ZSBvZiBXZWJLaXRXZWJGcmFtZSdzIGFzIG9mIGJ1ZyAjMjE4MzcKCiAgICBDcmVhdGUgYW5kIERl
c3Ryb3kgYSBXZWJWaWV3LiBUaGlzIHNob3VsZCBub3QgY3Jhc2guIEFsc28gdmVyaWZ5CiAgICB0
aGF0IHRoZSBXZWJLaXRXZWJGcmFtZSBpcyBkZXN0cm95ZWQgd2hlbiBkZXN0cm95aW5nIHRoZQog
ICAgV2ViS2l0V2ViVmlldy4KLS0tCiBHTlVtYWtlZmlsZS5hbSAgICAgICAgICB8ICAgMjIgKysr
KysrKysrKysrCiBXZWJLaXQvZ3RrL3Rlc3RzL21haW4uYyB8ICAgODMgKysrKysrKysrKysrKysr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTA1IGlu
c2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgV2ViS2l0L2d0
ay90ZXN0cy9tYWluLmMKCmRpZmYgLS1naXQgYS9HTlVtYWtlZmlsZS5hbSBiL0dOVW1ha2VmaWxl
LmFtCmluZGV4IDY5YjhjNzAuLjgwY2E3MGQgMTAwNjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisr
KyBiL0dOVW1ha2VmaWxlLmFtCkBAIC00NTksNiArNDU5LDI4IEBAIGluY2x1ZGUgSmF2YVNjcmlw
dENvcmUvR05VbWFrZWZpbGUuYW0KIGluY2x1ZGUgV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQogaW5j
bHVkZSBXZWJLaXRUb29scy9HTlVtYWtlZmlsZS5hbQogCisjIEJ1aWxkIHVuaXQgdGVzdAorbm9p
bnN0X1BST0dSQU1TICs9IFByb2dyYW1zL1VuaXRUZXN0cworUHJvZ3JhbXNfVW5pdFRlc3RzX0NQ
UEZMQUdTID0gXAorCS1JJChzcmNkaXIpL1dlYktpdC9ndGsgXAorCS1JJCh0b3BfYnVpbGRkaXIp
L1dlYktpdC9ndGsgXAorCSQoZ2xvYmFsX2NwcGZsYWdzKSBcCisJJChqYXZhc2NyaXB0Y29yZV9j
cHBmbGFncykKKworUHJvZ3JhbXNfVW5pdFRlc3RzX1NPVVJDRVMgPSBcCisJV2ViS2l0L2d0ay90
ZXN0cy9tYWluLmMKKworUHJvZ3JhbXNfVW5pdFRlc3RzX0NGTEFHUyA9IFwKKwktZm5vLXN0cmlj
dC1hbGlhc2luZyBcCisJLU8yIFwKKwkkKGdsb2JhbF9jZmxhZ3MpIFwKKwkkKEdMSUJfQ0ZMQUdT
KSBcCisJJChHVEtfQ0ZMQUdTKQorCitQcm9ncmFtc19Vbml0VGVzdHNfTERBREQgPSBcCisJbGli
d2Via2l0LTEuMC5sYSBcCisJJChHVEtfTElCUykKKwogIyBBdXRvZ2VuZXJhdGVkIHNvdXJjZXMK
IEJVSUxUX1NPVVJDRVMgOj0gXAogCSQoamF2YXNjcmlwdGNvcmVfYnVpbHRfc291cmNlcykgXApk
aWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMgYi9XZWJLaXQvZ3RrL3Rlc3RzL21h
aW4uYwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5lMjg1NjE1Ci0tLSAvZGV2
L251bGwKKysrIGIvV2ViS2l0L2d0ay90ZXN0cy9tYWluLmMKQEAgLTAsMCArMSw4MyBAQAorLyoK
KyAqIENvcHlyaWdodCAoQykgMjAwOCBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlcgorICoKKyAq
IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh
bmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdl
bmVyYWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2Fy
ZSBGb3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0
IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMg
ZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBX
SVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9m
CisgKiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0Uu
ICBTZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3Jl
IGRldGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUg
R05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxp
YnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRo
ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlm
dGggRmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqLworCisjaW5jbHVk
ZSA8Z2xpYi5oPgorI2luY2x1ZGUgPHdlYmtpdC93ZWJraXQuaD4KKworI2lmIEdMSUJfQ0hFQ0tf
VkVSU0lPTigyLCAxNiwgMCkKKworc3RhdGljIHZvaWQgdGVzdF93ZWJraXRfd2ViX2ZyYW1lX2Ny
ZWF0ZV9kZXN0cm95KHZvaWQpCit7CisgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldzsKKyAgICBn
X3Rlc3RfYnVnKCIyMTgzNyIpOworCisgICAgd2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyh3ZWJr
aXRfd2ViX3ZpZXdfbmV3KCkpOworICAgIGdfb2JqZWN0X3JlZl9zaW5rKHdlYlZpZXcpOworICAg
IGdfYXNzZXJ0X2NtcGludChHX09CSkVDVCh3ZWJWaWV3KS0+cmVmX2NvdW50LCA9PSwgMSk7CisK
KyAgICAvLyBUaGlzIGNyYXNoZWQgd2l0aCB0aGUgb3JpZ2luYWwgdmVyc2lvbgorICAgIGdfb2Jq
ZWN0X3VucmVmKHdlYlZpZXcpOworfQorCitzdGF0aWMgdm9pZCB0ZXN0X3dlYmtpdF93ZWJfZnJh
bWVfbGlmZXRpbWUodm9pZCkKK3sKKyAgICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3OworICAgIFdl
YktpdFdlYkZyYW1lKiB3ZWJGcmFtZTsKKyAgICBnX3Rlc3RfYnVnKCIyMTgzNyIpOworCisgICAg
d2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyh3ZWJraXRfd2ViX3ZpZXdfbmV3KCkpOworICAgIGdf
b2JqZWN0X3JlZl9zaW5rKHdlYlZpZXcpOworICAgIGdfYXNzZXJ0X2NtcGludChHX09CSkVDVCh3
ZWJWaWV3KS0+cmVmX2NvdW50LCA9PSwgMSk7CisgICAgd2ViRnJhbWUgPSB3ZWJraXRfd2ViX3Zp
ZXdfZ2V0X21haW5fZnJhbWUod2ViVmlldyk7CisgICAgZ19hc3NlcnRfY21waW50KEdfT0JKRUNU
KHdlYkZyYW1lKS0+cmVmX2NvdW50LCA9PSwgMSk7CisKKyAgICAvLyBBZGQgZHVtbXkgcmVmZXJl
bmNlIG9uIHRoZSBXZWJLaXRXZWJGcmFtZSB0byBrZWVwIGl0IGFsaXZlCisgICAgZ19vYmplY3Rf
cmVmKHdlYkZyYW1lKTsKKyAgICBnX2Fzc2VydF9jbXBpbnQoR19PQkpFQ1Qod2ViRnJhbWUpLT5y
ZWZfY291bnQsID09LCAyKTsKKworICAgIC8vIFRoaXMgY3Jhc2hlZCB3aXRoIHRoZSBvcmlnaW5h
bCB2ZXJzaW9uCisgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CisKKyAgICAvLyBNYWtlIHN1
cmUgdGhhdCB0aGUgZnJhbWUgZ290IGRlbGV0ZWQgYXMgd2VsbC4gV2UgZGlkIHRoaXMKKyAgICAv
LyBieSBhZGRpbmcgYW4gZXh0cmEgcmVmIG9uIHRoZSBXZWJLaXRXZWJGcmFtZSBhbmQgd2Ugc2hv
dWxkCisgICAgLy8gYmUgdGhlIG9uZSBob2xkaW5nIHRoZSBsYXN0IHJlZmVyZW5jZS4KKyAgICBn
X2Fzc2VydF9jbXBpbnQoR19PQkpFQ1Qod2ViRnJhbWUpLT5yZWZfY291bnQsID09LCAxKTsKKyAg
ICBnX29iamVjdF91bnJlZih3ZWJGcmFtZSk7Cit9CisKK2ludCBtYWluKGludCBhcmdjLCBjaGFy
KiogYXJndikKK3sKKyAgICBnX3RocmVhZF9pbml0KE5VTEwpOworICAgIGd0a190ZXN0X2luaXQo
JmFyZ2MsICZhcmd2LCBOVUxMKTsKKworICAgIGdfdGVzdF9idWdfYmFzZSgiaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvIik7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L3dlYnZpZXcvY3Jl
YXRlX2Rlc3Ryb3kiLCB0ZXN0X3dlYmtpdF93ZWJfZnJhbWVfY3JlYXRlX2Rlc3Ryb3kpOworICAg
IGdfdGVzdF9hZGRfZnVuYygiL3dlYmtpdC93ZWJmcmFtZS9saWZldGltZSIsIHRlc3Rfd2Via2l0
X3dlYl9mcmFtZV9saWZldGltZSk7CisKKyAgICByZXR1cm4gZ190ZXN0X3J1biAoKTsKK30KKwor
I2Vsc2UKK2ludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKK3sKKyAgICBnX2NyaXRpY2Fs
KCJZb3Ugd2lsbCBuZWVkIGF0IGxlYXN0IGdsaWItMi4xNi4wIHRvIHJ1biB0aGUgdW5pdCB0ZXN0
cy4gRG9pbmcgbm90aGluZyBub3cuIik7CisgICAgcmV0dXJuIDA7Cit9CisKKyNlbmRpZgotLSAK
MS41LjYuMwoK
</data>

          </attachment>
      

    </bug>

</bugzilla>