224885 2021-04-21 12:21:02 -0700 PCM: Remove PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable overrides in testing 2021-05-04 13:45:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224321 https://bugs.webkit.org/show_bug.cgi?id=225364 InRadar P2 Normal --- 1 wilander wilander bfulgham jiewen_tan webkit-bug-importer oldest_to_newest 1752860 0 wilander 2021-04-21 12:21:02 -0700 We had a temporary override to PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable in WebKit::PrivateClickMeasurementManager::getTokenPublicKey() and WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken(). We should remove those overrides since the network load hang has been resolved. 1752862 1 webkit-bug-importer 2021-04-21 12:22:50 -0700 <rdar://problem/76973184> 1752868 2 426730 wilander 2021-04-21 12:30:13 -0700 Created attachment 426730 Patch 1752908 3 426730 bfulgham 2021-04-21 13:46:58 -0700 Comment on attachment 426730 Patch rs=me 1752919 4 wilander 2021-04-21 14:12:19 -0700 Thanks, Brent! Waiting for EWS’s verdict before landing. 1752986 5 wilander 2021-04-21 17:35:41 -0700 iOS bot test failure is unrelated. 1752999 6 ews-feeder 2021-04-21 18:15:20 -0700 Committed r276413 (236878@main): <https://commits.webkit.org/236878@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426730. 1756642 7 jiewen_tan 2021-05-04 13:06:33 -0700 This change has caused TestWebKitAPI.EventAttribution.FraudPrevention to timeout. 1756650 8 jiewen_tan 2021-05-04 13:41:20 -0700 The change will be reverted in 224321 then. 1756653 9 jiewen_tan 2021-05-04 13:45:18 -0700 (In reply to Jiewen Tan from comment #7) > This change has caused TestWebKitAPI.EventAttribution.FraudPrevention to > timeout. Here is the test history: https://results.safari.apple.com/?suite=api-tests&test=TestWebKitAPI.EventAttribution.FraudPrevention. And here is the range of changes: https://trac.webkit.org/log/webkit/?action=stop_on_copy&mode=stop_on_copy&rev=276427&stop_rev=276379&limit=999. This is the only relevant change in that range. And I have locally confirmed that this is the cause. 426730 2021-04-21 12:30:13 -0700 2021-04-21 18:15:20 -0700 Patch bug-224885-20210421123012.patch text/plain 2868 wilander U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDA2NjA4MDI1MDZiYjczNmFi OTBmNDkzZjkyNjRjY2IxNGU0ZmUxYjkuLjg4YjNjZDM3MmQ0MWNkOWU2ZWIyMDVmZjBiZTRjNTU1 YWVhM2Y5ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDQtMjEgIEpvaG4gV2ls YW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CisKKyAgICAgICAgUENNOiBSZW1vdmUgUHJpdmF0 ZUNsaWNrTWVhc3VyZW1lbnQ6OlBjbURhdGFDYXJyaWVkOjpOb25QZXJzb25hbGx5SWRlbnRpZmlh YmxlIG92ZXJyaWRlcyBpbiB0ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjQ4ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2OTczMTg0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGhh ZCBhIHRlbXBvcmFyeSBvdmVycmlkZSB0byBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudDo6UGNtRGF0 YUNhcnJpZWQ6Ok5vblBlcnNvbmFsbHlJZGVudGlmaWFibGUKKyAgICAgICAgaW4gV2ViS2l0OjpQ cml2YXRlQ2xpY2tNZWFzdXJlbWVudE1hbmFnZXI6OmdldFRva2VuUHVibGljS2V5KCkgYW5kCisg ICAgICAgIFdlYktpdDo6UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyOjpnZXRTaWduZWRV bmxpbmthYmxlVG9rZW4oKS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgdGhvc2Ugb3Zl cnJpZGVzIHNpbmNlIHRoZSBuZXR3b3JrIGxvYWQgaGFuZyBoYXMgYmVlbiByZXNvbHZlZC4KKwor ICAgICAgICBObyBuZXcgdGVzdHMuIEV4aXN0aW5nIHRlc3RzIGNvdmVyIHRoaXMgY29kZS4KKwor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL1ByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlci5j cHA6CisgICAgICAgIChXZWJLaXQ6OlByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6Z2V0 VG9rZW5QdWJsaWNLZXkpOgorICAgICAgICAoV2ViS2l0OjpQcml2YXRlQ2xpY2tNZWFzdXJlbWVu dE1hbmFnZXI6OmdldFNpZ25lZFVubGlua2FibGVUb2tlbik6CisKIDIwMjEtMDQtMjEgIEthdGUg Q2hlbmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CiAKICAgICAgICAgRm9sbG93dXAg Y2hhbmdlIHRvIGJ1ZyAyMjQ3NzkgYmFzZWQgb24gcG9zdC1sYW5kIHJldmlldyBjb21tZW50Lgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2YXRlQ2xpY2tNZWFz dXJlbWVudE1hbmFnZXIuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9Qcml2YXRl Q2xpY2tNZWFzdXJlbWVudE1hbmFnZXIuY3BwCmluZGV4IDYwNTI2OTI3MzI0ZjFjN2FlNzBkYjQx ZmU1Njk1MGQ2YTFmMjljMzIuLjhjODMzY2E4YWEzM2FhZTFlM2E1MWQwZTkxZTlmYzFkZjk1YTk0 OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvUHJpdmF0ZUNsaWNr TWVhc3VyZW1lbnRNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L1ByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlci5jcHAKQEAgLTE0NSw3ICsxNDUsNiBAQCB2 b2lkIFByaXZhdGVDbGlja01lYXN1cmVtZW50TWFuYWdlcjo6Z2V0VG9rZW5QdWJsaWNLZXkoUHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnQmJgogICAgICAgICBpZiAoYXR0cmlidXRpb25SZXBvcnRFbmRw b2ludCA9PSBQcml2YXRlQ2xpY2tNZWFzdXJlbWVudDo6QXR0cmlidXRpb25SZXBvcnRFbmRwb2lu dDo6RGVzdGluYXRpb24pCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIHRva2VuUHVibGlj S2V5VVJMID0gKm1fdG9rZW5QdWJsaWNLZXlVUkxGb3JUZXN0aW5nOwotICAgICAgICBwY21EYXRh Q2FycmllZCA9IFByaXZhdGVDbGlja01lYXN1cmVtZW50OjpQY21EYXRhQ2FycmllZDo6Tm9uUGVy c29uYWxseUlkZW50aWZpYWJsZTsKICAgICB9CiAKICAgICBpZiAodG9rZW5QdWJsaWNLZXlVUkwu aXNFbXB0eSgpIHx8ICF0b2tlblB1YmxpY0tleVVSTC5pc1ZhbGlkKCkpCkBAIC0xODMsMTAgKzE4 Miw4IEBAIHZvaWQgUHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnRNYW5hZ2VyOjpnZXRTaWduZWRVbmxp bmthYmxlVG9rZW4oUHJpdmF0ZUNsaWNrTWVhc3VyCiAgICAgLy8gVGhpcyBpcyBndWFyYW50ZWVk IHRvIGJlIGNsb3NlIGluIHRpbWUgdG8gdGhlIG5hdmlnYXRpb25hbCBjbGljayB3aGljaCBtYWtl cyBpdCBsaWtlbHkgdG8gYmUgcGVyc29uYWxseSBpZGVudGlmaWFibGUuCiAgICAgYXV0byBwY21E YXRhQ2FycmllZCA9IFByaXZhdGVDbGlja01lYXN1cmVtZW50OjpQY21EYXRhQ2FycmllZDo6UGVy c29uYWxseUlkZW50aWZpYWJsZTsKICAgICBhdXRvIHRva2VuU2lnbmF0dXJlVVJMID0gYXR0cmli dXRpb24udG9rZW5TaWduYXR1cmVVUkwoKTsKLSAgICBpZiAobV90b2tlblNpZ25hdHVyZVVSTEZv clRlc3RpbmcpIHsKKyAgICBpZiAobV90b2tlblNpZ25hdHVyZVVSTEZvclRlc3RpbmcpCiAgICAg ICAgIHRva2VuU2lnbmF0dXJlVVJMID0gKm1fdG9rZW5TaWduYXR1cmVVUkxGb3JUZXN0aW5nOwot ICAgICAgICBwY21EYXRhQ2FycmllZCA9IFByaXZhdGVDbGlja01lYXN1cmVtZW50OjpQY21EYXRh Q2FycmllZDo6Tm9uUGVyc29uYWxseUlkZW50aWZpYWJsZTsKLSAgICB9CiAKICAgICBpZiAodG9r ZW5TaWduYXR1cmVVUkwuaXNFbXB0eSgpIHx8ICF0b2tlblNpZ25hdHVyZVVSTC5pc1ZhbGlkKCkp CiAgICAgICAgIHJldHVybjsK