224879 2021-04-21 10:41:58 -0700 webkitpy's git code should always use --no-abbrev-commit 2021-04-22 18:08:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1752818 0 gsnedders 2021-04-21 10:41:58 -0700 At least some of our tests break with log.abbrevCommit set to true. I don't know how much this breaks actual functionality, but we should simply outright avoid it being a risk by always passing --no-abbrev-commit to log/show which overrides the config option. 1752821 1 426713 gsnedders 2021-04-21 10:49:29 -0700 Created attachment 426713 Patch 1752886 2 ews-feeder 2021-04-21 13:06:51 -0700 Committed r276387 (236862@main): <https://commits.webkit.org/236862@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426713. 1753419 3 webkit-bug-importer 2021-04-22 18:08:12 -0700 <rdar://problem/77048736> 426713 2021-04-21 10:49:29 -0700 2021-04-21 13:06:52 -0700 Patch bug-224879-20210421184928.patch text/plain 6584 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOThiYjE3M2E2MjU1NmZjNDRkNjEwYmRiZGVlNDE0Yjc1 ZGE4NjhkMS4uZTEyYmE3ZjRiYjExZDNjMGI3ZjM0MTMyYjA2YmY4MzhiNzMwYmQ4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDIxLTA0LTIxICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgQWx3YXlzIHBhc3MgLS1uby1hYmJyZXYtY29tbWl0IHRvIGdpdC1sb2cvc2hvdworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0ODc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IHNv bWUgb2YgdGhlIFNDTSB0ZXN0cyBmYWlsIHdpdGggZ2l0J3MgbG9nLmFiYnJldkNvbW1pdDsgd2Ug c2hvdWxkCisgICAgICAgIGF2b2lkIGFueSByaXNrIG9mIHRoZSB0ZXN0cyBmYWlsaW5nIG9yIGZ1 bmN0aW9uYWxpdHkgYmVpbmcgYnJva2VuIGJ5IGFsd2F5cworICAgICAgICBhc2tpbmcgZm9yIHRo ZSB1bmFiYnJldmlhdGVkIGNvbW1pdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29t bW9uL2NoZWNrb3V0L3NjbS9naXQucHk6CisgICAgICAgIChHaXQubG9jYWxfY29tbWl0cyk6Cisg ICAgICAgIChHaXQuZXhpc3RzKToKKyAgICAgICAgKEdpdC5fY2hhbmdlc19maWxlc19mb3JfY29t bWl0KToKKyAgICAgICAgKEdpdC5yZXZpc2lvbnNfY2hhbmdpbmdfZmlsZSk6CisgICAgICAgIChH aXQuX21vc3RfcmVjZW50X2xvZ19tYXRjaGluZyk6CisgICAgICAgIChHaXQuX21vc3RfcmVjZW50 X2xvZ19mb3JfcmV2aXNpb24pOgorICAgICAgICAoR2l0LmdpdF9jb21taXRfZnJvbV9zdm5fcmV2 aXNpb24pOgorICAgICAgICAoR2l0LmNvbnRlbnRzX2F0X3JldmlzaW9uKToKKyAgICAgICAgKEdp dC5zaG93X2hlYWQpOgorICAgICAgICAoR2l0LmNvbW1pdHRlcl9lbWFpbF9mb3JfcmV2aXNpb24p OgorCiAyMDIxLTA0LTIxICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtXUEVdIEFsbG93IGRlZmluaW5nIGN1c3RvbSByZXBvIGFuZCBicmFuY2ggZm9yIENvZyBj aGVja291dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tv dXQvc2NtL2dpdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3Nj bS9naXQucHkKaW5kZXggNGEyNDhmZTIyYjIxODQxN2M1NDc0YWVlZGZlYjc2NDExNWMwY2ZmNC4u ZDg0YWY0NGNjZDIwNWMzODYwMDViOGIxMzFiODQ1OWNkMmVjNzhhZiAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL2dpdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vZ2l0LnB5CkBAIC0xNTUsNyAr MTU1LDcgQEAgY2xhc3MgR2l0KFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAgICAgICAgIHNlbGYuX3J1 bl9naXQoWydyZXNldCcsICctLWhhcmQnLCBzZWxmLnJlbW90ZV9icmFuY2hfcmVmKCldKQogCiAg ICAgZGVmIGxvY2FsX2NvbW1pdHMoc2VsZik6Ci0gICAgICAgIHJldHVybiBzZWxmLl9ydW5fZ2l0 KFsnbG9nJywgJy0tcHJldHR5PW9uZWxpbmUnLCAnSEVBRC4uLicgKyBzZWxmLnJlbW90ZV9icmFu Y2hfcmVmKCldKS5zcGxpdGxpbmVzKCkKKyAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWyds b2cnLCAnLS1uby1hYmJyZXYtY29tbWl0JywgJy0tcHJldHR5PW9uZWxpbmUnLCAnSEVBRC4uLicg KyBzZWxmLnJlbW90ZV9icmFuY2hfcmVmKCldKS5zcGxpdGxpbmVzKCkKIAogICAgIGRlZiByZWJh c2VfaW5fcHJvZ3Jlc3Moc2VsZik6CiAgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lzdGVtLmV4 aXN0cyhzZWxmLmFic29sdXRlX3BhdGgoc2VsZi5fZmlsZXN5c3RlbS5qb2luKCcuZ2l0JywgJ3Jl YmFzZS1hcHBseScpKSkKQEAgLTE4NSw3ICsxODUsNyBAQCBjbGFzcyBHaXQoU0NNLCBTVk5SZXBv c2l0b3J5KToKICAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWyJybSIsICItZiJdICsgcGF0 aHMpCiAKICAgICBkZWYgZXhpc3RzKHNlbGYsIHBhdGgpOgotICAgICAgICByZXR1cm5fY29kZSA9 IHNlbGYuX3J1bl9naXQoWyJzaG93IiwgIkhFQUQ6JXMiICUgcGF0aF0sIHJldHVybl9leGl0X2Nv ZGU9VHJ1ZSwgZGVjb2RlX291dHB1dD1GYWxzZSkKKyAgICAgICAgcmV0dXJuX2NvZGUgPSBzZWxm Ll9ydW5fZ2l0KFsic2hvdyIsICItLW5vLWFiYnJldi1jb21taXQiLCAiSEVBRDolcyIgJSBwYXRo XSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlLCBkZWNvZGVfb3V0cHV0PUZhbHNlKQogICAgICAgICBy ZXR1cm4gcmV0dXJuX2NvZGUgIT0gc2VsZi5FUlJPUl9GSUxFX0lTX01JU1NJTkcKIAogICAgIGRl ZiBfYnJhbmNoX2Zyb21fcmVmKHNlbGYsIHJlZik6CkBAIC0yNDMsNyArMjQzLDcgQEAgY2xhc3Mg R2l0KFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAKICAgICBkZWYgX2NoYW5nZXNfZmlsZXNfZm9yX2Nv bW1pdChzZWxmLCBnaXRfY29tbWl0KToKICAgICAgICAgIyAtLXByZXR0eT0iZm9ybWF0OiIgbWFr ZXMgZ2l0IHNob3cgbm90IHByaW50IHRoZSBjb21taXQgbG9nIGhlYWRlci4KLSAgICAgICAgY2hh bmdlZF9maWxlcyA9IHNlbGYuX3J1bl9naXQoWyJzaG93IiwgIi0tcHJldHR5PWZvcm1hdDoiLCAi LS1uYW1lLW9ubHkiLCBnaXRfY29tbWl0XSkKKyAgICAgICAgY2hhbmdlZF9maWxlcyA9IHNlbGYu X3J1bl9naXQoWyJzaG93IiwgIi0tbm8tYWJicmV2LWNvbW1pdCIsICItLXByZXR0eT1mb3JtYXQ6 IiwgIi0tbmFtZS1vbmx5IiwgZ2l0X2NvbW1pdF0pCiAgICAgICAgICMgU3RyaXAgYmxhbmsgbGlu ZXMgd2hpY2ggY291bGQgYXBwZWFyIGF0IHRoZSB0b3Agb24gb2xkZXIgdmVyc2lvbnMgb2YgZ2l0 LgogICAgICAgICByZXR1cm4gY2hhbmdlZF9maWxlcy5sc3RyaXAoKS5zcGxpdGxpbmVzKCkKIApA QCAtMjUzLDcgKzI1Myw3IEBAIGNsYXNzIEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgogCiAgICAg ZGVmIHJldmlzaW9uc19jaGFuZ2luZ19maWxlKHNlbGYsIHBhdGgsIGxpbWl0PTUpOgogICAgICAg ICAjIGdpdCByZXYtbGlzdCBoZWFkIC0tcmVtb3ZlLWVtcHR5IC0tbGltaXQ9NSAtLSBwYXRoIHdv dWxkIGJlIGVxdWl2YWxlbnQuCi0gICAgICAgIGNvbW1pdF9pZHMgPSBzZWxmLl9ydW5fZ2l0KFsi bG9nIiwgIi0tcmVtb3ZlLWVtcHR5IiwgIi0tcHJldHR5PWZvcm1hdDolSCIsICItJXMiICUgbGlt aXQsICItLSIsIHBhdGhdKS5zcGxpdGxpbmVzKCkKKyAgICAgICAgY29tbWl0X2lkcyA9IHNlbGYu X3J1bl9naXQoWyJsb2ciLCAiLS1uby1hYmJyZXYtY29tbWl0IiwgIi0tcmVtb3ZlLWVtcHR5Iiwg Ii0tcHJldHR5PWZvcm1hdDolSCIsICItJXMiICUgbGltaXQsICItLSIsIHBhdGhdKS5zcGxpdGxp bmVzKCkKICAgICAgICAgcmV0dXJuIGxpc3QoZmlsdGVyKGxhbWJkYSByZXZpc2lvbjogcmV2aXNp b24sIG1hcChzZWxmLnN2bl9yZXZpc2lvbl9mcm9tX2dpdF9jb21taXQsIGNvbW1pdF9pZHMpKSkK IAogICAgIGRlZiBjb25mbGljdGVkX2ZpbGVzKHNlbGYpOgpAQCAtMjc4LDEwICsyNzgsMTAgQEAg Y2xhc3MgR2l0KFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAgICAgZGVmIF9tb3N0X3JlY2VudF9sb2df bWF0Y2hpbmcoc2VsZiwgZ3JlcF9zdHIsIHBhdGgpOgogICAgICAgICAjIFdlIHVzZSAnLS1ncmVw PScgKyBmb28gcmF0aGVyIHRoYW4gJy0tZ3JlcCcsIGZvbyBiZWNhdXNlCiAgICAgICAgICMgZ2l0 IDEuNy4wLjQgKGFuZCBlYXJsaWVyKSBkaWRuJ3Qgc3VwcG9ydCB0aGUgc2VwYXJhdGUgYXJnLgot ICAgICAgICByZXR1cm4gc2VsZi5fcnVuX2dpdChbJ2xvZycsICctMScsICctLWdyZXA9JyArIGdy ZXBfc3RyLCAnLS1kYXRlPWlzbycsIHNlbGYuZmluZF9jaGVja291dF9yb290KHBhdGgpXSkKKyAg ICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWydsb2cnLCAnLS1uby1hYmJyZXYtY29tbWl0Jywg Jy0xJywgJy0tZ3JlcD0nICsgZ3JlcF9zdHIsICctLWRhdGU9aXNvJywgc2VsZi5maW5kX2NoZWNr b3V0X3Jvb3QocGF0aCldKQogCiAgICAgZGVmIF9tb3N0X3JlY2VudF9sb2dfZm9yX3JldmlzaW9u KHNlbGYsIHJldmlzaW9uLCBwYXRoKToKLSAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWyds b2cnLCAnLTEnLCByZXZpc2lvbiwgJy0tZGF0ZT1pc28nLCBzZWxmLmZpbmRfY2hlY2tvdXRfcm9v dChwYXRoKV0pCisgICAgICAgIHJldHVybiBzZWxmLl9ydW5fZ2l0KFsnbG9nJywgJy0tbm8tYWJi cmV2LWNvbW1pdCcsICctMScsIHJldmlzaW9uLCAnLS1kYXRlPWlzbycsIHNlbGYuZmluZF9jaGVj a291dF9yb290KHBhdGgpXSkKIAogICAgIGRlZiBfZmllbGRfZnJvbV9naXRfc3ZuX2lkKHNlbGYs IHBhdGgsIGZpZWxkKToKICAgICAgICAgIyBLZWVwIHRoaXMgaW4gc3luYyB3aXRoIHRoZSByZWdl eCBmcm9tIGdpdF9zdm5faWRfcmVnZXhwKCkgYWJvdmUuCkBAIC0zOTEsNyArMzkxLDcgQEAgY2xh c3MgR2l0KFNDTSwgU1ZOUmVwb3NpdG9yeSk6CiAKICAgICBAbWVtb2l6ZWQKICAgICBkZWYgZ2l0 X2NvbW1pdF9mcm9tX3N2bl9yZXZpc2lvbihzZWxmLCBzdm5fcmV2aXNpb24pOgotICAgICAgICBn aXRfbG9nID0gc2VsZi5fcnVuX2dpdChbJ2xvZycsICctMScsICctLWdyZXA9XlxzKmdpdC1zdm4t aWQ6LipAJXMgJyAlIHN2bl9yZXZpc2lvbl0pCisgICAgICAgIGdpdF9sb2cgPSBzZWxmLl9ydW5f Z2l0KFsnbG9nJywgJy0tbm8tYWJicmV2LWNvbW1pdCcsICctMScsICctLWdyZXA9XlxzKmdpdC1z dm4taWQ6LipAJXMgJyAlIHN2bl9yZXZpc2lvbl0pCiAgICAgICAgIGdpdF9jb21taXQgPSByZS5z ZWFyY2goIl5jb21taXQgKD9QPGNvbW1pdD5bYS1mMC05XXs0MH0pIiwgZ2l0X2xvZykKICAgICAg ICAgaWYgbm90IGdpdF9jb21taXQ6CiAgICAgICAgICAgICAjIEZJWE1FOiBBbHRlcm5hdGl2ZWx5 IHdlIGNvdWxkIG9mZmVyIHRvIHVwZGF0ZSB0aGUgY2hlY2tvdXQ/IE9yIHJldHVybiBOb25lPwpA QCAtNDA2LDcgKzQwNiw3IEBAIGNsYXNzIEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgogICAgIGRl ZiBjb250ZW50c19hdF9yZXZpc2lvbihzZWxmLCBwYXRoLCByZXZpc2lvbik6CiAgICAgICAgICIi IlJldHVybnMgYSBieXRlIGFycmF5IChzdHIoKSkgY29udGFpbmluZyB0aGUgY29udGVudHMKICAg ICAgICAgb2YgcGF0aCBAIHJldmlzaW9uIGluIHRoZSByZXBvc2l0b3J5LiIiIgotICAgICAgICBy ZXR1cm4gc2VsZi5fcnVuX2dpdChbInNob3ciLCAiJXM6JXMiICUgKHNlbGYuZ2l0X2NvbW1pdF9m cm9tX3N2bl9yZXZpc2lvbihyZXZpc2lvbiksIHBhdGgpXSwgZGVjb2RlX291dHB1dD1GYWxzZSkK KyAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWyJzaG93IiwgIi0tbm8tYWJicmV2LWNvbW1p dCIsICIlczolcyIgJSAoc2VsZi5naXRfY29tbWl0X2Zyb21fc3ZuX3JldmlzaW9uKHJldmlzaW9u KSwgcGF0aCldLCBkZWNvZGVfb3V0cHV0PUZhbHNlKQogCiAgICAgZGVmIGRpZmZfZm9yX3Jldmlz aW9uKHNlbGYsIHJldmlzaW9uKToKICAgICAgICAgZ2l0X2NvbW1pdCA9IHNlbGYuZ2l0X2NvbW1p dF9mcm9tX3N2bl9yZXZpc2lvbihyZXZpc2lvbikKQEAgLTQxNiwxMSArNDE2LDExIEBAIGNsYXNz IEdpdChTQ00sIFNWTlJlcG9zaXRvcnkpOgogICAgICAgICByZXR1cm4gc2VsZi5fcnVuX2dpdChb J2RpZmYnLCAnSEVBRCcsICctLW5vLXJlbmFtZXMnLCAnLS0nLCBwYXRoXSkKIAogICAgIGRlZiBz aG93X2hlYWQoc2VsZiwgcGF0aCk6Ci0gICAgICAgIHJldHVybiBzZWxmLl9ydW5fZ2l0KFsnc2hv dycsICdIRUFEOicgKyBzZWxmLnRvX29iamVjdF9uYW1lKHBhdGgpXSwgZGVjb2RlX291dHB1dD1G YWxzZSkKKyAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9naXQoWydzaG93JywgJy0tbm8tYWJicmV2 LWNvbW1pdCcsICdIRUFEOicgKyBzZWxmLnRvX29iamVjdF9uYW1lKHBhdGgpXSwgZGVjb2RlX291 dHB1dD1GYWxzZSkKIAogICAgIGRlZiBjb21taXR0ZXJfZW1haWxfZm9yX3JldmlzaW9uKHNlbGYs IHJldmlzaW9uKToKICAgICAgICAgZ2l0X2NvbW1pdCA9IHNlbGYuZ2l0X2NvbW1pdF9mcm9tX3N2 bl9yZXZpc2lvbihyZXZpc2lvbikKLSAgICAgICAgY29tbWl0dGVyX2VtYWlsID0gc2VsZi5fcnVu X2dpdChbImxvZyIsICItMSIsICItLXByZXR0eT1mb3JtYXQ6JWNlIiwgZ2l0X2NvbW1pdF0pCisg ICAgICAgIGNvbW1pdHRlcl9lbWFpbCA9IHNlbGYuX3J1bl9naXQoWyJsb2ciLCAiLS1uby1hYmJy ZXYtY29tbWl0IiwgIi0xIiwgIi0tcHJldHR5PWZvcm1hdDolY2UiLCBnaXRfY29tbWl0XSkKICAg ICAgICAgIyBHaXQgYWRkcyBhbiBleHRyYSBAcmVwb3NpdG9yeV9oYXNoIHRvIHRoZSBlbmQgb2Yg ZXZlcnkgY29tbWl0dGVyIGVtYWlsLCByZW1vdmUgaXQ6CiAgICAgICAgIHJldHVybiBjb21taXR0 ZXJfZW1haWwucnNwbGl0KCJAIiwgMSlbMF0KIAo=