224864 2021-04-21 03:33:46 -0700 WebGL GPUP crashes when preparing for display due to off-thread WeakPtr access (IOSURFACE_SET_OWNERSHIP_IDENTITY) 2021-04-22 18:25:45 -0700 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 224881 217211 1 kkinnunen kkinnunen cdumez dino kbr kkinnunen peng.liu6 webkit-bug-importer oldest_to_newest 1752689 0 kkinnunen 2021-04-21 03:33:46 -0700 WebGL GPUP crashes when preparing for display due to off-thread WeakPtr access (IOSURFACE_SET_OWNERSHIP_IDENTITY) 1752691 1 426666 kkinnunen 2021-04-21 03:39:08 -0700 Created attachment 426666 Patch 1752729 2 426666 cdumez 2021-04-21 07:38:55 -0700 Comment on attachment 426666 Patch r=me 1752763 3 ews-feeder 2021-04-21 08:42:04 -0700 Committed r276363 (236841@main): <https://commits.webkit.org/236841@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426666. 1752795 4 426666 peng.liu6 2021-04-21 09:59:18 -0700 Comment on attachment 426666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review > Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 > +#if HAVE(TASK_IDENTITY_TOKEN) Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? 1752800 5 426666 cdumez 2021-04-21 10:08:10 -0700 Comment on attachment 426666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review >> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 >> +#if HAVE(TASK_IDENTITY_TOKEN) > > Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? Why? 1752805 6 426666 peng.liu6 2021-04-21 10:13:53 -0700 Comment on attachment 426666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426666&action=review >>> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 >>> +#if HAVE(TASK_IDENTITY_TOKEN) >> >> Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? > > Why? There will be a compiling error like "xxx is not used" if HAVE(TASK_IDENTITY_TOKEN) is true while HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY) is false. 1752849 7 peng.liu6 2021-04-21 12:06:34 -0700 Will be fixed in https://bugs.webkit.org/show_bug.cgi?id=224881.(In reply to Peng Liu from comment #6) > Comment on attachment 426666 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426666&action=review > > >>> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:50 > >>> +#if HAVE(TASK_IDENTITY_TOKEN) > >> > >> Is the macro here correct? Do we need to use HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)? or maybe both? > > > > Why? > > There will be a compiling error like "xxx is not used" if > HAVE(TASK_IDENTITY_TOKEN) is true while > HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY) is false. FYI. It will be fixed in https://bugs.webkit.org/show_bug.cgi?id=224881. 1753431 8 webkit-bug-importer 2021-04-22 18:25:45 -0700 <rdar://problem/77049474> 426666 2021-04-21 03:39:08 -0700 2021-04-21 08:42:05 -0700 Patch bug-224864-20210421133906.patch text/plain 3153 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGExYjA4YTc5OTFiM2MwYzIz ZTM3ZGJlYTE4ZWM0NmFmMGRiNzFhYTYuLmIwYWRjOWQ0YThlZjg5OGUwZjNjNjk1MzQ0MzhjYmE4 NjAwMTQyZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDQtMjEgIEtpbW1vIEtp bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJHTCBHUFVQIGNyYXNo ZXMgd2hlbiBwcmVwYXJpbmcgZm9yIGRpc3BsYXkgZHVlIHRvIG9mZi10aHJlYWQgV2Vha1B0ciBh Y2Nlc3MgKElPU1VSRkFDRV9TRVRfT1dORVJTSElQX0lERU5USVRZKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0ODY0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IG5hdmlnYXRlIFdlYWtQdHIg aW4gUmVtb3RlR3JhcGhpY3NDb250ZXh0R0wgdGhyZWFkLgorICAgICAgICBJbnN0ZWFkLCBjYWNo ZSB0aGUgb3duZXJzaGlwIGlkZW50aXR5IHRhZyBkdXJpbmcgY29uc3RydWN0b3IKKyAgICAgICAg aW4gbWFpbiB0aHJlYWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjYXVnaHQgd2l0aCBleGlz dGluZyB0ZXN0cyB3aGVuIHRoZSBkZWZpbmUKKyAgICAgICAgaXMgZW5hYmxlZC4KKworICAgICAg ICAqIEdQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlR3JhcGhpY3NDb250ZXh0R0xDb2NvYS5jcHA6 CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUdyYXBoaWNzQ29udGV4dEdMQ29jb2E6OlJlbW90ZUdy YXBoaWNzQ29udGV4dEdMQ29jb2EpOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVHcmFwaGljc0Nv bnRleHRHTENvY29hOjpwcmVwYXJlRm9yRGlzcGxheSk6CisKIDIwMjEtMDQtMjAgIEtpbW1vIEtp bm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBDb25uZWN0aW9uOjptX21h aW5UaHJlYWQgaXMgdW51c2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mv Z3JhcGhpY3MvUmVtb3RlR3JhcGhpY3NDb250ZXh0R0xDb2NvYS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3RlR3JhcGhpY3NDb250ZXh0R0xDb2NvYS5jcHAKaW5k ZXggYzkwNmE3ZmRkOTdiZDliMTA4YzZjMDQ1YzMzNWIxMmY1MDNmMTQwZC4uZDFhYmZlNjM3YmUz ZDQ3NjYzMTlkYjczZTFjNDAwY2U5ZTg0ZGM4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9H UFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZUdyYXBoaWNzQ29udGV4dEdMQ29jb2EuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1vdGVHcmFwaGljc0NvbnRleHRH TENvY29hLmNwcApAQCAtNDcsNiArNDcsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBwcmVwYXJlRm9y RGlzcGxheShDb21wbGV0aW9uSGFuZGxlcjx2b2lkKFdURjo6TWFjaFNlbmRSaWdodCYmKT4mJikg ZmluYWw7CiBwcml2YXRlOgogICAgIFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMSU9TdXJmYWNl U3dhcENoYWluIG1fc3dhcENoYWluOworI2lmIEhBVkUoVEFTS19JREVOVElUWV9UT0tFTikKKyAg ICB0YXNrX2lkX3Rva2VuX3QgbV93ZWJQcm9jZXNzSWRlbnRpdHlUb2tlbjsKKyNlbmRpZgogfTsK IAogfQpAQCAtNjAsNyArNjMsMTEgQEAgUmVmPFJlbW90ZUdyYXBoaWNzQ29udGV4dEdMPiBSZW1v dGVHcmFwaGljc0NvbnRleHRHTDo6Y3JlYXRlKEdQVUNvbm5lY3Rpb25Ub1dlYlAKIAogUmVtb3Rl R3JhcGhpY3NDb250ZXh0R0xDb2NvYTo6UmVtb3RlR3JhcGhpY3NDb250ZXh0R0xDb2NvYShHUFVD b25uZWN0aW9uVG9XZWJQcm9jZXNzJiBncHVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLCBHcmFwaGlj c0NvbnRleHRHTElkZW50aWZpZXIgZ3JhcGhpY3NDb250ZXh0R0xJZGVudGlmaWVyLCBSZW1vdGVS ZW5kZXJpbmdCYWNrZW5kJiByZW5kZXJpbmdCYWNrZW5kLCBJUEM6OlN0cmVhbUNvbm5lY3Rpb25C dWZmZXImJiBzdHJlYW0pCiAgICAgOiBSZW1vdGVHcmFwaGljc0NvbnRleHRHTChncHVDb25uZWN0 aW9uVG9XZWJQcm9jZXNzLCBncmFwaGljc0NvbnRleHRHTElkZW50aWZpZXIsIHJlbmRlcmluZ0Jh Y2tlbmQsIFdURk1vdmUoc3RyZWFtKSkKKyNpZiBIQVZFKElPU1VSRkFDRV9TRVRfT1dORVJTSElQ X0lERU5USVRZKQorICAgICwgbV93ZWJQcm9jZXNzSWRlbnRpdHlUb2tlbihncHVDb25uZWN0aW9u VG9XZWJQcm9jZXNzLndlYlByb2Nlc3NJZGVudGl0eVRva2VuKCkpCisjZW5kaWYKIHsKKwogfQog CiB2b2lkIFJlbW90ZUdyYXBoaWNzQ29udGV4dEdMQ29jb2E6OnBsYXRmb3JtV29ya1F1ZXVlSW5p dGlhbGl6ZShXZWJDb3JlOjpHcmFwaGljc0NvbnRleHRHTEF0dHJpYnV0ZXMmJiBhdHRyaWJ1dGVz KQpAQCAtNzUsOCArODIsNyBAQCB2b2lkIFJlbW90ZUdyYXBoaWNzQ29udGV4dEdMQ29jb2E6OnBy ZXBhcmVGb3JEaXNwbGF5KENvbXBsZXRpb25IYW5kbGVyPHZvaWQoV1RGOgogICAgIGlmIChhdXRv KiBzdXJmYWNlID0gbV9zd2FwQ2hhaW4uZGlzcGxheUJ1ZmZlcigpLnN1cmZhY2UuZ2V0KCkpIHsK ICNpZiBIQVZFKElPU1VSRkFDRV9TRVRfT1dORVJTSElQX0lERU5USVRZKQogICAgICAgICAvLyBN YXJrIHRoZSBJT1N1cmZhY2UgYXMgYmVpbmcgb3duZWQgYnkgdGhlIFdlYlByb2Nlc3MgZXZlbiB0 aG91Z2ggaXQgd2FzIGNvbnN0cnVjdGVkIGJ5IHRoZSBHUFVQcm9jZXNzIHNvIHRoYXQgSmV0c2Ft IGtub3dzIHdoaWNoIHByb2Nlc3MgdG8ga2lsbC4KLSAgICAgICAgaWYgKG1fZ3B1Q29ubmVjdGlv blRvV2ViUHJvY2VzcykKLSAgICAgICAgICAgIHN1cmZhY2UtPnNldE93bmVyc2hpcElkZW50aXR5 KG1fZ3B1Q29ubmVjdGlvblRvV2ViUHJvY2Vzcy0+d2ViUHJvY2Vzc0lkZW50aXR5VG9rZW4oKSk7 CisgICAgICAgIHN1cmZhY2UtPnNldE93bmVyc2hpcElkZW50aXR5KG1fd2ViUHJvY2Vzc0lkZW50 aXR5VG9rZW4pOwogI2VuZGlmCiAgICAgICAgIHNlbmRSaWdodCA9IHN1cmZhY2UtPmNyZWF0ZVNl bmRSaWdodCgpOwogICAgIH0K