224854 2021-04-20 23:11:28 -0700 ANGLE should be compiled with thread-safe statics 2021-04-28 00:00:58 -0700 1 1 1 Unclassified WebKit ANGLE Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224863 InRadar P2 Normal --- 1 kkinnunen kkinnunen darin dino ews-watchlist graouts kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1752642 0 kkinnunen 2021-04-20 23:11:28 -0700 ANGLE should be compiled with thread-safe statics The code assumes that, as that's the c++ semantics and ANGLE is a c++ project. 1752646 1 426651 kkinnunen 2021-04-20 23:33:32 -0700 Created attachment 426651 Patch 1752647 2 ews-watchlist 2021-04-20 23:34:35 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1753719 3 426651 kbr 2021-04-23 14:15:06 -0700 Comment on attachment 426651 Patch Seems fine. r+ 1754056 4 426651 darin 2021-04-25 13:18:07 -0700 Comment on attachment 426651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426651&action=review > Source/ThirdParty/ANGLE/ChangeLog:11 > + Compile ANGLE with normal thread-safe c++ local statics. > + No known threading failures. Based on ad-hoc risk vs benefit > + evaluation of today and after future merges, it appears > + better to err in the side of caution. Excellent that we can/will do this. This comment addresses the safety side of the tradeoff. What about the performance side? 1754921 5 webkit-bug-importer 2021-04-27 23:12:13 -0700 <rdar://problem/77250303> 1754932 6 kkinnunen 2021-04-27 23:49:35 -0700 (In reply to Darin Adler from comment #4) > Excellent that we can/will do this. > > This comment addresses the safety side of the tradeoff. What about the > performance side? Based on ad hoc testing of WebGL, I could not spot any difference. 1754936 7 ews-feeder 2021-04-28 00:00:56 -0700 Committed r276693 (237107@main): <https://commits.webkit.org/237107@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426651. 426651 2021-04-20 23:33:32 -0700 2021-04-28 00:00:57 -0700 Patch bug-224854-20210421093330.patch text/plain 1595 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMTljZWM3MWRkZTdlZTlmYjBlODUzMzRhODVlNDM5NzVhYzc5NjQzZC4uM2RkOTM2MjUxOTJl MmIxNGI2NTdjNWZjNDA5MzJlNzdiNWY4MGU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTIwICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgc2hvdWxkIGJlIGNvbXBpbGVkIHdpdGggdGhy ZWFkLXNhZmUgc3RhdGljcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0ODU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQ29tcGlsZSBBTkdMRSB3aXRoIG5vcm1hbCB0aHJlYWQtc2FmZSBjKysgbG9jYWwg c3RhdGljcy4KKyAgICAgICAgTm8ga25vd24gdGhyZWFkaW5nIGZhaWx1cmVzLiBCYXNlZCBvbiBh ZC1ob2MgcmlzayB2cyBiZW5lZml0CisgICAgICAgIGV2YWx1YXRpb24gb2YgdG9kYXkgYW5kIGFm dGVyIGZ1dHVyZSBtZXJnZXMsIGl0IGFwcGVhcnMKKyAgICAgICAgYmV0dGVyIHRvIGVyciBpbiB0 aGUgc2lkZSBvZiBjYXV0aW9uLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvQmFzZS54Y2Nv bmZpZzoKKwogMjAyMS0wNC0yMCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIE1hY0NhdGFseXN0IEFOR0xFIGlzIGxpbmtlZCB3aXRoIEBsb2Fk ZXJfcGF0aC8uLi8uLi8uLi9saWJBTkdMRS1zaGFyZWQuZHlsaWIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcgYi9Tb3VyY2Uv VGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCmluZGV4IDk4YmE2 MjQwMDUzOTk3MDFmMmJlMDFlMzY4MmM3Zjc5NWY5YTQ1NDguLjU1NzI5NDBmOTdhNmRjOTgxNWIy ZjRkODQ0MzVhNDJjODM1YWU5NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwpAQCAtNDgsNyArNDgsNiBAQCBHQ0NfTk9f Q09NTU9OX0JMT0NLUyA9IFlFUzsKIEdDQ19PQkpDX0NBTExfQ1hYX0NEVE9SUyA9IFlFUzsKIEdD Q19QUkVDT01QSUxFX1BSRUZJWF9IRUFERVIgPSBOTzsKIEdDQ19TWU1CT0xTX1BSSVZBVEVfRVhU RVJOID0gWUVTOwotR0NDX1RIUkVBRFNBRkVfU1RBVElDUyA9IE5POwogR0NDX1RSRUFUX1dBUk5J TkdTX0FTX0VSUk9SUyA9IFlFUzsKIEdDQ19WRVJTSU9OID0gY29tLmFwcGxlLmNvbXBpbGVycy5s bHZtLmNsYW5nLjFfMDsKIEdDQ19XQVJOXzY0X1RPXzMyX0JJVF9DT05WRVJTSU9OID0gWUVTOwo=