224841 2021-04-20 16:18:43 -0700 v2: Web Inspector: exempt API::SharedJSContext from remote inspection and automatic inspection 2021-04-22 11:01:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1752497 0 bburg 2021-04-20 16:18:43 -0700 The fix for bug 217109 was insufficient, I have a better fix. 1752498 1 bburg 2021-04-20 16:20:18 -0700 <rdar://69386559> 1752501 2 426611 bburg 2021-04-20 16:23:54 -0700 Created attachment 426611 Patch v1.0 1752506 3 426611 hi 2021-04-20 16:34:02 -0700 Comment on attachment 426611 Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=426611&action=review r=me Out of curiosity, does this prevent inspection forever? Or does it just prevent auto-attach/auto-pause? Would be nice to still be able to inspect this later on if possible :) > Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:52 > [m_context _setRemoteInspectionEnabled:NO]; I think we can remove this since it's only set `if (JSRemoteInspectorGetInspectionEnabledByDefault())`. 1753175 4 bburg 2021-04-22 08:33:03 -0700 (In reply to Devin Rousso from comment #3) > Comment on attachment 426611 [details] > Patch v1.0 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426611&action=review > > r=me > > Out of curiosity, does this prevent inspection forever? Or does it just > prevent auto-attach/auto-pause? Would be nice to still be able to inspect > this later on if possible :) The default is to not allow inspection, so yes, this would continue to not be listed. This could be fixed (i.e, for engineering purposes) by making JSRemoteInspectorGetInspectionEnabledByDefault always return true, or changing the default value of m_enabled in JSC::RemoteInspectionTarget. But in general, I don't think there is much point in exposing this context outside of engineering builds. > > > Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:52 > > [m_context _setRemoteInspectionEnabled:NO]; > > I think we can remove this since it's only set `if > (JSRemoteInspectorGetInspectionEnabledByDefault())`. True, it would default to false as explained above. 1753222 5 bburg 2021-04-22 11:00:59 -0700 Committed r276446 (236906@main): <https://commits.webkit.org/236906@main> 426611 2021-04-20 16:23:54 -0700 2021-04-22 11:01:09 -0700 Patch v1.0 bug-224841-20210420162353.patch text/plain 2334 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQzZTU1MTVmZjQ4OGMxODBl OTdkZTIzM2U0ZTcwNjlmZGE1MmEzOWQuLjg1YzZkMTY2YTlmYjYyMWU5ODMwMTQzN2UwNWY2N2E0 MWE5MDIwY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMjAgIEJKIEJ1cmcg IDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgdjI6IFdlYiBJbnNwZWN0b3I6IGV4ZW1wdCBB UEk6OlNoYXJlZEpTQ29udGV4dCBmcm9tIHJlbW90ZSBpbnNwZWN0aW9uIGFuZCBhdXRvbWF0aWMg aW5zcGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI0ODQxCisgICAgICAgIDxyZGFyOi8vNjkzODY1NTk+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBSZW1vdGVJbnNwZWN0b3IgQyBT UEkgdG8gdGVtcG9yYXJpbHkgdHVybiBvZmYgImFsbG93IHJlbW90ZSBpbnNwZWN0aW9uIGJ5IGRl ZmF1bHQiLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9BUElTZXJpYWxpemVkU2Ny aXB0VmFsdWVDb2NvYS5tbToKKyAgICAgICAgKEFQSTo6U2hhcmVkSlNDb250ZXh0OjplbnN1cmVD b250ZXh0KToKKwogMjAyMS0wNC0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCByYWNlcyBpbiBMaWJXZWJSVENDb2RlY3MgaW50cm9kdWNlZCBpbiByMjc2 MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvQVBJU2Vy aWFsaXplZFNjcmlwdFZhbHVlQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvQVBJU2VyaWFsaXplZFNjcmlwdFZhbHVlQ29jb2EubW0KaW5kZXggMmViNzVjZTkxZjVi ZDNiMzE5OTQ5NTMxMzUyZmQ5YmMyZTEwOWE3YS4uZTkyNThkYmU4NzYyNjQxMjIxYWY5ZjllYWRi NGM1ZjBiMjgzNDVjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0Nv Y29hL0FQSVNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9Db2NvYS9BUElTZXJpYWxpemVkU2NyaXB0VmFsdWVDb2NvYS5tbQpAQCAt MSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE1LCAyMDIxIEFwcGxlIEluYy4gQWxs IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjks NiArMjksNyBAQAogI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2ltcG9ydCA8 SmF2YVNjcmlwdENvcmUvSlNDb250ZXh0UHJpdmF0ZS5oPgogI2ltcG9ydCA8SmF2YVNjcmlwdENv cmUvSlNHbG9iYWxPYmplY3RJbmxpbmVzLmg+CisjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU1Jl bW90ZUluc3BlY3Rvci5oPgogI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNWYWx1ZS5oPgogI2lt cG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+CiAjaW1wb3J0IDx3dGYvUnVuTG9vcC5oPgpAQCAt NDUsOCArNDYsMTIgQEAgcHVibGljOgogICAgIEpTQ29udGV4dCogZW5zdXJlQ29udGV4dCgpCiAg ICAgewogICAgICAgICBpZiAoIW1fY29udGV4dCkgeworICAgICAgICAgICAgYm9vbCBwcmV2aW91 cyA9IEpTUmVtb3RlSW5zcGVjdG9yR2V0SW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQoKTsKKyAg ICAgICAgICAgIEpTUmVtb3RlSW5zcGVjdG9yU2V0SW5zcGVjdGlvbkVuYWJsZWRCeURlZmF1bHQo ZmFsc2UpOwogICAgICAgICAgICAgbV9jb250ZXh0ID0gYWRvcHROUyhbW0pTQ29udGV4dCBhbGxv Y10gaW5pdF0pOwogICAgICAgICAgICAgW21fY29udGV4dCBfc2V0UmVtb3RlSW5zcGVjdGlvbkVu YWJsZWQ6Tk9dOworICAgICAgICAgICAgSlNSZW1vdGVJbnNwZWN0b3JTZXRJbnNwZWN0aW9uRW5h YmxlZEJ5RGVmYXVsdChwcmV2aW91cyk7CisKICAgICAgICAgICAgIG1fdGltZXIuc3RhcnRPbmVT aG90KDFfcyk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIG1fY29udGV4dC5nZXQoKTsK